e768c92fbc
* Update packages. * Add many more global analyses. * Catch trailing spaces and trailing newlines in all text files. Before we were only checking newly added files, but that means we missed some. * Port the trailing spaces logic to work on Windows too. * Correct all the files with trailing spaces and newlines. * Refactor some of the dev/bots logic into a utils.dart library. Notably, the "exit" and "print" shims for testing are now usable from test.dart, analyze.dart, and run_command.dart. * Add an "exitWithError" function that prints the red lines and then exits. This is the preferred way to exit from test.dart, analyze.dart, and run_command.dart. * More consistency in the output of analyze.dart. * Refactor analyze.dart to use the _allFiles file enumerating logic more widely. * Add some double-checking logic to the _allFiles logic to catch cases where changes to that logic end up catching fewer files than expected (helps prevent future false positives). * Add a check to prevent new binary files from being added to the repository. Grandfather in the binaries that we've already added. * Update all the dependencies (needed because we now import crypto in dev/bots/analyze.dart).
158 lines
4.7 KiB
Dart
158 lines
4.7 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'semantics_tester.dart';
|
|
|
|
void main() {
|
|
group('BlockSemantics', () {
|
|
testWidgets('hides semantic nodes of siblings', (WidgetTester tester) async {
|
|
final SemanticsTester semantics = SemanticsTester(tester);
|
|
|
|
await tester.pumpWidget(Stack(
|
|
textDirection: TextDirection.ltr,
|
|
children: <Widget>[
|
|
Semantics(
|
|
label: 'layer#1',
|
|
textDirection: TextDirection.ltr,
|
|
child: Container(),
|
|
),
|
|
const BlockSemantics(),
|
|
Semantics(
|
|
label: 'layer#2',
|
|
textDirection: TextDirection.ltr,
|
|
child: Container(),
|
|
),
|
|
],
|
|
));
|
|
|
|
expect(semantics, isNot(includesNodeWith(label: 'layer#1')));
|
|
|
|
await tester.pumpWidget(Stack(
|
|
textDirection: TextDirection.ltr,
|
|
children: <Widget>[
|
|
Semantics(
|
|
label: 'layer#1',
|
|
textDirection: TextDirection.ltr,
|
|
child: Container(),
|
|
),
|
|
],
|
|
));
|
|
|
|
expect(semantics, includesNodeWith(label: 'layer#1'));
|
|
|
|
semantics.dispose();
|
|
});
|
|
|
|
testWidgets('does not hides semantic nodes of siblings outside the current semantic boundary', (WidgetTester tester) async {
|
|
final SemanticsTester semantics = SemanticsTester(tester);
|
|
|
|
await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Stack(
|
|
children: <Widget>[
|
|
Semantics(
|
|
label: '#1',
|
|
child: Container(),
|
|
),
|
|
Semantics(
|
|
label: '#2',
|
|
container: true,
|
|
explicitChildNodes: true,
|
|
child: Stack(
|
|
children: <Widget>[
|
|
Semantics(
|
|
label: 'NOT#2.1',
|
|
child: Container(),
|
|
),
|
|
Semantics(
|
|
label: '#2.2',
|
|
child: BlockSemantics(
|
|
child: Semantics(
|
|
container: true,
|
|
label: '#2.2.1',
|
|
child: Container(),
|
|
),
|
|
),
|
|
),
|
|
Semantics(
|
|
label: '#2.3',
|
|
child: Container(),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
Semantics(
|
|
label: '#3',
|
|
child: Container(),
|
|
),
|
|
],
|
|
)));
|
|
|
|
expect(semantics, includesNodeWith(label: '#1'));
|
|
expect(semantics, includesNodeWith(label: '#2'));
|
|
expect(semantics, isNot(includesNodeWith(label:'NOT#2.1')));
|
|
expect(semantics, includesNodeWith(label: '#2.2'));
|
|
expect(semantics, includesNodeWith(label: '#2.2.1'));
|
|
expect(semantics, includesNodeWith(label: '#2.3'));
|
|
expect(semantics, includesNodeWith(label: '#3'));
|
|
|
|
semantics.dispose();
|
|
});
|
|
|
|
testWidgets('node is semantic boundary and blocking previously painted nodes', (WidgetTester tester) async {
|
|
final SemanticsTester semantics = SemanticsTester(tester);
|
|
final GlobalKey stackKey = GlobalKey();
|
|
|
|
await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Stack(
|
|
key: stackKey,
|
|
children: <Widget>[
|
|
Semantics(
|
|
label: 'NOT#1',
|
|
child: Container(),
|
|
),
|
|
BoundaryBlockSemantics(
|
|
child: Semantics(
|
|
label: '#2.1',
|
|
child: Container(),
|
|
),
|
|
),
|
|
Semantics(
|
|
label: '#3',
|
|
child: Container(),
|
|
),
|
|
],
|
|
)));
|
|
|
|
expect(semantics, isNot(includesNodeWith(label: 'NOT#1')));
|
|
expect(semantics, includesNodeWith(label: '#2.1'));
|
|
expect(semantics, includesNodeWith(label: '#3'));
|
|
|
|
semantics.dispose();
|
|
});
|
|
});
|
|
}
|
|
|
|
class BoundaryBlockSemantics extends SingleChildRenderObjectWidget {
|
|
const BoundaryBlockSemantics({ Key key, Widget child }) : super(key: key, child: child);
|
|
|
|
@override
|
|
RenderBoundaryBlockSemantics createRenderObject(BuildContext context) => RenderBoundaryBlockSemantics();
|
|
}
|
|
|
|
class RenderBoundaryBlockSemantics extends RenderProxyBox {
|
|
RenderBoundaryBlockSemantics({ RenderBox child }) : super(child);
|
|
|
|
@override
|
|
void describeSemanticsConfiguration(SemanticsConfiguration config) {
|
|
super.describeSemanticsConfiguration(config);
|
|
|
|
config
|
|
..isBlockingSemanticsOfPreviouslyPaintedNodes = true
|
|
..isSemanticBoundary = true;
|
|
}
|
|
}
|