flutter/packages/flutter_localizations
Casey Hillers 1f42612323
Revert PRs relating to single window assumption (#122369)
* Revert "Remove references to BindingBase.window (#122119)"

This reverts commit c7681f00cf1fb1c63bebb27d715f29feb77b78b7.

* Revert "Remove another reference to BindingBase.window (#122341)"

This reverts commit 6ec444506375cfa94535a45c2320e01094c295e0.

* Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)"

This reverts commit eb3d317ea06e59fadc379210f5c6e685505d8e0f.

* Revert "Remove single view assumption from TestViewConfiguration (#122352)"

This reverts commit 927289fb4e5b25a71f794bc808a8c31554859a50.

* Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)"

This reverts commit 67e17e45f05271c6c409183c1d33806683cb9e4d.

* Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)"

This reverts commit c2a5111cc0f9bcb104982b38a1a0a9c4210b601f.

* Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)"

This reverts commit 28b65e089b3f8e8c21572cd8a73184858b6360c3.

* Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)"

This reverts commit 01367d52d7886f51a8921c9dc4a8e4c541686e98.
2023-03-09 22:53:38 -08:00
..
2023-02-23 19:21:53 +00:00

Flutter Framework localizations

This package contains the localizations used by the Flutter framework itself.

See the localization README for more detailed information about the localizations themselves.

Adding a new string to localizations

If you (someone contributing to the Flutter framework) want to add a new string to the MaterialLocalizations, WidgetsLocalizations or the CupertinoLocalizations objects (e.g. because you've added a new widget and it has a tooltip), follow these steps (these instructions are for MaterialLocalizations, but apply equally to CupertinoLocalizations and WidgetsLocalizations, with appropriate name substitutions):

  1. For messages without parameters, add new getter

    String get showMenuTooltip;
    

    to the localizations class MaterialLocalizations, in packages/flutter/lib/src/material/material_localizations.dart;

    For messages with parameters, add new function

    String aboutListTileTitle(String applicationName);
    

    to the same localization class.

  2. Implement a default return value in DefaultMaterialLocalizations in the same file as in step 1.

    Messages without parameters:

    @override
    String get showMenuTooltip => 'Show menu';
    

    Messages with parameters:

    @override
    String aboutListTileTitle(String applicationName) => 'About $applicationName';
    

    For messages with parameters, do also add the function to GlobalMaterialLocalizations in packages/flutter_localizations/lib/src/material_localizations.dart, and add a raw getter as demonstrated below:

    /// The raw version of [aboutListTileTitle], with `$applicationName` verbatim
    /// in the string.
    @protected
    String get aboutListTileTitleRaw;
    
    @override
    String aboutListTileTitle(String applicationName) {
      final String text = aboutListTileTitleRaw;
      return text.replaceFirst(r'$applicationName', applicationName);
    }
    
  3. Add a test to test/material/localizations_test.dart that verifies that this new value is implemented.

  4. Update the flutter_localizations package. To add a new string to the flutter_localizations package, you must first add it to the English translations (lib/src/l10n/material_en.arb), including a description.

    Messages without parameters:

    "showMenuTooltip": "Show menu",
    "@showMenuTooltip": {
      "description": "The tooltip for the button that shows a popup menu."
    },
    

    Messages with parameters:

    "aboutListTileTitle": "About $applicationName",
    "@aboutListTileTitle": {
      "description": "The default title for the drawer item that shows an about page for the application. The value of $applicationName is the name of the application, like GMail or Chrome.",
      "parameters": "applicationName"
    },
    

    Then you need to add new entries for the string to all of the other language locale files by running:

    dart dev/tools/localization/bin/gen_missing_localizations.dart
    

    Which will copy the English strings into the other locales as placeholders until they can be translated.

    Finally you need to re-generate lib/src/l10n/localizations.dart by running:

    dart dev/tools/localization/bin/gen_localizations.dart --overwrite
    

    If you got an error when running this command, this issue might be helpful.

    TL;DR: If you got the same type of errors as discussed in the issue, run this instead:

    dart dev/tools/localization/bin/gen_localizations.dart --overwrite --remove-undefined
    

    There is a localization README file with further information in the lib/src/l10n/ directory.

  5. If you are a Google employee, you should then also follow the instructions at go/flutter-l10n. If you're not, don't worry about it.

Updating an existing string

If you or someone contributing to the Flutter framework wants to modify an existing string in the MaterialLocalizations objects, follow these steps:

  1. Modify the default value of the relevant getter(s) in DefaultMaterialLocalizations below.

  2. Update the flutter_localizations package. Modify the out-of-date English strings in lib/src/l10n/material_en.arb.

    You also need to re-generate lib/src/l10n/localizations.dart by running:

    dart dev/tools/localization/bin/gen_localizations.dart --overwrite
    

    This script may result in your updated getters being created in newer locales and set to the old value of the strings. This is to be expected. Leave them as they were generated, and they will be picked up for translation.

    There is a localization README file with further information in the lib/src/l10n/ directory.

  3. If you are a Google employee, you should then also follow the instructions at go/flutter-l10n. If you're not, don't worry about it.