5d1bfdcb87
This pull request aims for improved readability, based on issue #146600. ```dart // before List<SupportedPlatform> getSupportedPlatforms({bool includeRoot = false}) { final List<SupportedPlatform> platforms = includeRoot ? <SupportedPlatform>[SupportedPlatform.root] : <SupportedPlatform>[]; if (android.existsSync()) { platforms.add(SupportedPlatform.android); } if (ios.exists) { platforms.add(SupportedPlatform.ios); } if (web.existsSync()) { platforms.add(SupportedPlatform.web); } if (macos.existsSync()) { platforms.add(SupportedPlatform.macos); } if (linux.existsSync()) { platforms.add(SupportedPlatform.linux); } if (windows.existsSync()) { platforms.add(SupportedPlatform.windows); } if (fuchsia.existsSync()) { platforms.add(SupportedPlatform.fuchsia); } return platforms; } // after List<SupportedPlatform> getSupportedPlatforms({bool includeRoot = false}) { return <SupportedPlatform>[ if (includeRoot) SupportedPlatform.root, if (android.existsSync()) SupportedPlatform.android, if (ios.exists) SupportedPlatform.ios, if (web.existsSync()) SupportedPlatform.web, if (macos.existsSync()) SupportedPlatform.macos, if (linux.existsSync()) SupportedPlatform.linux, if (windows.existsSync()) SupportedPlatform.windows, if (fuchsia.existsSync()) SupportedPlatform.fuchsia, ]; } ```
76 lines
2.6 KiB
Dart
76 lines
2.6 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'base/io.dart';
|
|
import 'base/platform.dart';
|
|
import 'doctor_validator.dart';
|
|
|
|
/// A validator that displays configured HTTP_PROXY environment variables.
|
|
///
|
|
/// if the `HTTP_PROXY` environment variable is non-empty, the contents are
|
|
/// validated along with `NO_PROXY`.
|
|
class ProxyValidator extends DoctorValidator {
|
|
ProxyValidator({
|
|
required Platform platform,
|
|
}) : shouldShow = _getEnv('HTTP_PROXY', platform).isNotEmpty,
|
|
_httpProxy = _getEnv('HTTP_PROXY', platform),
|
|
_noProxy = _getEnv('NO_PROXY', platform),
|
|
super('Proxy Configuration');
|
|
|
|
final bool shouldShow;
|
|
final String _httpProxy;
|
|
final String _noProxy;
|
|
|
|
/// Gets a trimmed, non-null environment variable. If the variable is not set
|
|
/// an empty string will be returned. Checks for the lowercase version of the
|
|
/// environment variable first, then uppercase to match Dart's HTTP implementation.
|
|
static String _getEnv(String key, Platform platform) =>
|
|
platform.environment[key.toLowerCase()]?.trim() ??
|
|
platform.environment[key.toUpperCase()]?.trim() ??
|
|
'';
|
|
|
|
@override
|
|
Future<ValidationResult> validate() async {
|
|
if (_httpProxy.isEmpty) {
|
|
return const ValidationResult(
|
|
ValidationType.success, <ValidationMessage>[]);
|
|
}
|
|
|
|
final List<ValidationMessage> messages = <ValidationMessage>[
|
|
const ValidationMessage('HTTP_PROXY is set'),
|
|
if (_noProxy.isEmpty)
|
|
const ValidationMessage.hint('NO_PROXY is not set')
|
|
else
|
|
...<ValidationMessage>[
|
|
ValidationMessage('NO_PROXY is $_noProxy'),
|
|
for (final String host in await _getLoopbackAddresses())
|
|
if (_noProxy.contains(host))
|
|
ValidationMessage('NO_PROXY contains $host')
|
|
else
|
|
ValidationMessage.hint('NO_PROXY does not contain $host'),
|
|
],
|
|
];
|
|
|
|
final bool hasIssues = messages.any(
|
|
(ValidationMessage msg) => msg.isHint || msg.isError);
|
|
|
|
return ValidationResult(
|
|
hasIssues ? ValidationType.partial : ValidationType.success,
|
|
messages,
|
|
);
|
|
}
|
|
|
|
Future<List<String>> _getLoopbackAddresses() async {
|
|
final List<NetworkInterface> networkInterfaces =
|
|
await listNetworkInterfaces(includeLinkLocal: true, includeLoopback: true);
|
|
|
|
return <String>[
|
|
'localhost',
|
|
for (final NetworkInterface networkInterface in networkInterfaces)
|
|
for (final InternetAddress internetAddress in networkInterface.addresses)
|
|
if (internetAddress.isLoopback) internetAddress.address,
|
|
];
|
|
}
|
|
}
|