fixed project problems (warnings)

This commit is contained in:
Kima 2024-03-11 23:29:17 +01:00
parent 146ff9251c
commit a4d569db8d
13 changed files with 32 additions and 29 deletions

View File

@ -28,6 +28,7 @@ class AppIconHelper {
} }
} else if (Platform.isAndroid) { } else if (Platform.isAndroid) {
// change icon on android // change icon on android
// ignore: no_leading_underscores_for_local_identifiers
final _androidDynamicIconPlugin = AndroidDynamicIcon(); final _androidDynamicIconPlugin = AndroidDynamicIcon();
await _androidDynamicIconPlugin.changeIcon( await _androidDynamicIconPlugin.changeIcon(
bundleId: 'hu.refilc.naplo', bundleId: 'hu.refilc.naplo',

View File

@ -10,13 +10,13 @@ import 'package:provider/provider.dart';
class GoalCompleteModal extends StatelessWidget { class GoalCompleteModal extends StatelessWidget {
const GoalCompleteModal( const GoalCompleteModal(
this.subject, { this.subject, {
Key? key, super.key,
required this.user, required this.user,
required this.database, required this.database,
required this.goalAverage, required this.goalAverage,
required this.beforeAverage, required this.beforeAverage,
required this.averageDifference, required this.averageDifference,
}) : super(key: key); });
final UserProvider user; final UserProvider user;
final DatabaseProvider database; final DatabaseProvider database;
@ -120,7 +120,7 @@ class GoalCompleteModal extends StatelessWidget {
), ),
Text( Text(
'improved_by'.i18n.fill([ 'improved_by'.i18n.fill([
averageDifference.toStringAsFixed(2) + '%', '${averageDifference.toStringAsFixed(2)}%',
]), ]),
textAlign: TextAlign.center, textAlign: TextAlign.center,
style: TextStyle( style: TextStyle(
@ -237,6 +237,7 @@ class GoalCompleteModal extends StatelessWidget {
double avgDifference = ((goalAvg - beforeAvg) / beforeAvg.abs()) * 100; double avgDifference = ((goalAvg - beforeAvg) / beforeAvg.abs()) * 100;
return showDialog<T?>( return showDialog<T?>(
// ignore: use_build_context_synchronously
context: context, context: context,
builder: (context) => GoalCompleteModal( builder: (context) => GoalCompleteModal(
subject, subject,

View File

@ -5,11 +5,10 @@ import 'package:provider/provider.dart';
class GoalInput extends StatelessWidget { class GoalInput extends StatelessWidget {
const GoalInput( const GoalInput(
{Key? key, {super.key,
required this.currentAverage, required this.currentAverage,
required this.value, required this.value,
required this.onChanged}) required this.onChanged});
: super(key: key);
final double currentAverage; final double currentAverage;
final double value; final double value;

View File

@ -419,6 +419,7 @@ class _GoalPlannerScreenState extends State<GoalPlannerScreen> {
goalPinDates, goalPinDates,
userId: user.id!); userId: user.id!);
// ignore: use_build_context_synchronously
Navigator.of(context).pop(); Navigator.of(context).pop();
}, },
fillColor: Theme.of(context).colorScheme.primary, fillColor: Theme.of(context).colorScheme.primary,

View File

@ -1,3 +1,5 @@
// ignore_for_file: use_build_context_synchronously
import 'package:refilc/api/providers/database_provider.dart'; import 'package:refilc/api/providers/database_provider.dart';
import 'package:refilc/api/providers/user_provider.dart'; import 'package:refilc/api/providers/user_provider.dart';
import 'package:refilc/helpers/average_helper.dart'; import 'package:refilc/helpers/average_helper.dart';
@ -26,7 +28,7 @@ import 'graph.dart';
class GoalStateScreen extends StatefulWidget { class GoalStateScreen extends StatefulWidget {
final GradeSubject subject; final GradeSubject subject;
const GoalStateScreen({Key? key, required this.subject}) : super(key: key); const GoalStateScreen({super.key, required this.subject});
@override @override
State<GoalStateScreen> createState() => _GoalStateScreenState(); State<GoalStateScreen> createState() => _GoalStateScreenState();
@ -394,8 +396,7 @@ class _GoalStateScreenState extends State<GoalStateScreen> {
), ),
const SizedBox(width: 5.0), const SizedBox(width: 5.0),
Text( Text(
avgDifference.toStringAsFixed(2) + '${avgDifference.toStringAsFixed(2)}%',
'%',
textAlign: TextAlign.center, textAlign: TextAlign.center,
style: TextStyle( style: TextStyle(
color: avgDifference.isNegative color: avgDifference.isNegative

View File

@ -4,7 +4,7 @@ import 'package:flutter/material.dart';
import 'package:provider/provider.dart'; import 'package:provider/provider.dart';
class GradeDisplay extends StatelessWidget { class GradeDisplay extends StatelessWidget {
const GradeDisplay({Key? key, required this.grade}) : super(key: key); const GradeDisplay({super.key, required this.grade});
final int grade; final int grade;

View File

@ -10,18 +10,17 @@ import 'package:fl_chart/fl_chart.dart';
import 'package:provider/provider.dart'; import 'package:provider/provider.dart';
class GoalGraph extends StatefulWidget { class GoalGraph extends StatefulWidget {
const GoalGraph(this.data, {Key? key, this.dayThreshold = 7, this.classAvg}) const GoalGraph(this.data, {super.key, this.dayThreshold = 7, this.classAvg});
: super(key: key);
final List<Grade> data; final List<Grade> data;
final int dayThreshold; final int dayThreshold;
final double? classAvg; final double? classAvg;
@override @override
_GoalGraphState createState() => _GoalGraphState(); GoalGraphState createState() => GoalGraphState();
} }
class _GoalGraphState extends State<GoalGraph> { class GoalGraphState extends State<GoalGraph> {
late SettingsProvider settings; late SettingsProvider settings;
List<FlSpot> getSpots(List<Grade> data) { List<FlSpot> getSpots(List<Grade> data) {
@ -135,6 +134,7 @@ class _GoalGraphState extends State<GoalGraph> {
) )
: ClipRect( : ClipRect(
child: SizedBox( child: SizedBox(
height: 158,
child: subjectSpots.length > 1 child: subjectSpots.length > 1
? Padding( ? Padding(
padding: const EdgeInsets.only(top: 8.0, right: 8.0), padding: const EdgeInsets.only(top: 8.0, right: 8.0),
@ -242,7 +242,6 @@ class _GoalGraphState extends State<GoalGraph> {
), ),
) )
: null, : null,
height: 158,
), ),
); );
} }

View File

@ -8,12 +8,11 @@ enum RouteMark { recommended, fastest }
class RouteOption extends StatelessWidget { class RouteOption extends StatelessWidget {
const RouteOption( const RouteOption(
{Key? key, {super.key,
required this.plan, required this.plan,
this.mark, this.mark,
this.selected = false, this.selected = false,
required this.onSelected}) required this.onSelected});
: super(key: key);
final Plan plan; final Plan plan;
final RouteMark? mark; final RouteMark? mark;
@ -144,10 +143,10 @@ class RouteOption extends StatelessWidget {
class RouteOptionRow extends StatelessWidget { class RouteOptionRow extends StatelessWidget {
const RouteOptionRow({ const RouteOptionRow({
Key? key, super.key,
required this.plan, required this.plan,
this.mark, this.mark,
}) : super(key: key); });
final Plan plan; final Plan plan;
final RouteMark? mark; final RouteMark? mark;

View File

@ -1,3 +1,5 @@
// ignore_for_file: unused_element
import 'package:refilc_plus/ui/mobile/premium/upsell.dart'; import 'package:refilc_plus/ui/mobile/premium/upsell.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';

View File

@ -12,8 +12,7 @@ import 'package:provider/provider.dart';
import 'app_icon_screen.i18n.dart'; import 'app_icon_screen.i18n.dart';
class PremiumCustomAppIconMenu extends StatelessWidget { class PremiumCustomAppIconMenu extends StatelessWidget {
const PremiumCustomAppIconMenu({Key? key, required this.settings}) const PremiumCustomAppIconMenu({super.key, required this.settings});
: super(key: key);
final SettingsProvider settings; final SettingsProvider settings;
@ -43,7 +42,7 @@ class PremiumCustomAppIconMenu extends StatelessWidget {
} }
class ModifyAppIcon extends StatefulWidget { class ModifyAppIcon extends StatefulWidget {
const ModifyAppIcon({Key? key}) : super(key: key); const ModifyAppIcon({super.key});
@override @override
State<ModifyAppIcon> createState() => _ModifyAppIconState(); State<ModifyAppIcon> createState() => _ModifyAppIconState();
@ -167,14 +166,14 @@ class _ModifyAppIconState extends State<ModifyAppIcon> {
class AppIconItem extends StatelessWidget { class AppIconItem extends StatelessWidget {
const AppIconItem({ const AppIconItem({
Key? key, super.key,
required this.iconName, required this.iconName,
required this.iconPath, required this.iconPath,
required this.displayName, required this.displayName,
this.description, this.description,
required this.selected, required this.selected,
required this.selectCallback, required this.selectCallback,
}) : super(key: key); });
final String iconName; final String iconName;
final String iconPath; final String iconPath;

View File

@ -1,4 +1,3 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter_feather_icons/flutter_feather_icons.dart'; import 'package:flutter_feather_icons/flutter_feather_icons.dart';
import 'package:provider/provider.dart'; import 'package:provider/provider.dart';
@ -23,10 +22,10 @@ class GradeRarityTextSetting extends StatefulWidget {
final List<String> defaultRarities; final List<String> defaultRarities;
@override @override
_GradeRarityTextSettingState createState() => _GradeRarityTextSettingState(); GradeRarityTextSettingState createState() => GradeRarityTextSettingState();
} }
class _GradeRarityTextSettingState extends State<GradeRarityTextSetting> { class GradeRarityTextSettingState extends State<GradeRarityTextSetting> {
late SettingsProvider settings; late SettingsProvider settings;
late DatabaseProvider db; late DatabaseProvider db;
late UserProvider user; late UserProvider user;

View File

@ -3,7 +3,7 @@ import 'package:flutter/material.dart';
import 'package:provider/provider.dart'; import 'package:provider/provider.dart';
class PremiumShareTheme extends StatefulWidget { class PremiumShareTheme extends StatefulWidget {
const PremiumShareTheme({Key? key}) : super(key: key); const PremiumShareTheme({super.key});
@override @override
State<PremiumShareTheme> createState() => _PremiumShareThemeState(); State<PremiumShareTheme> createState() => _PremiumShareThemeState();

View File

@ -35,6 +35,8 @@ dependencies:
flutter_dynamic_icon: ^2.1.0 flutter_dynamic_icon: ^2.1.0
android_dynamic_icon: ^1.0.1 android_dynamic_icon: ^1.0.1
i18n_extension: ^11.0.12 i18n_extension: ^11.0.12
http: ^1.2.0
fl_chart: ^0.45.1
dev_dependencies: dev_dependencies:
flutter_lints: ^3.0.1 flutter_lints: ^3.0.1