firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Specs: define registerElement() more carefully; add an 'end tag

Browse Source 
parsed' callback; pass the element's module to the constructor when
constructing a custom element (these are rather experimental changes
and we may want to go a different way on this stuff)

Review URL: https://codereview.chromium.org/701873004
This commit is contained in:
Hixie 2014-11-04 11:57:02 -08:00
parent 44ac35308c
commit 01f3d8fa67
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
examples/radio.sky
View File

@ -16,9 +16,9 @@ SKY MODULE - radio button and radio button group
module.exports.RadioElement = module.registerElement({ module.exports.RadioElement = module.registerElement({
tagName: 'radio', tagName: 'radio',
shadow: true, shadow: true,
prototype: class extends Element { prototype: (class extends Element {
constructor () { constructor (module) {
super(); super(module);
this.addEventListener('click', (event) => this.checked = true); this.addEventListener('click', (event) => this.checked = true);
this.shadowRoot.appendChild(module.document.findId('radio-shadow').content.cloneNode(true)); this.shadowRoot.appendChild(module.document.findId('radio-shadow').content.cloneNode(true));
} }
@ -42,7 +42,7 @@ SKY MODULE - radio button and radio button group
if (this.parentNode instanceof module.exports.RadioGroupElement) if (this.parentNode instanceof module.exports.RadioGroupElement)
this.parentNode.setChecked(this); this.parentNode.setChecked(this);
} }
}, }).prototype,
}); });
</script> </script>
@ -56,9 +56,9 @@ SKY MODULE - radio button and radio button group
module.exports.RadioGroupElement = module.registerElement({ module.exports.RadioGroupElement = module.registerElement({
tagName: 'radiogroup', tagName: 'radiogroup',
shadow: true, shadow: true,
prototype: class extends Element { prototype: (class extends Element {
constructor () { constructor (module) {
super(); super(module);
this.shadowRoot.appendChild(module.document.findId('radiogroup-shadow').content.cloneNode(true)); this.shadowRoot.appendChild(module.document.findId('radiogroup-shadow').content.cloneNode(true));
} }
get value () { get value () {
@ -85,6 +85,6 @@ SKY MODULE - radio button and radio button group
if (child != radio) if (child != radio)
child.checked = false; child.checked = false;
} }
}, }).prototype,
}); });
</script> </script>