firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use ValueKey finder instead of text finder in keyboard_textfield_test (#97996)

Browse Source
This commit is contained in:
LongCatIsLooong 2022-02-07 20:00:19 -08:00 committed by GitHub
parent 3f7d997c3a
commit 213f766e35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dev/integration_tests/ui/lib/keyboard_textfield.dart
View File

@ -55,16 +55,17 @@ class _MyHomePageState extends State<MyHomePage> {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final String softKeyboardVisibility = MediaQuery.of(context).viewInsets.bottom > 100 final bool isSoftKeyboardVisible = MediaQuery.of(context).viewInsets.bottom > 100;
? 'keyboard visible'
: 'keyboard not visible';
return Scaffold( return Scaffold(
body: Column( body: Column(
children: <Widget>[ children: <Widget>[
Text('$offset', Text('$offset',
key: const ValueKey<String>(keys.kOffsetText), key: const ValueKey<String>(keys.kOffsetText),
), ),
Text(softKeyboardVisibility), if (isSoftKeyboardVisible) const Text(
'keyboard visible',
key: ValueKey<String>(keys.kKeyboardVisibleView),
),
Expanded( Expanded(
child: ListView( child: ListView(
key: const ValueKey<String>(keys.kListView), key: const ValueKey<String>(keys.kListView),

1
dev/integration_tests/ui/lib/keys.dart
View File

@ -7,3 +7,4 @@ const String kHeightText = 'height_text';
const String kUnfocusButton = 'unfocus_button'; const String kUnfocusButton = 'unfocus_button';
const String kOffsetText = 'offset_text'; const String kOffsetText = 'offset_text';
const String kListView = 'list_view'; const String kListView = 'list_view';
const String kKeyboardVisibleView = 'keyboard_visible';

2
dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart
View File

@ -24,7 +24,7 @@ void main() {
final SerializableFinder listViewFinder = find.byValueKey(keys.kListView); final SerializableFinder listViewFinder = find.byValueKey(keys.kListView);
final SerializableFinder textFieldFinder = find.byValueKey(keys.kDefaultTextField); final SerializableFinder textFieldFinder = find.byValueKey(keys.kDefaultTextField);
final SerializableFinder offsetFinder = find.byValueKey(keys.kOffsetText); final SerializableFinder offsetFinder = find.byValueKey(keys.kOffsetText);
final SerializableFinder keyboardVisibilityIndicatorFinder = find.text('keyboard visible'); final SerializableFinder keyboardVisibilityIndicatorFinder = find.byValueKey(keys.kKeyboardVisibleView);
// Align TextField with bottom edge to ensure it would be covered when keyboard comes up. // Align TextField with bottom edge to ensure it would be covered when keyboard comes up.
await driver.waitForAbsent(textFieldFinder); await driver.waitForAbsent(textFieldFinder);