firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary kCliAnimationsFeatureName that is available as .configSetting. (#158013)

Browse Source 
... for consistency with the rest of the file/features.
This commit is contained in:
Matan Lurey 2024-11-01 12:20:59 -07:00 committed by GitHub
parent 49ccfb7302
commit 2ce743d0f0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/features.dart
View File

@ -146,14 +146,12 @@ const Feature flutterCustomDevicesFeature = Feature(
),
);
const String kCliAnimationsFeatureName = 'cli-animations';
/// The [Feature] for CLI animations.
///
/// The TERM environment variable set to "dumb" turns this off.
const Feature cliAnimation = Feature.fullyEnabled(
name: 'animations in the command line interface',
configSetting: kCliAnimationsFeatureName,
configSetting: 'cli-animations',
);
/// Enable native assets compilation and bundling.

2
packages/flutter_tools/test/general.shard/reporting/first_run_test.dart
View File

@ -20,7 +20,7 @@ void main() {
testWithoutContext('FirstRunMessenger informs user how to disable animations', () {
final FirstRunMessenger messenger = setUpFirstRunMessenger(redisplayWelcomeMessage: false);
expect(messenger.licenseTerms, contains('flutter config --no-$kCliAnimationsFeatureName'));
expect(messenger.licenseTerms, contains('flutter config --no-${cliAnimation.configSetting}'));
});
testWithoutContext('FirstRunMessenger requires redisplay if it has never been run before', () {