firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "[Tool] [Windows] Output app path on build completion (#122858)" (#122926)

Browse Source 
Revert "[Tool] [Windows] Output app path on build completion"
This commit is contained in:
Loïc Sharma 2023-03-17 14:29:12 -07:00 committed by GitHub
parent db5711bfad
commit 3635a3048e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
dev/devicelab/lib/tasks/run_tests.dart
View File

@ -177,9 +177,6 @@ class WindowsRunOutputTest extends DesktopRunOutputTest {
r'Building Windows application\.\.\.\s*\d+(\.\d+)?(ms|s)', r'Building Windows application\.\.\.\s*\d+(\.\d+)?(ms|s)',
multiLine: true, multiLine: true,
); );
static final RegExp _builtOutput = RegExp(
r'Built build\\windows\\runner\\(Debug|Release)\\\w+\.exe( \(\d+(\.\d+)?MB\))?\.',
);
@override @override
void verifyBuildOutput(List<String> stdout) { void verifyBuildOutput(List<String> stdout) {
@ -188,25 +185,6 @@ class WindowsRunOutputTest extends DesktopRunOutputTest {
_buildOutput.hasMatch, _buildOutput.hasMatch,
'Building Windows application...', 'Building Windows application...',
); );
final String buildMode = release ? 'Release' : 'Debug';
_findNextMatcherInList(
stdout,
(String line) {
if (!_builtOutput.hasMatch(line) || !line.contains(buildMode)) {
return false;
}
// Size information is only included in release builds.
final bool hasSize = line.contains('MB).');
if (release != hasSize) {
return false;
}
return true;
},
'Built build\\windows\\runner\\$buildMode\\app.exe',
);
} }
} }

17
packages/flutter_tools/lib/src/windows/build_windows.dart
View File

@ -8,7 +8,6 @@ import '../base/common.dart';
import '../base/file_system.dart'; import '../base/file_system.dart';
import '../base/logger.dart'; import '../base/logger.dart';
import '../base/project_migrator.dart'; import '../base/project_migrator.dart';
import '../base/terminal.dart';
import '../base/utils.dart'; import '../base/utils.dart';
import '../build_info.dart'; import '../build_info.dart';
import '../cache.dart'; import '../cache.dart';
@ -93,22 +92,6 @@ Future<void> buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, {
} finally { } finally {
status.stop(); status.stop();
} }
final File appFile = buildDirectory
.childDirectory('runner')
.childDirectory(sentenceCase(buildModeName))
.childFile('${windowsProject.parent.manifest.appName}.exe');
if (appFile.existsSync()) {
final String appSize = (buildInfo.mode == BuildMode.debug)
? '' // Don't display the size when building a debug variant.
: ' (${getSizeAsMB(appFile.lengthSync())})';
globals.logger.printStatus(
'${globals.logger.terminal.successMark} '
'Built ${globals.fs.path.relative(appFile.path)}$appSize.',
color: TerminalColor.green,
);
}
if (buildInfo.codeSizeDirectory != null && sizeAnalyzer != null) { if (buildInfo.codeSizeDirectory != null && sizeAnalyzer != null) {
final String arch = getNameForTargetPlatform(TargetPlatform.windows_x64); final String arch = getNameForTargetPlatform(TargetPlatform.windows_x64);
final File codeSizeFile = globals.fs.directory(buildInfo.codeSizeDirectory) final File codeSizeFile = globals.fs.directory(buildInfo.codeSizeDirectory)