firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Partially Rollback caret change for Android (#32043)

Browse Source
This commit is contained in:
Gary Qian 2019-05-03 12:32:04 -07:00 committed by GitHub
parent 0a3df1b576
commit 3bd1737c0e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/rendering/editable.dart
View File

@ -1503,7 +1503,7 @@ class RenderEditable extends RenderBox {
case TargetPlatform.iOS: case TargetPlatform.iOS:
return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight + 2); return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight + 2);
default: default:
return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight - 2.0 * _kCaretHeightOffset); return Rect.fromLTWH(0.0, _kCaretHeightOffset, cursorWidth, preferredLineHeight - 2.0 * _kCaretHeightOffset);
} }
} }
@override @override
@ -1569,7 +1569,7 @@ class RenderEditable extends RenderBox {
// TODO(garyq): See the TODO for _getCaretPrototype. // TODO(garyq): See the TODO for _getCaretPrototype.
caretRect = Rect.fromLTWH( caretRect = Rect.fromLTWH(
caretRect.left, caretRect.left,
caretRect.top, caretRect.top - _kCaretHeightOffset,
caretRect.width, caretRect.width,
_textPainter.getFullHeightForCaret(textPosition, _caretPrototype), _textPainter.getFullHeightForCaret(textPosition, _caretPrototype),
); );