firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant assignment of geometry (#151821)

Browse Source 
Remove redundant assignment of geometry.
This commit is contained in:
hgraceb 2024-07-18 00:34:53 +08:00 committed by GitHub
parent e5d8466006
commit 46cb56d313
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -125,3 +125,4 @@ Amir Panahandeh <amirpanahandeh@gmail.com>
Kostiantyn Sokolovskyi <sokolovskyi.konstantin@gmail.com> Kostiantyn Sokolovskyi <sokolovskyi.konstantin@gmail.com>
Valentin Vignal <valentin.vignal.dev@outlook.fr> Valentin Vignal <valentin.vignal.dev@outlook.fr>
Cedric Vanden Bosch <cedvdb@youvision.dev> Cedric Vanden Bosch <cedvdb@youvision.dev>
Flop <kukuzuo@gmail.com>

11
packages/flutter/lib/src/rendering/sliver_persistent_header.dart
View File

@ -365,20 +365,9 @@ abstract class RenderSliverScrollingPersistentHeader extends RenderSliverPersist
return stretchOffset > 0 ? 0.0 : math.min(0.0, paintExtent - childExtent); return stretchOffset > 0 ? 0.0 : math.min(0.0, paintExtent - childExtent);
} }
@override @override
void performLayout() { void performLayout() {
final SliverConstraints constraints = this.constraints;
final double maxExtent = this.maxExtent;
layoutChild(constraints.scrollOffset, maxExtent); layoutChild(constraints.scrollOffset, maxExtent);
final double paintExtent = maxExtent - constraints.scrollOffset;
geometry = SliverGeometry(
scrollExtent: maxExtent,
paintOrigin: math.min(constraints.overlap, 0.0),
paintExtent: clampDouble(paintExtent, 0.0, constraints.remainingPaintExtent),
maxPaintExtent: maxExtent,
hasVisualOverflow: true, // Conservatively say we do have overflow to avoid complexity.
);
_childPosition = updateGeometry(); _childPosition = updateGeometry();
} }