firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] skip perspective transformed text goldens. (#143623)

Browse Source 
Part of https://github.com/flutter/flutter/issues/143616

The perspective transformed text goldens are super unstable, possibly for the same reason they are in flutter/engine.
This commit is contained in:
Jonah Williams 2024-02-16 18:13:22 -08:00 committed by GitHub
parent bb1c7a6ccb
commit 4e27f3472c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/test/cupertino/date_picker_test.dart
View File

@ -15,6 +15,8 @@ import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart'; import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
import '../impeller_test_helpers.dart';
// TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785 // TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785
const bool skipPerspectiveTextGoldens = isBrowser; const bool skipPerspectiveTextGoldens = isBrowser;
@ -1607,7 +1609,7 @@ void main() {
matchesGoldenFile('date_picker_test.datetime.drag.png'), matchesGoldenFile('date_picker_test.datetime.drag.png'),
); );
} }
}); }, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
testWidgets('DatePicker displays the date in correct order', (WidgetTester tester) async { testWidgets('DatePicker displays the date in correct order', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
@ -1752,7 +1754,7 @@ void main() {
matchesGoldenFile('timer_picker_test.datetime.drag.png'), matchesGoldenFile('timer_picker_test.datetime.drag.png'),
); );
} }
}); }, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
testWidgets('TimerPicker only changes hour label after scrolling stops', (WidgetTester tester) async { testWidgets('TimerPicker only changes hour label after scrolling stops', (WidgetTester tester) async {
Duration? duration; Duration? duration;