firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip /api/update-task-status on Devicelab (#165614)

Browse Source 
Mitigates https://github.com/flutter/flutter/issues/165610.

If this works, we can likely not only fix the tree status, but delete
code from Cocoon (and dev/devicelab). Yay!
This commit is contained in:
Matan Lurey 2025-03-20 17:08:03 -07:00 committed by GitHub
parent cab4fe33c3
commit 55f257e39e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
dev/devicelab/lib/command/upload_results.dart
View File

@ -53,8 +53,8 @@ class UploadResultsCommand extends Command<void> {
@override
Future<void> run() async {
final String? resultsPath = argResults!['results-file'] as String?;
final String? serviceAccountTokenFile = argResults!['service-account-token-file'] as String?;
final String? testFlakyStatus = argResults!['test-flaky'] as String?;
// final String? serviceAccountTokenFile = argResults!['service-account-token-file'] as String?;
// final String? testFlakyStatus = argResults!['test-flaky'] as String?;
final String? gitBranch = argResults!['git-branch'] as String?;
final String? builderName = argResults!['luci-builder'] as String?;
final String? testStatus = argResults!['test-status'] as String?;
@ -69,14 +69,17 @@ class UploadResultsCommand extends Command<void> {
print('Successfully uploaded metrics to skia perf');
}
final Cocoon cocoon = Cocoon(serviceAccountTokenPath: serviceAccountTokenFile);
return cocoon.sendTaskStatus(
resultsPath: resultsPath,
isTestFlaky: testFlakyStatus == 'True',
gitBranch: gitBranch,
builderName: builderName,
testStatus: testStatus,
builderBucket: builderBucket,
print(
'Intentionally skipping /api/update-task-status ($gitBranch/$builderName/$testStatus/$builderBucket) because yjbanov@ said so',
);
// final Cocoon cocoon = Cocoon(serviceAccountTokenPath: serviceAccountTokenFile);
// return cocoon.sendTaskStatus(
// resultsPath: resultsPath,
// isTestFlaky: testFlakyStatus == 'True',
// gitBranch: gitBranch,
// builderName: builderName,
// testStatus: testStatus,
// builderBucket: builderBucket,
// );
}
}