firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove now-unnecessary command felt analyze. (#160986)

Browse Source 
Closes https://github.com/flutter/flutter/issues/154143.

The entire engine sub-repo is now checked for Dart analysis issues, so a
separate command is not needed.
This commit is contained in:
Matan Lurey 2025-01-06 13:43:47 -08:00 committed by GitHub
parent 18163e3695
commit 5a23a2a3c4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 0 additions and 76 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/ci/builders/linux_web_engine_test.json
View File

@ -194,13 +194,6 @@
"check-licenses"
],
"script": "flutter/lib/web_ui/dev/felt"
},
{
"name": "web engine analysis",
"parameters": [
"analyze"
],
"script": "flutter/lib/web_ui/dev/felt"
}
]
},

62
engine/src/flutter/lib/web_ui/dev/analyze.dart
View File

@ -1,62 +0,0 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'package:args/command_runner.dart';
import 'environment.dart';
import 'pipeline.dart';
import 'utils.dart';
class AnalyzeCommand extends Command<bool> with ArgUtils<bool> {
@override
String get name => 'analyze';
@override
String get description => 'Analyze the Flutter web engine.';
@override
FutureOr<bool> run() async {
final Pipeline buildPipeline = Pipeline(steps: <PipelineStep>[PubGetStep(), AnalyzeStep()]);
await buildPipeline.run();
return true;
}
}
/// Runs `dart pub get`.
class PubGetStep extends ProcessStep {
@override
String get description => 'pub get';
@override
bool get isSafeToInterrupt => true;
@override
Future<ProcessManager> createProcess() {
print('Running `dart pub get`...');
return startProcess(environment.dartExecutable, <String>[
'pub',
'get',
], workingDirectory: environment.webUiRootDir.path);
}
}
/// Runs `dart analyze --fatal-infos`.
class AnalyzeStep extends ProcessStep {
@override
String get description => 'analyze';
@override
bool get isSafeToInterrupt => true;
@override
Future<ProcessManager> createProcess() {
print('Running `dart analyze`...');
return startProcess(environment.dartExecutable, <String>[
'analyze',
'--fatal-infos',
], workingDirectory: environment.webUiRootDir.path);
}
}

2
engine/src/flutter/lib/web_ui/dev/felt.dart
View File

@ -6,7 +6,6 @@ import 'dart:io' as io;
import 'package:args/command_runner.dart';
import 'analyze.dart';
import 'build.dart';
import 'clean.dart';
import 'exceptions.dart';
@ -18,7 +17,6 @@ import 'utils.dart';
CommandRunner<bool> runner =
CommandRunner<bool>('felt', 'Command-line utility for building and testing Flutter web engine.')
..addCommand(AnalyzeCommand())
..addCommand(BuildCommand())
..addCommand(CleanCommand())
..addCommand(RollFallbackFontsCommand())

5
engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart
View File

@ -117,11 +117,6 @@ class GenerateBuilderJsonCommand extends Command<bool> {
'parameters': <String>['check-licenses'],
'script': 'flutter/lib/web_ui/dev/felt',
},
<String, dynamic>{
'name': 'web engine analysis',
'parameters': <String>['analyze'],
'script': 'flutter/lib/web_ui/dev/felt',
},
],
};
}