firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes multi line textfield hint text gets ellipsized (#148423)

Browse Source 
fixes https://github.com/flutter/flutter/issues/148353
This commit is contained in:
chunhtai 2024-06-03 15:03:06 -07:00 committed by GitHub
parent 5e448f4ce5
commit 6ec1c75ac7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/input_decorator.dart
View File

@ -2164,7 +2164,7 @@ class _InputDecoratorState extends State<InputDecorator> with TickerProviderStat
hintText, hintText,
style: hintStyle, style: hintStyle,
textDirection: decoration.hintTextDirection, textDirection: decoration.hintTextDirection,
overflow: hintStyle.overflow ?? TextOverflow.ellipsis, overflow: hintStyle.overflow ?? (decoration.hintMaxLines == null ? null : TextOverflow.ellipsis),
textAlign: textAlign, textAlign: textAlign,
maxLines: decoration.hintMaxLines, maxLines: decoration.hintMaxLines,
), ),

42
packages/flutter/test/material/text_field_test.dart
View File

@ -1875,6 +1875,48 @@ void main() {
expect(find.text('Paste'), findsOneWidget); expect(find.text('Paste'), findsOneWidget);
}, skip: isContextMenuProvidedByPlatform); // [intended] only applies to platforms where we supply the context menu. }, skip: isContextMenuProvidedByPlatform); // [intended] only applies to platforms where we supply the context menu.
testWidgets('infinite multi-line text hint text is not ellipsized by default', (WidgetTester tester) async {
const String kLongString =
'Enter your email Enter your email Enter your '
'email Enter your email Enter your email Enter '
'your email Enter your email';
const double defaultLineHeight = 24;
await tester.pumpWidget(overlay(
child: const TextField(
maxLines: null,
decoration: InputDecoration(
labelText: 'Email',
hintText: kLongString,
),
),
));
final Text hintText = tester.widget<Text>(find.text(kLongString));
expect(hintText.overflow, isNull);
final RenderParagraph paragraph = tester.renderObject<RenderParagraph>(find.text(kLongString));
expect(paragraph.size.height > defaultLineHeight * 2, isTrue);
});
testWidgets('non-infinite multi-line hint text is ellipsized by default', (WidgetTester tester) async {
const String kLongString =
'Enter your email Enter your email Enter your '
'email Enter your email Enter your email Enter '
'your email Enter your email';
const double defaultLineHeight = 24;
await tester.pumpWidget(overlay(
child: const TextField(
maxLines: 2,
decoration: InputDecoration(
labelText: 'Email',
hintText: kLongString,
),
),
));
final Text hintText = tester.widget<Text>(find.text(kLongString));
expect(hintText.overflow, TextOverflow.ellipsis);
final RenderParagraph paragraph = tester.renderObject<RenderParagraph>(find.text(kLongString));
expect(paragraph.size.height < defaultLineHeight * 2 + precisionErrorTolerance, isTrue);
});
testWidgets('Entering text hides selection handle caret', (WidgetTester tester) async { testWidgets('Entering text hides selection handle caret', (WidgetTester tester) async {
final TextEditingController controller = _textEditingController(); final TextEditingController controller = _textEditingController();