firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adjust timeout for devicelab tests (#156553)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/156456

There is a known long running test that has been bumping up against the default timeout. This adjusts the perTestTimeout for the devicelab tests to add 15 seconds to stop this from flaking.

The test is question: 82ebb74c64/dev/devicelab/test/run_test.dart (L76)

`test/run_test.dart: run.dart script prints a message after a few seconds when failing to connect (this test takes >10s)`
This commit is contained in:
Kate Lovett 2024-10-15 13:47:03 -07:00 committed by GitHub
parent 9fe609ecf4
commit 7b0b03bc0d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dev/bots/suite_runners/run_framework_tests.dart
View File

@ -235,7 +235,10 @@ Future<void> frameworkTestsRunner() async {
tests: <String>[ 'test' ],
);
await runDartTest(path.join(flutterRoot, 'dev', 'bots'));
await runDartTest(path.join(flutterRoot, 'dev', 'devicelab'), ensurePrecompiledTool: false); // See https://github.com/flutter/flutter/issues/86209
await runDartTest(
path.join(flutterRoot, 'dev', 'devicelab'),
ensurePrecompiledTool: false, // See https://github.com/flutter/flutter/issues/86209
);
await runDartTest(path.join(flutterRoot, 'dev', 'conductor', 'core'), forceSingleCore: true);
// TODO(gspencergoog): Remove the exception for fatalWarnings once https://github.com/flutter/flutter/issues/113782 has landed.
await runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'android_semantics_testing'), fatalWarnings: false);

2
dev/devicelab/test/run_test.dart
View File

@ -91,7 +91,7 @@ void main() {
emitsThrough(contains('VM service still not ready. It is possible the target has failed')),
);
expect(process.kill(), isTrue);
});
}, timeout: const Timeout(Duration(seconds: 45))); // Standard 30 is flaky because this is a long running test, https://github.com/flutter/flutter/issues/156456
test('exits with code 1 when results are mixed', () async {
await expectScriptResult(