firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add --no-dds to Mac_arm64_ios version of hot_mode_dev_cycle_ios__benchmark (#145335)

Browse Source 
Attempting to debug https://github.com/flutter/flutter/issues/142305.
This commit is contained in:
Victoria Ashworth 2024-03-18 13:51:26 -05:00 committed by GitHub
parent f4ee956d3e
commit 7f368f7ed4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.ci.yaml
View File

@ -4690,7 +4690,8 @@ targets:
properties:
tags: >
["devicelab", "ios", "mac"]
task_name: hot_mode_dev_cycle_ios__benchmark
# TODO(vashworth): Use "hot_mode_dev_cycle_ios__benchmark" once https://github.com/flutter/flutter/issues/142305 is fixed.
task_name: hot_mode_dev_cycle_ios__benchmark_no_dds
- name: Mac_x64 hot_mode_dev_cycle_ios_simulator
recipe: devicelab/devicelab_drone

2
TESTOWNERS
View File

@ -184,6 +184,8 @@
/dev/devicelab/bin/tasks/fullscreen_textfield_perf_ios__e2e_summary.dart @vashworth @flutter/engine
/dev/devicelab/bin/tasks/hello_world_ios__compile.dart @jmagman @flutter/engine
/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark.dart @vashworth @flutter/tool
# TODO(vashworth): Remove once https://github.com/flutter/flutter/issues/142305 is fixed.
/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/imagefiltered_transform_animation_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine
/dev/devicelab/bin/tasks/integration_test_test_ios.dart @jmagman @flutter/engine
/dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @vashworth @flutter/tool

15
dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart Normal file
View File

@ -0,0 +1,15 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/hot_mode_tests.dart';
Future<void> main() async {
// TODO(vashworth): Remove once https://github.com/flutter/flutter/issues/142305 is fixed.
deviceOperatingSystem = DeviceOperatingSystem.ios;
await task(createHotModeTest(
additionalOptions: <String>['--no-dds'],
));
}

2
dev/devicelab/lib/tasks/hot_mode_tests.dart
View File

@ -23,6 +23,7 @@ const String kReplacementLine = 'fontSize: (orientation == Orientation.portrait)
TaskFunction createHotModeTest({
String? deviceIdOverride,
bool checkAppRunningOnLocalDevice = false,
List<String>? additionalOptions,
}) {
// This file is modified during the test and needs to be restored at the end.
final File flutterFrameworkSource = file(path.join(
@ -47,6 +48,7 @@ TaskFunction createHotModeTest({
'--no-publish-port',
'--verbose',
'--uninstall-first',
if (additionalOptions != null) ...additionalOptions,
];
int hotReloadCount = 0;
late Map<String, dynamic> smallReloadData;