firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Disable usage of bare instructions in AOT (#27410)" (#27789)

Browse Source 
This reverts commit 965dc52e2e86158a983e502ecfbac07ee29035f4 as performance gains seems to outweigh compressed apk size increase.
This commit is contained in:
Alexander Aprelev 2019-02-13 15:29:50 -08:00 committed by GitHub
parent d8cd2ff484
commit 8de5a07c3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter_tools/lib/src/base/build.dart
View File

@ -125,7 +125,6 @@ class AOTSnapshotter {
final String depfilePath = fs.path.join(outputDir.path, 'snapshot.d'); final String depfilePath = fs.path.join(outputDir.path, 'snapshot.d');
final List<String> genSnapshotArgs = <String>[ final List<String> genSnapshotArgs = <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
]; ];
if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) { if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) {
printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions'); printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions');

8
packages/flutter_tools/test/base/build_test.dart
View File

@ -193,7 +193,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--no-sim-use-hardfp', '--no-sim-use-hardfp',
@ -233,7 +232,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill', 'main.dill',
@ -273,7 +271,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -318,7 +315,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -359,7 +355,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--no-sim-use-hardfp', '--no-sim-use-hardfp',
@ -399,7 +394,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill', 'main.dill',
@ -457,7 +451,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -502,7 +495,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',