firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

_RawAutocompleteState should dispose _highlightedOptionIndex. (#133700)

Browse Source
This commit is contained in:
Polina Cherkasova 2023-08-30 16:07:35 -07:00 committed by GitHub
parent 31600c829e
commit 95e197ba69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/widgets/autocomplete.dart
View File

@ -565,6 +565,7 @@ class _RawAutocompleteState<T extends Object> extends State<RawAutocomplete<T>>
_floatingOptions?.remove(); _floatingOptions?.remove();
_floatingOptions?.dispose(); _floatingOptions?.dispose();
_floatingOptions = null; _floatingOptions = null;
_highlightedOptionIndex.dispose();
super.dispose(); super.dispose();
} }

4
packages/flutter/test/material/autocomplete_test.dart
View File

@ -5,6 +5,7 @@
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
class User { class User {
const User({ const User({
@ -45,7 +46,8 @@ void main() {
User(name: 'Charlie', email: 'charlie123@gmail.com'), User(name: 'Charlie', email: 'charlie123@gmail.com'),
]; ];
testWidgets('can filter and select a list of string options', (WidgetTester tester) async { testWidgetsWithLeakTracking('can filter and select a list of string options', (WidgetTester tester) async {
late String lastSelection; late String lastSelection;
await tester.pumpWidget( await tester.pumpWidget(
MaterialApp( MaterialApp(