firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove duplicate setState in TextFormFieldState.reset (#69062)

Browse Source 
Small performance optimization by removing a duplicate setState call.
This commit is contained in:
Justin McCandless 2020-12-14 10:26:52 -08:00 committed by GitHub
parent cd294666bf
commit a42aa04826
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/material/text_form_field.dart
View File

@ -359,10 +359,10 @@ class _TextFormFieldState extends FormFieldState<String> {
@override @override
void reset() { void reset() {
// setState will be called in the superclass, so even though state is being
// manipulated, no setState call is needed here.
_effectiveController!.text = widget.initialValue ?? '';
super.reset(); super.reset();
setState(() {
_effectiveController!.text = widget.initialValue ?? '';
});
} }
void _handleControllerChanged() { void _handleControllerChanged() {