firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Add equals and hasCode to Tween (#37793)" (#37895)

Browse Source 
This reverts commit b39e315e5cb9a9c51ebdf3242a108084378a1d9b.
This commit is contained in:
Michael Goderbauer 2019-08-08 18:15:40 -07:00 committed by GitHub
parent 90a3d8e3ca
commit a9151779aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/flutter/lib/src/animation/tween.dart
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
import 'dart:ui' show Color, Rect, Size, hashValues; import 'dart:ui' show Color, Size, Rect;
import 'package:flutter/foundation.dart'; import 'package:flutter/foundation.dart';
@ -260,21 +260,6 @@ class Tween<T extends dynamic> extends Animatable<T> {
return lerp(t); return lerp(t);
} }
@override
int get hashCode {
return hashValues(begin, end);
}
@override
bool operator ==(dynamic other) {
if (identical(this, other))
return true;
if (other.runtimeType != runtimeType)
return false;
final Tween<T> typedOther = other;
return typedOther.begin == begin && typedOther.end == end;
}
@override @override
String toString() => '$runtimeType($begin \u2192 $end)'; String toString() => '$runtimeType($begin \u2192 $end)';
} }

14
packages/flutter/test/animation/tween_test.dart
View File

@ -93,18 +93,4 @@ void main() {
expect(tween.lerp(0.5), 100.0); expect(tween.lerp(0.5), 100.0);
expect(tween.lerp(1.0), 100.0); expect(tween.lerp(1.0), 100.0);
}); });
test('Tween equals', () {
final Tween<double> doubleTween1 = Tween<double>(begin: 10, end: 22);
final Tween<double> doubleTween2 = Tween<double>(begin: 10, end: 22);
final Tween<double> doubleTween3 = Tween<double>(begin: 33, end: 44);
final Tween<int> intTween = Tween<int>(begin: 33, end: 44);
final Tween<double> constantTween = ConstantTween<double>(10);
expect(doubleTween1 == doubleTween1, isTrue);
expect(doubleTween1 == doubleTween2, isTrue);
expect(doubleTween2 == doubleTween3, isFalse);
expect(doubleTween2 == intTween, isFalse);
expect(doubleTween1 == constantTween, isFalse);
});
} }