firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add the number of mismatched pixels to golden tests output (#142975)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/141036
This commit is contained in:
Valentin Vignal 2024-02-08 02:59:57 +08:00 committed by GitHub
parent 0202e3bf7a
commit ab836a2db0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_test/lib/src/_goldens_io.dart
View File

@ -262,7 +262,7 @@ Future<ComparisonResult> compareLists(List<int>? test, List<int>? master) async
passed: false, passed: false,
diffPercent: diffPercent, diffPercent: diffPercent,
error: 'Pixel test failed, ' error: 'Pixel test failed, '
'${(diffPercent * 100).toStringAsFixed(2)}% ' '${(diffPercent * 100).toStringAsFixed(2)}%, ${pixelDiffCount}px '
'diff detected.', 'diff detected.',
diffs: <String, Image>{ diffs: <String, Image>{
'masterImage' : masterImage, 'masterImage' : masterImage,

6
packages/flutter_test/test/goldens_test.dart
View File

@ -192,7 +192,7 @@ void main() {
throwsA(isFlutterError.having( throwsA(isFlutterError.having(
(FlutterError error) => error.message, (FlutterError error) => error.message,
'message', 'message',
contains('% diff detected'), contains('100.00%, 1px diff detected'),
)), )),
); );
final io.File master = fs.file( final io.File master = fs.file(
@ -223,7 +223,7 @@ void main() {
throwsA(isFlutterError.having( throwsA(isFlutterError.having(
(FlutterError error) => error.message, (FlutterError error) => error.message,
'message', 'message',
contains('% diff detected'), contains('100.00%, 1px diff detected'),
)), )),
); );
final io.File master = fs.file( final io.File master = fs.file(
@ -302,7 +302,7 @@ void main() {
throwsA(isFlutterError.having( throwsA(isFlutterError.having(
(FlutterError error) => error.message, (FlutterError error) => error.message,
'message', 'message',
contains('% diff detected'), contains('100.00%, 1px diff detected'),
)), )),
); );
}); });