firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "AlertDialog widget scrollable by default (#49848)" (#51886)

Browse Source 
This reverts commit 28f2c96a8a63ca75700b307692b3bc691d6d010c.
This commit is contained in:
Shi-Hao Hong 2020-03-03 14:03:05 -08:00 committed by GitHub
parent f9c118b6b2
commit ad44b05ca4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/dialog.dart
View File

@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget {
this.insetPadding = _defaultInsetPadding,
this.clipBehavior = Clip.none,
this.shape,
this.scrollable = true,
this.scrollable = false,
}) : assert(contentPadding != null),
assert(clipBehavior != null),
super(key: key);

3
packages/flutter/test/material/dialog_test.dart
View File

@ -1100,6 +1100,7 @@ void main() {
color: Colors.green,
height: 1000,
),
scrollable: true,
);
await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X'));
@ -1119,6 +1120,7 @@ void main() {
color: Colors.orange,
height: 1000,
),
scrollable: true,
);
await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X'));
@ -1144,6 +1146,7 @@ void main() {
color: Colors.orange,
height: 400,
),
scrollable: true,
);
await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X'));