firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up leaky test. (#152094)

Browse Source
This commit is contained in:
Polina Cherkasova 2024-07-22 09:53:40 -07:00 committed by GitHub
parent c63733310f
commit c9ee9ad616
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/flutter/test/material/carousel_test.dart
View File

@ -256,11 +256,14 @@ void main() {
}); });
testWidgets('CarouselController initialItem', (WidgetTester tester) async { testWidgets('CarouselController initialItem', (WidgetTester tester) async {
final CarouselController controller = CarouselController(initialItem: 5);
addTearDown(controller.dispose);
await tester.pumpWidget( await tester.pumpWidget(
MaterialApp( MaterialApp(
home: Scaffold( home: Scaffold(
body: CarouselView( body: CarouselView(
controller: CarouselController(initialItem: 5), controller: controller,
itemExtent: 400, itemExtent: 400,
children: List<Widget>.generate(10, (int index) { children: List<Widget>.generate(10, (int index) {
return Center( return Center(
@ -290,11 +293,14 @@ void main() {
}); });
testWidgets('CarouselView.weighted respects CarouselController.initialItem', (WidgetTester tester) async { testWidgets('CarouselView.weighted respects CarouselController.initialItem', (WidgetTester tester) async {
final CarouselController controller = CarouselController(initialItem: 5);
addTearDown(controller.dispose);
await tester.pumpWidget( await tester.pumpWidget(
MaterialApp( MaterialApp(
home: Scaffold( home: Scaffold(
body: CarouselView.weighted( body: CarouselView.weighted(
controller: CarouselController(initialItem: 5), controller: controller,
flexWeights: const <int>[7, 1], flexWeights: const <int>[7, 1],
children: List<Widget>.generate(10, (int index) { children: List<Widget>.generate(10, (int index) {
return Center( return Center(
@ -324,11 +330,14 @@ void main() {
}); });
testWidgets('The initialItem should be the first item with expanded size(max extent)', (WidgetTester tester) async { testWidgets('The initialItem should be the first item with expanded size(max extent)', (WidgetTester tester) async {
final CarouselController controller = CarouselController(initialItem: 5);
addTearDown(controller.dispose);
await tester.pumpWidget( await tester.pumpWidget(
MaterialApp( MaterialApp(
home: Scaffold( home: Scaffold(
body: CarouselView.weighted( body: CarouselView.weighted(
controller: CarouselController(initialItem: 5), controller: controller,
flexWeights: const <int>[1, 8, 1], flexWeights: const <int>[1, 8, 1],
children: List<Widget>.generate(10, (int index) { children: List<Widget>.generate(10, (int index) {
return Center( return Center(
@ -945,6 +954,8 @@ void main() {
testWidgets('The initialItem stays when the flexWeights is updated', (WidgetTester tester) async { testWidgets('The initialItem stays when the flexWeights is updated', (WidgetTester tester) async {
final CarouselController controller = CarouselController(initialItem: 3); final CarouselController controller = CarouselController(initialItem: 3);
addTearDown(controller.dispose);
Widget buildCarousel(List<int> flexWeights) { Widget buildCarousel(List<int> flexWeights) {
return MaterialApp( return MaterialApp(
home: Scaffold( home: Scaffold(
@ -991,6 +1002,8 @@ void main() {
testWidgets('The item that currently occupies max weight stays when the flexWeights is updated', (WidgetTester tester) async { testWidgets('The item that currently occupies max weight stays when the flexWeights is updated', (WidgetTester tester) async {
final CarouselController controller = CarouselController(initialItem: 3); final CarouselController controller = CarouselController(initialItem: 3);
addTearDown(controller.dispose);
Widget buildCarousel(List<int> flexWeights) { Widget buildCarousel(List<int> flexWeights) {
return MaterialApp( return MaterialApp(
home: Scaffold( home: Scaffold(
@ -1038,6 +1051,8 @@ void main() {
testWidgets('The initialItem stays when the itemExtent is updated', (WidgetTester tester) async { testWidgets('The initialItem stays when the itemExtent is updated', (WidgetTester tester) async {
final CarouselController controller = CarouselController(initialItem: 3); final CarouselController controller = CarouselController(initialItem: 3);
addTearDown(controller.dispose);
Widget buildCarousel(double itemExtent) { Widget buildCarousel(double itemExtent) {
return MaterialApp( return MaterialApp(
home: Scaffold( home: Scaffold(