ToDo Audit - Cupertino+ Library (#54798)
This commit is contained in:
parent
88fd7081b1
commit
cbc121e392
@ -50,11 +50,7 @@ Future<void> main(List<String> arguments) async {
|
|||||||
final StringBuffer buf = StringBuffer();
|
final StringBuffer buf = StringBuffer();
|
||||||
buf.writeln('name: Flutter');
|
buf.writeln('name: Flutter');
|
||||||
buf.writeln('homepage: https://flutter.dev');
|
buf.writeln('homepage: https://flutter.dev');
|
||||||
// TODO(dnfield): We should make DartDoc able to avoid emitting this. If we
|
// TODO(dnfield): Re-factor for proper versioning, https://github.com/flutter/flutter/issues/55409
|
||||||
// use the real value here, every file will get marked as new instead of only
|
|
||||||
// files that have otherwise changed. Instead, we replace it dynamically using
|
|
||||||
// JavaScript so that fewer files get marked as changed.
|
|
||||||
// https://github.com/dart-lang/dartdoc/issues/1982
|
|
||||||
buf.writeln('version: 0.0.0');
|
buf.writeln('version: 0.0.0');
|
||||||
buf.writeln('dependencies:');
|
buf.writeln('dependencies:');
|
||||||
for (final String package in findPackageNames()) {
|
for (final String package in findPackageNames()) {
|
||||||
|
@ -99,7 +99,7 @@ bool _mapsEqual(Map<String, dynamic> expectedArgs, Map<String, dynamic> args) {
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO(dnfield): we can drop this in favor of vm_service when https://github.com/dart-lang/webdev/issues/899 is resolved.
|
// TODO(dnfield): This can be removed in favor of using the vm_service package, https://github.com/flutter/flutter/issues/55411
|
||||||
class TimelineObtainer {
|
class TimelineObtainer {
|
||||||
WebSocket _observatorySocket;
|
WebSocket _observatorySocket;
|
||||||
int _lastCallId = 0;
|
int _lastCallId = 0;
|
||||||
|
@ -18,10 +18,7 @@ void main() {
|
|||||||
await tester.pump();
|
await tester.pump();
|
||||||
|
|
||||||
// Verify it correctly exposes its semantics.
|
// Verify it correctly exposes its semantics.
|
||||||
// TODO(goderbauer): Use `SemanticsTester` after https://github.com/flutter/flutter/issues/12286.
|
final SemanticsNode semantics = tester.getSemantics(find.byType(AdjustableDropdownListTile));
|
||||||
final SemanticsNode semantics = tester
|
|
||||||
.renderObject(find.byType(AdjustableDropdownListTile))
|
|
||||||
.debugSemantics;
|
|
||||||
|
|
||||||
expectAdjustable(semantics,
|
expectAdjustable(semantics,
|
||||||
hasIncreaseAction: true,
|
hasIncreaseAction: true,
|
||||||
|
@ -937,13 +937,15 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
|
|||||||
Widget build(BuildContext context) {
|
Widget build(BuildContext context) {
|
||||||
return _ActionButtonParentDataWidget(
|
return _ActionButtonParentDataWidget(
|
||||||
isPressed: _isPressed,
|
isPressed: _isPressed,
|
||||||
// TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786
|
// TODO(mattcarroll): Button press dynamics need overhaul for iOS:
|
||||||
|
// https://github.com/flutter/flutter/issues/19786
|
||||||
child: GestureDetector(
|
child: GestureDetector(
|
||||||
excludeFromSemantics: true,
|
excludeFromSemantics: true,
|
||||||
behavior: HitTestBehavior.opaque,
|
behavior: HitTestBehavior.opaque,
|
||||||
onTapDown: (TapDownDetails details) => setState(() => _isPressed = true),
|
onTapDown: (TapDownDetails details) => setState(() => _isPressed = true),
|
||||||
onTapUp: (TapUpDetails details) => setState(() => _isPressed = false),
|
onTapUp: (TapUpDetails details) => setState(() => _isPressed = false),
|
||||||
// TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783
|
// TODO(mattcarroll): Cancel is currently triggered when user moves past
|
||||||
|
// slop instead of off button: https://github.com/flutter/flutter/issues/19783
|
||||||
onTapCancel: () => setState(() => _isPressed = false),
|
onTapCancel: () => setState(() => _isPressed = false),
|
||||||
child: widget.child,
|
child: widget.child,
|
||||||
),
|
),
|
||||||
|
@ -378,8 +378,8 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker
|
|||||||
// decoy will pop on top of the AppBar if the child is partially behind it,
|
// decoy will pop on top of the AppBar if the child is partially behind it,
|
||||||
// such as a top item in a partially scrolled view. However, if we don't use
|
// such as a top item in a partially scrolled view. However, if we don't use
|
||||||
// an overlay, then the decoy will appear behind its neighboring widget when
|
// an overlay, then the decoy will appear behind its neighboring widget when
|
||||||
// it expands. This may be solveable by adding a widget to Scaffold that's
|
// it expands. This may be solvable by adding a widget to Scaffold that's
|
||||||
// undernearth the AppBar.
|
// underneath the AppBar.
|
||||||
_lastOverlayEntry = OverlayEntry(
|
_lastOverlayEntry = OverlayEntry(
|
||||||
opaque: false,
|
opaque: false,
|
||||||
builder: (BuildContext context) {
|
builder: (BuildContext context) {
|
||||||
|
@ -995,7 +995,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
|
|||||||
return _ActionButtonParentDataWidget(
|
return _ActionButtonParentDataWidget(
|
||||||
isPressed: _isPressed,
|
isPressed: _isPressed,
|
||||||
child: MergeSemantics(
|
child: MergeSemantics(
|
||||||
// TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786
|
// TODO(mattcarroll): Button press dynamics need overhaul for iOS:
|
||||||
|
// https://github.com/flutter/flutter/issues/19786
|
||||||
child: GestureDetector(
|
child: GestureDetector(
|
||||||
excludeFromSemantics: true,
|
excludeFromSemantics: true,
|
||||||
behavior: HitTestBehavior.opaque,
|
behavior: HitTestBehavior.opaque,
|
||||||
@ -1005,7 +1006,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
|
|||||||
onTapUp: (TapUpDetails details) => setState(() {
|
onTapUp: (TapUpDetails details) => setState(() {
|
||||||
_isPressed = false;
|
_isPressed = false;
|
||||||
}),
|
}),
|
||||||
// TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783
|
// TODO(mattcarroll): Cancel is currently triggered when user moves
|
||||||
|
// past slop instead of off button: https://github.com/flutter/flutter/issues/19783
|
||||||
onTapCancel: () => setState(() => _isPressed = false),
|
onTapCancel: () => setState(() => _isPressed = false),
|
||||||
child: widget.child,
|
child: widget.child,
|
||||||
),
|
),
|
||||||
|
Loading…
x
Reference in New Issue
Block a user