firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix UNNECESSARY_TYPE_CHECK_TRUE violations. (#89186)

Browse Source
This commit is contained in:
Konstantin Scheglov 2021-08-31 16:46:05 -06:00 committed by GitHub
parent db0c4fa960
commit cfd0743d10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dev/bots/test.dart
View File

@ -455,9 +455,6 @@ Future<void> _runBuildTests() async {
Future<void> _runExampleProjectBuildTests(Directory exampleDirectory, [File? mainFile]) async { Future<void> _runExampleProjectBuildTests(Directory exampleDirectory, [File? mainFile]) async {
// Only verify caching with flutter gallery. // Only verify caching with flutter gallery.
final bool verifyCaching = exampleDirectory.path.contains('flutter_gallery'); final bool verifyCaching = exampleDirectory.path.contains('flutter_gallery');
if (exampleDirectory is! Directory) {
return;
}
final String examplePath = exampleDirectory.path; final String examplePath = exampleDirectory.path;
final bool hasNullSafety = File(path.join(examplePath, 'null_safety')).existsSync(); final bool hasNullSafety = File(path.join(examplePath, 'null_safety')).existsSync();
final List<String> additionalArgs = <String>[ final List<String> additionalArgs = <String>[

1
dev/devicelab/lib/framework/manifest.dart
View File

@ -107,7 +107,6 @@ List<ManifestTask> _validateAndParseTasks(dynamic tasksYaml) {
} }
ManifestTask _validateAndParseTask(String taskName, dynamic taskYaml) { ManifestTask _validateAndParseTask(String taskName, dynamic taskYaml) {
_checkType(taskName is String, taskName, 'Task name', 'string');
_checkType(taskYaml is YamlMap, taskYaml, 'Value of task "$taskName"', 'dictionary'); _checkType(taskYaml is YamlMap, taskYaml, 'Value of task "$taskName"', 'dictionary');
_checkKeys(taskYaml as YamlMap, 'Value of task "$taskName"', const <String>[ _checkKeys(taskYaml as YamlMap, 'Value of task "$taskName"', const <String>[
'description', 'description',