firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent expandos on all SkyElements.

Browse Source 
Expandos make v8 sad, lets not allow them.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/835353004
This commit is contained in:
Elliott Sprehn 2015-01-08 15:30:18 -08:00
parent 8ac50c62ca
commit dfba1a80ac
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
examples/city-list/city-list.sky
View File

@ -27,6 +27,9 @@ module.exports = {};
</template> </template>
<script> <script>
module.exports.StateHeaderElement = class extends SkyElement { module.exports.StateHeaderElement = class extends SkyElement {
created() {
this.state = "";
}
set datum(datum) { set datum(datum) {
this.state = datum.state; this.state = datum.state;
} }
@ -49,6 +52,9 @@ module.exports.StateHeaderElement = class extends SkyElement {
</template> </template>
<script> <script>
module.exports.LetterHeaderElement = class extends SkyElement { module.exports.LetterHeaderElement = class extends SkyElement {
created() {
this.letter = "";
}
set datum(datum) { set datum(datum) {
this.letter = datum.letter; this.letter = datum.letter;
} }
@ -92,6 +98,10 @@ module.exports.LetterHeaderElement = class extends SkyElement {
</template> </template>
<script> <script>
module.exports.CityItemElement = class extends SkyElement { module.exports.CityItemElement = class extends SkyElement {
created() {
this.name = "";
this.population = "";
}
set datum(datum) { set datum(datum) {
this.name = datum.name; this.name = datum.name;
this.population = datum.population; this.population = datum.population;
@ -553,6 +563,7 @@ module.exports.CityItemElement = class extends SkyElement {
this.date = null; this.date = null;
this.month = null; this.month = null;
this.views = null; this.views = null;
this.scrollerElement = null;
} }
attached() { attached() {
@ -566,7 +577,6 @@ module.exports.CityItemElement = class extends SkyElement {
cityItem: 30 cityItem: 30
}); });
this.dataLoaded = this.dataLoaded.bind(this);
this.scrollerElement = this.shadowRoot.getElementById('scroller'); this.scrollerElement = this.shadowRoot.getElementById('scroller');
this.scrollerElement.addEventListener('scroll', this.scrollerElement.addEventListener('scroll',
this.handleScroll.bind(this)); this.handleScroll.bind(this));
@ -574,7 +584,7 @@ module.exports.CityItemElement = class extends SkyElement {
var self = this; var self = this;
setTimeout(function() { setTimeout(function() {
self.domReady(); self.domReady();
self.loader.maybeLoadMoreData(self.dataLoaded); self.loader.maybeLoadMoreData(self.dataLoaded.bind(self));
}); });
} }
@ -591,7 +601,7 @@ module.exports.CityItemElement = class extends SkyElement {
this.tiler.drawTiles(scrollFrame, data); this.tiler.drawTiles(scrollFrame, data);
var datum = scrollChanged ? var datum = scrollChanged ?
this.tiler.getFirstVisibleDatum(scrollFrame) : null; this.tiler.getFirstVisibleDatum(scrollFrame) : null;
this.loader.maybeLoadMoreData(this.dataLoaded, datum); this.loader.maybeLoadMoreData(this.dataLoaded.bind(this), datum);
} }
dataLoaded(data, indexOffset) { dataLoaded(data, indexOffset) {