firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove unnecessary ignore prefer_const_constructors (#21934)

Browse Source
This commit is contained in:
Alexandre Ardhuin 2018-09-18 05:54:03 +02:00 committed by GitHub
parent cffa67da68
commit e2d0b062d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/bots/test/common.dart
View File

@ -13,7 +13,7 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
// TODO(ianh): Remove this file once https://github.com/dart-lang/matcher/issues/98 is fixed // TODO(ianh): Remove this file once https://github.com/dart-lang/matcher/issues/98 is fixed
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();
void tryToDelete(Directory directory) { void tryToDelete(Directory directory) {
// This should not be necessary, but it turns out that // This should not be necessary, but it turns out that

2
dev/devicelab/test/common.dart
View File

@ -11,4 +11,4 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
// TODO(ianh): Remove this file once https://github.com/dart-lang/matcher/issues/98 is fixed // TODO(ianh): Remove this file once https://github.com/dart-lang/matcher/issues/98 is fixed
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();

2
dev/integration_tests/android_semantics_testing/lib/src/flutter_test_alternative.dart
View File

@ -11,4 +11,4 @@ import 'package:test/test.dart' as test_package show TypeMatcher;
export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; export 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();

2
packages/flutter/test/flutter_test_alternative.dart
View File

@ -11,4 +11,4 @@ import 'package:test/test.dart' as test_package show TypeMatcher;
export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; export 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();

1
packages/flutter/test/material/reorderable_list_test.dart
View File

@ -914,7 +914,6 @@ Future<void> longPressDrag(WidgetTester tester, Offset start, Offset end) async
class _Stateful extends StatefulWidget { class _Stateful extends StatefulWidget {
// Ignoring the preference for const constructors because we want to test with regular non-const instances. // Ignoring the preference for const constructors because we want to test with regular non-const instances.
// ignore:prefer_const_constructors
// ignore:prefer_const_constructors_in_immutables // ignore:prefer_const_constructors_in_immutables
_Stateful({Key key}) : super(key: key); _Stateful({Key key}) : super(key: key);

2
packages/flutter/test/painting/flutter_logo_test.dart
View File

@ -7,7 +7,6 @@ import 'package:flutter/painting.dart';
void main() { void main() {
// Here and below, see: https://github.com/dart-lang/sdk/issues/26980 // Here and below, see: https://github.com/dart-lang/sdk/issues/26980
// ignore: prefer_const_constructors
final FlutterLogoDecoration start = FlutterLogoDecoration( final FlutterLogoDecoration start = FlutterLogoDecoration(
lightColor: const Color(0xFF000000), lightColor: const Color(0xFF000000),
darkColor: const Color(0xFFFFFFFF), darkColor: const Color(0xFFFFFFFF),
@ -16,7 +15,6 @@ void main() {
margin: const EdgeInsets.all(10.0), margin: const EdgeInsets.all(10.0),
); );
// ignore: prefer_const_constructors
final FlutterLogoDecoration end = FlutterLogoDecoration( final FlutterLogoDecoration end = FlutterLogoDecoration(
lightColor: const Color(0xFFFFFFFF), lightColor: const Color(0xFFFFFFFF),
darkColor: const Color(0xFF000000), darkColor: const Color(0xFF000000),

2
packages/flutter_driver/test/common.dart
View File

@ -13,7 +13,7 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
// TODO(ianh): Clean this up once https://github.com/dart-lang/matcher/issues/98 is fixed // TODO(ianh): Clean this up once https://github.com/dart-lang/matcher/issues/98 is fixed
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();
void tryToDelete(Directory directory) { void tryToDelete(Directory directory) {
// This should not be necessary, but it turns out that // This should not be necessary, but it turns out that

2
packages/flutter_test/lib/src/matchers.dart
View File

@ -194,7 +194,7 @@ final Matcher isAssertionError = isInstanceOf<AssertionError>();
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
// TODO(ianh): Remove this once https://github.com/dart-lang/matcher/issues/98 is fixed // TODO(ianh): Remove this once https://github.com/dart-lang/matcher/issues/98 is fixed
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();
/// Asserts that two [double]s are equal, within some tolerated error. /// Asserts that two [double]s are equal, within some tolerated error.
/// ///

2
packages/flutter_tools/test/src/common.dart
View File

@ -20,7 +20,7 @@ export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; // Defines a 'pa
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
// TODO(ianh): Remove this once https://github.com/dart-lang/matcher/issues/98 is fixed // TODO(ianh): Remove this once https://github.com/dart-lang/matcher/issues/98 is fixed
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();
void tryToDelete(Directory directory) { void tryToDelete(Directory directory) {
// This should not be necessary, but it turns out that // This should not be necessary, but it turns out that

2
packages/fuchsia_remote_debug_protocol/test/common.dart
View File

@ -11,4 +11,4 @@ import 'package:test/test.dart' as test_package show TypeMatcher;
export 'package:test/test.dart' hide TypeMatcher, isInstanceOf; export 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
/// A matcher that compares the type of the actual value to the type argument T. /// A matcher that compares the type of the actual value to the type argument T.
Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>(); // ignore: prefer_const_constructors, https://github.com/dart-lang/sdk/issues/32544 Matcher isInstanceOf<T>() => test_package.TypeMatcher<T>();