firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash in continuations.

Browse Source 
Style sharing didn't play nicely with elements getting
their display adjusted based off the parent's display.
We style share without doing adjusting, so we need to
avoid style sharing if adjusting would result in
a different style. Particularly, we need to make sure
that the display coercion would happen in the same way.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/839153002
This commit is contained in:
Ojan Vafai 2015-01-08 17:20:00 -08:00
parent e185d614cc
commit e5e8909c1b
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/tests/TestExpectations
View File

@ -22,5 +22,3 @@ https://github.com/domokit/mojo/issues/24 mutation-observer/observe-attributes.s
# This test only fails on the bots:
crbug.com/434822 inspector/page-agent-get-resource-tree.sky [ Pass Failure ]
crbug.com/446739 layout/continuations.sky [ Crash ]

6
engine/src/flutter/tests/layout/continuations-expected.txt
View File

@ -3,9 +3,9 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x19
RenderBlock {sky} at (0,0) size 800x19
RenderBlock {div} at (0,0) size 800x19
RenderBlock {span} at (0,0) size 800x19
RenderBlock {div} at (0,0) size 25.22x19
RenderBlock (anonymous) at (0,0) size 25.22x19
RenderParagraph {span} at (0,0) size 800x19
RenderBlock (inline-block) {div} at (0,0) size 25.22x19
RenderParagraph (anonymous) at (0,0) size 25.22x19
RenderText {#text} at (0,0) size 26x19
text run at (0,0) width 26: "foo"
RenderText {#text} at (25,0) size 27x19