firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow hit testing dirty boxes if they have a size. (#9060)

Browse Source 
The new scrolling world marks nodes dirty between frames instead of
waiting for the frame, and we've decided that's actually ok.

There's no test here because the test harness has a bug that hides
this exception. I will submit a separate PR to fix the harness, which
will fix a test that, without _this_ patch, fails. All of which is to
say, this is actually already tested.
This commit is contained in:
Ian Hickson 2017-03-28 17:15:56 -07:00 committed by GitHub
parent 8f9d4a2260
commit ee3fcafcb7
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
packages/flutter/lib/src/rendering/box.dart
View File

@ -1694,25 +1694,28 @@ abstract class RenderBox extends RenderObject {
/// even through it does not [paint] its children.
bool hitTest(HitTestResult result, { @required Point position }) {
assert(() {
if (debugNeedsLayout) {
throw new FlutterError(
'Cannot hit test a dirty render box.\n'
'The hitTest() method was called on this RenderBox:\n'
' $this\n'
'Unfortunately, since this object has been marked as needing layout, its geometry is not known at this time. '
'This means it cannot be accurately hit-tested. Make sure to only mark nodes as needing layout during a pipeline '
'flush, so that it is marked clean before any event handling occurs. If you are trying to perform a hit test '
'during the layout phase itself, make sure you only hit test nodes that have completed layout (e.g. the node\'s '
'children, after their layout() method has been called).'
);
}
if (!hasSize) {
if (debugNeedsLayout) {
throw new FlutterError(
'Cannot hit test a render box that has never been laid out.\n'
'The hitTest() method was called on this RenderBox:\n'
' $this\n'
'Unfortunately, this object\'s geometry is not known at this time, '
'probably because it has never been laid out. '
'This means it cannot be accurately hit-tested. If you are trying '
'to perform a hit test during the layout phase itself, make sure '
'you only hit test nodes that have completed layout (e.g. the node\'s '
'children, after their layout() method has been called).'
);
}
throw new FlutterError(
'Cannot hit test a render box with no size.\n'
'The hitTest() method was called on this RenderBox:\n'
' $this\n'
'Although this node is not marked as needing layout, its size is not set. A RenderBox object must have an '
'explicit size before it can be hit-tested. Make sure that the RenderBox in question sets its size during layout.'
'Although this node is not marked as needing layout, '
'its size is not set. A RenderBox object must have an '
'explicit size before it can be hit-tested. Make sure '
'that the RenderBox in question sets its size during layout.'
);
}
return true;