Skip web hot reload tests that test execution for all platforms for now (#162682)
https://github.com/flutter/flutter/issues/162567 There's a general timing error that may occur when loading scripts, where main might be run before the scripts are done loading, leading to a crash. These tests test that output is being printed to stdout, and wait forever for that, leading to timeouts. This is flaky, so the race condition may or may not occur. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. Example of a timeout: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tool_tests/50762/overview
This commit is contained in:
parent
93fb5829b8
commit
f5e8fc35f0
@ -5,8 +5,6 @@
|
|||||||
@Tags(<String>['flutter-test-driver'])
|
@Tags(<String>['flutter-test-driver'])
|
||||||
library;
|
library;
|
||||||
|
|
||||||
import 'dart:io';
|
|
||||||
|
|
||||||
import '../integration.shard/test_data/hot_reload_test_common.dart';
|
import '../integration.shard/test_data/hot_reload_test_common.dart';
|
||||||
import '../src/common.dart';
|
import '../src/common.dart';
|
||||||
|
|
||||||
@ -17,6 +15,6 @@ void main() {
|
|||||||
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
|
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
|
||||||
],
|
],
|
||||||
// https://github.com/flutter/flutter/issues/162567
|
// https://github.com/flutter/flutter/issues/162567
|
||||||
skip: Platform.isWindows,
|
skip: true,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
@ -5,8 +5,6 @@
|
|||||||
@Tags(<String>['flutter-test-driver'])
|
@Tags(<String>['flutter-test-driver'])
|
||||||
library;
|
library;
|
||||||
|
|
||||||
import 'dart:io';
|
|
||||||
|
|
||||||
import '../integration.shard/test_data/hot_reload_with_asset_test_common.dart';
|
import '../integration.shard/test_data/hot_reload_with_asset_test_common.dart';
|
||||||
import '../src/common.dart';
|
import '../src/common.dart';
|
||||||
|
|
||||||
@ -17,6 +15,6 @@ void main() {
|
|||||||
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
|
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
|
||||||
],
|
],
|
||||||
// https://github.com/flutter/flutter/issues/162567
|
// https://github.com/flutter/flutter/issues/162567
|
||||||
skip: Platform.isWindows,
|
skip: true,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
@ -5,8 +5,6 @@
|
|||||||
@Tags(<String>['flutter-test-driver'])
|
@Tags(<String>['flutter-test-driver'])
|
||||||
library;
|
library;
|
||||||
|
|
||||||
import 'dart:io';
|
|
||||||
|
|
||||||
import '../integration.shard/test_data/stateless_stateful_hot_reload_test_common.dart';
|
import '../integration.shard/test_data/stateless_stateful_hot_reload_test_common.dart';
|
||||||
import '../src/common.dart';
|
import '../src/common.dart';
|
||||||
|
|
||||||
@ -17,6 +15,6 @@ void main() {
|
|||||||
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
|
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
|
||||||
],
|
],
|
||||||
// https://github.com/flutter/flutter/issues/162567
|
// https://github.com/flutter/flutter/issues/162567
|
||||||
skip: Platform.isWindows,
|
skip: true,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user