firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove explicit width in ListTile trailing element (#12221)

Browse Source 
It was incorrectly added in #11858
This commit is contained in:
Todd Volkert 2017-09-24 13:21:28 -07:00 committed by GitHub
parent 47c387b6c7
commit ff45d50655
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/material/list_tile.dart
View File

@ -432,7 +432,6 @@ class ListTile extends StatelessWidget {
data: iconThemeData, data: iconThemeData,
child: new Container( child: new Container(
margin: const EdgeInsetsDirectional.only(start: 16.0), margin: const EdgeInsetsDirectional.only(start: 16.0),
width: 40.0,
alignment: FractionalOffsetDirectional.centerEnd, alignment: FractionalOffsetDirectional.centerEnd,
child: trailing, child: trailing,
), ),

4
packages/flutter/test/material/list_tile_test.dart
View File

@ -77,6 +77,8 @@ void main() {
double right(String text) => tester.getTopRight(find.text(text)).dx; double right(String text) => tester.getTopRight(find.text(text)).dx;
double top(String text) => tester.getTopLeft(find.text(text)).dy; double top(String text) => tester.getTopLeft(find.text(text)).dy;
double bottom(String text) => tester.getBottomLeft(find.text(text)).dy; double bottom(String text) => tester.getBottomLeft(find.text(text)).dy;
double width(String text) => tester.getSize(find.text(text)).width;
double height(String text) => tester.getSize(find.text(text)).height;
// 16.0 padding to the left and right of the leading and trailing widgets // 16.0 padding to the left and right of the leading and trailing widgets
void testHorizontalGeometry() { void testHorizontalGeometry() {
@ -86,12 +88,14 @@ void main() {
expect(left('subtitle'), 72.0); expect(left('subtitle'), 72.0);
expect(left('title'), right('leading') + 16.0); expect(left('title'), right('leading') + 16.0);
expect(right('trailing'), 800.0 - 16.0); expect(right('trailing'), 800.0 - 16.0);
expect(width('trailing'), 112.0);
} }
void testVerticalGeometry(double expectedHeight) { void testVerticalGeometry(double expectedHeight) {
expect(tester.getSize(find.byType(ListTile)), new Size(800.0, expectedHeight)); expect(tester.getSize(find.byType(ListTile)), new Size(800.0, expectedHeight));
if (hasSubtitle) if (hasSubtitle)
expect(top('subtitle'), bottom('title')); expect(top('subtitle'), bottom('title'));
expect(height('trailing'), 14.0); // Fits on one line (doesn't wrap)
} }
await tester.pumpWidget(buildFrame()); await tester.pumpWidget(buildFrame());