Amir Hardon
4aaa5dfe31
Don't reject the gesture after all pointers are up on AndroidView. ( #21295 )
...
This was a bug, when e.g a LongPressGestureRecognizer was in the gesture
arena, the android view gesture team may not yet win the arena when the
last pointer was up. This change allows AndroidView to win the gesture
even after all pointers are up.
2018-08-31 16:32:21 -07:00
Amir Hardon
abb55cb649
fix wrong hashCode implementation in FakeMotionEvent ( #21291 )
2018-08-31 16:16:37 -07:00
Chris Bracken
4a0106658f
Migrate hot reload tests to Dart 2 ( #21290 )
2018-08-31 15:40:00 -07:00
Chris Bracken
4d0f09a2aa
Migrate Flutter Tester tests to Dart 2 ( #21292 )
2018-08-31 15:39:34 -07:00
liyuqian
c1beb15f85
Use Visibility to hide gallery menu ( #19121 )
2018-08-31 14:46:19 -07:00
Chris Bracken
a6af2ca643
Run resident_runner_test in Dart 2 mode ( #21288 )
2018-08-31 14:31:38 -07:00
engine-flutter-autoroll
1593b98166
Roll engine f612a761c2f0..017dafd42660 (2 commits) ( #21287 )
...
f612a761c2...017dafd426flutter/engine#6132 )
842546824 Roll buildroot to pick up new NDK r17b (flutter/engine#6131 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 17:10:32 -04:00
Michael Goderbauer
c1c4c41867
Roll engine to 017dafd4266005805167045739fa2ddec9bb7cad (1 commit, new NDK) ( #21283 )
2018-08-31 13:57:02 -07:00
Chris Bracken
251e82d211
Migrate devfs tests to Dart 2 ( #21285 )
...
DevFS.update only runs in Dart 2 mode when the generator parameter is
supplied. In Dart 2 mode, both mainPath and pathToReload are required
parameters; this patch marks them as such.
generator is required for running in Dart 2. All call sites other than tests already explicitly set this value.
Note the statements on line 510 and line 516 for why mainPath and pathToReload are required.
2018-08-31 13:31:56 -07:00
Chris Bracken
9d0084ff57
Restrict compilationQueue to library-visibility ( #21280 )
...
Its type uses a generic type which is limited to library-visibility.
Eliminating compilationQueue from ResidentCompiler's public interface
makes it possible to mock in tests.
2018-08-31 12:22:50 -07:00
engine-flutter-autoroll
80a58439ca
Roll engine 90faf8531c00..f612a761c2f0 (1 commits) ( #21282 )
...
90faf8531c...f612a761c2flutter/engine#6130 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 15:11:32 -04:00
engine-flutter-autoroll
927a056a0a
Roll engine a114659c4a83..90faf8531c00 (1 commits) ( #21274 )
...
a114659c4a...90faf8531cflutter/engine#6129 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 09:59:32 -04:00
Mikkel Nygaard Ravn
6cc8008283
Fix extraction of product bundle ID for iOS projects ( #21252 )
2018-08-31 11:07:15 +02:00
engine-flutter-autoroll
f999f1447a
Roll engine dc7b5eb89da3..a114659c4a83 (5 commits) ( #21261 )
...
dc7b5eb89d...a114659c4aflutter/engine#6127 )
21ac961df Roll src/third_party/skia 8e318fda76df..381efe73499e (11 commits) (flutter/engine#6126 )
e7767ae9b Add license file patching instructions to README (flutter/engine#6125 )
51d4be774 Add a `-[FlutterViewController splashScreenView]` property (flutter/engine#6112 )
a047fd20f Roll src/third_party/skia 7ed0eae0cd13..8e318fda76df (17 commits) (flutter/engine#6123 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-31 02:30:34 -04:00
liyuqian
f7b2722d50
Add clipBehavior to Chips and update documents ( #21231 )
...
This fixes https://github.com/flutter/flutter/issues/20746
2018-08-30 23:27:37 -07:00
xster
cda2c223f5
Turn on unawaited_futures in flutter_tools ( #21048 )
2018-08-30 20:57:44 -07:00
Jonah Williams
f2442b8a13
Fix traversal order issues caused by intersecting or overlapping child rects ( #21235 )
2018-08-30 19:55:07 -07:00
Todd Volkert
2f32166f4b
Update packges ( #21241 )
...
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Chris Bracken
9f9676c4c6
Eliminate Dart 1 support in devicelab tests ( #21240 )
...
Flutter commands all default to --preview-dart-2. Eliminate support for
the use of this option and the previewDart2 parameter in dev/devicelab
tests.
2018-08-30 17:17:37 -07:00
Alexander Aprelev
eab5cd9853
Fix analysis shard of dev/bots/test.dart so it works on Windows. ( #21203 )
...
Normalize file path to non-Windows so string path comparison works.
2018-08-30 14:47:04 -07:00
Chris Bracken
6d7ecab25c
Minor improvements to analyzer test naming ( #21234 )
...
Clarify the intent of these tests.
2018-08-30 14:07:34 -07:00
engine-flutter-autoroll
5a5ebde3d3
Roll engine 252da4808277..dc7b5eb89da3 (5 commits) ( #21233 )
...
252da48082...dc7b5eb89dflutter/engine#6121 )
1c7682418 entering a character with a selection deletes the selection (flutter/engine#6113 )
9fc355d2c Roll src/third_party/skia cd7907b57d76..7ed0eae0cd13 (1 commits) (flutter/engine#6120 )
6586016da Roll src/third_party/skia f7c723c93d26..cd7907b57d76 (1 commits) (flutter/engine#6119 )
1fa5fe6a0 Roll src/third_party/skia eb0bb732f43f..f7c723c93d26 (3 commits) (flutter/engine#6118 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-30 16:19:32 -04:00
Alexander Aprelev
e4b7e87bdd
Pass uri instead of filepaths when hot-reloading. ( #21201 )
...
* Pass uri instead of filepaths when hot-reloading.
Bug: https://github.com/flutter/flutter/issues/21168
* Remove imports. Enable another test
* Restore skipping of test on mac
2018-08-30 12:08:23 -07:00
Suvorov Daniil
7598050fff
Add VS Code path to user install ( #21070 )
2018-08-30 18:42:25 +01:00
Alan Russian
7306ac95d5
Fix spellings of AppBar ( #21197 )
2018-08-30 10:41:34 -07:00
Hans Muller
ce51e71d19
Add Card clipBehavior pass-through property ( #21187 )
2018-08-30 10:09:44 -07:00
Greg Spencer
ec5c2e3e0c
Add links to implicit animation illustrations. ( #21092 )
...
This adds links to the already existing animated diagrams in the asset-for-api-docs repo.
2018-08-30 10:09:22 -07:00
Jonah Williams
d1417c72a3
'fix' build ( #21225 )
2018-08-30 09:51:01 -07:00
Alexander Aprelev
391e91c996
Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart ( #21174 )
...
* Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart.
This allows to run analysis step with command line arguments that are only applicable to flutter analyze(like --dart-sdk, needed for dart-flutter-engine head-head-head bot).
* Add forgotten dev/bots/analyze.dart
* Refactor common code from analyze.dart and test.dart into run_command.dart
* Remove comments, add header
2018-08-30 07:30:25 -07:00
Mikkel Nygaard Ravn
22832d3634
Support for flutter run/build module on iOS ( #21216 )
2018-08-30 16:18:44 +02:00
MH Johnson
19c9628256
[Material] Fix 20051 FAB tooltip touch target ( #21084 )
...
* [FAB] Updated tooltip touch target.
* Remove "new" keyword
* [FAB] Updated tooltip touch target.
* "long press button edge"
* remove new
* remove new
* put "new" keywords back in
* Remove check for childless tooltip
* Added regression test - tooltip works on edge of FAB which has no child.
Added helper method to find the right edge of a in the tests.
* Changed "find.byType(text)" to "find.text('Add')"
2018-08-30 09:59:13 -04:00
Greg Spencer
7cebaac985
Makes switching channels remove version freshness stamp. ( #21182 )
...
When switching between channels, we were leaving around the version freshness stamp file (bin/cache/flutter_version_check.stamp), which meant that the flutter tool would read from that file to see what the cached date of the most recent commit to the current channel (branch) was. The problem was that since the file was created while on the previous channel, the cached date was for the wrong channel, so if you switch from master to beta, flutter would think that the channel was out of date, and a new version was available, at least for three days after the first time it checked (after three days since the last time the freshness was checked, the cached date would get updated).
This PR modifies the channel command to remove that stamp file whenever the user switches channels, so that the cached date will be from the right channel when it is recreated.
Fixes #21134
2018-08-29 21:53:39 -07:00
engine-flutter-autoroll
8f8af99983
Roll engine a02a94e0182c..252da4808277 (6 commits) ( #21196 )
...
a02a94e018...252da48082flutter/engine#6116 )
cba35d33a Roll Tonic (flutter/engine#6114 )
7a599658d Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115 )
4a6990734 Fix libtxt unit tests (flutter/engine#6111 )
c765bee59 Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106 )
9fde6e0d8 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-29 21:42:32 -04:00
Jonah Williams
f353c308a1
remove flaky rects ( #21194 )
2018-08-29 17:21:08 -07:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 ( #21181 )
2018-08-29 16:48:23 -07:00
Jonah Williams
44cdb049d8
Update Text/Rich text to describe recognizers in semantics ( #20676 )
2018-08-29 13:55:48 -07:00
Alexander Aprelev
a7d954eb31
Add TODOs to remove lint ignore directives. ( #21170 )
...
This is follow-up to https://github.com/flutter/flutter/pull/21143 .
2018-08-29 10:25:19 -07:00
Alexander Aprelev
1e5cb2d87f
Remove workaround for compiler dill-initialization. ( #20541 )
...
Workaround is not needed since real fix has landed in dart sdk: https://dart-review.googlesource.com/c/sdk/+/62729 .
2018-08-29 08:56:19 -07:00
engine-flutter-autoroll
8c8ee83b33
Roll engine eceb722b7111..a02a94e0182c (1 commits) ( #21163 )
...
eceb722b71...a02a94e018flutter/engine#6109 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-29 11:05:32 -04:00
engine-flutter-autoroll
11d49a2db4
Roll engine f3ff83a5db71..eceb722b7111 (2 commits) ( #21161 )
...
f3ff83a5db...eceb722b71dart-lang/sdk@760a9690c2 (flutter/engine#6108 )
be9d8ffbb Roll src/third_party/skia 5f0726b01019..33f34556b5fc (1 commits) (flutter/engine#6107 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-29 10:00:34 -04:00
Danny Tuppeny
a9275d2154
Swap order of attach/stop in flutter_attach integration test ( #21106 )
...
This is a bit of a stab in the dark for a flake sometimes seen on bots (but I can't repro locally) #20822 . Detaching from a Flutter app currently seems to terminate it, so it may be the cause of the "app not found" when trying to stop the app subsequently.
This change means we stop the app from the main process first, before terminating the attach process.
2018-08-29 07:58:11 +01:00
Alexander Aprelev
cf764e3012
Use differrent name for initial flutter tester kernel file. ( #21137 )
...
Bug: https://github.com/flutter/flutter/issues/17833
2018-08-28 22:16:38 -07:00
Alexander Aprelev
abc17236f7
Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll). ( #21143 )
...
* Roll engine to 56139397e6ae1257bdabd1ef79ff7aca96c67d4.6
Changes since last roll:
```
56139397e Roll src/third_party/skia 7ba1d64f0706..5f0726b01019 (12 commits) (#6104 )
47a1ce0e6 Allow embedders to set the root surface transformation. (#6085 )
```
* Roll engine to f3ff83a5db71262d240aa5337a2a9a22c73c4749. (dart roll).
* Add const
* Add ignore analyzer prefer_const_constructors_in_immutables
2018-08-28 21:30:36 -07:00
Jonah Williams
bf5e4b45fe
Make sure modal BottomSheets routes are identified as dialog routes ( #21075 )
2018-08-28 19:21:00 -07:00
xster
373243bcf8
make /timeline-dashboard consistent between build and paint profiles ( #21099 )
2018-08-28 16:48:58 -07:00
xster
f23c9ae5f8
Cupertino nav bar transitions between routes ( #20322 )
2018-08-28 16:44:34 -07:00
Jacob Richman
05b4bd748c
Update CONTRIBUTING.md to suggest Android Studio and fix Mac command to install android-platform-tools. ( #19537 )
2018-08-28 16:22:50 -07:00
Janice Collins
e7d87af4d2
Update dartdoc to 0.20.4. ( #21131 )
2018-08-28 14:58:52 -07:00
engine-flutter-autoroll
af8986e969
Roll engine af42b6dc95bd..56bad48ab2ed (9 commits) ( #21132 )
...
af42b6dc95...56bad48ab2flutter/engine#6072 )
ad4e87d07 Convert synthesized Android motion events to long and not to int. (flutter/engine#6103 )
f05b08b7b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102 )
eb9738610 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100 )
06b8fa4ed Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098 )
bf078042d Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097 )
c867305c3 Unconditionally set resource id to empty string (flutter/engine#6096 )
b4b1d0578 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095 )
8694036a6 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-08-28 17:40:32 -04:00
Ian Hickson
10aa41f00f
Fix coverage collection crash ( #21015 )
...
* Fix coverage collection crash
Based on Jason's patch in https://github.com/flutter/flutter/pull/19546/
This is more or less the same but I tried to avoid using `dynamic`.
* Improve argument and variable names in flutter_platform
* Don't bother with reduce, since the order is guaranteed.
2018-08-28 14:36:06 -07:00
