12070 Commits

Author SHA1 Message Date
David Shuckerow
77095356e9
Attach command: add Bazel filesystem support (#21082) 2018-08-28 14:50:03 -06:00
Janice Collins
5e39476aef
Remove workaround for markup stripping dartdoc bug (#20748)
* Remove workaround for dart-lang/dartdoc#1125

* Update update_icons.dart for optional const and to remove markup stripping workaround
2018-08-28 13:23:07 -07:00
Jonah Williams
3b309bda07
Add a localization for counter text, separate into own semantic node (#21029) 2018-08-28 12:39:24 -07:00
Ian Hickson
1c2d3f324d
Shut down gradle at the end of each task (#20968)
Apparently Gradle leaks memory and it's causing failures.
2018-08-28 11:28:25 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
David Shuckerow
458d0b3d21
Update the reorderable list to use the primary scroll controller when… (#20895) 2018-08-28 12:08:41 -06:00
Danny Tuppeny
8b0227b4a3
Don't time out if process terminates when told to stop (#21103)
* Don't time out if process terminates when told to stop but response was not processed

While trying to reproduce #20822 I found a condition where the app may quit before the `app.stop` response is received but this code (which is called in integration test teardown) would sit around waiting and time out. With this change, the process exit is considered a valid response to the stop request.

* Add process exit to log for better errors in failures

This log can be turned on for debugging but is also dumped when a test fails (in certain conditions). With this in the log, it'll be clear if the timeout is because we're waiting for an event but the process quit.
2018-08-28 18:26:46 +01:00
Danny Tuppeny
5eebfeb345
Let bot/devicelab tests run concurrently (#21116) 2018-08-28 18:15:00 +01:00
Michael Goderbauer
91dde9074a
No more nasty errors during flutter upgrade/channel on Windows (#21085)
Fixes https://github.com/flutter/flutter/issues/14578.
2018-08-28 09:37:34 -07:00
Greg Spencer
7a07b28c93
Fix typo in AnimatedWidget (#21091) 2018-08-28 09:12:16 -07:00
Amir Hardon
c5b7766cbb
Re-land "Make AndroidView participate in gesture arenas." (#21097)
This re-lands commit c594696.

The original PR was breaking the integration test as while the
gesture was active the AndroidView's parent widget got rebuilt which
disposed the _AndroidViewGestureRecognizer and dropped pointer events
from that point on.

This change adds a unit test that reproduces the failure case, and
fixes it by not rebuilding the _AndroidViewGestureRecognizer if the
list of gesture recognizers did not change.
2018-08-28 08:52:46 -07:00
Greg Spencer
2b14ac1efc
Fix setting of ANDROID_HOME in deploy_gallery.sh (#21080)
ANDROID_HOME should be coming from the env, and it wasn't: it was being set in the script.
2018-08-27 22:17:22 -07:00
Michael Goderbauer
f88d2d9c12
Revert 20917 platform view arena (#21086)
This reverts commit c594696f0626e32dcd83d2a7d8c479460d475374.
2018-08-27 17:36:40 -07:00
xster
3313f5185f
Put Cupertino gallery demos in alphabetical order (#21081) 2018-08-27 15:10:05 -07:00
amirh
c594696f06
Make AndroidView participate in gesture arenas. (#20917)
Pointer events are dispatched to the Android view only if it won
Flutter's gesture arena for the pointer.
Specific gestures that should be dispatched to the android view can be
specified with the gestureRecognizers parameter.
2018-08-27 15:07:19 -07:00
Viet Do
0b93911653
Add Cupertino Countdown Timer Picker (#20966)
Add a countdown timer picker as part of the Cupertino date picker.
2018-08-27 12:37:55 -07:00
Sebastian Podjasek
f8a2fc7c28 Implement resizeToAvoidBottomPadding in CupertinoPageScaffold (#20929) 2018-08-27 11:58:30 -07:00
liyuqian
38d155a421
Add default-no-clip tests to more buttons (#21012)
Note that such tests already exist for RaisedButton and MaterialButton
2018-08-27 11:25:47 -07:00
amirh
688d96b652
Add a creation parameters argument to AndroidView. (#21067)
This allows to pass construction parameters for the embedded Android
view from the Dart side.
2018-08-27 11:24:54 -07:00
Michael Thomsen
7f0f938de7
A few README fixes (#20985)
* Few readme fixes

* Fix link

* Make casing consistent
2018-08-27 11:11:14 +02:00
Danny Tuppeny
4466c9db4c
Re-enable integration tests (#20947)
* Unskip expression evaluation integration tests for non-Windows

* Add additional into to skip comments

* Add missing import
2018-08-27 09:29:07 +01:00
engine-flutter-autoroll
546449238a
Roll engine a52724fcf859..af42b6dc95bd (7 commits) (#21044)
Auto-roller completed checks. Merging.
2018-08-26 19:50:02 -04:00
engine-flutter-autoroll
b661886259
Roll engine 091492601479..a52724fcf859 (2 commits) (#21013)
Auto-roller completed checks. Merging.
2018-08-26 19:06:00 -04:00
amirh
510c0eeaff
Don't ignore the ByteData buffer offset in StringCodec.decode(). (#21011) 2018-08-24 17:19:30 -07:00
Greg Spencer
977da4fb20
Ignore pub-cache when analyzing (#20925)
This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.

Also, I centralized the ANSI "red line" so that they would all use the same final string.
2018-08-24 14:06:25 -07:00
liyuqian
5d6707b78e
Expose clipBehavior to more buttons (#20538)
This allows developers to control the clipBehavior of those buttons.
2018-08-24 13:53:54 -07:00
amirh
fd44d0bb65
Update the android_views integration test to the new Android views API. (#20999)
This updates the test to match the engine API change introduced in:
https://github.com/flutter/engine/pull/6081

This also rolls the engine, the roll includes only the relevant engine commit:
```
091492601 Allow passing extra creation parameters for embedded Android views. (#6081)
```
2018-08-24 12:43:56 -07:00
Mehmet Fidanboylu
ac8d442a6f
Fix Dart check failure. (#20995) 2018-08-24 10:15:05 -07:00
engine-flutter-autoroll
20e019ef8d
Roll engine 0b728a314001..78e74d4d1816 (7 commits) (#20997)
Auto-roller completed checks. Merging.
2018-08-24 13:08:20 -04:00
Shams Zakhour
3c624f8b2c
Update README.md
Updating a few things on the README page. It needs more work.
2018-08-23 19:23:02 -07:00
amirh
146b906bbb
Mark the embedded_android_views_test as non flaky. (#20962)
Was marked as flaky as that's our policy for assing new device lab
tests. It's been consistently green so marking as non flaky.
2018-08-23 19:01:28 -07:00
xster
c418b2f328
Auto populate nav bar title and previous from page route (#19637) 2018-08-23 18:24:30 -07:00
liyuqian
ce8ba6e8b3
Set the default clip to Clip.none again. (#20752)
This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b and
updates the goldens versoin.

This requires https://github.com/flutter/flutter/pull/20751 to
land first.
2018-08-23 18:05:11 -07:00
jslavitz
3900d42bfa
Control, Shift and Arrow Key functionality for Chromebook (#20204)
* added keyboard functionatliy to android builds

* Added tests

* almost ready for review

* ready for review

* Fixes

* final comments

* final commit

* removing raw keyboard changes

* removing raw keyboard changes

* removing raw keyboard changes

* actual last commit

* fixed the imports

* a few more changes

* A few more changes

* a few changes

* Final changes

* Final changes2

* final actual commit for real

* final actual commit for real2

* final actual commit for real3

* final actual commit for real4

* final

* final 2

* f

* f2

* fin

* fin 2

* fin3

* fin4
2018-08-23 17:16:44 -07:00
Danny Tuppeny
dc5a5c18a9
Start logger in startProgress to avoid assertion failure (#20814)
* Start logger in startProgress to avoid assertion failure

There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).

Fixes #20812.

* Enable asserts for tools tests

* Fix lint

* Rename enableAsserts -> enableFlutterToolAsserts

To make it clearer that it only enables asserts for flutter_tools when set.
2018-08-23 20:49:59 +01:00
amirh
1ba16d55f3
Don't size Android views to (0,0) (#20956)
Virtual displays must have a non zero size. This was causing a crash:
https://github.com/flutter/flutter/issues/20456
2018-08-23 12:29:29 -07:00
Hans Muller
3fcc1069e9
Made the memory_nav benchmark a little more robust (#20938) 2018-08-23 12:05:47 -07:00
Hans Muller
be601c26a5
Correct gen_date_localizations.dart supported locales computation (#20920) 2018-08-23 11:56:33 -07:00
Jonah Williams
e235ccd76f
Support disabled animations (#20354) 2018-08-23 11:50:04 -07:00
amirh
1f31c3b354
Run the embedded Android views integration test on the device lab. (#20841) 2018-08-23 10:26:00 -07:00
Janice Collins
d3844d7d9c
Strip upstream from footer (#20757)
* Strip upstream from footer

* cleanup (readd accidentally deleted whitespace)
2018-08-23 10:25:15 -07:00
Viet Do
8e70d54e81
add cupertino localizations (#20756)
add cupertino localizations abstract class and the default cupertino localizations in US English.
2018-08-23 10:10:57 -07:00
Günter Zöchbauer
bd0b666ad3
Fix image refs to moved image directory
fixes #20940
2018-08-23 08:46:56 +02:00
Jonah Williams
99b382953b
Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700) 2018-08-22 22:56:54 -07:00
engine-flutter-autoroll
676a33581c
Roll engine c62248bdd3f4..0b728a314001 (3 commits) (#20942)
Auto-roller completed checks. Merging.
2018-08-23 01:52:59 -04:00
amirh
1fc7814bb1
Add a layoutDirection parameter to AndroidView (#20838) 2018-08-22 21:42:40 -07:00
asiva
5d1f874075 Roll engine to version c62248bdd3f46794b78d1bd141e92691d539e56f
This includes the following changes
c62248bdd Roll src/third_party/skia 82cf64a0d317..33d5394d08f6 (14 commits) (#6068)
b0fb3e660 Roll src/third_party/skia 96597c22c344..82cf64a0d317 (12 commits) (#6067)
ea8b949a7 Roll src/third_party/skia 4d727c560b58..96597c22c344 (27 commits) (#6066)
4fde39583 Roll Dart to version ccb16f72824374163562364bf19dd18e8a882fab (#6065)
140a5b757 Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060)
2018-08-22 18:46:02 -07:00
asiva
107c750da6 Roll engine to version 4fde3958388cab4210d6f7da86ec78e32fc4e7ee
Contains the following changes:
4fde39583 Roll Dart to version ccb16f72824374163562364bf19dd18e8a882fab (#6065)
140a5b757 Alllow access to Flutter engine, Dart & Skia versions in the Shell API. (#6060)
2018-08-22 18:46:02 -07:00
Jonah Williams
f0e80933b0
Mark memory_nav as flaky (#20930) 2018-08-22 17:34:29 -07:00
Jonah Williams
09fe34708f
Add localization for expand icon collapse/expand tap hint (#20766) 2018-08-22 10:20:51 -07:00