firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,514 Commits 1 Branch 0 Tags
Commit Graph

37514 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Elliott Brooks
01eef7ca13
Upgrade Flutter deps to pull in latest vm_service and dwds (#136734) 
Generated by running `flutter update-packages --force-upgrade`

Updates vm_service to [12.0.0](https://pub.dev/packages/vm_service/versions/12.0.0) and dwds to [22.0.0](https://pub.dev/packages/dwds/versions/22.0.0)

The changes to `packages/flutter_tools/lib/src/isolated/devfs_web.dart` are for the new interface of DWDS introduced in https://github.com/dart-lang/webdev/pull/2243

FYI @bkonyi
 2023-10-19 18:29:02 +00:00
Victoria Ashworth
3c3d414e7c
[Reland] Skip injecting Bonjour settings when port publication is disabled (#136842) 
Reland https://github.com/flutter/flutter/pull/136751 with fixes.
 2023-10-19 17:38:52 +00:00
Kostia Sokolovskyi
9fa9fd365c
_DefaultTabControllerState should dispose all created TabContoller instances. (#136608) 2023-10-19 10:38:19 -07:00
Greg Spencer
0abb017cfd
Reland: "Add code for updating focusedChild when removing grandchildren from scope" (#136899) 2023-10-19 10:22:46 -07:00
engine-flutter-autoroll
f82299ef91
Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (#136901) 
418dce4fea...9d49175618

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from b31b189be018 to 04449cda5a0a (1 revision) (flutter/engine#47105)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 17:22:04 +00:00
Gray Mackall
f8c00983d6
Unmark linux_android platform_channels_benchmarks as flaky (#136838) 
Unmarking this test as flaky in favor of a fix for the [underlying issue](https://github.com/flutter/flutter/issues/135035). None of the other impacted tests have been marked as flaky, so I think it is better for this one to not be treated differently.
 2023-10-19 17:09:13 +00:00
engine-flutter-autoroll
ced0e7417b
Roll Packages from 14aa69e2e54c to 09c6b1152070 (4 revisions) (#136896) 
14aa69e2e5...09c6b11520

2023-10-19 engine-flutter-autoroll@skia.org Manual roll Flutter from 6eea6e277e56 to 189196d104e2 (44 revisions) (flutter/packages#5178)
2023-10-18 47866232+chunhtai@users.noreply.github.com [go_router] adds ability to dynamically update routing table. (flutter/packages#5079)
2023-10-18 devoncarew@google.com [flutter_lints] rev flutter_lints to 3.0; increase dep on package:lints (flutter/packages#5177)
2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2f708eb8396e to 6c4930c4ac86 (1 revision) (flutter/packages#5173)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 15:45:27 +00:00
engine-flutter-autoroll
f9bec6cfb9
Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (#136895) 
28cb2508b8...418dce4fea

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 8cf64b0795af to b31b189be018 (1 revision) (flutter/engine#47103)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b425a25a6dd to ea86103e06b1 (1 revision) (flutter/engine#47101)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 15:30:07 +00:00
auto-submit[bot]
c2bd2c1175
Reverts "Fixes ability to call nextFocus() on a node to focus its descendant" (#136894) 
Reverts flutter/flutter#136773
Initiated by: itsjustkevin
This change reverts the following previous change:
Original Description:
fixes https://github.com/flutter/flutter/issues/134854
 2023-10-19 14:38:26 +00:00
engine-flutter-autoroll
8ab876702f
Roll Flutter Engine from d0d7b4d61265 to 28cb2508b8e0 (1 revision) (#136878) 
d0d7b4d612...28cb2508b8

2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 62acc1e162cc to 8cf64b0795af (2 revisions) (flutter/engine#47097)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 12:08:32 +00:00
engine-flutter-autoroll
136249f2d6
Roll Flutter Engine from 8d51b64e9440 to d0d7b4d61265 (13 revisions) (#136872) 
8d51b64e94...d0d7b4d612

2023-10-19 flar@google.com Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094)
2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092)
2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091)
2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090)
2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084)
2023-10-18 chinmaygarde@google.com Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078)
2023-10-18 fujino@google.com migrate const_finder to use the implementation from package:kernel (flutter/engine#47077)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076)
2023-10-18 jason-simmons@users.noreply.github.com [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068)
2023-10-18 chinmaygarde@google.com [Impeller] Document ReactorGLES. (flutter/engine#47070)
2023-10-18 matej.knopp@gmail.com [web] Ensure handled key event is not propagated to IME (flutter/engine#46829)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv
  fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 07:59:57 +00:00
auto-submit[bot]
cbf50a953b
Reverts "Add code for updating focusedChild when removing grandchildren from scope" (#136862) 
Reverts flutter/flutter#136771
Initiated by: gspencergoog
This change reverts the following previous change:
Original Description:
## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.
 2023-10-19 03:13:25 +00:00
auto-submit[bot]
c881808ed2
Reverts "Use Layer.toImage for golden tests on CanvasKit" (#136860) 
Reverts flutter/flutter#135249
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
 2023-10-19 02:20:19 +00:00
Michael Goderbauer
571039f6ee
Bump flutter_lints to 3.0 (#136841) 
Follow-up to https://github.com/flutter/packages/pull/5177
 2023-10-18 23:53:08 +00:00
Greg Spencer
2492242593
Add code for updating focusedChild when removing grandchildren from scope (#136771) 
## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.
 2023-10-18 23:44:40 +00:00
Harry Terkelsen
747128ff7a
Use Layer.toImage for golden tests on CanvasKit (#135249) 
Changes golden tests on CanvasKit to use Layer.toImage instead of
browser APIs for screenshots. This brings it more in line with other
platforms and should also fix some async timing bugs with tests.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-18 16:39:27 -07:00
engine-flutter-autoroll
9391a88b18
Roll Flutter Engine from b67edb05d3f7 to 8d51b64e9440 (4 revisions) (#136846) 
b67edb05d3...8d51b64e94

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074)
2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073)
2023-10-18 dkwingsmt@users.noreply.github.com Reland 2 (part 1): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47062)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 23:09:37 +00:00
engine-flutter-autoroll
d9fdbd3df4
Roll Flutter Engine from 6caee3236d37 to b67edb05d3f7 (5 revisions) (#136844) 
6caee3236d...b67edb05d3

2023-10-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603)
2023-10-18 zanderso@users.noreply.github.com Reland: Remove the frontend server wrapper (flutter/engine#47010)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 22:25:47 +00:00
Sam Rawlins
25d2cdaab7
Null-assert the value given to a Completer expecting a non-null value (#136776) 
The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value.

The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253.

Fixes https://github.com/flutter/flutter/issues/136775
 2023-10-18 22:19:18 +00:00
engine-flutter-autoroll
189196d104
Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (#136834) 
ab86c53c19...6caee3236d

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063)
2023-10-18 matanlurey@users.noreply.github.com Add `--lint-all=<regex>` as an option for `clang_tidy`, refactor lint targets (flutter/engine#46522)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 21:27:10 +00:00
auto-submit[bot]
c32ffa65c9
Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (#136839) 
Reverts flutter/flutter#136751
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
 2023-10-18 20:33:17 +00:00
Greg Spencer
13a0d475f5
Convert menus to use OverlayPortal (#130534) 
## Description

This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/124830

## Tests
 - No tests yet (hence it is a draft)
 2023-10-18 20:13:08 +00:00
Victoria Ashworth
1599cbebc3
[Reland] Skip injecting Bonjour settings when port publication is disabled (#136751) 
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
 2023-10-18 20:08:19 +00:00
engine-flutter-autoroll
697242c9f1
Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (#136832) 
0eff5d1918...ab86c53c19

2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 19:39:07 +00:00
chunhtai
24530b8021
Fixes ability to call nextFocus() on a node to focus its descendant (#136773) 
fixes https://github.com/flutter/flutter/issues/134854
 2023-10-18 19:00:53 +00:00
engine-flutter-autoroll
f847346d9c
Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) (#136829) 
b778a07f8a...0eff5d1918

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5857f5f05b35 to b8c989df901a (5 revisions) (flutter/engine#47060)
2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from OudOcFarQhQQzKDBx... to 2HSBpWikGWvPJlHOP... (flutter/engine#47059)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from a52d2a9e2b01 to 5857f5f05b35 (1 revision) (flutter/engine#47057)
2023-10-18 jiahaog@users.noreply.github.com Add missing source file (flutter/engine#47046)
2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Kp2wNpzRlAtbME0R4... to PxJM5ivbnbYoVkqBg... (flutter/engine#47056)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5172e904def7 to a52d2a9e2b01 (2 revisions) (flutter/engine#47055)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from OudOcFarQhQQ to 2HSBpWikGWvP
  fuchsia/sdk/core/mac-amd64 from Kp2wNpzRlAtb to PxJM5ivbnbYo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 18:45:18 +00:00
Robert Ancell
fe9d9a9db3
Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (#136780) 
This was added because the dispose method doesn't seem to be called - something must still have a reference to the application after shutdown.

Solution for https://github.com/flutter/flutter/issues/136582
 2023-10-18 18:08:53 +00:00
engine-flutter-autoroll
07d081b284
Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) (#136818) 
7f37c9b181...b778a07f8a

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8132e3356d63 to 5172e904def7 (4 revisions) (flutter/engine#47052)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 18:08:50 +00:00
Taha Tesser
4f959b97a7
Fix Slider onChanged callback order & never calls onChangeStart on SliderInteraction.slideOnly allowed interaction (#136720) 
fixes [Slider will call onChanged before onChangeStart when sliding.](https://github.com/flutter/flutter/issues/136707)

This fixes a regression from https://github.com/flutter/flutter/pull/121483

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  double _sliderValue = 0.5;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Slider(
          // allowedInteraction: SliderInteraction.tapAndSlide,
          // allowedInteraction: SliderInteraction.tapOnly,
          // allowedInteraction: SliderInteraction.slideOnly
          // allowedInteraction: SliderInteraction.slideThumb,
          value: _sliderValue,
          onChangeStart: (newValue) {
            print("onChangeStart ......");
          },
          onChanged: (newValue) {
            print("onChanged ......");
            setState(() {
              _sliderValue = newValue;
            });
          },
          onChangeEnd: (newValue) {
            print("onChangeEnd ......");
          },
        ),
      ),
    );
  }
}
```

</details>
 2023-10-18 16:25:47 +00:00
engine-flutter-autoroll
d195d90dc6
Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) (#136817) 
78026b4003...7f37c9b181

2023-10-18 zanderso@users.noreply.github.com Revert "Roll buildroot to pull in removal of //tools." (flutter/engine#47053)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 16:20:02 +00:00
Arash
a9567313c1
[Feat] Stroke color for Slider value indicator (#135986) 
Consider a scenario where the background color and indicator's background color are the same. 

Adding a stroke color to the value indicator would be a valuable for the following reasons:
- **Visual Clarity:** It would allow developers to make the value indicator stand out more against the background, making it easier for users to notice.
- **Customization:** It would provide more flexibility in customizing the appearance of the sliding widget, allowing developers to match the design requirements of their apps.
- **Accessibility:** Improved visual distinction can enhance the accessibility of the sliding widget for users with various needs.

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes #135984
 2023-10-18 16:03:08 +00:00
Aakash Pamnani
941897f60b
Fixed : Empty Rows shown at last page in Paginated data table (#132646) 
Fixed empty rows at the last page in paginated data table

BEFORE:
![Before](https://github.com/flutter/flutter/assets/76067278/1f1e364c-df38-462f-b9fb-868554ce04a5)

AFTER:
![After](https://github.com/flutter/flutter/assets/76067278/80648a25-e9e6-4873-805f-b18c7c6a00af)

Issues resolves : #80421
 2023-10-18 15:44:31 +00:00
engine-flutter-autoroll
8e4292b144
Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) (#136814) 
46923fd390...78026b4003

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from fed09695a0b9 to 8132e3356d63 (2 revisions) (flutter/engine#47050)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 15:41:10 +00:00
engine-flutter-autoroll
553088f673
Roll Packages from d4390624a624 to 14aa69e2e54c (1 revision) (#136813) 
d4390624a6...14aa69e2e5

2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter from afc391602b06 to 6eea6e277e56 (27 revisions) (flutter/packages#5165)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 15:41:08 +00:00
Daco Harkes
402a5455d9
Don't build native assets in flutter build bundle (#136641) 
Closes: https://github.com/flutter/flutter/issues/136547
 2023-10-18 11:57:44 +00:00
engine-flutter-autoroll
4b7b4d4176
Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) (#136795) 
c9c9684e03...46923fd390

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 212da8293790 to fed09695a0b9 (1 revision) (flutter/engine#47045)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 09:21:31 +00:00
engine-flutter-autoroll
e1fc37d8dc
Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) (#136792) 
0c1c29271e...c9c9684e03

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 3d938d4b00ee to 212da8293790 (1 revision) (flutter/engine#47043)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 07:54:11 +00:00
engine-flutter-autoroll
552360e3de
Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) (#136789) 
1de09d13e7...0c1c29271e

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8796ee7d1c66 to 3d938d4b00ee (3 revisions) (flutter/engine#47042)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 13694b8c64aa to 8796ee7d1c66 (1 revision) (flutter/engine#47041)
2023-10-18 matej.knopp@gmail.com [macOS] Fix tests failing on Sonoma (flutter/engine#46461)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 07:03:20 +00:00
engine-flutter-autoroll
8a4c81b54a
Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) (#136785) 
6fc36e61a9...1de09d13e7

2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VtEx0R7lepGAvwAMU... to OudOcFarQhQQzKDBx... (flutter/engine#47039)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VtEx0R7lepGA to OudOcFarQhQQ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 05:56:30 +00:00
engine-flutter-autoroll
de49229395
Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) (#136781) 
3f818efff3...6fc36e61a9

2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E0Ui7KmD3u5JSKEk5... to Kp2wNpzRlAtbME0R4... (flutter/engine#47037)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from E0Ui7KmD3u5J to Kp2wNpzRlAtb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 04:44:16 +00:00
engine-flutter-autoroll
911c4789fe
Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) (#136777) 
2eef9b43cf...3f818efff3

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from f62b4dce5e55 to 13694b8c64aa (2 revisions) (flutter/engine#47033)
2023-10-18 chinmaygarde@google.com Roll buildroot to pull in removal of //tools. (flutter/engine#47032)
2023-10-18 jonahwilliams@google.com Disable threading test that fails on CI (flutter/engine#47034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 02:19:42 +00:00
engine-flutter-autoroll
4cf73ca586
Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) (#136774) 
5df7af34a7...2eef9b43cf

2023-10-17 chris@bracken.jp Move imgui from buildroot to flutter third_party (flutter/engine#47031)
2023-10-17 jonahwilliams@google.com [Impeller] Rework Vulkan GPUTracker to decorate existing cmd buffers. (flutter/engine#46963)
2023-10-17 chris@bracken.jp [fml][embedder] Improve thread-check logging (flutter/engine#47020)
2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 99ce477503f8 to da48c75b73b1 (1 revision) (flutter/engine#47027)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 00:58:11 +00:00
Christopher Fujino
8a31a3a284
Flutter preview device (#135639) 
Fixes https://github.com/flutter/flutter/issues/130277

This PR does two things:

1. introduce a hidden `flutter build _preview` command, that will build a debug windows desktop app and copy it into the SDK's binary cache. This command is only intended to be run during packaging.
2. introduce a new device type, called `PreviewDevice`, which relies on the prebuilt desktop debug app from step 1, copies it into the target app's assets build folder, and then hot reloads their dart code into it.
 2023-10-18 00:27:54 +00:00
Gildásio Filho
492b6f7ddf
Add findChildIndexCallback examples (#133469) 
The documentation for using `findChildIndexCallback` recommends using `indexOf`, but that causes [this line](05259ca938/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart (L259)) to throw in debug mode, and when using `SliverList`, it breaks the render.

This PR changes the usage to check if the index is not negative before using it, and changes to return `null` instead if the child wasn't able to be found.

There's the related issue #107123, but this doesn't actually fix it.

-----

This PR has been updated to add the snippets that were used in the `findChildIndexCallback` comment as examples with proper tests, as well as updating the comment to reference the new examples.
 2023-10-18 00:26:17 +00:00
pdblasi-google
52a1a31823
Adds API for performing semantics actions in tests (#132598) 
* Added `performAction` to `SemanticsController` as well as specific methods for specific actions
* Added a `scrollable` finder to `find.semantics` as a convenience method for `findAny(<all scrollable actions>)`
* Updated `containsSemantics` and `matchSemantics` matchers to also work on `FinderBase<Semantics>`

Closes #112413
 2023-10-18 00:26:14 +00:00
engine-flutter-autoroll
11a2bc0b09
Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) (#136772) 
e57b5bac42...5df7af34a7

2023-10-17 chinmaygarde@google.com Roll buildroot to pull in //gpu removal. (flutter/engine#47014)
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 00:19:24 +00:00
engine-flutter-autoroll
23d3b1e4a5
Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (#136768) 
f9f937e510...e57b5bac42

2023-10-17 jason-simmons@users.noreply.github.com Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024)
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017)
2023-10-17 jason-simmons@users.noreply.github.com Manual roll of Clang from 576b184d6e3b to 00396e6a1a0b (flutter/engine#46980)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 23:08:23 +00:00
Andrew Kolos
cdc40b5226
clean up --dart-define-from-file option tests (#135980) 
Fixes https://github.com/flutter/flutter/issues/134279.

Changes:
* Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`.
* Deletes a duplicate test of malformed JSON detection behavior.
* Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file.
* Renames several tests to better articulate what is under test and what the expected result is.
* Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.
 2023-10-17 22:31:38 +00:00
Kostia Sokolovskyi
22f593e578
GoldenFileComparators should dispose created Image objects. (#136716) 2023-10-17 15:25:52 -07:00
LinChen
3d1d4532b5
make integration_test_driver_extended.dart support writeResponseData--(done) (#128382) 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*
- https://github.com/flutter/flutter/issues/128381

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 2023-10-17 22:17:09 +00:00