Flutter GitHub Bot
8c978e9c23
Marks Linux build_android_host_app_with_module_aar to be unflaky ( #157409 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_android_host_app_with_module_aar"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_android_host_app_with_module_aar%22 ).
This test can be marked as unflaky.
2024-10-23 22:02:00 +00:00
Flutter GitHub Bot
2a074311be
Marks Windows build_tests_3_8 to be unflaky ( #157414 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_3_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_3_8%22 ).
This test can be marked as unflaky.
2024-10-23 22:00:54 +00:00
Flutter GitHub Bot
8c36518372
Marks Windows build_tests_4_8 to be unflaky ( #157415 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_4_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_4_8%22 ).
This test can be marked as unflaky.
2024-10-23 22:00:51 +00:00
Flutter GitHub Bot
c8a285870f
Marks Windows build_tests_5_8 to be unflaky ( #157416 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_5_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_5_8%22 ).
This test can be marked as unflaky.
2024-10-23 21:59:26 +00:00
Flutter GitHub Bot
fbfda5aeb2
Marks Windows build_tests_7_8 to be unflaky ( #157418 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_7_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_7_8%22 ).
This test can be marked as unflaky.
2024-10-23 21:59:23 +00:00
Flutter GitHub Bot
d1d7496e53
Marks Windows build_tests_6_8 to be unflaky ( #157417 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_6_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_6_8%22 ).
This test can be marked as unflaky.
2024-10-23 21:40:14 +00:00
engine-flutter-autoroll
d7c8cd1038
Roll Flutter Engine from 19f9c5ad2d86 to 73c54fadf5ee (2 revisions) ( #157464 )
...
19f9c5ad2d...73c54fadf5skia-flutter-autoroll@skia.org Roll Skia from 721bbd7c0340 to 42f9070e6625 (1 revision) (flutter/engine#56064 )
2024-10-23 devoncarew@google.com Update the engine deps to track new SoT git locations for several packages (flutter/engine#56028 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 20:59:21 +00:00
Mohellebi abdessalem
c155e30467
small update in regex in flutter.groovy ( #156484 )
...
see #147122 for more context
`/(\\ |[^\s])+/ ` and `/(\\ |\S)+/` are basically equivalant but the
last one won't trigger android Studio warnings
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-23 16:31:07 -04:00
engine-flutter-autoroll
cedd859c44
Roll Flutter Engine from 6b022dfbc8ea to 19f9c5ad2d86 (3 revisions) ( #157460 )
...
6b022dfbc8...19f9c5ad2dskia-flutter-autoroll@skia.org Roll Skia from ad09ab099fe4 to 721bbd7c0340 (10 revisions) (flutter/engine#56063 )
2024-10-23 aam@google.com Reland copy gen snapshot (flutter/engine#56061 )
2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a4b728f6a03 to 75c42f30af7a (1 revision) (flutter/engine#56060 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 20:02:20 +00:00
Andrew Kolos
eccf4ee226
fix test sharding ( #156768 )
...
Also cleans up https://github.com/flutter/flutter/issues/156762
<details>
<summary> Pre-launch checklist </summary>
</details>
2024-10-23 19:36:09 +00:00
Elliott Brooks
802bae0111
Allow requesting a reduced widget tree with getRootWidgetTree service extension ( #157309 )
2024-10-23 12:30:55 -07:00
engine-flutter-autoroll
99ddbc308f
Roll Flutter Engine from ec6e28ac8b49 to 6b022dfbc8ea (1 revision) ( #157455 )
...
ec6e28ac8b...6b022dfbc830870216+gaaclarke@users.noreply.github.com Fixes crash in testTrackpadGesturesAreSentToFramework (flutter/engine#55990 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 18:49:59 +00:00
Flutter GitHub Bot
4faa4a415e
Marks Mac build_android_host_app_with_module_source to be unflaky ( #157412 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac build_android_host_app_with_module_source"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20build_android_host_app_with_module_source%22 ).
This test can be marked as unflaky.
2024-10-23 17:51:15 +00:00
engine-flutter-autoroll
e81614253b
Roll Flutter Engine from 50f6d98cb8be to ec6e28ac8b49 (11 revisions) ( #157453 )
...
50f6d98cb8...ec6e28ac8bjonahwilliams@google.com [display_list] grow display list backing store by power of two. (flutter/engine#56004 )
2024-10-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xPbin_33tT-_omeQT... to NxrFCTty8wV4-6Cpl... (flutter/engine#56056 )
2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 20470aaa17be to 2a4b728f6a03 (3 revisions) (flutter/engine#56055 )
2024-10-23 robert.ancell@canonical.com Move get_keyboard_state from FlKeyboardViewDelegate to FlKeyboardManager. (flutter/engine#56021 )
2024-10-23 robert.ancell@canonical.com Move send_key_event from FlKeyboardViewDelegate to FlKeyboardManager. (flutter/engine#56020 )
2024-10-23 bdero@google.com [Flutter GPU] Fix assert failure in createDeviceBufferWithCopy. (flutter/engine#56039 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 8de85635d731 to 20470aaa17be (4 revisions) (flutter/engine#56038 )
2024-10-22 ditman@gmail.com [web] Remove old futureToPromise. (flutter/engine#55847 )
2024-10-22 737941+loic-sharma@users.noreply.github.com [dart:ui] Improve Clip's docs (flutter/engine#55978 )
2024-10-22 jonahwilliams@google.com [Impeller] flush thread local resources during toImage/toImageSync. (flutter/engine#56037 )
2024-10-22 kpsroka@users.noreply.github.com [canvaskit] Makes access to CkSurface null-safer (flutter/engine#54895 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xPbin_33tT-_ to NxrFCTty8wV4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 17:46:09 +00:00
Flutter GitHub Bot
78d2acad72
Marks Windows build_android_host_app_with_module_source to be unflaky ( #157420 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_android_host_app_with_module_source"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_android_host_app_with_module_source%22 ).
This test can be marked as unflaky.
2024-10-23 17:31:08 +00:00
Flutter GitHub Bot
272c4302c6
Marks Linux build_android_host_app_with_module_source to be unflaky ( #157410 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_android_host_app_with_module_source"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_android_host_app_with_module_source%22 ).
This test can be marked as unflaky.
2024-10-23 17:27:04 +00:00
engine-flutter-autoroll
a96dd8b288
Roll Flutter Engine from 2d3f0f41b940 to 50f6d98cb8be (3 revisions) ( #157389 )
...
2d3f0f41b9...50f6d98cb8jonahwilliams@google.com [Impeller] refactor clip rendering.
(flutter/engine#56030 )
2024-10-22 magder@google.com Fix macos xcprivacy manifest copy location
(flutter/engine#56010 )
2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Copy gen_snapshots using python's shutil.copy, avoid links (#55830 )"
(flutter/engine#56034 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-23 08:48:44 -07:00
Bruno Leroux
b9c889d7d0
Reland "Fix TextField selects all content after the application is resumed" ( #157399 )
...
## Description
Relands https://github.com/flutter/flutter/pull/156968 wich was reverted in https://github.com/flutter/flutter/pull/157378
This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus).
Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed
## Related Issue
Fixes [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](https://github.com/flutter/flutter/issues/156078 ).
## Tests
Adds 1 test.
2024-10-23 15:13:35 +00:00
Valentin Vignal
e016ac3035
Add test for platform_menu_bar.0.dart ( #157328 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/material/platform_menu_bar/platform_menu_bar.0_test.dart`
2024-10-23 06:57:13 +00:00
Valentin Vignal
7504abcc14
Add test for pointer_signal_resolver.0.dart ( #157330 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/gestures/pointer_signal_resolver/pointer_signal_resolver.0_test.dart`
2024-10-23 02:20:40 +00:00
Polina Cherkasova
9441f8f6c8
Upgrade leak tracker. ( #157369 )
2024-10-23 00:42:28 +00:00
Nate Wilson
ea0fda51ef
WidgetStateInputBorder (#157190 )
...
**Changes**
- Add `WidgetStateInputBorder` class, with `.resolveWith()` and `.fromMap()` constructors
- Deprecate `MaterialStateOutlineInputBorder` and `MaterialStateUnderlineInputBorder` and provide data-driven fixes
<br>
**Other changes** based on https://github.com/flutter/flutter/pull/154972#pullrequestreview-2344092821
- Fix documentation copy-paste typo ("OutlinedBorder" â "InputBorder")
- Add test to ensure borders are painted correctly
- Add DartPad sample & relevant test
2024-10-22 23:45:41 +00:00
John McDole
4af4a9b282
Make hash script for Frob ( #157390 )
...
All engine hashing is required to be version controlled, otherwise you'll be broken.
2024-10-22 23:37:27 +00:00
Loïc Sharma
b2026572db
Add example to Directionality docs ( #157230 )
2024-10-22 22:20:02 +00:00
Loïc Sharma
bfdb366b50
Add example to ClipOval docs ( #157227 )
2024-10-22 22:20:00 +00:00
engine-flutter-autoroll
18d1afa3e4
Roll Flutter Engine from 2410cdf12c8f to 2d3f0f41b940 (5 revisions) ( #157383 )
...
2410cdf12c...2d3f0f41b9skia-flutter-autoroll@skia.org Roll Skia from 3731c1f7cf29 to ad09ab099fe4 (2 revisions) (flutter/engine#56033 )
2024-10-22 109111084+yaakovschectman@users.noreply.github.com Fix typo in testing script (flutter/engine#56029 )
2024-10-22 chinmaygarde@google.com [Impeller] libImpeller: Document the entire API. (flutter/engine#56003 )
2024-10-22 jonahwilliams@google.com [Impeller] eagerly flip backdrop back to onscreen. (flutter/engine#55983 )
2024-10-22 codefu@google.com Typo in engine_binary_hashing.md (flutter/engine#55866 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 21:24:42 +00:00
Matan Lurey
5a1ae9779d
Remove the only reference to settings.gradle.legacy_versions. ( #157380 )
...
Code references:
https://github.com/search?q=repo%3Aflutter%2Fflutter%20%22legacy_versions%22&type=code .
Closes https://github.com/flutter/flutter/issues/87922 .
Work towards https://github.com/flutter/flutter/issues/48918 .
2024-10-22 14:03:50 -07:00
Loïc Sharma
945067ae91
Remove duplicated widget of the week video embed ( #157299 )
...
The `ScaffoldMessenger` widget embeds its widget of the week video twice: https://main-api.flutter.dev/flutter/material/ScaffoldMessenger-class.html
2024-10-22 20:34:24 +00:00
auto-submit[bot]
60d4c9b741
Reverts "Fix TextField selects all content after the application is resumed ( #156968 )" ( #157378 )
...
Reverts: flutter/flutter#156968
Initiated by: jacobsimionato
Reason for reverting: Google3 roll failing - see b/375019489
Original PR Author: bleroux
Reviewed By: {justinmc, gspencergoog}
This change reverts the following previous change:
## Description
This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus).
Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed
## Related Issue
Fixes [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](https://github.com/flutter/flutter/issues/156078 ).
## Tests
Adds 1 test.
2024-10-22 19:59:22 +00:00
René Kilczan
48149781f2
Add windows build version detection ( #154797 )
...
With this PR flutter doctor will report the actual Windows version. This
resolves #154796
<!-- *If you had to change anything in the [flutter/tests] repo, include
a link to the migration guide as per the [breaking change policy].* -->
The flutter doctor result is with this patch like this:
```
[√] Flutter (Channel stable, 3.24.2, on Microsoft Windows [Version 10.0.22631.4037], locale de-DE)
[√] Windows Version (Windows 11 - 23H2)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.3)
[√] Android Studio (version 2024.1)
[√] Connected device (3 available)
[√] Network resources
• No issues found!
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-22 15:53:08 -04:00
Jenn Magder
e38eb756bc
Test alternate correct macOS framework xcprivacy manifest location ( #157318 )
...
Cherry-pick the beta branch test https://github.com/flutter/flutter/pull/157136 back to master so this doesn't regress in the next beta.
This is the framework test for https://github.com/flutter/flutter/issues/157016 on master. Engine fix can be merged once this merges.
2024-10-22 19:41:14 +00:00
João Victor Schramm
1d5087eb30
fix: CupertinoDatePicker.DateAndTime using showDayOfWeek ( #155260 )
...
As mentioned in the issue https://github.com/flutter/flutter/issues/153576 , even if we declare the 'showDayOfWeek' value as false, when using the mode CupertinoDatePickerMode.dateAndTime, the days of week still shows in the screen.
This PR is about making an assert that prevent developers from using `DateTimePicker.DateAndTime` with `showDayOfWeek` as false (because it only works on date mode) as suggested by @Piinks.
2024-10-22 19:37:19 +00:00
romain.gyh
21814805c1
fix: Considers strokeAlign to compute border dimensions ( #155495 )
...
Fixes #155491
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
There are 3 golden tests that don't pass on my computer, but they were
already not passing before my changes.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2024-10-22 12:02:02 -07:00
Bruno Leroux
260bee4d08
Fix MenuController.isOpen throws when unattached ( #157331 )
...
## Description
This PR change `MenuController.isOpen` to return false when the `MenuController` is not attached.
Previously `MenuController.isOpen` thrown an assert error when the menu controller was unattached.
With this PR, it is now possible to have some widgets outside the `MenuAnchor` body depending on the menu controller state.
## Related Issue
Fixes [Querying isOpen state for a menu controller that was never attached throws an assertion error](https://github.com/flutter/flutter/issues/157329 ).
## Tests
Adds 1 test.
2024-10-22 18:49:15 +00:00
Mouad Debbar
e9fb545c05
[web] Allow control of hitTestBehavior of Platform Views ( #157189 )
...
Hit testing behavior is currently hardcoded to `opaque` in `HtmlElementView` which causes the platform view to swallow pointer events when it's a descendant of a `GestureDetector` (see this [example](https://dartpad.dev/?id=5348fbf82be5eeb7d995f953437f0ce6 )).
In order to fix this, we need to make `hitTestBehavior` configurable in `HtmlElementView`. This way users can decide to make their platform views `transparent` for hit testing purposes.
**_Note_**: this specific case isn't fixable by `PointerInterceptor` because the framework is already receiving the pointer events, so there's nothing that `PointerInterceptor` can do. This issue is all happening on the framework side since it treats the rectangle occupied by the platform view as an opaque rectangle for hit testing.
**_Workaround_**: in the meantime, users can work around this limitation by surrounding the `HtmlElementView` with an `IgnorePointer` widget.
2024-10-22 17:53:17 +00:00
engine-flutter-autoroll
42773df6b6
Roll Flutter Engine from 1df749a00e32 to 2410cdf12c8f (1 revision) ( #157356 )
...
1df749a00e...2410cdf12cskia-flutter-autoroll@skia.org Roll Skia from b11804aaabbb to 3731c1f7cf29 (3 revisions) (flutter/engine#56027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 17:42:09 +00:00
Jiten Patel
5fa5a64842
[ #155269 ] Platform adaptive showAboutDialog and AboutDialog feature c… ( #155377 )
...
This PR introduces a new `showAdaptiveAboutDialog` function, ensuring that the About dialog matches the platformâs design (Material for Android, Fuchsia, Linux, Windows, and, Cupertino for iOS & macOS), providing a more consistent user experience across platforms.
Fixes #155269
- [] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
2024-10-22 17:32:05 +00:00
Bartek Pacia
eb5ef69d6b
Use Gradle KTS in new Android app projects by default (2nd try) ( #157195 )
...
This PR resolves #151166
This PR relands #154061
2024-10-22 17:28:31 +00:00
Polina Cherkasova
9edd1ae008
Fix leaks in some image tests and explain hackyness of opted-out. ( #154481 )
2024-10-22 10:22:01 -07:00
Jiten Patel
3e9901dac9
Fix: showDatePicker should have a simple example in the docs ( #156196 )
...
This PR introduces a basic example of how to use the `showDatePicker` function. The purpose of this PR is to simplify the onboarding process for new Flutter developers by providing a straightforward demonstration of handling the asynchronous Future returned by the showDatePicker. This will help users unfamiliar with the intricacies of asynchronous operations in Flutter.
Fixes #156157
2024-10-22 17:04:23 +00:00
engine-flutter-autoroll
849ce1d888
Roll Flutter Engine from b3205a28d0fa to 1df749a00e32 (1 revision) ( #157351 )
...
b3205a28d0...1df749a00eskia-flutter-autoroll@skia.org Roll Skia from c89324dd8f6e to b11804aaabbb (1 revision) (flutter/engine#56025 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 16:38:13 +00:00
engine-flutter-autoroll
9d27d52b5b
Roll Packages from b6f7e47c7586 to 5e03bb1da411 (3 revisions) ( #157349 )
...
b6f7e47c75...5e03bb1da443054281+camsim99@users.noreply.github.com [video_player_android] Correct rotation of videos recorded by the camera (flutter/packages#7846 )
2024-10-21 gspencergoog@users.noreply.github.com Allow custom blocks to be something other than `Column` or `SizedBox` (flutter/packages#7859 )
2024-10-21 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/camera/camera_android/android (flutter/packages#7905 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 15:47:24 +00:00
engine-flutter-autoroll
5fabd3d908
Roll Flutter Engine from e6856502b52b to b3205a28d0fa (3 revisions) ( #157348 )
...
e6856502b5...b3205a28d0bdero@google.com [Flutter GPU] Fix conditional when checking DeviceBuffer bounds. (flutter/engine#56017 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 86ac62245577 to 8de85635d731 (3 revisions) (flutter/engine#56019 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Skia from 64f4f1922946 to c89324dd8f6e (1 revision) (flutter/engine#56018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 15:43:31 +00:00
engine-flutter-autoroll
71ddc6836a
Roll Flutter Engine from 1596c6bd884f to e6856502b52b (1 revision) ( #157333 )
...
1596c6bd88...e6856502b5skia-flutter-autoroll@skia.org Roll Skia from 9c6cc020751d to 64f4f1922946 (3 revisions) (flutter/engine#56016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 09:01:25 +00:00
engine-flutter-autoroll
38e8d0b5de
Roll Flutter Engine from 30bd6c9e8616 to 1596c6bd884f (1 revision) ( #157326 )
...
30bd6c9e86...1596c6bd88skia-flutter-autoroll@skia.org Roll Skia from a71df7d9bc63 to 9c6cc020751d (1 revision) (flutter/engine#56013 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 07:25:27 +00:00
Valentin Vignal
a484aa260b
Add test for selectable_region.0.dart ( #157258 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/material/selectable_region/selectable_region.0_test.dart`
2024-10-22 07:25:25 +00:00
engine-flutter-autoroll
ba1017d81e
Roll Flutter Engine from 88288446c395 to 30bd6c9e8616 (2 revisions) ( #157323 )
...
88288446c3...30bd6c9e86skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from avSAUwQTf5xVGuZQU... to xPbin_33tT-_omeQT... (flutter/engine#56011 )
2024-10-22 aam@google.com Copy gen_snapshots using python's shutil.copy, avoid links (flutter/engine#55830 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from avSAUwQTf5xV to xPbin_33tT-_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 06:03:35 +00:00
Bruno Leroux
383a221cf3
Fix TextField selects all content after the application is resumed ( #156968 )
...
## Description
This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus).
Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed
## Related Issue
Fixes to [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](https://github.com/flutter/flutter/issues/156078 ).
## Tests
To be done
2024-10-22 04:41:31 +00:00
Valentin Vignal
27f0c6a08e
Add test for navigation_rail.extended_animation.0_test.dart ( #157222 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/material/navigation_rail/navigation_rail.extended_animation.0_test.dart`
2024-10-22 03:55:21 +00:00
engine-flutter-autoroll
b2ca7ebb59
Roll Flutter Engine from b3e227b9a5d9 to 88288446c395 (2 revisions) ( #157317 )
...
b3e227b9a5...88288446c3bdero@google.com [Flutter GPU] Add missing MSAA stuff. (flutter/engine#55424 )
2024-10-22 skia-flutter-autoroll@skia.org Roll Skia from 3a081993e2a7 to a71df7d9bc63 (24 revisions) (flutter/engine#56005 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 03:10:38 +00:00
