engine-flutter-autoroll
07799f0343
Roll Flutter Engine from d302cc96e8b0 to b3e227b9a5d9 (3 revisions) ( #157314 )
...
d302cc96e8...b3e227b9a5devoncarew@google.com update the SoT location for package:http_parser (flutter/engine#55998 )
2024-10-21 68449066+zijiehe-google-com@users.noreply.github.com Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55932 )
2024-10-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 10387c3fc6d4 to 86ac62245577 (1 revision) (flutter/engine#55995 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-22 01:47:26 +00:00
John McDole
c60e69040d
Add dart command line tool for calculating engine hash ( #157212 )
...
Useful in tooling, releases, etc - where Dart is available
Example usages:
```bash
# Monorepo world
❯ dart ./dev/tools/bin/engine_hash.dart -s head
226e13826c7253c968d798666f323b1f207979f8
# Non-monorepo world
❯ dart ./dev/tools/bin/engine_hash.dart -s head
Error calculating engine hash: Not in a monorepo
```
2024-10-21 16:26:28 -07:00
engine-flutter-autoroll
53a97dd9d4
Roll Flutter Engine from 5eb21d2706c0 to d302cc96e8b0 (2 revisions) ( #157302 )
...
5eb21d2706...d302cc96e8yjbanov@google.com Revert "[web:a11y] make header a proper <header> (#55747 )" (flutter/engine#55993 )
2024-10-21 yjbanov@google.com [web] implement selectable semantics (flutter/engine#55970 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 23:04:36 +00:00
Jason Simmons
8b4d48715b
Ensure that the build system checks for updates of locally built flutter_web_sdk artifacts ( #156534 )
...
The SourceVisitor uses the engineVersion parameter to determine whether it needs to check for changes to artifacts or if it can assume that artifacts are unmodified from a versioned build of the engine. engineVersion is set based on whether the Artifacts instance sets the isLocalEngine property.
CachedLocalWebSdkArtifacts (instantiated when the --local-web-sdk flag is used) was only setting isLocalEngine if --local-engine was also used. This caused the build system to ignore changes to the files in the locally built flutter_web_sdk when using --local-web-sdk alone.
This PR renames Artifacts.isLocalEngine to usesLocalArtifacts in order to clarify what it means. It also changes CachedLocalWebSdkArtifacts to always enable usesLocalArtifacts.
2024-10-21 22:52:29 +00:00
Reid Baker
4e8060eff5
Match framework and engine android emulator versions ( #157291 )
...
Related to https://buganizer.corp.google.com/issues/371020223
See https://github.com/flutter/engine/pull/55591 where I updated the engine android 35 emulator version.
2024-10-21 22:34:25 +00:00
Jonah Williams
5bcb3073f4
[devicelab] remove flaky designation from flutter_driver_android_test ( #157300 )
...
https://github.com/flutter/engine/pull/55944 should have fixed all flakes and rolled into framework.
2024-10-21 22:27:52 +00:00
Jason Simmons
bf6c990765
Revert "[devicelab] handle missed lifecycle messages. ( #156596 )" ( #157293 )
...
This reverts commit f1f83aa909c0d6bf39ad8274ac68e48c20825c2b.
With https://github.com/flutter/engine/pull/55933 this should not be needed.
2024-10-21 21:50:04 +00:00
Polina Cherkasova
4b169a81ea
Fix some leaky tests. ( #157294 )
2024-10-21 21:29:05 +00:00
engine-flutter-autoroll
a945427e95
Roll Flutter Engine from de569baa5703 to 5eb21d2706c0 (2 revisions) ( #157295 )
...
de569baa57...5eb21d2706jonahwilliams@google.com [Impeller] Reland: one descriptor pool per frame. (flutter/engine#55960 )
2024-10-21 jmccandless@google.com Scribe (Android stylus handwriting text input) (flutter/engine#52943 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 21:17:23 +00:00
Mohellebi abdessalem
fba8c5770f
fix Consider using 'named' to avoid unnecessary configuration inside flutter.groovy ( #157221 )
...
see #147122 for context
[gradle docs](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html ) for reference(scroll until [this)](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#eager_apis_to_avoid )
also this the lint :
2024-10-21 19:56:18 +00:00
Parker Lougheed
2336329baf
Resolve pupup menu test TODO ( #157251 )
...
Flutter no longer supports versions of Dart that will output the non-reified version.
2024-10-21 19:52:30 +00:00
engine-flutter-autoroll
4d39760097
Roll Flutter Engine from 315540ec20c5 to de569baa5703 (1 revision) ( #157290 )
...
315540ec20...de569baa57devoncarew@google.com re-land "update the repo references for package:file (#55906 )" (flutter/engine#55935 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 19:43:33 +00:00
Parker Lougheed
1995a6cba1
Migrate away from deprecated whereNotNull ( #157250 )
2024-10-21 19:25:54 +00:00
Parker Lougheed
a0a82f2821
Fix a few typos in framework code and doc comments ( #157248 )
2024-10-21 19:25:52 +00:00
stuartmorgan
e0d6271911
Update ecosystem contribution docs ( #157288 )
...
Document the requirements for adding a new external, client-facing dependency in flutter/packages
2024-10-21 19:06:04 +00:00
engine-flutter-autoroll
6cae408579
Roll Flutter Engine from 1a8ef6e24fc6 to 315540ec20c5 (1 revision) ( #157284 )
...
1a8ef6e24f...315540ec20zanderso@users.noreply.github.com Increase timeout for Linux mac_clangd (flutter/engine#55988 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 18:47:27 +00:00
Polina Cherkasova
6d3167e025
Dispose temporarily created CurvedAnimation [prod-leak-fix] ( #157233 )
2024-10-21 11:04:04 -07:00
engine-flutter-autoroll
effaeee603
Roll Flutter Engine from 68f922560038 to 1a8ef6e24fc6 (5 revisions) ( #157277 )
...
68f9225600...1a8ef6e24fjason-simmons@users.noreply.github.com Request another frame in ImageReaderSurfaceProducer.dequeueImage if more images are pending in the queue (flutter/engine#55944 )
2024-10-21 skia-flutter-autoroll@skia.org Roll Dart SDK from c8659684d34d to 10387c3fc6d4 (1 revision) (flutter/engine#55987 )
2024-10-21 mdebbar@google.com [web] Support woff2 fonts (flutter/engine#55908 )
2024-10-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PWz1ufnYNOGpgw-qg... to avSAUwQTf5xVGuZQU... (flutter/engine#55985 )
2024-10-21 skia-flutter-autoroll@skia.org Manual roll Dart SDK from a51df90298ca to c8659684d34d (4 revisions) (flutter/engine#55984 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PWz1ufnYNOGp to avSAUwQTf5xV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 17:30:23 +00:00
Taha Tesser
2665a72559
Fix unattached MenuController throws assertion error when calling MenuController.close() ( #156588 )
...
Fixes [Closing a menu controller that was never attached throws an assertion error](https://github.com/flutter/flutter/issues/156572 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key});
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: ElevatedButton(
onPressed: () => Navigator.of(context).push(
MaterialPageRoute(
builder: (context) => const MenuControllerPage(),
),
),
child: const Text('Press Me'),
),
),
);
}
}
class MenuControllerPage extends StatefulWidget {
const MenuControllerPage({super.key});
@override
State<MenuControllerPage> createState() => _MenuControllerPageState();
}
class _MenuControllerPageState extends State<MenuControllerPage> {
// This menu controller is intentionally left as not attached to a MenuAnchor.
final MenuController _menuController = MenuController();
@override
void dispose() {
// Close the menu when the page is popped.
_menuController.close();
super.dispose();
}
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: ElevatedButton(
child: const Text('Go back'),
onPressed: () => Navigator.of(context).pop(),
),
),
);
}
}
```
</details>
2024-10-21 17:26:09 +00:00
engine-flutter-autoroll
d21bf7139a
Roll Packages from 2a1c477a788c to b6f7e47c7586 (5 revisions) ( #157271 )
...
2a1c477a78...b6f7e47c75flutter/packages#7895 )
2024-10-18 stuartmorgan@google.com [in_app_purchase] Update iOS Pigeon for non-nullable generics (flutter/packages#7820 )
2024-10-18 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `Ad` (flutter/packages#7880 )
2024-10-18 stuartmorgan@google.com [video_player] Remove Android API 19 SSL handling (flutter/packages#7876 )
2024-10-18 109111084+yaakovschectman@users.noreply.github.com [google_maps_android_flutter] Convert `Config.sdk` to `minSdk` in Robolectric tests and lower to `LOLLIPOP` (flutter/packages#7805 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 17:02:59 +00:00
Hannes Hultergård
8621694fdf
Add callbacks for detecting tap up events to TapRegion ( #156110 )
...
Adds `onTapUpOutside` and `onTapUpInside` callbacks to `TapRegion`, and `onTapUpOutside` to `EditableText` text fields. This allows users to detect `PointerUpEvent`s, which in turn can be used to differentiate between a tap and pan / scroll gesture (for example by comparing the distance between the down and up events).
Fixes #140271 and potentially #138190
2024-10-21 16:59:16 +00:00
Loïc Sharma
4ff8c9507b
Polish the texture example ( #157176 )
...
Replaces `SizedBox`es with the new `spacing` parameter in `Column` and fixes some minor formatting issues.
This is a refactoring with no semantic changes. I will get a test exemption.
2024-10-21 16:54:04 +00:00
engine-flutter-autoroll
a4280f9396
Roll Flutter Engine from 53e187a1d4e4 to 68f922560038 (1 revision) ( #157246 )
...
53e187a1d4...68f9225600flar@google.com [Impeller] New impeller round rect class (flutter/engine#55946 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-21 16:31:36 +00:00
Gray Mackall
3baf9d4c60
Make android dependency version test suite run on changes to templates ( #157196 )
...
We have a group of tests that verifies that we can build a flutter app across the range of AGP, Kotlin, and Gradle versions we claim to support. They currently only run on postsubmit.
This pr aims to make them run in presubmit as well, but only when changes are made to the templates (not just android templates, see https://github.com/flutter/flutter/pull/157196#discussion_r1807055791 as to why).
2024-10-21 15:36:45 +00:00
Jackson Gardner
e19d352fc9
Add support for flutter build web --debug. ( #157186 )
...
There have been various requests for this for a while. See https://github.com/flutter/flutter/issues/96283 for an example. This has become more important with dart2wasm builds in the mix, as the profiling versions of the dart2wasm builds are a lot less debuggable than the debug versions. Most of this is already wired up so it just requires taking out a few explicit checks for it and making sure that we compile with the right optimization levels when compiling debug.
2024-10-21 15:35:11 +00:00
Andrew Kolos
3512745071
make ChromiumDevice.stopApp a no-op if it has already been called ( #156778 )
...
(Hopefully) fixes https://github.com/flutter/flutter/issues/156700
To summarize that thread, there are a few ways to trigger cleanup logic
in `flutter run -d chrome`. For example, pressing `q` will close Chrome,
but Chrome closing triggers cleanup logic in the resident runner (which
includes trying to close Chrome, which is redundant).
A simple way to fix this is to not call `Chrome.close` in
`ChromiumDevice.stopApp` when we've already called it once. This
solution isn't ideal—consider a scenario where two calls to `stopApp`
are made concurrently. The second one would probably complete before the
browser is actually closed. However, I don't foresee anything ever
depending on `stopApp` finishing implying that the browser is closed.
I feel like there might be a yak to shave here (`ResidentWebRunner`
could keep track of its state and not initiate redundant cleanup
operations), but I am not sure its worth the continued effort.
<details>
<summary> Pre-launch checklist </summary>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
</details>
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-10-21 11:28:30 -04:00
Valentin Vignal
3405f11e5c
Add test for flexible_space_bar.0.dart ( #157107 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/test/material/flexible_space_bar/flexible_space_bar.0_test.dart`
2024-10-21 15:17:14 +00:00
Gray Mackall
bcc3146185
Delete line referencing v1 string ( #157170 )
...
This property would previously have been used by
ad9e4fef45/shell/platform/android/io/flutter/app/FlutterActivityDelegate.java (L59C31-L59C58)https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-pre-1.12-Android-projects.md
2024-10-21 14:20:22 +00:00
Gray Mackall
76ed5355a4
Delete unused string in gradle_errors.dart ( #157187 )
...
Follow up to https://github.com/flutter/flutter/pull/157132
I stopped using this string but didn't delete it.
2024-10-21 14:20:19 +00:00
Ildeberto Vasconcelos
8aa25aeff2
Add Tests for bottom_app_bar api examples ( #156501 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
`examples/api/test/material/bottom_app_bar/bottom_app_bar.1_test.dart` and
`examples/api/test/material/bottom_app_bar/bottom_app_bar.2_test.dart`
This are tests of snippets used in [AutofillGroup class](https://api.flutter.dev/flutter/widgets/AutofillGroup-class.html )
2024-10-21 12:31:21 +00:00
engine-flutter-autoroll
47035a0102
Roll Flutter Engine from c763c9110988 to 53e187a1d4e4 (1 revision) ( #157237 )
...
c763c91109...53e187a1d4skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tNQZ8d5mRYpe3--lk... to PWz1ufnYNOGpgw-qg... (flutter/engine#55982 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tNQZ8d5mRYpe to PWz1ufnYNOGp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-20 09:27:31 +00:00
engine-flutter-autoroll
a775f8a0b8
Roll Flutter Engine from dd37446fbc55 to c763c9110988 (1 revision) ( #157229 )
...
dd37446fbc...c763c91109jonahwilliams@google.com [Impeller] batch submit vulkan command buffers on newer hardware. (flutter/engine#55956 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-19 17:47:24 +00:00
engine-flutter-autoroll
0500af2b5f
Roll Flutter Engine from 76d310e42c06 to dd37446fbc55 (17 revisions) ( #157215 )
...
76d310e42c...dd37446fbcrobert.ancell@canonical.com Move keymap from
FlKeyboardViewDelegate to FlKeyboardManager (flutter/engine#55942 )
2024-10-19 jonahwilliams@google.com [UI] fix scene builder parameter
naming. (flutter/engine#55969 )
2024-10-19 chris@bracken.jp iOS: Improve thread safety of first frame
callback (flutter/engine#55966 )
2024-10-18 chris@bracken.jp iOS: Fix flaky tests (remove timeouts)
(flutter/engine#55961 )
2024-10-18 jonahwilliams@google.com [Impeller] allocate the impeller
onscreen texture from the render target cache. (flutter/engine#55943 )
2024-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
9F_NaKPd2twhbPwP7... to tNQZ8d5mRYpe3--lk... (flutter/engine#55963 )
2024-10-18 30870216+gaaclarke@users.noreply.github.com Started filtering
out close line segments in rrect polylines. (flutter/engine#55929 )
2024-10-18 chinmaygarde@google.com [Impeller] libImpeller: Allow custom
font registrations. (flutter/engine#55934 )
2024-10-18 chris@bracken.jp Re-reland "iOS: Migrate FlutterEngine to
ARC" (flutter/engine#55962 )
2024-10-18 chinmaygarde@google.com [Impeller] libImpeller: Add a README.
(flutter/engine#55940 )
2024-10-18 chris@bracken.jp iOS: Eliminate needless profiler metrics
ivar (flutter/engine#55957 )
2024-10-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[Impeller] one descriptor pool per frame. (#55939 )"
(flutter/engine#55959 )
2024-10-18 chris@bracken.jp Revert "Reland "iOS: Migrate FlutterEngine
to ARC" (#55937 )" (flutter/engine#55954 )
2024-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
993d3069f42e to a51df90298ca (7 revisions) (flutter/engine#55951 )
2024-10-18 jonahwilliams@google.com [engine] add back opt out for merged
threads. (flutter/engine#55952 )
2024-10-18 jonahwilliams@google.com [Impeller] one descriptor pool per
frame. (flutter/engine#55939 )
2024-10-18 jonahwilliams@google.com [Impeller] add mechanism for sharing
bdf inputs. (flutter/engine#55701 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9F_NaKPd2twh to tNQZ8d5mRYpe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-18 21:26:31 -07:00
Flutter GitHub Bot
384f0cc6d3
Marks Mac flavors_test_macos to be flaky ( #156944 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac flavors_test_macos"
}
-->
Issue link: https://github.com/flutter/flutter/issues/156943
2024-10-19 01:28:15 +00:00
John McDole
4f8a6c30d2
Preland support for monorepo engine hashing ( #157138 )
...
Tested on Windows and Mac
Documentation on hashing here: https://github.com/flutter/engine/blob/main/docs/monorepo/engine_binary_hashing.md#recommended-formula-and-implementation
CAVEAT: This is testing git tracked changes from HEAD, which could be a branch with local modifications to the engine. To find the engine version for AB testing, you would need the hash from:
`git merge-base HEAD upstream/master`
The assumption is the hash calculation at that point is done by the Flutter CLI or Engine Tool.
2024-10-18 22:55:07 +00:00
Yegor
cd0aa2b537
all selectable widgets set the hasSelectedState flag ( #157191 )
...
Set the `hasSelectedState` flag in all selectable widgets. This happens automatically because only selectable widgets have `Semantics.selected` set to a non-null value. When the value is propagated to `SemanticsConfiguration.isSelected`, it sets both `hasSelectedState` to true and `isSelected` as appropriate.
More progress towards https://github.com/flutter/flutter/issues/66673
2024-10-18 22:37:51 +00:00
auto-submit[bot]
9a41f11610
Reverts "Use Gradle KTS in new Android app projects by default ( #154061 )" ( #157194 )
...
Reverts: flutter/flutter#154061
Initiated by: QuncCccccc
Reason for reverting: might be the reason that cause Framework tree to red
Original PR Author: bartekpacia
Reviewed By: {gmackall, reidbaker}
This change reverts the following previous change:
This PR resolves #151166
2024-10-18 21:14:46 +00:00
Bartek Pacia
d3c54a115f
Use Gradle KTS in new Android app projects by default ( #154061 )
...
This PR resolves #151166
2024-10-18 20:46:01 +00:00
flutter-pub-roller-bot
0549bd8888
Roll pub packages ( #156925 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-10-18 20:17:18 +00:00
Matej Knopp
32cb866d3a
Fix native assets failing to build with AGP 8.4 and multiple flavors ( #155039 )
...
The nativeAssetDir is not flavor specific and it should only be added to the jniLibs.scrDir once.
Fixes https://github.com/flutter/flutter/issues/155038
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-10-18 19:33:22 +00:00
Victor Sanni
83a0b85e43
Snap CupertinoSliverNavigationBar large title and bottom widget ( #156381 )
...
## Flutter (with this PR):
https://github.com/user-attachments/assets/b0177c06-e4b5-4981-8ec3-62171a4f2547
## Native:
https://github.com/user-attachments/assets/6efa0825-d26c-4c20-81cc-c9fada6e15fc
Fixes https://github.com/flutter/flutter/issues/126028
Fixes https://github.com/flutter/flutter/issues/23321
2024-10-18 19:18:08 +00:00
Ramon Farizel
73da3b53bd
Update Snackbar actionOverflowThreshold Documentation ( #156926 )
...
This PR addresses an inconsistency in the snackbar widget documentation regarding the percentage threshold for action overflow. The current documentation states that setting the threshold to 0 will prevent the action from overflowing to a new line. However, this behavior is incorrect, as the action still wraps when the threshold is set to 0.
To resolve this, we propose updating the documentation to clarify that the threshold should be set to 1 to ensure the action remains on the same line as the content.
#156817
2024-10-18 19:09:13 +00:00
Gray Mackall
c49ec359a2
Add handler for jlink error when using Java 21 ( #157132 )
...
Fixes https://github.com/flutter/flutter/issues/156304 .
Also fixes https://github.com/flutter/flutter/issues/155449 .
Unfortunately, because the error handler only sees one line at a time, it is hard to make this handling any more specific than this. If we run in to another jlink related error (unlikely) between now and when we phase out support for AGP 8.2.0 and below, we might have trouble differentiating them. We should delete the error handler when we phase out support for those versions.
Example of handled error output:
```
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':shared_preferences_android:compileReleaseJavaWithJavac'.
> Could not resolve all files for configuration ':shared_preferences_android:androidJdkImage'.
> Failed to transform core-for-system-modules.jar to match attributes {artifactType=_internal_android_jdk_image, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}.
> Execution failed for JdkImageTransform: /Users/mackall/Library/Android/sdk/platforms/android-34/core-for-system-modules.jar.
> Error while executing process /Users/mackall/Desktop/JDKs/21/jdk-21.0.2.jdk/Contents/Home/bin/jlink with arguments {--module-path /Users/mackall/.gradle/caches/8.9/transforms/2890fec03da42154757073d3208548e5-79660961-f91d-4df2-90bc-b9a3f2a270bd/transformed/output/temp/jmod --add-modules java.base --output /Users/mackall/.gradle/caches/8.9/transforms/2890fec03da42154757073d3208548e5-79660961-f91d-4df2-90bc-b9a3f2a270bd/transformed/output/jdkImage --disable-plugin system-modules}
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org .
BUILD FAILED in 1s
Running Gradle task 'assembleRelease'... 2,100ms
ââ Flutter Fix ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
â [!] This is likely due to a known bug in Android Gradle Plugin (AGP) versions less than 8.2.1, when â
â 1. setting a value for SourceCompatibility and â
â 2. using Java 21 or above. â
â To fix this error, please upgrade your AGP version to at least 8.2.1. The version of AGP that your project uses is likely defined in: â
â /Users/mackall/development/BugTesting/fifth/android/settings.gradle, â
â in the 'plugins' closure (by the number following "com.android.application"). â
â Alternatively, if your project was created with an older version of the templates, it is likely â
â in the buildscript.dependencies closure of the top-level build.gradle: â
â /Users/mackall/development/BugTesting/fifth/android/build.gradle, â
â by the number following "com.android.tools.build:gradle:". â
â â
â For more information, see: â
â https://b.corp.google.com/issues/294137077 â
â https://github.com/flutter/flutter/issues/156304 â
âââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
Gradle task assembleRelease failed with exit code 1
```
2024-10-18 19:06:16 +00:00
engine-flutter-autoroll
88816add42
Roll Packages from 5582669ac6d0 to 2a1c477a788c (4 revisions) ( #157171 )
...
5582669ac6...2a1c477a78109111084+yaakovschectman@users.noreply.github.com [camera_android] Convert Dart to native calls to use Pigeon (flutter/packages#7874 )
2024-10-17 ftsui@google.com [url_launcher] Decode file URLs before passing it to ShellExecuteW (flutter/packages#7774 )
2024-10-17 louisehsu@google.com [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7887 )
2024-10-17 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAd` (flutter/packages#7873 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-18 17:43:18 +00:00
engine-flutter-autoroll
f111c91af6
Roll Flutter Engine from a9bd470d90e0 to 76d310e42c06 (1 revision) ( #157163 )
...
a9bd470d90...76d310e42cjason-simmons@users.noreply.github.com On a merged UI/platform thread, immediately execute platform message handlers and then run microtasks (flutter/engine#55933 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-18 17:00:18 +00:00
engine-flutter-autoroll
30553504b9
Roll Flutter Engine from 0bb6b1f3b7a3 to a9bd470d90e0 (2 revisions) ( #157147 )
...
0bb6b1f3b7...a9bd470d90jonahwilliams@google.com [Impeller] simpler labels for render target textures and cmd buffers. (flutter/engine#55936 )
2024-10-18 jonahwilliams@google.com [Impeller] use render pass to transition attachments to eGeneral instead of barriers. (flutter/engine#55930 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-18 06:57:39 +00:00
engine-flutter-autoroll
f0b47863ea
Roll Flutter Engine from 09598f663aee to 0bb6b1f3b7a3 (4 revisions) ( #157143 )
...
09598f663a...0bb6b1f3b7robert.ancell@canonical.com Move redispatch_event from FlKeyboardViewDelegate to FlKeyboardManager (flutter/engine#55941 )
2024-10-18 robert.ancell@canonical.com Remove FlKeyResponder and use the two responder classes directly. (flutter/engine#55925 )
2024-10-17 chris@bracken.jp Reland "iOS: Migrate FlutterEngine to ARC" (flutter/engine#55937 )
2024-10-17 bdero@google.com [Flutter GPU] Remove Command/VertexBuffer usage from Flutter GPU. (flutter/engine#55893 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-18 04:45:14 +00:00
engine-flutter-autoroll
a042892ee0
Roll Flutter Engine from bf8530e901b8 to 09598f663aee (1 revision) ( #157130 )
...
bf8530e901...09598f663ayjbanov@google.com Introduce SemanticsFlag.hasSelectedState to the engine API (flutter/engine#55780 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-17 23:48:07 +00:00
FMorschel
c40f418c05
Removing unnecessary parenthesis ( #156928 )
...
This is simply removing unnecessary parenthesis from various places. This change is because of a change to the unnecessary_parentesis lint that will trigger there. Here is the CL https://dart-review.googlesource.com/c/sdk/+/390161 .
- https://github.com/dart-lang/linter/issues/4996
If anything else is needed please let me know.
I'd like to ask for this PR to wait a bit until the bots are run again on that CL so that I can be sure nothing else will trigger, I will come back here and update this whenever everything is complete. Thanks!
2024-10-17 23:46:25 +00:00
Zachary Anderson
4ed8136610
Move analyzer_benchmark to the devicelab ( #157127 )
...
We want this benchmark to run in the devicelab rather than on a VM so that it will give consistent results across runs.
First run (results at the bottom):
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8733793239434768065/+/u/run_analyzer_benchmark/stdout
2024-10-17 23:03:10 +00:00
