8074 Commits

Author SHA1 Message Date
Brian Slesinsky
054c937917 don't use curl progress bar since it looks bad in IDEA console window (#9538)
Without this flag, it shows progress via increasing numbers instead of a progress bar. For some reason, the IDEA console seems to be okay with that.
2017-04-23 10:30:27 -07:00
Alexandre Ardhuin
26c7411d66 unnecessary_override (#9540) 2017-04-22 22:58:21 +02:00
Alexandre Ardhuin
ad496e142b enable lint overridden_fields (#9527)
* enable lint overridden_fields

* address review comment
2017-04-22 10:27:03 +02:00
Adam Barth
0d0861b3ee The const will continue until morale improves (#9536) 2017-04-21 14:59:24 -07:00
xster
76ecb0b9a1 Remove InputField (#9520) 2017-04-21 14:12:14 -07:00
Alexandre Ardhuin
10099db4e2 try lint prefer_expression_function_bodies (#9494) 2017-04-21 23:10:37 +02:00
Adam Barth
a57018a4bb Add GridView.builder (#9522)
This constructor makes it easier to use a GridView with a builder
callback.

Fixes #8952
2017-04-21 14:09:53 -07:00
Alexandre Ardhuin
9541848272 make @immutable const classes (#9532)
* make @immutable const

* fix build
2017-04-21 23:09:42 +02:00
Adam Barth
1abb6f5d74 Explain why the Padding widget exists (#9523)
Fixes #5166
2017-04-21 14:09:35 -07:00
Adam Barth
930183916c Box/Sliver mismatches should have better error messages (#9525)
We now attempt to explain what went wrong.

Fixes #9509
2017-04-21 14:09:25 -07:00
Hans Muller
39d9bcdae8 ListView.Builder() handles appends when scrolled to the end (#9533) 2017-04-21 14:07:41 -07:00
Ian Hickson
df45aac166 Don't paint on unattached layers. (#9519) 2017-04-21 13:39:55 -07:00
Phil Quitslund
bd8f3f3a29 Bump Dart SDK to 1.23.0-dev.11.11. (#9530) 2017-04-21 13:25:04 -07:00
Ian Hickson
a591628cab Reorganise the drag related gesture files. (#9487)
Move the Drag*Details classes into drag_details.dart.
Move the one-gesture drag recognizers into monodrag.dart.
Move Drag into drag.dart.

Adjust the comments to claim that Drag is used by other things than
MultiDragGestureRecognizer. (Right now this is a lie but it will
hopefully be true soon.)
2017-04-21 13:13:20 -07:00
Adam Barth
31b1964a23 Document that you can call runApp again (#9526)
This is such a fundamental property of the system that we forgot to
document it.

Fixes #6818
2017-04-21 09:32:32 -07:00
jcollins-g
37fafeecb1 Dartdoc bot sanity flexibility (#9496)
* Have sanity check pass on old and new versions of flutter
2017-04-21 08:11:33 -07:00
Michael Thomsen
7a57d37195 Add Pods cache dir to ios/.gitignore (#9464)
* Add Pods cache dir to ios/.gitngnore

* Add missing ending newlines
2017-04-21 13:18:05 +02:00
Michael Thomsen
3510082ac9 Better separation between app and plugin main.dart and fix plugin main.dart issues. (#9491)
* Make seperation between app and plugin main.dart more manageable.

* Jakob review feedback

* Remove empty line

* Add missing newline
2017-04-21 12:49:42 +02:00
Alexandre Ardhuin
c794221f96 enable lint prefer_adjacent_string_concatenation (#9493) 2017-04-21 08:52:07 +02:00
Zachary Anderson
9b250cb6e8 [fuchsia_reload] More information from --list (#9503) 2017-04-20 15:06:56 -07:00
P.Y. Laligand
5b02aaabb4 Added a simple test runner for Fuchsia. (#9461) 2017-04-20 14:18:24 -07:00
Todd Volkert
ca2bf1efd0 Redirect curl's stderr to stdout, since it draws its progress bar to stderr (#9497) 2017-04-20 11:37:10 -07:00
John McCutchan
03d684be6d Fix a race in runFromSource. (#9495)
There is a race where we could complete a future based on a stream event
and then before we cancel the stream subscription, we get another event
and try and complete the future again.
2017-04-20 10:05:30 -07:00
Devon Carew
f29dd4f921 improve progress display when running apps; speed up startup (#9475)
* improve progress display when running apps; speed up startup

* review comments
2017-04-20 07:13:35 -07:00
Alexandre Ardhuin
35803c2297 comprehensive list of lints (#9330)
* comprehensive list of lints
* add comments to commented out lint
* fix unnecessary_this lints
* exclude prefer_final_fields
2017-04-20 09:38:57 +02:00
Ian Hickson
96d8a2a3ad Mark some tests as flaky (#9489)
These tests have recently been turning the build red incorrectly. Until they are reliable, let's mark them flaky.
2017-04-20 00:11:31 -07:00
Alexandre Ardhuin
03c54abd5f make some widgets const (#9477) 2017-04-20 08:59:05 +02:00
Kasper Lund
cbb49179c9 Remove unnecessary ignoring of (removed) strong mode warning (#9463) 2017-04-20 08:20:26 +02:00
xster
311d35354a roll (#9488) 2017-04-19 18:45:14 -07:00
Hans Muller
92e40b5c45 Image color blend mode (#9486) 2017-04-19 17:46:00 -07:00
Jason Simmons
da7867be0e Request a layout when a paragraph's overflow mode is changed (#9485)
A change in overflow mode requires calculation of the text size and resetting
the overflow shader
2017-04-19 17:06:58 -07:00
Jason Simmons
a657428b5c Capture didExceedMaxLines after doing text layout with constraints (#9457)
Subsequent operations like debugAssertDoesMeetConstraints() may do layout
operations that alter _textPainter's state.

Fixes https://github.com/flutter/flutter/issues/9372
2017-04-19 16:04:47 -07:00
Adam Barth
ab1aa07e8f Update engine (#9484) 2017-04-19 15:42:02 -07:00
Devon Carew
a97060e095 don't pass in --no-packages-dir (#9476) 2017-04-19 15:26:24 -07:00
Chinmay Garde
9b90ec4846 Remove FadeTransition from _MountainViewFadeTransition. (#9472)
* Remove FadeTransition from _MountainViewFadeTransition.
* Update tests.
2017-04-19 15:12:40 -07:00
xster
3cf23fcb20 Remove deprecated (#9474) 2017-04-19 12:50:51 -07:00
Hans Muller
2366cf73bc Dimissing the system keyboard shouldn't defeat scrolling (#9470) 2017-04-19 11:10:34 -07:00
Ian Hickson
0252622869 Promote Layer to full AbstractNode status (#9456) 2017-04-19 10:04:58 -07:00
Devon Carew
84a9ff7318 list which version of dartdoc we're using (#9466) 2017-04-19 10:00:18 -07:00
Adam Barth
7be9115a43 Deploy @immutable in more places (#9462)
Turns out we have many immutable classes.

Fixes #6892
2017-04-19 09:30:43 -07:00
John McCutchan
367e11a4a8 Handle reassemble timeouts gracefully. (#9467)
- [x] Switch the reassemble timeout to 5 seconds.
- [x] Print a status message if reassemble fails:

```
Performing hot reload...
Reassembling app.flx$main took too long. Hot reload may have failed.
Reloaded 0 of 418 libraries in 5,322ms.
```

Fixes #9316
Fixes #8861
Fixes #8857
Fixes #8856
2017-04-19 09:30:14 -07:00
Brian Slesinsky
af25a5b888 gallery: set Dart SDK location in IDEA (#9452) 2017-04-18 15:46:22 -07:00
Mikkel Nygaard Ravn
cb220c85be Add test of flutter create --plugin (#9459) 2017-04-19 00:00:39 +02:00
Ian Hickson
a6a8d997a3 Some clean-up of the Heroes code (#9428) 2017-04-18 14:42:56 -07:00
John McCutchan
71d80fbd3f Fix hot reload / restart after the back button dismisses the app on Android (#9455)
- [x] Refresh FlutterViews before issuing a hot reload / restart

Fixes #7248
2017-04-18 14:18:33 -07:00
Hans Muller
1e4151691a Fix PageSelector, page selector gallery demo (#9448) 2017-04-18 14:15:32 -07:00
Devon Carew
4631717f1b De-duplicate the dartanalyzer command output (#9441) 2017-04-18 14:02:06 -07:00
Mikkel Nygaard Ravn
79afc77594 Plugin template uses new channel name (#9453) 2017-04-18 22:54:01 +02:00
John McCutchan
2cf50ce574 Fix hot restart when application is being debugged (#9450)
- [x] Resume the isolate before performing a hot restart.

Fixes #8923
2017-04-18 13:27:53 -07:00
Hans Muller
4906297c28 Scrollable TabBar shows initialIndex (#9402) 2017-04-18 13:11:35 -07:00