17448 Commits

Author SHA1 Message Date
Jonah Williams
068fa84c5b
[flutter_driver] document caveats with driver method (#50017) 2020-02-03 10:57:28 -08:00
Shi-Hao Hong
e10df3c1a6
Step 1.5 of 3: AboutDialog uses scrollable AlertDialog (#49913) 2020-01-31 19:23:01 -08:00
Dan Field
8600d2305e
Image provider fix (#49920)
* Fix image provider missing early return

* test

* comments

* whitespace, another comment
2020-01-31 19:19:48 -08:00
Dan Field
a1aa3c5b3d
Reland elide long tree walks (#49891) 2020-01-31 19:18:03 -08:00
engine-flutter-autoroll
f98433e79c
Roll engine 6b8c150639b5..e625e174c5df (3 commits) (#49916)
6b8c150639...e625e174c5

git log 6b8c150639b5..e625e174c5df --first-parent --oneline
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/dart 162d6c5634a0..5ae5aff6406a (28 commits) (flutter/engine#16303)
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6305b2f8342a..0ee16f689843 (2 commits) (flutter/engine#16286)
2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from yissX... to x6sVj... (flutter/engine#16288)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-31 22:15:41 -05:00
Yegor
ff7eb778f6
Respect CHROME_EXECUTABLE in web benchmarks (#49911) 2020-01-31 18:31:08 -08:00
Cristian Zazo
306c23fd36
[web] Fix typo apple-mobile-web-app-status-bar-style (#49894) 2020-01-31 15:38:02 -08:00
engine-flutter-autoroll
d2941340ab
Roll engine 804dca62a17c..6b8c150639b5 (3 commits) (#49908)
804dca62a1...6b8c150639

git log 804dca62a17c..6b8c150639b5 --first-parent --oneline
2020-01-31 gw280@google.com Use static constexpr for iphone_xs_times (flutter/engine#16264)
2020-01-31 30870216+gaaclarke@users.noreply.github.com Started coalescing updates to viewport metrics after foregrounding the app. (flutter/engine#16270)
2020-01-31 chinmaygarde@google.com Remove superfluous INFO logs from //flutter/runtime. (flutter/engine#16280)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-31 18:34:41 -05:00
Hans Muller
bf4cde74e1
Clarified AppBar toolbar layout API docs (#49583) 2020-01-31 15:33:01 -08:00
Emmanuel Garcia
e03f439145
Reland: Skia gold driver test (#49905) 2020-01-31 14:50:50 -08:00
Alexandre Ardhuin
8061894f05
update template for gen_keycodes (#49884) 2020-01-31 21:58:51 +01:00
Kate Lovett
8b600032ee
Fixing constraints.precedingScrollExtent passed to SliverPadding child (#49433) 2020-01-31 12:58:03 -08:00
Kate Lovett
bc8bfb10f8
Exposing inner controller of NestedScrollView (#49004) 2020-01-31 12:53:03 -08:00
chunhtai
2dc71a343f
reland Refactors global key duplication detection (#49896)
* reland "Refactors global key duplication detection (#46183)"

This reverts commit d2b66dbfcfdad68473fc4366e3042cd2e17706ac.

* fix test
2020-01-31 12:51:42 -08:00
Zachary Anderson
2c51efef29
[flutter_tools] Make Config context-free (#49834) 2020-01-31 12:51:20 -08:00
Emmanuel Garcia
1eb5bb653c
Revert "Use skia golden files in driver test (#49750)" (#49900) 2020-01-31 12:14:08 -08:00
Emmanuel Garcia
a50743f658
Use skia golden files in driver test (#49750) 2020-01-31 11:05:29 -08:00
Prerak Mann
688948b778
switching channel prompts to run flutter upgrade (#49511) 2020-01-31 09:33:29 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations (#49622) 2020-01-31 18:30:21 +01:00
Bogdan Lukin
275ec45ec4
fix material selection handle paint with transparent textSelectionHandleColor (#49830) 2020-01-31 09:28:17 -08:00
Dan Field
b2a27c109c
Be clearer about when and why we override HttpClient in tests (#49844) 2020-01-31 09:22:30 -08:00
Shi-Hao Hong
effc019054
Revert "Elide tree walks (#48413)" (#49886)
This reverts commit 46ccd086745bb9ade53f2457f3bb91942b2af970.
2020-02-01 00:20:04 +08:00
Dan Field
46ccd08674
Elide tree walks (#48413) 2020-01-31 07:09:44 -08:00
engine-flutter-autoroll
aab7bd74c7
Roll engine 74d07b5f6b4f..804dca62a17c (13 commits) (#49873)
74d07b5f6b...804dca62a1

git log 74d07b5f6b4f..804dca62a17c --first-parent --oneline
2020-01-31 yjbanov@google.com Use bundled Roboto in all tests (flutter/engine#16218)
2020-01-31 gw280@google.com Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (#15118)" (flutter/engine#16277)
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 36c0521d57de..6305b2f8342a (8 commits) (flutter/engine#16272)
2020-01-31 jason-simmons@users.noreply.github.com Revert "[web] Correct getPositionForOffset for multi-line paragraphs (#16206)" (flutter/engine#16268)
2020-01-30 stuartmorgan@google.com Fix Windows file checks of unicode paths (flutter/engine#16105)
2020-01-30 iska.kaushik@gmail.com [fuchsia] Fix the import for dart_api.h (flutter/engine#16269)
2020-01-30 iska.kaushik@gmail.com [fuchsia] SceneHostBindings are no longer thread locals (flutter/engine#16262)
2020-01-30 gw280@google.com Pass through invoker.resources in fuchsia_test_archive (flutter/engine#16265)
2020-01-30 matthew-carroll@users.noreply.github.com Notify PlatformViewsController within FlutterEngine when a hot restart occurs. (#48518) (flutter/engine#16230)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/dart fc3af737c759..162d6c5634a0 (209 commits) (flutter/engine#16261)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia d1be5d64f8a7..36c0521d57de (13 commits) (flutter/engine#16260)
2020-01-30 mouad.debbar@gmail.com [web] Correct getPositionForOffset for multi-line paragraphs (flutter/engine#16206)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from -mGIA... to 93K0d... (flutter/engine#16257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-31 06:01:41 -05:00
Alexandre Ardhuin
5a8de59a66
refactor generateString to emit simpler dart code (#49334) 2020-01-31 11:57:54 +01:00
Alexandre Ardhuin
94210a6632
Revert "Roll engine 74d07b5f6b4f..e5209202fb00 (4 commits) (#49835)" (#49869)
This reverts commit 25f798a1aaaa292c1e30d25b7a6cc54fed38ab45.
2020-01-31 11:10:14 +01:00
Gary Qian
83d4d63a71
Track lastKnownRemoteTextEditingValue separately from received data (#49406) 2020-01-30 18:10:36 -08:00
engine-flutter-autoroll
25f798a1aa
Roll engine 74d07b5f6b4f..e5209202fb00 (4 commits) (#49835)
74d07b5f6b...e5209202fb

git log 74d07b5f6b4f..e5209202fb00 --first-parent --oneline
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/dart fc3af737c759..162d6c5634a0 (209 commits) (flutter/engine#16261)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia d1be5d64f8a7..36c0521d57de (13 commits) (flutter/engine#16260)
2020-01-30 mouad.debbar@gmail.com [web] Correct getPositionForOffset for multi-line paragraphs (flutter/engine#16206)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from -mGIA... to 93K0d... (flutter/engine#16257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-30 21:07:41 -05:00
Jonah Williams
d2b66dbfcf
Revert "Refactors global key duplication detection (#46183)" (#49847)
This reverts commit 340b193f20e85f2cfbebf84fe315112985a38a13.
2020-01-30 17:02:16 -08:00
chunhtai
340b193f20
Refactors global key duplication detection (#46183) 2020-01-30 14:23:02 -08:00
Yegor
423459da18
Initial web benchmark harness and 3 benchmarks (#49460)
Initial web benchmark harness and 3 benchmarks
2020-01-30 14:19:17 -08:00
Greg Spencer
e7baef08a1
Use DiagnosticableMixin instead of Diagnosticable for some conditionals. (#49726)
This PR fixes #49647 by changing DiagnosticableMixin.toDiagnosticsNode and other things to accept DiagnosticableMixin instead of requiring Diagnosticable.
2020-01-30 14:18:09 -08:00
Greg Spencer
6ee8b6546b
Revert "Always use new plugin schema for plugin template (#48258)" (#49827)
This reverts commit 9d4a35b because it appears to break

the gradle_non_android_plugin_test.
2020-01-30 12:46:12 -08:00
ZichangG
0be9127dfd
add preserveHeaderCase for classes extends HttpHeaders (#49766) 2020-01-30 11:43:02 -08:00
Dan Field
169529c370
Defer image decoding when scrolling fast (#49389) 2020-01-30 11:38:00 -08:00
Tong Wu
2bb290c2ed
[Devicelab] microbenchmarks is broken. (#49807)
The test hangs on iOS 13 device, see https://github.com/flutter/flutter/issues/49635.
2020-01-30 11:33:15 -08:00
刘冲
51d5b1a2d5
Use the default find if possible else fall back (#47522) 2020-01-30 11:33:02 -08:00
stuartmorgan
9d4a35ba8b
Always use new plugin schema for plugin template (#48258)
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
2020-01-30 11:30:31 -08:00
engine-flutter-autoroll
2ec32a00de
Roll engine f6526c0cf8a3..74d07b5f6b4f (2 commits) (#49812)
f6526c0cf8...74d07b5f6b

git log f6526c0cf8a3..74d07b5f6b4f --first-parent --oneline
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8f44c3504ca6..d1be5d64f8a7 (4 commits) (flutter/engine#16251)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from MK0YU... to yissX... (flutter/engine#16250)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-30 14:29:41 -05:00
Matthew Cliatt
9375377fa9
Fix handling backspace on macos with text selection (#49760)
Fixes #46150 by catching both the delete and backspace keys, rather than just the delete key.
2020-01-30 09:36:41 -08:00
chunhtai
406d8f7f1e
Fix focus when popping pages (#49714)
Fixes the focus handling when popping pages so that when multiple pages are popped, the focus doesn't try to focus the interstitial pages.
2020-01-30 09:35:58 -08:00
liyuqian
2ccf3f877d
Print more layer debug info (#49679) 2020-01-30 09:33:01 -08:00
engine-flutter-autoroll
4673724e41
Roll engine 6061b804e359..f6526c0cf8a3 (7 commits) (#49799)
6061b804e3...f6526c0cf8

git log 6061b804e359..f6526c0cf8a3 --first-parent --oneline
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 25bcd6a6215e..8f44c3504ca6 (2 commits) (flutter/engine#16243)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 24ed75db12ba..25bcd6a6215e (5 commits) (flutter/engine#16234)
2020-01-30 chinmaygarde@google.com Make output of run_tests.py easier to understand. (flutter/engine#16229)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from c3sk5... to MK0YU... (flutter/engine#16221)
2020-01-30 chinmaygarde@google.com Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. (flutter/engine#16214)
2020-01-30 chris@bracken.jp Correct the Fuchsia licenses golden file (flutter/engine#16215)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia a2a0c8a2c475..24ed75db12ba (12 commits) (flutter/engine#16216)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-30 12:32:41 -05:00
Greg Spencer
4b4cff94bf
Move stocks example app into dev/benchmarks/test_apps (#49559)
The stocks example app is outdated and deprecated, but we still use it for some benchmark tests. Moving it into the benchmarks directory to indicate its status.
2020-01-30 09:31:07 -08:00
Jonah Williams
58811028a4
[flutter] Allow hot reload replacements of Stateless/Stateful Widget (#48932) 2020-01-30 07:58:03 -08:00
engine-flutter-autoroll
211ecc86cf
6061b804e In the test harness, don’t attempt to load AOT snapshots from non-existent dylibs. (flutter/engine#16210) (#49758)
6007c17fd2...6061b804e3

git log 6007c17fd246..6061b804e359 --first-parent --oneline
2020-01-29 chinmaygarde@google.com In the test harness, don’t attempt to load AOT snapshots from non-existent dylibs. (flutter/engine#16210)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-30 10:54:41 -05:00
Zachary Anderson
92f7e16312
[flutter_tools] Make OperatingSystemUtils context-free (#49740) 2020-01-29 17:51:31 -08:00
Gary Qian
52df599419
Expose TextHeightBehavior in Text, RichText, and DefaultTextStyle. (#48346) 2020-01-29 17:02:57 -08:00
Jenn Magder
e8b3d7f358
Update Xcode compatibility version (#49654) 2020-01-29 15:58:02 -08:00
engine-flutter-autoroll
2c7073188d
Roll engine 4a55b4fd2500..6007c17fd246 (2 commits) (#49743)
* ee297aa69 Reland "Engine/LibTxt/dart:ui impl of TextHeightBehavior #15087" (flutter/engine#16155)

* 6007c17fd Roll src/third_party/skia dc49b0ca9816..a2a0c8a2c475 (4 commits) (flutter/engine#16197)
2020-01-29 15:56:33 -08:00