* Added return value to a onNotification callback.
The LayoutChangedNotification callback was missing a return value.
This commit changes it to return true and stop notification from
bubbling up the tree.
* Changed _RenderInkFeatures to use fresh clip box.
Since it wasn't using the most current value of the RenderBox's
size, _RenderInkFeatures was rendering splashes incorrectly when
the underlying Material size was animating. This commit changes
the clip reference to use the size of the Renderbox instead of
the size method in order to get the newest value.
* Fix covariant overrides in SynchronousFuture.
There were two things going on here. In timeout(), the callback's return
type was needlessly tightened to only allow callbacks that return
futures. This makes SynchronousFuture not substitutable with Future,
whose timeout() allows callbacks that return immediate values.
Since SynchronousFuture.timeout() never calls the callback anyway, I
just loosened it to match Future.timeout().
SynchronousFuture.whenComplete() is just wrong. The type error, again,
is that the callback's return type is too tight. Future.whenComplete()
allows synchronous callbacks.
But the actual implementation is wrong as well. whenComplete() should
return a future that completes to the *original value*, not whatever the
callback returns.
So I just fixed the method to work correctly, including handling
callbacks with synchronous results.
* "(error, stackTrace)" -> "(e, stack)".
It was widening the return type of a couple of operators compared to
what EquationMember declared it should return. Since it did in fact
always return an Expression, the widening wasn't needed.
This just tightens them to match the base class.
* Remove stray PRODUCT_BUNDLE_IDENTIFIER
This was erroneously added and overrides
the bundle for the gallery causing signing
to fail in my setup.
@chinmaygarde
* Remove PRODUCT_BUNDLE_IDENTIFIER from all Runner pbxproj's
I took the logo_square from:
https://github.com/flutter/identity-assets/tree/master/assets/logo_square
Opened it in preview, gave it a white background
and then dropped it in the icon tool to create
these updated icons.
We may want to use offwhite like we did for Android
but this is sufficient for my demo today.
@hansmuller
