38025 Commits

Author SHA1 Message Date
Parker Lougheed
096cdc39a9
Update links and surrounding text for new main-api docs (#138602)
Issue reference: https://github.com/flutter/flutter/issues/133877
2023-11-17 22:27:53 +00:00
engine-flutter-autoroll
a8fbd27404
Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (#138643)
141a01c5c7...e010f17eeb

2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from 8e9e168418a0 to dd7a26ead897 (1 revision) (flutter/engine#48178)
2023-11-17 ychris@google.com [Ios] move flutter_test_ios_mrc unittests to arc (flutter/engine#48162)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 22:20:10 +00:00
engine-flutter-autoroll
30b6586fe6
Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (#138637)
90c3ada368...141a01c5c7

2023-11-17 dnfield@google.com Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." (flutter/engine#46275)
2023-11-17 matanlurey@users.noreply.github.com Make `impeller/geometry/...` compatible with `.clang-tidy`. (flutter/engine#48154)
2023-11-17 matanlurey@users.noreply.github.com Make `impeller/{archivist|compiler|core|entity}/...` compatible with … (flutter/engine#48153)
2023-11-17 109111084+yaakovschectman@users.noreply.github.com Assign mojom `kSwitch` role to switches (flutter/engine#48146)
2023-11-17 mdebbar@google.com [web] Move scene DOM management to DomManager (flutter/engine#47460)
2023-11-17 30870216+gaaclarke@users.noreply.github.com [Impeller] Unify around "transform" (flutter/engine#48184)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182)
2023-11-17 matanlurey@users.noreply.github.com Actually make `status_or.h` compatible with `.clang-tidy`. (flutter/engine#48151)
2023-11-17 jonahwilliams@google.com [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180)
2023-11-17 mdebbar@google.com [web] Move all DOM creation to DomManager (flutter/engine#48123)
2023-11-17 15619084+vashworth@users.noreply.github.com Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 46e8b18047eb to a9c212f2f54b (1 revision) (flutter/engine#48176)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from bcd22e8f95bc to 8e9e168418a0 (1 revision) (flutter/engine#48173)
2023-11-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... (flutter/engine#48172)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from c8ee25282849 to bcd22e8f95bc (1 revision) (flutter/engine#48170)
2023-11-17 bdero@google.com [Flutter GPU] Add Textures. (flutter/engine#48118)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from M0zM3CJLIrd5 to Bcq9TZdt-vtT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 21:44:06 +00:00
engine-flutter-autoroll
0d3c87ee98
Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (#138599)
5064aeff00...90c3ada368

2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 12c5efc94edf to 46e8b18047eb (1 revision) (flutter/engine#48168)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from c7d2a4933dfa to c8ee25282849 (2 revisions) (flutter/engine#48164)
2023-11-17 dnfield@google.com Only run systrace test on API 29+, avoid building scenario app for 28 (flutter/engine#48163)
2023-11-17 matanlurey@users.noreply.github.com Make `lib/ui/text/...` compatible with `.clang-tidy`. (flutter/engine#48156)
2023-11-17 matanlurey@users.noreply.github.com Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#48148)
2023-11-17 bdero@google.com [Impeller] Add support for external GL textures to TiledTextureContents. (flutter/engine#47586)
2023-11-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 906f23c1cb20 to 12c5efc94edf (1 revision) (flutter/engine#48157)
2023-11-17 skia-flutter-autoroll@skia.org Roll Skia from 762d95ed65e0 to c7d2a4933dfa (1 revision) (flutter/engine#48159)
2023-11-16 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Size the PictureRecorder when calling Scene.toImage (flutter/engine#48142)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 21:03:18 +00:00
林洵锋
3c80df5040
Fix NoSplash not being disposed (#138542)
Fix https://github.com/flutter/flutter/issues/136441
2023-11-17 18:50:33 +00:00
auto-submit[bot]
0135a3310a
Reverts "Introduce AnimationStyle" (#138628)
Reverts flutter/flutter#137945
Initiated by: HansMuller
This change reverts the following previous change:
Original Description:
This PR introduces `AnimationStyle`, it is used to override default animation curves and durations in several widgets.

fixes  [Add the ability to customize MaterialApp theme animation duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and duration](https://github.com/flutter/flutter/issues/135638)

Here is an example where popup menu curve and transition duration is overriden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```
2023-11-17 16:59:19 +00:00
Victor Eronmosele
e9de448420
Enable flutter screenshot outside Flutter project directory (#138160)
This PR enables the `flutter screenshot` to work outside a Flutter project. 

This works by enabling `ScreenshotCommand` to find target devices not supported by the project. 

Before: 
```bash
$ cd $HOME # not a Flutter directory

$ flutter screenshot

No devices found yet. Checking for wireless devices...

No supported devices connected.

The following devices were found, but are not supported by this project:
sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
macOS (desktop)             • macos         • darwin-arm64   • macOS 13.3.1 22E772610a darwin-arm64
Chrome (web)                • chrome        • web-javascript • Google Chrome 119.0.6045.105
If you would like your app to run on android or macos or web, consider running `flutter create .` to generate projects for these platforms.
Must have a connected device for screenshot type device
```

After: 

```bash
$ cd $HOME # not a Flutter directory

$ flutter_source screenshot

Screenshot written to flutter_01.png (313kB).
```

Fixes #115790
2023-11-17 01:08:13 +00:00
engine-flutter-autoroll
2e5990ca63
Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (#138585)
aae07e989b...5064aeff00

2023-11-16 jonahwilliams@google.com [Impeller] Clang tidy even more (flutter/engine#48102)
2023-11-16 30870216+gaaclarke@users.noreply.github.com [Impeller] Implements gaussian blur that scales down before applying the blur (flutter/engine#47576)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-17 00:51:00 +00:00
chunhtai
d8a5f3d11b
Improves output file path logic in Android analyze (#136981) 2023-11-16 22:59:02 +00:00
Polina Cherkasova
2dc811135c
Turn off leak tracker in master to make found leaks not blocking. (#138567) 2023-11-16 14:45:33 -08:00
engine-flutter-autoroll
86a898e6a5
Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (#138574)
094a3383a4...aae07e989b

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 4c099aaa259f to 762d95ed65e0 (2 revisions) (flutter/engine#48140)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48137)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 22:43:17 +00:00
Jason Simmons
d859865e34
Enable the silent flag for invalid string exceptions when building a TextSpan (#138564)
This error can occur in a release app (for example, if the text comes from user input that is not valid UTF-16).  In that case, TextSpan will replace the invalid text with a placeholder character.
2023-11-16 21:55:26 +00:00
engine-flutter-autoroll
61d3710500
Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (#138568)
22baa83db6...094a3383a4

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 297049bbfc0d to 4c099aaa259f (5 revisions) (flutter/engine#48138)
2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b512191e9612 to 906f23c1cb20 (1 revision) (flutter/engine#48136)
2023-11-16 matanlurey@users.noreply.github.com Disable the `runIfNot` clauses in `.ci.yaml`, as they are unsafe. (flutter/engine#48132)
2023-11-16 15619084+vashworth@users.noreply.github.com Fix race condition in Unobstructed Platform View Scenario tests (flutter/engine#48096)
2023-11-16 jonahwilliams@google.com [Impeller] store all path point data in single buffer. (flutter/engine#47896)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) (flutter/engine#48133)
2023-11-16 chris@bracken.jp [macOS] Replace pasteboard mock with fake (flutter/engine#48110)
2023-11-16 chinmaygarde@google.com [Impeller] Fix issue where the lock was not re-acquired when the wait exits on CV. (flutter/engine#48104)
2023-11-16 jonahwilliams@google.com [Impeller] Create a drawable backed TextureMTL. (flutter/engine#48049)
2023-11-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48130)
2023-11-16 chris@bracken.jp [macOS] Replace fixture subclasses with usings (flutter/engine#48111)
2023-11-16 matanlurey@users.noreply.github.com Make `flow/embedded_views.h` compatible with `.clang_tidy`. (flutter/engine#47994)
2023-11-16 matanlurey@users.noreply.github.com Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#47995)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 21:52:29 +00:00
Arpit Gandhi
428bff1dde
#60704: Pass cert for TLS localhost connection (#106635)
*Pass locally generated certificate via command line*

*Fixes: #60704*

Added ARGS: 

- web-tls-cert-path
- web-tls-cert-key-path

Passing the path of local certificate and the key to cert will allow flutter tool to create a secure debugging session on chrome

**Pre-launch Checklist**

✅   I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs.
✅   I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities.
✅   I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement).
✅   I signed the [CLA](https://cla.developers.google.com/).
✅   I listed at least one issue that this PR fixes in the description above.
✅   I updated/added relevant documentation (doc comments with ///).
✅   I added new tests to check the change I am making.
✅   All existing and new tests are passing.
2023-11-16 21:19:07 +00:00
lsaudon
9be8f4fd58
Bump cupertino_icons to 1.0.6 (#136962)
Bump cupertino_icons to 1.0.6
2023-11-16 21:15:04 +00:00
Fedor Blagodyr
27394f6052
Fix sliver persistent header expand animation (#137913)
Added animation status check at showOnScreen method to prevent broken animation of expanding SliverAppBar when focusing EditableText

close #137901
2023-11-16 21:13:14 +00:00
Ian Hickson
4d788b109d
Reduce animations further when --no-cli-animations is set. (#133598) 2023-11-16 21:05:22 +00:00
engine-flutter-autoroll
d8c98c1199
Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (#138560)
0c57a50810...22baa83db6

2023-11-16 matanlurey@users.noreply.github.com Make `lib/ui/painting/...` compatible with `.clang_tidy`. (flutter/engine#47999)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `lib/ui/{text|window}/...` compatible with `.ci.yaml`" (flutter/engine#48097)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from bf1d6d84db73 to b9ead4140f84 (1 revision) (flutter/engine#48124)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 2fe70dd9cbf8 to bf1d6d84db73 (1 revision) (flutter/engine#48122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 20:04:50 +00:00
Taha Tesser
19e284f88f
Introduce AnimationStyle (#137945)
This PR introduces `AnimationStyle`, it is used to override default animation curves and durations in several widgets.

fixes  [Add the ability to customize MaterialApp theme animation duration](https://github.com/flutter/flutter/issues/78372)
fixes [Allow customization of showMenu transition animation curves and duration](https://github.com/flutter/flutter/issues/135638)

Here is an example where popup menu curve and transition duration is overriden:

```dart
          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),
```

Set `AnimationStyle.noAnimation` to disable animation.
```dart
    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,
```
2023-11-16 18:33:20 +00:00
Dan Field
c6c451ee46
Just use string interpolation for ws url for tests (#138235)
Follows up on https://github.com/flutter/flutter/pull/137969 - we don't
need decodeComponent here
2023-11-16 10:27:25 -08:00
huycozy
c245bd8932
Adding new packages to the first-party package issue template (#138540)
Closes https://github.com/flutter/flutter/issues/138539.

Adding `two_dimensional_scrollables`, `process`, `platform` to the first-party package issue template so user can file issues related to them.
2023-11-16 17:24:04 +00:00
engine-flutter-autoroll
9e826464b1
Roll Packages from 0cd23780741d to 07b4b298face (3 revisions) (#138549)
0cd2378074...07b4b298fa

2023-11-16 kevmoo@users.noreply.github.com [script] use dart:io support for forwarding stdout/stderr (flutter/packages#5410)
2023-11-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from d211f4286035 to db7ef5bf9f59 (1539 revisions) (flutter/packages#5409)
2023-11-15 ychris@google.com [in_app_purchase] add storefront in skpaymentqueuewrapper (flutter/packages#5348)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 16:09:03 +00:00
engine-flutter-autoroll
ac50921309
Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (#138546)
2e9f0df868...0c57a50810

2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 5cccc24d127f to b512191e9612 (1 revision) (flutter/engine#48120)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 15:04:31 +00:00
engine-flutter-autoroll
53a57adcf1
Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (#138543)
8ab189b77b...2e9f0df868

2023-11-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AuDKY8ob6GrGwDlmk... to M0zM3CJLIrd5lb0u0... (flutter/engine#48115)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from AuDKY8ob6GrG to M0zM3CJLIrd5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 13:01:42 +00:00
engine-flutter-autoroll
3b1b3cb3d3
Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (#138533)
622fa06144...8ab189b77b

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 2642516e7de7 to 2fe70dd9cbf8 (1 revision) (flutter/engine#48114)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 09:40:33 +00:00
Bruno Leroux
dcdf72a670
[flutter_tools] - Add queries section to Android manifest file (#137207)
## Description

This PR adds a new section to the Android manifest file.
This section is required for https://github.com/flutter/engine/pull/44579 (because it uses `PackageManager.queryIntentActivities` API ), see:

1. https://developer.android.com/training/package-visibility?hl=en
2. https://developer.android.com/reference/android/content/Intent#ACTION_PROCESS_TEXT
3. https://developer.android.com/reference/android/content/pm/PackageManager?hl=en#queryIntentActivities(android.content.Intent,%20android.content.pm.PackageManager.ResolveInfoFlags)

## Related Issue

Android manifest update for https://github.com/flutter/flutter/issues/107603

## Tests

This PR updates the integration tests and examples Android manifest files, this will help catch error or warning related to this change.
2023-11-16 08:57:20 +00:00
engine-flutter-autoroll
76f7d2d9fd
Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (#138532)
8aff9c134b...622fa06144

2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from add865f891c8 to 2642516e7de7 (1 revision) (flutter/engine#48112)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 08:53:26 +00:00
engine-flutter-autoroll
396cd71351
Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (#138529)
3cfcdebe86...8aff9c134b

2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc6acfd7d57c to 5cccc24d127f (1 revision) (flutter/engine#48109)
2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 5d6bdbf69dea to add865f891c8 (1 revision) (flutter/engine#48108)
2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to cc6acfd7d57c (5 revisions) (flutter/engine#48100)
2023-11-16 matanlurey@users.noreply.github.com Make `fml/status_or.h` compatible with `.clang_tidy`. (flutter/engine#48002)
2023-11-16 dnfield@google.com [Impeller] Gate Vulkan selection on API 29 (flutter/engine#48089)
2023-11-16 chris@bracken.jp [macOS] Clean up allocations in menu plugin test (flutter/engine#48093)
2023-11-16 matanlurey@users.noreply.github.com Re-land "Make `fml/...` compatible with `.clang_tidy` (flutter/engine#48030)
2023-11-15 ychris@google.com [ios] introduce weak_nsobject (flutter/engine#47947)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from e954d1a1972c to 5d6bdbf69dea (2 revisions) (flutter/engine#48094)
2023-11-15 jonahwilliams@google.com [Impeller] add async command submission for blit pass. (flutter/engine#48040)
2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/compositing/...` compatible with `.clang_tidy`. (flutter/engine#48001)
2023-11-15 godofredoc@google.com Remove the linux fuchsia v1 build. (flutter/engine#48085)
2023-11-15 mdebbar@google.com [web] Apply global styles before inserting the DOM element (flutter/engine#48027)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from b23074a79bda to e954d1a1972c (7 revisions) (flutter/engine#48092)
2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`." (flutter/engine#48083)
2023-11-15 41930132+hellohuanlin@users.noreply.github.com [ios]fix ios 16 auto correction highlight showing on top left corner (flutter/engine#47279)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from c42226314a4f to b23074a79bda (3 revisions) (flutter/engine#48081)
2023-11-15 matanlurey@users.noreply.github.com Make `lib/ui/{text|window}/...` compatible with `.clang_tidy`. (flutter/engine#48000)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-16 07:55:06 +00:00
engine-flutter-autoroll
9baa539251
Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (#138515) 2023-11-15 23:12:27 -08:00
Elias Yishak
04afff387f
Catch error for missing directory in FontConfigManager (#138496)
Closes:
- https://github.com/flutter/flutter/issues/138434

We will catch any errors while attempting to clear the temp directories that don't exist for the `FontConfigManager` class
2023-11-15 23:17:29 +00:00
Bernardo Ferrari
2afec776c9
Make UnderlineInputBorder consistent (#124153)
This was easy to implement. I like the result, I think `borderRadius.zero` -> `borderRadius.circular` makes a nice transition, and many places (like macOS) use an effect similar to this PR, while Google doesn't use anywhere (yet). I'm curious if it is going to break goldens or google testing.

<img width="954" alt="ttt" src="https://user-images.githubusercontent.com/351125/229918871-9f2ab851-6b41-44f5-80b9-c7928a8c0014.png">

What do you think? cc @HansMuller @gspencergoog. Is this something you want, should I ask the community, or do you prefer the current one?

Side effects:
- This makes strokeAlign work with `UnderlineInputBorder` (TODO: fix `drawLine` when borderRadius is zero).
- This is faster than the current implementation (clip is slow on Skia). 🚀 
- We could just call `BoxBorder._paintNonUniformBorder` (if it weren't private). Single LOC implementation.
- Web does this by default:
![image](https://user-images.githubusercontent.com/351125/233448671-90ce62ff-be91-40ca-8007-e82b57f3272e.png)
- Apparently no tests fail and most usages around (via code search) seem to be without a borderRadius.
2023-11-15 23:06:57 +00:00
Greg Spencer
f796e62cee
Prepare ShortcutActivator and ShortcutManager to migrate to KeyEvent from RawKeyEvent. (#136854) 2023-11-15 15:05:58 -08:00
Srujan Gaddam
d8ffc7390c
Pin package:web 0.4.0 (#138428)
This version is needed so that dart:js_interop can move to extension
types. Also adds some code to handle some breaking changes:

- Body -> Response. Body was an IDL interface mixin type we exposed in
dart:html. Going forward, users should either use Request or Response.
- Casts to JSAny. These are temporary until we move package:web types to
extension types. Currently, package:web types can't implement JSObject
as JSObject will move to be an extension type itself.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
2023-11-15 15:03:21 -08:00
auto-submit[bot]
82a7a62b45
Reverts "Reland VelocityTracker update (#132291)" (#138512)
Reverts flutter/flutter#137381
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728
2023-11-15 21:22:19 +00:00
Yegor
465288588f
[web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (#138498)
Skipping the test due to
https://github.com/flutter/flutter/issues/137669. It's not clear which
PR started it, so we can't revert anything, and the fix is not yet clear
either. However, the flakiness is very high and is disruptive to the
Flutter team.
2023-11-15 12:58:53 -08:00
engine-flutter-autoroll
ca31aa17b2
Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (#138502)
7c2b8d520b...30327eae08

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1f23a0b74619 to c42226314a4f (2 revisions) (flutter/engine#48075)
2023-11-15 gspencergoog@users.noreply.github.com Update keycode output (flutter/engine#47988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 19:48:18 +00:00
Kate Lovett
1ac73332bc
Reland VelocityTracker update (#132291) (#137381)
This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.

Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761

The change was reverted due to flakiness it introduced in tests that use fling gestures.
* https://github.com/flutter/flutter/issues/135728
2023-11-15 19:31:48 +00:00
engine-flutter-autoroll
7f3f52f00c
Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (#138499)
f58dac64ad...7c2b8d520b

2023-11-15 jason-simmons@users.noreply.github.com In the scenario game loop test, cancel the results writer task if the activity has been destroyed (flutter/engine#48051)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 18:51:38 +00:00
Kate Lovett
cf18d250ad
Fix 2D tap to stop scrolling (#138442)
Adopted from https://github.com/flutter/flutter/pull/133750
That PR was abandoned. This finishes it up so we can land it.
Fixes https://github.com/flutter/flutter/issues/133529

Moves the `PanGestureRecognizer` used to drag the content along both axis to the outer vertical `Scrollable` subclass instead of the inner horizontal `Scrollable` subclass.

- This solves the issue of the inner `Scrollable` gestures being disabled while the outer `Scrollable` is scrolling
- Enables the user to stop the scroll movement by dragging the content again
2023-11-15 18:29:40 +00:00
engine-flutter-autoroll
4720750650
Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (#138494)
d22d063ac9...f58dac64ad

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 3b7a62e2ac3f to 1f23a0b74619 (1 revision) (flutter/engine#48074)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 1abce6b0a763 to 3b7a62e2ac3f (2 revisions) (flutter/engine#48071)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 18:11:54 +00:00
Binni Goel
684980e97d
SemanticOwner should dispatch creation and disposal events (#138388) 2023-11-15 09:27:55 -08:00
engine-flutter-autoroll
0f42d19477
Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (#138489)
ecaf944203...d22d063ac9

2023-11-15 zanderso@users.noreply.github.com Reverts Dart to 3.3.0-135.0.dev (flutter/engine#48070)
2023-11-15 mdebbar@google.com [web] Move `EmbeddingStrategy` and `DimensionsProvider` out of `FlutterViewEmbedder` (flutter/engine#48025)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from d0e4a53f56f5 to 1abce6b0a763 (3 revisions) (flutter/engine#48067)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 849fd6ccc339 to 002e66832465 (1 revision) (flutter/engine#48065)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 65819963fb17 to 849fd6ccc339 (1 revision) (flutter/engine#48060)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 17:14:07 +00:00
engine-flutter-autoroll
cffa654902
Roll Packages from 428ba3e24532 to 0cd23780741d (1 revision) (#138482)
428ba3e245...0cd2378074

2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter from f66215027e14 to e8c2bb135659 (66 revisions) (flutter/packages#5399)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 15:43:34 +00:00
Flutter GitHub Bot
defa2b7443
Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (#138472)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/138072 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20hot_mode_dev_cycle__benchmark%22).
This test can be marked as unflaky.
2023-11-15 11:32:08 +00:00
engine-flutter-autoroll
bf38935701
Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (#138468)
a7a48a68e6...ecaf944203

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 2f2c74633e0f to d0e4a53f56f5 (1 revision) (flutter/engine#48059)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 09:13:13 +00:00
engine-flutter-autoroll
35132072d8
Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (#138463)
976edd5192...a7a48a68e6

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from a701a64f1ba9 to 2f2c74633e0f (1 revision) (flutter/engine#48058)
2023-11-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f1322227bdf to 65819963fb17 (2 revisions) (flutter/engine#48056)
2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 5778a54af88d to a701a64f1ba9 (1 revision) (flutter/engine#48055)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 07:38:18 +00:00
engine-flutter-autoroll
68633f7048
Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (#138462)
a7f2267dd1...976edd5192

2023-11-15 skia-flutter-autoroll@skia.org Roll Skia from 0d9175bb5cfa to 5778a54af88d (1 revision) (flutter/engine#48052)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 06:01:26 +00:00
engine-flutter-autoroll
a930fd8e4a
Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (#138459)
bc5bbd3b9e...a7f2267dd1

2023-11-15 chris@bracken.jp [macOS] Clean up allocations in key responder tests (flutter/engine#48048)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 05:03:08 +00:00
engine-flutter-autoroll
cfdc6c58a5
Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (#138457)
d7ca057b89...bc5bbd3b9e

2023-11-15 ditman@gmail.com [web] JSConfig: Add multiViewEnabled value. (flutter/engine#47939)
2023-11-15 jonahwilliams@google.com [Impeller] Simplify convex tessellation (flutter/engine#47957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 03:35:33 +00:00
engine-flutter-autoroll
3f910e8988
Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (#138456)
1347413470...d7ca057b89

2023-11-15 jacksongardner@google.com Use flutter.js in the actual test harness. (flutter/engine#47670)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-15 02:52:24 +00:00