engine-flutter-autoroll
0b15c3e00a
Roll Flutter Engine from 5acdac549034 to 40ddc30b9d6c (1 revision) ( #136526 )
...
5acdac5490...40ddc30b9dskia-flutter-autoroll@skia.org Roll Dart SDK from 849253fd69b6 to 54ef02480719 (2 revisions) (flutter/engine#46871 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 10:32:23 +00:00
engine-flutter-autoroll
4603314cd2
Roll Flutter Engine from b59d779d4f7f to 5acdac549034 (2 revisions) ( #136523 )
...
b59d779d4f...5acdac5490skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XnH2CtqEH7byTHna7... to SDPa6SfaKvRRSUCij... (flutter/engine#46868 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from faad330e7120 to f27c0f222320 (1 revision) (flutter/engine#46869 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from XnH2CtqEH7by to SDPa6SfaKvRR
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 09:02:27 +00:00
engine-flutter-autoroll
d479b5e2c6
Roll Flutter Engine from dc30b4cd0239 to b59d779d4f7f (2 revisions) ( #136521 )
...
dc30b4cd02...b59d779d4fskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QLiomHC9D-GWh_gyK... to pI1BVH08V0eG0M7sw... (flutter/engine#46867 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from aee708412bec to faad330e7120 (1 revision) (flutter/engine#46866 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from QLiomHC9D-GW to pI1BVH08V0eG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 07:35:07 +00:00
engine-flutter-autoroll
962fcd6243
Roll Flutter Engine from 31ec5e31a914 to dc30b4cd0239 (1 revision) ( #136518 )
...
31ec5e31a9...dc30b4cd02skia-flutter-autoroll@skia.org Roll Skia from bf557aeaaef8 to aee708412bec (1 revision) (flutter/engine#46865 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 06:50:14 +00:00
engine-flutter-autoroll
bae67d96f0
Roll Flutter Engine from 7a6172e9d34c to 31ec5e31a914 (1 revision) ( #136516 )
...
7a6172e9d3...31ec5e31a9skia-flutter-autoroll@skia.org Roll Dart SDK from b0d65ad14354 to 849253fd69b6 (1 revision) (flutter/engine#46864 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 06:05:16 +00:00
engine-flutter-autoroll
43d8a133ac
Roll Flutter Engine from ffb3b5b67f61 to 7a6172e9d34c (1 revision) ( #136515 )
...
ffb3b5b67f...7a6172e9d3zanderso@users.noreply.github.com Revert "Remove the frontend server wrapper" (flutter/engine#46863 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 05:25:21 +00:00
Kostia Sokolovskyi
7d79472531
SearchAnchor should dispose created FocusNode and SearchController. ( #136120 )
2023-10-12 19:35:46 -07:00
engine-flutter-autoroll
e0b8ec0782
Roll Flutter Engine from dee90f16aacd to ffb3b5b67f61 (2 revisions) ( #136506 )
...
dee90f16aa...ffb3b5b67fskia-flutter-autoroll@skia.org Roll Dart SDK from 34c06f0bcb29 to b0d65ad14354 (3 revisions) (flutter/engine#46859 )
2023-10-12 jason-simmons@users.noreply.github.com Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 02:00:26 +00:00
Todd Volkert
bc688cf0df
Make constraints a covariant argument in RenderBox.computeDryLayout() ( #136432 )
...
Some render box subclasses have a specific layout contract that is tightly coupled with other render box subclasses (e.g. two private classes in a local project file). In these cases, it is also possible that they use a constraints object that is a subclass of `BoxConstraints`. To allow for this, this change makes the `constraints` argument to `RenderBox.computeDryLayout()` a covariant argument.
For completeness' sake, this updates the other render objects in the rendering package to also use the covariant keyword for this argument.
2023-10-13 01:10:29 +00:00
Yegor
0f082889a8
[web] remove loading indicator in -d web-server builds ( #136482 )
...
Fixes https://github.com/flutter/flutter/issues/135226
2023-10-12 23:45:06 +00:00
engine-flutter-autoroll
5f796b2950
Roll Flutter Engine from cb37ebc81939 to dee90f16aacd (3 revisions) ( #136502 )
...
cb37ebc819...dee90f16aaskia-flutter-autoroll@skia.org Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (flutter/engine#46853 )
2023-10-12 uysalere@gmail.com [fuchsia] Add fatal error for Vulkan failure (flutter/engine#46831 )
2023-10-12 mdebbar@google.com [web] Stop using `flutterViewEmbedder` for platform views (flutter/engine#46046 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 23:45:03 +00:00
engine-flutter-autoroll
856475c0e4
Roll Flutter Engine from 7eb20a09073e to cb37ebc81939 (2 revisions) ( #136492 )
...
7eb20a0907...cb37ebc819skia-flutter-autoroll@skia.org Roll Skia from 222fe6b9b0eb to 8b110fd65de9 (1 revision) (flutter/engine#46852 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from fdcbbc4d5c25 to 222fe6b9b0eb (2 revisions) (flutter/engine#46849 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 22:59:09 +00:00
xubaolin
3f722c1442
[SingleChildScrollView] Correct the offset pixels if it is out of range during layout ( #136239 )
...
Fixes https://github.com/flutter/flutter/issues/105733
FIxes https://github.com/flutter/flutter/issues/135865
The above two issues will not occur on the `ListView` widget, so after analyzing their differences, it was found that the `SingleChildScrollView` pixels were not corrected according to the content dimensions during layout.
### ListView correct the pixels codes
5dfd78c2e3/packages/flutter/lib/src/rendering/viewport.dart (L1462-L1465)
2023-10-12 21:25:09 +00:00
Greg Spencer
22b0a62a0c
Allow TapRegion to consume tap events ( #136305 )
...
## Description
In order for `MenuAnchor` menus to be able to not pass on the taps that close their menus, `TapRegion` needed a way to consume them. This change adds a flag to the `TapRegion`, `consumeOutsideTap` that will consume taps that occur outside of the region if the flag is set (it is false by default). The same flag is added to `MenuAnchor` to allow selecting the behavior for menus.
`TapRegion` consumes the tap event by registering with the gesture arena and immediately resolving the tap as accepted if any regions in a group have `consumeOutsideTap` set to true.
This PR also deprecates `MenuAnchor.anchorTapClosesMenu`, since it is a much more limited version of the same feature that only applied to the anchor itself, and even then only applied to closing the menu, not passing along the tap. The same functionality can now be implemented by handling a tap on the anchor widget and checking to see if the menu is open before closing it.
## Related Issues
- https://github.com/flutter/flutter/issues/135327
## Tests
- Added tests for `TapRegion` to make sure taps are consumed properly.
2023-10-12 21:04:41 +00:00
Michael Goderbauer
7ea5536f12
Fix doc TODO ( #136485 )
...
Underlying bug (https://github.com/dart-lang/dartdoc/issues/2276 ) has been fixed a while ago.
2023-10-12 20:52:51 +00:00
engine-flutter-autoroll
1b797baf0d
Roll Flutter Engine from f02006736390 to 7eb20a09073e (4 revisions) ( #136478 )
...
f020067363...7eb20a0907skia-flutter-autoroll@skia.org Roll Skia from 1d134a8f3ae2 to fdcbbc4d5c25 (7 revisions) (flutter/engine#46844 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8AXhoo-MMME8NMKt0... to XnH2CtqEH7byTHna7... (flutter/engine#46843 )
2023-10-12 chinmaygarde@google.com [Impeller] Specify default border color for texture wrap mode that clamps. (flutter/engine#46806 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from giQtXxdSj6NdIViCw... to QLiomHC9D-GWh_gyK... (flutter/engine#46838 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from giQtXxdSj6Nd to QLiomHC9D-GW
fuchsia/sdk/core/mac-amd64 from 8AXhoo-MMME8 to XnH2CtqEH7by
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 20:16:25 +00:00
Michael Goderbauer
437361321a
Bump file,process,process_runner ( #136418 )
2023-10-12 13:05:24 -07:00
engine-flutter-autoroll
90b24fb5b1
Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) ( #136467 )
...
664657d329...f020067363zanderso@users.noreply.github.com Remove the frontend server wrapper (flutter/engine#46440 )
2023-10-12 jason-simmons@users.noreply.github.com Roll SwiftShader to include a fix required by the latest Clang toolchain (flutter/engine#46803 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 17:54:12 +00:00
huycozy
e8a0cf3ae8
Fix PageView API doc sample fails on Desktop and Web ( #135910 )
...
### Description
This PR aims to improve/fix the PageView API doc sample for Web and Desktop platforms. On these platforms, mouse dragging gestures do not provide natural behavior similar to other desktop applications. This PR will add navigation buttons (indicators) so users can interact with the demo.
### Related issue
Fixes https://github.com/flutter/flutter/issues/135188
### Demo video
https://github.com/flutter/flutter/assets/104349824/0f9c60bd-8b18-404e-b5b6-1d594604de31
2023-10-12 17:28:13 +00:00
Derek Xu
406c4dbf77
Add --trace-to-file option to flutter run ( #135713 )
2023-10-12 13:23:52 -04:00
Christopher Fujino
9751fe6449
[flutter_tools] handle ERROR_INVALID_FUNCTION when trying to symlink across drives ( #136424 )
...
~~Fixes https://github.com/flutter/flutter/issues/136321~~
edit by @andrewkolos: Fixes https://github.com/flutter/flutter/issues/66224
2023-10-12 17:15:45 +00:00
pdblasi-google
fa827eb2aa
Updates references to finders.dart in controller.dart to use a namespace. ( #136423 )
...
Updates references to `finders.dart` in `controller.dart` to use a namespace. This enables us to make use of `finders.dart#find` in `SemanticsController` without anything being shadowed.
Fixes #136421
2023-10-12 17:02:32 +00:00
Victoria Ashworth
d6ec0cf564
Change some tests to run on macs without iOS devices attached ( #136463 )
...
Some tests have been running on devicelab bots with iOS devices attached, however, they don't require an iOS device. So moving them to run on bots without iOS devices.
Fixes https://github.com/flutter/flutter/issues/136415 .
2023-10-12 16:52:16 +00:00
engine-flutter-autoroll
ee7e41fec0
Roll Packages from 4b483f242936 to 93c3f69fa6c6 (9 revisions) ( #136461 )
...
4b483f2429...93c3f69fa6goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121 )
2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416 )
2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759 ] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081 )
2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106 )
2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096 )
2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903 )
2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986 )
2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038 )
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f7e55d to 83134ac7e44c (25 revisions) (flutter/packages#5104 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 16:13:06 +00:00
Victoria Ashworth
ddc9b40a98
Fix typo in function name ( #136273 )
...
Rename `removeIOSimulator` to `removeIOSSimulator`.
2023-10-12 15:53:00 +00:00
Taha Tesser
f65dd3bac0
Fix chip widgets don't the apply provided iconTheme ( #135751 )
...
fixes [`Chip.iconTheme` does not apply the icon theme](https://github.com/flutter/flutter/issues/111828 )
### Description
- Fix chip widgets that don't utilize the provided `iconTheme`.
- Prevent `iconTheme` with just color from overriding the default icon size.
- Add some missing M3 tests for the chip and chip theme properties.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(useMaterial3: true),
home: const Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
final bool _isEnable = true;
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
RawChip(
iconTheme: const IconThemeData(color: Colors.amber),
avatar: const Icon(Icons.favorite_rounded),
label: const Text('RawChip'),
onPressed: () {},
isEnabled: _isEnable,
),
const Chip(
iconTheme: IconThemeData(color: Colors.amber),
avatar: Icon(Icons.favorite_rounded),
label: Text('Chip'),
// onDeleted: () {},
),
FilterChip(
iconTheme: const IconThemeData(color: Colors.amber),
avatar: const Icon(Icons.favorite_rounded),
label: const Text('FilterChip'),
selected: false,
onSelected: _isEnable ? (bool value) {} : null,
),
InputChip(
iconTheme: const IconThemeData(color: Colors.amber),
avatar: const Icon(Icons.favorite_rounded),
label: const Text('InputChip'),
isEnabled: _isEnable,
onPressed: () {},
),
ActionChip(
iconTheme: const IconThemeData(color: Colors.amber),
avatar: const Icon(Icons.favorite_rounded),
label: const Text('ActionChip'),
onPressed: _isEnable ? () {} : null,
),
ChoiceChip(
iconTheme: const IconThemeData(color: Colors.amber),
avatar: const Icon(Icons.favorite_rounded),
label: const Text('ChoiceChip'),
selected: false,
onSelected: _isEnable ? (bool value) {} : null,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: () {},
child: const Icon(Icons.add),
),
);
}
}
```
</details>
### Before
### After
2023-10-12 14:17:56 +00:00
engine-flutter-autoroll
fad8bda64a
Roll Flutter Engine from 33a6d21b3364 to 664657d32992 (2 revisions) ( #136450 )
...
33a6d21b33...664657d329skia-flutter-autoroll@skia.org Roll Dart SDK from 9afac395dfb1 to 34c06f0bcb29 (1 revision) (flutter/engine#46820 )
2023-10-12 skia-flutter-autoroll@skia.org Roll ICU from 985b9a6f70e1 to 995db880cff2 (1 revision) (flutter/engine#46818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 11:40:22 +00:00
engine-flutter-autoroll
b89e1df7ac
Roll Flutter Engine from d00fabf0b919 to 33a6d21b3364 (5 revisions) ( #136442 )
...
d00fabf0b9...33a6d21b33skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qjz4zE4Oe0AO_7T3f... to 8AXhoo-MMME8NMKt0... (flutter/engine#46814 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 9f5080c58aac to 2dd1579c6921 (1 revision) (flutter/engine#46813 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from db2465f106ad to 9afac395dfb1 (1 revision) (flutter/engine#46812 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hMA99PoacaRZVXHgr... to giQtXxdSj6NdIViCw... (flutter/engine#46811 )
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from ff3c2e3d45bd to 9f5080c58aac (1 revision) (flutter/engine#46809 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hMA99PoacaRZ to giQtXxdSj6Nd
fuchsia/sdk/core/mac-amd64 from Qjz4zE4Oe0AO to 8AXhoo-MMME8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 08:07:21 +00:00
engine-flutter-autoroll
c0d19ca561
Roll Flutter Engine from 05e26c1b2c79 to d00fabf0b919 (5 revisions) ( #136431 )
...
05e26c1b2c...d00fabf0b9skia-flutter-autoroll@skia.org Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807 )
2023-10-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797 )
2023-10-11 bdero@google.com [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610 )
2023-10-11 bdero@google.com [Impeller] Bump impeller-cmake (flutter/engine#46764 )
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-12 03:33:07 +00:00
Qun Cheng
6388e3d727
Floating SnackBar should always float above the bottom widgets ( #136411 )
...
Fixes #136162
This PR is to fix the floating `SnackBar` issue so that when the top of the bottom bar is higher than the top of the FAB, the snack bar will still float and not be clipped.
| Before fix | After fix |
|--------|--------|
|  | 
|
2023-10-12 01:17:07 +00:00
Bryan Olivares
d9c0d3ae51
SearchBar should listen to changes to the SearchController and update suggestions on change ( #134337 )
...
This PR is adding a listener to the `SearchController`, so that the `suggestionBuilder` can be updated when the `SearchController` changes.
Another method we can possibly do is have an update method on `SearchController`, so that the user can manually update the suggestions instead of us doing it automatically.
Fixes #132161
2023-10-12 00:55:38 +00:00
Kevin Moore
3e60999b11
Allow latest pkg:material_color_utilities ( #132445 )
...
* Allow latest pkg:material_color_utilities
* Bump other dependencies to their latest - including pkg:web
2023-10-11 23:57:16 +00:00
engine-flutter-autoroll
695825419d
Roll Flutter Engine from 8bf1460892c6 to 05e26c1b2c79 (3 revisions) ( #136422 )
...
8bf1460892...05e26c1b2cjason-simmons@users.noreply.github.com Run the binary size treemap script from the buildroot directory (flutter/engine#46740 )
2023-10-11 dnfield@google.com [Impeller] flutter_tester --enable-impeller (flutter/engine#46389 )
2023-10-11 jacksongardner@google.com Switch to Chrome For Testing instead of Chromium (flutter/engine#46683 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 23:52:06 +00:00
Kevin Chisholm
6027d5d3fc
Create template for umbrella issues ( #134235 )
...
In order to better track features, I propose that we have a unified
template for creating Umbrella issues. This is not required to create
umbrella issue to add to the feature tracker, however for those who
would like a more fleshed out format, this will serve the purpose.
Fixes: https://github.com/flutter/flutter/issues/134234
2023-10-11 18:22:49 -05:00
Loïc Sharma
50b56de215
[Windows Arm64] Add the 'platform_channel_sample_test_windows' Devicelab test ( #136401 )
...
â
Successful run: 2a327123e9/+/build.protohttps://github.com/flutter/flutter/issues/129806
2023-10-11 23:07:29 +00:00
engine-flutter-autoroll
a44e0862a8
Roll Flutter Engine from 2b1b4b97f787 to 8bf1460892c6 (4 revisions) ( #136414 )
...
2b1b4b97f7...8bf146089234871572+gmackall@users.noreply.github.com Revert "[Android] Add support for text processing actions (#44579 )" (flutter/engine#46788 )
2023-10-11 danchevalier@google.com [web] Adds Noto Music fallback font (flutter/engine#46720 )
2023-10-11 jason-simmons@users.noreply.github.com Fix some image_external_texture entries in the license golden file (flutter/engine#46790 )
2023-10-11 john@johnmccutchan.com Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 23:04:17 +00:00
Christopher Fujino
8ca7d7d136
Stop recommending android sdk root ( #136296 )
...
Fixes https://github.com/flutter/flutter/issues/117245
2023-10-11 21:04:59 +00:00
engine-flutter-autoroll
e83f53e6a0
Roll Flutter Engine from 5fcc16772cdd to 2b1b4b97f787 (1 revision) ( #136404 )
...
5fcc16772c...2b1b4b97f7skia-flutter-autoroll@skia.org Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 20:58:57 +00:00
Jackson Gardner
a277c5faaf
Switch to Chrome for Testing instead of vanilla Chromium. ( #136214 )
...
This switches over to using Chrome for Testing instead of Chromium. This should ensure that we are consistently using an official and consistent build of Chrome on all platforms, rather than whatever we can get from the continuous builds archive, which can potentially put platforms out of sync with each other.
2023-10-11 20:51:14 +00:00
Derek Xu
1a44710d19
Reland "Switch flutter_tools to run frontend server from AOT snapshot" ( #136282 )
...
This reverts commit a1639be.
2023-10-11 16:15:26 -04:00
engine-flutter-autoroll
58701ac2f2
Roll Flutter Engine from 4b02631b59bf to 5fcc16772cdd (2 revisions) ( #136397 )
...
4b02631b59...5fcc16772cjohn@johnmccutchan.com Fix 303652511 and add a regression test (flutter/engine#46743 )
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 20:00:04 +00:00
Kate Lovett
156e3487b0
Fix some deprecation details ( #136385 )
...
This fixes/notates a few deprecations from an audit for the next tech debt cycle.
- ThemeData errorColor and backgroundColor are notated as deprecated in multiple places, but one usage had a different version tag. Updated to match the rest.
- ThemeData.copyWith useMaterial3 was deprecated because it did not do what developers expected - it did not automatically reassign all of the color values and such. (confirmed with @HansMuller) I added a note so that when we later remove it we don't introduce a bug.
- the describeEnum deprecation was tagged wrong, it was a very long PR so by the time it merged the version it was finally tagged with was much later. (https://github.com/flutter/flutter/pull/125016 )
2023-10-11 19:39:06 +00:00
engine-flutter-autoroll
9a8a2c7fc9
Roll Flutter Engine from ed67e8aa9aba to 4b02631b59bf (1 revision) ( #136392 )
...
ed67e8aa9a...4b02631b59bdero@google.com [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 19:02:22 +00:00
droidbg
f84831c169
[leak-tracking] Add leak tracking in test/rendering - 1 ( #136275 )
2023-10-11 11:53:41 -07:00
Loïc Sharma
f2931dbd8c
Remove the 'Windows_arm64 plugin_test' Devicelab test ( #136379 )
...
This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.
2023-10-11 18:31:04 +00:00
engine-flutter-autoroll
ea8c6307fe
Roll Flutter Engine from 68a8ff743539 to ed67e8aa9aba (2 revisions) ( #136383 )
...
68a8ff7435...ed67e8aa9askia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778 )
2023-10-11 zanderso@users.noreply.github.com Roll goldctl forward (flutter/engine#46771 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-11 18:12:06 +00:00
Christopher Fujino
5a4497d47f
extend timeout from default 30 min to 1 hour for windows build tests ( #136300 )
...
Fixes https://github.com/flutter/flutter/issues/136299
2023-10-11 18:10:52 +00:00
Kenzie Davisson
a047358c5c
Add profilePlatformChannels service extension ( #136051 )
...
We will expose this from a button in DevTools.
https://github.com/flutter/devtools/issues/6166
2023-10-11 10:45:06 -07:00
Maximilian Fischer
6ff02dbc83
Include size factors when computing the intrinsic size of a RenderPositionedBox ( #135823 )
...
This PR includes the `widthFactor` and `heightFactor` when computing the intrinsic size of a `RenderPositionedBox`.
<details><summary>Code sample</summary>
Red should have a height of 100, blue one of 200.
```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Intrinsic Bug',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: Scaffold(
body: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Expanded(
child: IntrinsicHeight(
child: Align(
heightFactor: 0.5,
child: Container(
height: 200,
color: Colors.red,
),
),
),
),
Expanded(
child: Container(
height: 200,
color: Colors.blue,
),
),
],
),
),
);
}
}
```
</details>
Before:
After:
Fix #135822
2023-10-11 17:39:56 +00:00
Zachary Anderson
d773c5a9ea
[flutter_tool] Delete skipped tests ( #136364 )
...
These tests have been skipped due to flakiness for a long time.
Closes https://github.com/dart-lang/webdev/issues/1562
Closes https://github.com/flutter/flutter/issues/124214
2023-10-11 10:24:14 -07:00
