Bruno Leroux
0c6b600e76
Deprecate invalid InputDecoration.collapsed parameters ( #152486 )
...
## Description
This PR is a follow up to https://github.com/flutter/flutter/pull/152165#pullrequestreview-2200072459 .
It deprecates two parameters that should not have been added (`floatingLabelBehavior` and `floatingLabelAlignment`) to `InputDecoration.collapsed`. Those parameters are related to the floating label but a collapsed input decoration is not supposed to have labels.
For the dart_fix, I created a new fix file and moved some previous fixes to it.
## Tests
Adds 1 test, updates 1.
2024-07-31 07:59:41 +00:00
Andrew Kolos
7133a89c44
increase sharding on Windows tool_integration_tests ( #152582 )
...
Resolves https://github.com/flutter/flutter/issues/152211
Will remove `bringup` status after this merges.
2024-07-31 06:52:06 +00:00
engine-flutter-autoroll
6eceedd769
Roll Flutter Engine from e2ece7e58480 to b73367a30e9b (4 revisions) ( #152592 )
...
e2ece7e584...b73367a30ejason-simmons@users.noreply.github.com Update flutter_shell_native_unittests for compatibility with Android API 35 emulators (flutter/engine#54235 )
2024-07-31 chris@bracken.jp [docs] Delete obsolete ML guided optimisation doc (flutter/engine#54237 )
2024-07-31 skia-flutter-autoroll@skia.org Roll Dart SDK from e16dc217b1ac to 68e559110999 (1 revision) (flutter/engine#54236 )
2024-07-30 1961493+harryterkelsen@users.noreply.github.com enumify ImageType and ImageFileSignature (flutter/engine#54131 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 02:46:18 +00:00
engine-flutter-autoroll
14b51b498f
Roll Flutter Engine from 0b42657a184e to e2ece7e58480 (2 revisions) ( #152589 )
...
0b42657a18...e2ece7e584skia-flutter-autoroll@skia.org Roll Skia from e8fb6f320da0 to b6036baeebbd (3 revisions) (flutter/engine#54234 )
2024-07-30 chinmaygarde@google.com [Impeller] Use linear sampling to sample from AHB textures in Vulkan. (flutter/engine#54233 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 01:29:30 +00:00
engine-flutter-autoroll
357599b58a
Roll Flutter Engine from 08f9be3ab284 to 0b42657a184e (2 revisions) ( #152586 )
...
08f9be3ab2...0b42657a18skia-flutter-autoroll@skia.org Roll Skia from 4e31906b6312 to e8fb6f320da0 (5 revisions) (flutter/engine#54229 )
2024-07-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Do not disable partial repaint based on thread merging state (#54219 )" (flutter/engine#54230 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-31 00:23:10 +00:00
Matan Lurey
888149f9f5
Clarify and cleanup the test-exemption wording in tree-hygiene. ( #152402 )
...
Based off a [discussion on
Discord](https://discord.com/channels/608014603317936148/608018585025118217/1266501306852446421 ),
but I've also anecdotally had a few people ask this before.
Other than a bit of reformatting, I wanted to clarify that the PR
reviewer should still _agree_ an exemption is needed (i.e. not defer
this responsibility entirely to our small volunteer staff of reviewers),
and that _all_ reviewers should feel empowered to push back, and not
wait for a test exemption reviewer to do it. This [matches the guidance
in the
bot](f1b20b6e4c/app_dart/lib/src/service/config.dart (L253-L255)f1b20b6e4c/app_dart/lib/src/service/config.dart (L239-L255)
2024-07-30 16:53:54 -07:00
David Iglesias
111b4fe6d1
[web] Set COEP:credentialless on flutter run/drive. ( #152413 )
...
This PR changes the value of the `COEP` response header from `require-corp` to `credentialless` in the Flutter tool, when running `flutter run`/`drive` for Web projects.
This enables running tests compiled to wasm, that access 3P resources (like Google Maps) without blocking those resources.
Docs:
* https://developer.chrome.com/blog/coep-credentialless-origin-trial#credentialless_to_the_rescue
## Issue
* https://github.com/flutter/flutter/issues/152411
2024-07-30 23:14:06 +00:00
engine-flutter-autoroll
4778895036
Roll Flutter Engine from a4b88a37d511 to 08f9be3ab284 (5 revisions) ( #152583 )
...
a4b88a37d5...08f9be3ab2chris@bracken.jp [iOS] Delete unused create_ios_framework.py (flutter/engine#54227 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226 )
2024-07-30 jonahwilliams@google.com [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200 )
2024-07-30 matej.knopp@gmail.com Do not disable partial repaint based on thread merging state (flutter/engine#54219 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 22:59:04 +00:00
Flutter GitHub Bot
9bf8a283aa
Marks Mac platform_channel_sample_test_macos to be flaky ( #151884 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac platform_channel_sample_test_macos"
}
-->
Issue link: https://github.com/flutter/flutter/issues/151883
2024-07-30 22:50:59 +00:00
engine-flutter-autoroll
ccb58a9cef
Roll Flutter Engine from a6c5ff26c266 to a4b88a37d511 (2 revisions) ( #152575 )
...
a6c5ff26c2...a4b88a37d5skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QsN_RyaTWxm-8AD47... to cYjTzxe0MskG7PtkB... (flutter/engine#54223 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from c1fcf8e5a55c to b9b208f11c67 (2 revisions) (flutter/engine#54222 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from QsN_RyaTWxm- to cYjTzxe0MskG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 21:20:25 +00:00
hangyu
dc6a15995e
Reland #151599 (Add button semantics in list tile ) with a flag to control behavior. ( #152526 )
...
https://github.com/flutter/flutter/pull/151599 was reverted because it was a breaking change to g3
Will reland 151599 in 5 steps
1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false)
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly.
3. Send a PR to flip the default value to true.
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.
(<----This PR is step 1)
2024-07-30 20:38:06 +00:00
Zachary Anderson
5f460e10fc
Shift macOS/Android tests from Pixel 7 to mokey in staging ( #152571 )
...
Part of https://github.com/flutter/flutter/issues/148085
2024-07-30 12:48:34 -07:00
engine-flutter-autoroll
6a368d8680
Roll Flutter Engine from 31bb9f98472a to a6c5ff26c266 (5 revisions) ( #152573 )
...
31bb9f9847...a6c5ff26c2skia-flutter-autoroll@skia.org Roll Skia from a4d59988bde0 to c1fcf8e5a55c (1 revision) (flutter/engine#54220 )
2024-07-30 30870216+gaaclarke@users.noreply.github.com Reland: [Impeller] Use downsample shader for blur instead of mip levels. (flutter/engine#54149 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 2cb7f5443a48 to a4d59988bde0 (1 revision) (flutter/engine#54218 )
2024-07-30 30870216+gaaclarke@users.noreply.github.com [Impeller] makes the gaussian down sample scalar fixed by adjusting the downsample padding (flutter/engine#54150 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from ad4d2e8b2c65 to 14b51d32e3a6 (1 revision) (flutter/engine#54216 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 18:56:35 +00:00
engine-flutter-autoroll
5a47cfb3b0
Roll Packages from 247fb5f0b7e7 to 99e860679a9a (5 revisions) ( #152567 )
...
247fb5f0b7...99e860679aandrelvsousa@gmail.com [video_player_android] Add RTSP support (flutter/packages#7081 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.3.1 to 1.4.0 in /packages/video_player/video_player_android/android (flutter/packages#7241 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/camera/camera_android/android (flutter/packages#7236 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/path_provider/path_provider_android/android (flutter/packages#7244 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/packages#7234 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 17:53:10 +00:00
Taha Tesser
cd60efc618
Fix default avatar icon theme size for Material 2 ( #152307 )
...
fixes [ActionChip avatar still does not respect padding](https://github.com/flutter/flutter/issues/116508 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(brightness: Brightness.dark, useMaterial3: false),
home: Scaffold(
body: Center(
child: Builder(
builder: (BuildContext context) {
return Chip(
padding: const EdgeInsets.all(16.0),
avatar: const Icon(Icons.favorite),
label: const Text('Chip A'),
onDeleted: () {},
);
},
),
),
),
);
}
}
```
</details>
### Before
<img width="490" alt="Screenshot 2024-07-25 at 16 24 08" src="https://github.com/user-attachments/assets/45408aa2-b3ab-4ff9-ae72-53a91c87c76a ">
### After
<img width="490" alt="Screenshot 2024-07-25 at 16 23 56" src="https://github.com/user-attachments/assets/07ba367d-9ca3-46cc-8122-d1155dd2f32b ">
2024-07-30 16:44:08 +00:00
engine-flutter-autoroll
61848a448b
Roll Flutter Engine from c58d87d62c20 to 31bb9f98472a (8 revisions) ( #152555 )
...
c58d87d62c...31bb9f9847skia-flutter-autoroll@skia.org Roll Skia from 1339015537a3 to 2cb7f5443a48 (4 revisions) (flutter/engine#54212 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 6ab9452297e0 to ad4d2e8b2c65 (1 revision) (flutter/engine#54211 )
2024-07-30 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/engine#54208 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 20e4dfabb6b2 to 1339015537a3 (1 revision) (flutter/engine#54207 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Dart SDK from e8eca6f05494 to 6ab9452297e0 (1 revision) (flutter/engine#54206 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 56de22c39d0e to 20e4dfabb6b2 (1 revision) (flutter/engine#54205 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 946ca24d03ab to 56de22c39d0e (1 revision) (flutter/engine#54204 )
2024-07-30 skia-flutter-autoroll@skia.org Roll Skia from 8167ff71af2c to 946ca24d03ab (2 revisions) (flutter/engine#54202 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 16:42:10 +00:00
Bruno Leroux
85960d24b9
Fix Shortcut label for CharacterActivator does not include modifiers ( #152233 )
...
## Description
This PR fixes the shortcut label for CharacterActivator with modifiers keys.
**Before**:
**After**:
## Related Issue
Fixes https://github.com/flutter/flutter/issues/145040 .
## Tests
Adds 1 test.
2024-07-30 07:03:00 +00:00
Rexios
dfedcfe702
[wiki] Remove text saying wiki edits do not get code reviewed ( #152530 )
...
Sequel to https://github.com/flutter/flutter/pull/152529
2024-07-30 03:23:37 +00:00
engine-flutter-autoroll
c71d495fe4
Roll Flutter Engine from cb96743cc955 to c58d87d62c20 (1 revision) ( #152527 )
...
cb96743cc9...c58d87d62cskia-flutter-autoroll@skia.org Roll Skia from 832023dc041a to 8167ff71af2c (1 revision) (flutter/engine#54199 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 01:55:30 +00:00
Greg Spencer
b05c2fad0c
Add find.backButton finder and StandardComponentType enum to find components in tests. ( #149349 )
...
## Description
This adds `find.backButton()` in the Common Finders to allow finding different types of standard UI elements. It works by attaching a key made from an enum value in a new enum called `StandardComponentType` to all of the standard widgets that perform the associated function.
I also substituted the finder in several places where it is useful in tests.
This allows writing tests that want to find the "back" button without having to know exactly which icon the back button uses under what circumstances. To do it correctly is actually quite complicated, since there are several adaptations that occur (based on platform, and whether it is web or not).
## Tests
- Added tests.
2024-07-30 01:29:31 +00:00
engine-flutter-autoroll
1030429e1f
Roll Flutter Engine from 49324cd0b678 to cb96743cc955 (4 revisions) ( #152524 )
...
49324cd0b6...cb96743cc9jonahwilliams@google.com [Impeller] delete rasterizer class. (flutter/engine#54196 )
2024-07-29 skia-flutter-autoroll@skia.org Roll Skia from 62e955dbaef0 to 832023dc041a (1 revision) (flutter/engine#54198 )
2024-07-29 gorudonu@gmail.com [wiki] Fix link to engine dev setup (flutter/engine#54173 )
2024-07-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 9a6e058303af to e8eca6f05494 (2 revisions) (flutter/engine#54197 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-30 00:50:20 +00:00
Jonah Williams
85d687fe6f
[devicelab] remove Skia specific and unused devicelab metrics. ( #152523 )
...
Even though we haven't completed the process of removing the Skia backend, its unlikely that we will target changes to the picture/ayer cache system or investigate changes in these values that don't also result in raster time changes.
Remove to reduce noise in Skia Perf.
Part of https://github.com/flutter/flutter/issues/143532
2024-07-30 00:18:23 +00:00
Dimil Kalathiya
fcfbc49324
Add Dimil Kalathiya to authors ( #152491 )
...
Add myself to authors. [test-exempt]
Reference: [author:Dimilkalathiya](https://github.com/flutter/flutter/issues?q=author%3ADimilkalathiya+ )
2024-07-30 00:04:16 +00:00
engine-flutter-autoroll
43c2f8e9f6
Roll Flutter Engine from 240fb460675d to 49324cd0b678 (4 revisions) ( #152521 )
...
240fb46067...49324cd0b6skia-flutter-autoroll@skia.org Roll Skia from efd1d5b127ae to 62e955dbaef0 (5 revisions) (flutter/engine#54194 )
2024-07-29 jonahwilliams@google.com [iOS] leak a single overlay layer. (flutter/engine#54189 )
2024-07-29 jonahwilliams@google.com [engine] remove raster stats feature. (flutter/engine#54187 )
2024-07-29 chris@bracken.jp Revert "Set GLArea.has-alpha = true (#54053 )" (flutter/engine#54190 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 23:52:37 +00:00
Victor Sanni
e33eb5b46e
Stop CupertinoScrollbar's track from paging the scroll view on tap ( #152197 )
...
Fixes https://github.com/flutter/flutter/issues/120429
2024-07-29 23:02:02 +00:00
engine-flutter-autoroll
b3bb00c4d9
Roll Flutter Engine from 4ef0f0d988ec to 240fb460675d (1 revision) ( #152507 )
...
4ef0f0d988...240fb46067skia-flutter-autoroll@skia.org Roll Skia from c1de8c48c998 to efd1d5b127ae (2 revisions) (flutter/engine#54188 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 22:02:26 +00:00
engine-flutter-autoroll
fc2430d43d
Roll Flutter Engine from a0219f7a429c to 4ef0f0d988ec (1 revision) ( #152505 )
...
a0219f7a42...4ef0f0d988skia-flutter-autoroll@skia.org Roll Skia from 96b7575339b6 to c1de8c48c998 (3 revisions) (flutter/engine#54185 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 20:59:17 +00:00
Jonah Williams
102cd01693
[flutter_tools] remove raster stats CLI option. ( #152501 )
...
The raster stats feature is being removed from devtools and the engine. Remove the CLI option as well.
Fixes https://github.com/flutter/flutter/issues/144191
Fixes https://github.com/flutter/flutter/issues/132169
2024-07-29 20:30:54 +00:00
Zachary Anderson
53c732f484
Shift some mac Android tests to Mokey devices in staging ( #152499 )
...
Following https://github.com/flutter/flutter/issues/152406
For https://github.com/flutter/flutter/issues/148085
2024-07-29 13:24:41 -07:00
Jonah Williams
4a29a16e87
[devicelab] enable impeller in external texture test. ( #152502 )
...
This will allow us to test impeller with SurfaceTextures. Don't know how to verify if this will work ahead of time without just turning it on...
2024-07-29 20:15:25 +00:00
engine-flutter-autoroll
cb698ec8a4
Roll Flutter Engine from d1995f302c4d to a0219f7a429c (2 revisions) ( #152500 )
...
d1995f302c...a0219f7a42skia-flutter-autoroll@skia.org Roll Skia from 4a65e626ebbe to 96b7575339b6 (3 revisions) (flutter/engine#54183 )
2024-07-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YAzbrQ4d60z1yXx9X... to QsN_RyaTWxm-8AD47... (flutter/engine#54182 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YAzbrQ4d60z1 to QsN_RyaTWxm-
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 20:03:11 +00:00
engine-flutter-autoroll
634ff77381
Roll Flutter Engine from d803bb16c8b0 to d1995f302c4d (4 revisions) ( #152496 )
...
d803bb16c8...d1995f302caam@google.com Remove obsolete dependency from few more targets. (flutter/engine#54181 )
2024-07-29 jason-simmons@users.noreply.github.com [web] Fix scaledImageSize handling of a target width with no target height (flutter/engine#54122 )
2024-07-29 skia-flutter-autoroll@skia.org Roll Skia from 940c71c61d11 to 4a65e626ebbe (4 revisions) (flutter/engine#54180 )
2024-07-29 skia-flutter-autoroll@skia.org Roll Skia from f5a8dfda1131 to 940c71c61d11 (1 revision) (flutter/engine#54179 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 18:30:21 +00:00
Qun Cheng
2e7fa83f67
Normalize Card theme ( #151914 )
...
This PR is to make preparations to make `CardTheme` conform to Flutter's conventions for component themes:
* Added a `CardThemeData` class which defines overrides for the defaults for `Card` properties.
* Added 2 `CardTheme` constructor parameters: `CardThemeData? data` and `Widget? child`. This is now the preferred way to configure a `CardTheme`:
```dart
CardTheme(
data: CardThemeData(color: xxx, elevation: xxx, ...),
child: Card(...)
)
```
These two properties are made nullable to not break existing apps which has customized `ThemeData.cardTheme`.
* Changed the type of theme defaults from `CardTheme` to `CardThemeData`.
TODO:
* Fix internal failures that may have breakages.
* Change the type of `ThemeData.cardTheme` from `CardTheme` to `CardThemeData`. This may cause breaking changes, a migration guide will be created.
Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
2024-07-29 16:48:06 +00:00
engine-flutter-autoroll
804cca62de
Roll Flutter Engine from 2db47a1f3d0d to d803bb16c8b0 (1 revision) ( #152489 )
...
2db47a1f3d...d803bb16c8skia-flutter-autoroll@skia.org Roll Dart SDK from ad35a6027648 to 9a6e058303af (1 revision) (flutter/engine#54178 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 16:44:08 +00:00
engine-flutter-autoroll
1a1b2a15f3
Roll Packages from 3d358d921a84 to 247fb5f0b7e7 (8 revisions) ( #152488 )
...
3d358d921a...247fb5f0b7flutter/packages#7245 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7239 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/image_picker/image_picker_android/android (flutter/packages#6763 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7240 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7243 )
2024-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.12 to 3.25.15 (flutter/packages#7235 )
2024-07-29 engine-flutter-autoroll@skia.org Roll Flutter from 7d5c1c04fb56 to 031dc3d156b9 (97 revisions) (flutter/packages#7225 )
2024-07-26 jlund@overlay.ai [camera_windows] Support image streams on Windows platform (flutter/packages#7067 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 15:49:15 +00:00
Reid Baker
771650ca16
Update New-Android-version.md ( #152395 )
...
Related to https://github.com/flutter/flutter/issues/152374
2024-07-29 15:18:56 +00:00
engine-flutter-autoroll
a7bd806fc7
Roll Flutter Engine from 510f19a7e629 to 2db47a1f3d0d (1 revision) ( #152485 )
...
510f19a7e6...2db47a1f3dskia-flutter-autoroll@skia.org Roll Skia from 34ef6ecb027c to f5a8dfda1131 (1 revision) (flutter/engine#54177 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 13:32:50 +00:00
engine-flutter-autoroll
92ac565338
Roll Flutter Engine from 87cbf33b9028 to 510f19a7e629 (1 revision) ( #152473 )
...
87cbf33b90...510f19a7e6skia-flutter-autoroll@skia.org Roll Skia from e8348df56e4e to 34ef6ecb027c (1 revision) (flutter/engine#54175 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 09:36:41 +00:00
engine-flutter-autoroll
4228c05349
Roll Flutter Engine from 2cf3986cae52 to 87cbf33b9028 (2 revisions) ( #152469 )
...
2cf3986cae...87cbf33b90skia-flutter-autoroll@skia.org Roll Skia from 11e9bb9dbd1b to e8348df56e4e (2 revisions) (flutter/engine#54174 )
2024-07-29 skia-flutter-autoroll@skia.org Roll Skia from f59d83951edf to 11e9bb9dbd1b (1 revision) (flutter/engine#54170 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 08:14:58 +00:00
Valentin Vignal
1ceeb54087
Add tests for deletable_chip_attributes.on_deleted.0.dart ( #152361 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/chip/deletable_chip_attributes.on_deleted.0.dart`
2024-07-29 06:52:25 +00:00
engine-flutter-autoroll
9d5ede0f5a
Roll Flutter Engine from 7f7ad741fefa to 2cf3986cae52 (1 revision) ( #152464 )
...
7f7ad741fe...2cf3986caechinmaygarde@google.com [Impeller] Enable on-by-default on Android. (flutter/engine#54156 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-29 05:28:40 +00:00
Andrew Kolos
e2e43987c4
mark Mac tool_integration_tests_* as non-bringup ( #152412 )
...
Follow-up to https://github.com/flutter/flutter/pull/152399
2024-07-29 04:34:20 +00:00
engine-flutter-autoroll
844606008a
Roll Flutter Engine from 947bcb08a50f to 7f7ad741fefa (1 revision) ( #152454 )
...
947bcb08a5...7f7ad741feskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UJOkCKt967UoXQxZS... to YAzbrQ4d60z1yXx9X... (flutter/engine#54169 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UJOkCKt967Uo to YAzbrQ4d60z1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-28 18:39:21 +00:00
engine-flutter-autoroll
5efbde1a18
Roll Flutter Engine from f0effaaf4001 to 947bcb08a50f (1 revision) ( #152449 )
...
f0effaaf40...947bcb08a5skia-flutter-autoroll@skia.org Roll Skia from 78de03720755 to f59d83951edf (2 revisions) (flutter/engine#54168 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-28 07:40:40 +00:00
engine-flutter-autoroll
b6a6b2b51d
Roll Flutter Engine from dfdb2d5f114a to f0effaaf4001 (1 revision) ( #152446 )
...
dfdb2d5f11...f0effaaf40jason-simmons@users.noreply.github.com Fix a race in file I/O done by a BuildRunner test (flutter/engine#54167 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-28 02:37:28 +00:00
engine-flutter-autoroll
fac7d48a64
Roll Flutter Engine from add1b784b80a to dfdb2d5f114a (1 revision) ( #152440 )
...
add1b784b8...dfdb2d5f11matanlurey@users.noreply.github.com Migrates the bulk of flutter/engine to pub workspaces. (flutter/engine#54157 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-27 19:09:24 +00:00
engine-flutter-autoroll
f817e51a3a
Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) ( #152436 )
...
38fddb289f...add1b784b8skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iuUKz0zFWsn54yP69... to UJOkCKt967UoXQxZS... (flutter/engine#54163 )
2024-07-27 aam@google.com Remove obsolete dependency (flutter/engine#54161 )
2024-07-27 skia-flutter-autoroll@skia.org Roll Skia from f478e89036d2 to 78de03720755 (1 revision) (flutter/engine#54160 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iuUKz0zFWsn5 to UJOkCKt967Uo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-27 16:42:22 +00:00
auto-submit[bot]
e8d4c98b07
Reverts "Add button semantics in list tile ( #151599 )" ( #152425 )
...
Reverts: flutter/flutter#151599
Initiated by: chingjun
Reason for reverting: broke an internal test.
Original PR Author: hangyujin
Reviewed By: {chunhtai}
This change reverts the following previous change:
fixes: https://github.com/flutter/flutter/issues/111960
2024-07-27 04:40:17 +00:00
engine-flutter-autoroll
17941362cc
Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) ( #152424 )
...
739ae15e8b...38fddb289fskia-flutter-autoroll@skia.org Roll Skia from 9632ef8f18c1 to f478e89036d2 (1 revision) (flutter/engine#54158 )
2024-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 65bb9e8275bc to ad35a6027648 (1 revision) (flutter/engine#54159 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-27 04:18:09 +00:00
Matan Lurey
40d9fcf767
Document that flutter drive --test-arguments can opt-in to dart test ( #152410 )
...
Closes https://github.com/flutter/flutter/issues/51135 .
Closes https://github.com/flutter/flutter/issues/145499 .
Making this the _default_, or better discoverable, is tracked in
https://github.com/flutter/flutter/issues/152409 .
You'll notice I also removed `-rexpanded`; @jonahwilliams believes that
was accidentally copied over from else-where, and never did anything
(someone I guess could have parsed it in `void main(...)`, but given
https://github.com/flutter/flutter/issues/51135 &
https://github.com/flutter/flutter/issues/145499 that seems unlikely.
2024-07-26 18:25:58 -07:00
