Matan Lurey
0e6c16c27a
Migrate apple-mobile-web-* to mobile-web-*. ( #154964 )
...
Closes https://github.com/flutter/flutter/issues/154596 .
It's less clear to me if your goal was to migrate _all_ of these btw:
https://github.com/search?q=org%3Aflutter+%22mobile-web-app-capable%22&type=code
2024-09-11 00:39:51 +00:00
engine-flutter-autoroll
2fb154f820
Roll Flutter Engine from 8a038a6f7099 to 60c15bc0f40e (15 revisions) ( #154960 )
...
8a038a6f70...60c15bc0f458529443+srujzs@users.noreply.github.com Update package:web to use new path and latest revision (flutter/engine#55085 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 82d2e4033333 to 1760de26fb83 (8 revisions) (flutter/engine#55084 )
2024-09-10 matanlurey@users.noreply.github.com Move more of the tests in the engine to `package:test` (flutter/engine#55083 )
2024-09-10 matanlurey@users.noreply.github.com Redirect `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53717 )
2024-09-10 jonahwilliams@google.com [Impeller] reland experimental canvas. (flutter/engine#55047 )
2024-09-10 magder@google.com Fix 'dart --enable-asserts' typo in license check script (flutter/engine#55082 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from af7460619b2b to 741512e72e92 (1 revision) (flutter/engine#55080 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 4815ec808aa5 to 82d2e4033333 (8 revisions) (flutter/engine#55079 )
2024-09-10 rmacnak@google.com Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. (flutter/engine#55051 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 5dc067350ab5 to 4815ec808aa5 (2 revisions) (flutter/engine#55074 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d59138eb6ec2 to af7460619b2b (1 revision) (flutter/engine#55073 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from c62380453c72 to 5dc067350ab5 (1 revision) (flutter/engine#55072 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kIWQ460iagZLxVRPc... to 8XJTJm4D4Go1dBaTi... (flutter/engine#55071 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 9bea95918e69 to c62380453c72 (1 revision) (flutter/engine#55070 )
2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from a60078a23978 to d59138eb6ec2 (2 revisions) (flutter/engine#55068 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kIWQ460iagZL to 8XJTJm4D4Go1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-11 00:26:07 +00:00
gaaclarke
746d8af006
Adds dart fixes for Color opacity functions ( #154953 )
...
fixes https://github.com/flutter/flutter/issues/154572
2024-09-10 23:12:56 +00:00
John McDole
1c3b501f53
Missing benchmarks for foundation/all_elements_bench.dart ( #154954 )
...
I missed awaiting a future. Probably should have a lint for unawaited futures...
2024-09-10 23:01:09 +00:00
gaaclarke
203f11647f
Update color assertions ( #154752 )
...
issue: https://github.com/flutter/flutter/issues/127855
This is a forward fix to help
https://github.com/flutter/engine/pull/54981 land.
It makes the following changes:
1) Removes hardcoded `Color.toString()` assumptions in asserts
1) Switches some lerp tests to use numbers that are more friendly to
uint8_t and floating point numbers
1) implements custom matchers for color
1) removes word wrapping for some asserts since it makes them fragile to
changes in `Color.toString()` invocations
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-10 15:32:40 -07:00
Andrew Kolos
30835d7dac
handle EAGAIN (macOS) in ErrorHandlingProcessManager ( #154306 )
...
~~Fixes~~ Discovered in https://github.com/flutter/flutter/issues/153776 .
To my knowledge, `Resource temporarily unavailable` when trying to run a process means that some required resource is at capacity. There may be too many processes active, not enough available ports, or some sort of blocking cache is full, etc. Feel free to independently research and see if you come to the same conclusion.
Then, it seems safe to catch and handle this within the tool's `ErrorHandlingProcessManager` abstraction, as Flutter cannot realistically do anything to prevent this issue.
2024-09-10 22:24:56 +00:00
Mairramer
93d06ebd6c
fix unpack freezing app with animation duration zero ( #153890 )
...
Fixes #153889 an issue where nodes were being removed incorrectly when using `AnimationStyle.noAnimation `or the animation duration was zero seconds, which previously caused the application to freeze due to hidden state updates. By skipping the animation and updating active nodes immediately in these cases, we avoid these issues and ensure smooth and accurate management of node states.
2024-09-10 22:24:54 +00:00
Matan Lurey
4b5cf85534
Remove last --disable-dart-dev in flutter/flutter. ( #154948 )
...
Work towards https://github.com/flutter/flutter/issues/154268 .
2024-09-10 21:37:08 +00:00
Gray Mackall
6fd2b9f88b
Remove scheduler: luci from new build_aar_module_test ( #154945 )
...
This option was deprecated (/removed?) in the time since the test was originally disabled.
See https://github.com/flutter/flutter/issues/109712 , https://github.com/flutter/flutter/pull/109714
2024-09-10 20:35:07 +00:00
flutter-pub-roller-bot
ad4162f863
Roll pub packages ( #154939 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 19:54:11 +00:00
Qun Cheng
b872a27c4e
CupertinoSlidingSegmentedControl update (#152976 )
...
This PR is to improve `CupertinoSlidingSegmentedControl` fidelity and add a new property `setEnabled` so that segments can be disabled now.
Fidelity update includes:
* small change on default thumb radius (Based on iOS 17 Figma file)
* separator height (Based on the comparison with SegmentedControl example in Xcode)
* segment min padding (Based on iOS 17 Figma file)
* thumb scale alignment (Based on the comparison with SegmentedControl example in Xcode). If the thumb is on the first or last position in SegmentedControl, the alignment should be `Alignment.leftCenter` and `Alignment.rightCenter` respectively, assuming the text direction is left to right. For segments in middle, they should have center alignment as previously.
* TextStyle update (Based on both the Figma file and the Xcode example)
* Clipped thumb shadow if the shadow is outside of the segmented control (Based on the Xcode example)
* Fixed the overall size shaking issue during segment switching on macOS and iOS
<details><summary>Alignment update demo</summary>
https://github.com/user-attachments/assets/6de3986f-6810-4dc4-8688-f87120557d89
</details>
<details><summary>Comparison before and after</summary>
Before:
After:
</details>
<details><summary>Shaking issue</summary>
Before:
https://github.com/user-attachments/assets/910d1271-75ea-4cec-8666-24090f9d4fb0
After:
https://github.com/user-attachments/assets/bc5ae3e1-600d-49a6-95d9-b1f5d1bd9f6d
</details>
The `disabledChildren` feature can be used to disable segments. The default disabled color comes from the inspection in the Xcode example.
<details><summary>Disabled feature demos</summary>
Disabled segment cannot be highlighted:
https://github.com/user-attachments/assets/70339364-23d5-41c7-b071-c7abe92abd62
`groupValue` can still be highlighted programmatically if it is disabled.
</details>
2024-09-10 19:41:23 +00:00
flutter-pub-roller-bot
55af75d57b
Roll pub packages ( #154933 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 18:21:26 +00:00
Andrew Kolos
d88e692895
fix test chrome.close can recover if getTab throws a StateError ( #154889 )
...
Fixes https://github.com/flutter/flutter/issues/154857 .
Does so by:
* adding `await chromiumLauncher.connect(chrome, false);` before the `close` call to make sure we enter[ the block ](9cd2fc90af/packages/flutter_tools/lib/src/web/chrome.dart (L521-L535)
2024-09-10 17:23:56 +00:00
Justin McCandless
24d0b1db0a
SearchBar context menu ( #154833 )
...
SearchBar and SearchAnchor can now control their context menu. They both received new contextMenuBuilder parameters. See the docs for EditableText.contextMenuBuilder for how to use this, including how to use the native context menu on iOS and to control the browser's context menu on web.
2024-09-10 09:54:00 -07:00
Gray Mackall
f964f15dcb
Fix flutter build aar for modules that use a plugin ( #154757 )
...
https://github.com/flutter/flutter/pull/151675 bumped module templates to AGP 8.1.
In doing so, I tried to work around a behavior change [that was new in AGP 8.0](https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes ):
> AGP 8.0 creates no SoftwareComponent by default. Instead AGP creates SoftwareComponents only for variants that are configured to be published using the publishing DSL.
by using AGP's publishing DSL to define which variants to publish in the module's ephemeral gradle files:
```
android.buildTypes.all {buildType ->
if (!android.productFlavors.isEmpty()) {
android.productFlavors.all{productFlavor ->
android.publishing.singleVariant(productFlavor.name + buildType.name.capitalize()) {
withSourcesJar()
withJavadocJar()
}
}
} else {
android.publishing.singleVariant(buildType.name) {
withSourcesJar()
withJavadocJar()
}
}
}
```
The problem is that this doesn't get applied to the plugin projects used by the module, so if a module uses any plugin it breaks. This PR fixes that by applying similar logic, but to each project (not just the module's project).
Tested manually with https://github.com/gmackall/GrayAddToApp , and also re-enabled an old test that tested this use case as a part of the PR.
Fixes: https://github.com/flutter/flutter/issues/154371
2024-09-10 16:42:22 +00:00
engine-flutter-autoroll
7e2de37336
Roll Packages from b4e0fc1bc117 to bb53e5d536ae (4 revisions) ( #154926 )
...
b4e0fc1bc1...bb53e5d536magder@google.com [ci] Increase deprecation check minimum to macOS 14 (flutter/packages#7544 )
2024-09-09 paulberry@google.com [camerax] Ignore new `unreachable_switch_default` warning. (flutter/packages#7592 )
2024-09-09 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Split `CameraUpdate` into derived classes to use structured data (flutter/packages#7596 )
2024-09-09 stuartmorgan@google.com [google_maps_flutter] Disable setAndGetScrollPosition on iOS (flutter/packages#7609 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 16:34:19 +00:00
Taha Tesser
ebc2c3e437
Clean up SnackBar inherit theme data test ( #154921 )
...
Fixes [Verbose `SnackBar` inherit theme data test](https://github.com/flutter/flutter/issues/154920 )
2024-09-10 16:27:14 +00:00
davidhicks980
bffa21549c
Revert "Improve CupertinoPopupSurface appearance" ( #154893 )
...
Reverts flutter/flutter#151430 to fix
https://github.com/flutter/flutter/issues/154887 until I can investigate
further.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2024-09-10 08:12:46 -07:00
engine-flutter-autoroll
4be3035103
Roll Flutter Engine from 3dc8b71f96cc to 8a038a6f7099 (1 revision) ( #154904 )
...
3dc8b71f96...8a038a6f70yjbanov@google.com [skwasm] use temporary RawPaint objects (attempt #2 ) (flutter/engine#55035 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 14:53:34 +00:00
engine-flutter-autoroll
d6e2b6aedb
Roll Flutter Engine from 656117fc8ba9 to 3dc8b71f96cc (3 revisions) ( #154900 )
...
656117fc8b...3dc8b71f96skia-flutter-autoroll@skia.org Roll Dart SDK from b6c3cd9b93f1 to a60078a23978 (14 revisions) (flutter/engine#55059 )
2024-09-09 jason-simmons@users.noreply.github.com Add missing include to fml/hex_codec.h (flutter/engine#55034 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7e659d5538fa to 9bea95918e69 (3 revisions) (flutter/engine#55052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-10 05:27:20 +00:00
flutter-pub-roller-bot
b3481c3a2b
Roll pub packages ( #154894 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 04:26:19 +00:00
flutter-pub-roller-bot
ee89e9a560
Roll pub packages ( #154890 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-09-10 01:27:22 +00:00
Christopher Fujino
92697d3ecc
Improve tracing and fix packages_autoroller ( #154841 )
...
Reverts flutter/flutter#154555
Re-lands of https://github.com/flutter/flutter/pull/154441 and https://github.com/flutter/flutter/pull/154369
New changes in this PR:
1. extend timeout of the `Linux packages_autoroller` shard (see step 14 in this example [LED build](https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/7/infra ))
2. use the managed framework repo as the working directory in the `framework.streamDart()` helper function--we were generating gradle lockfiles in the wrong directory
A LED build with this code generated the following gradle lockfile update: d939981cd2
2024-09-09 23:31:21 +00:00
engine-flutter-autoroll
81d23d93f6
Roll Flutter Engine from c18ecf9e4000 to 656117fc8ba9 (2 revisions) ( #154883 )
...
c18ecf9e40...656117fc8bmagder@google.com Unskip Impeller iOS scenario tests (flutter/engine#55012 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7ad1252da14f to 7e659d5538fa (2 revisions) (flutter/engine#55050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 23:26:58 +00:00
engine-flutter-autoroll
c7f5b79c57
Roll Flutter Engine from 7ad9e5ba962c to c18ecf9e4000 (1 revision) ( #154855 )
...
7ad9e5ba96...c18ecf9e40skia-flutter-autoroll@skia.org Roll Skia from 8103f53635fd to 7ad1252da14f (3 revisions) (flutter/engine#55046 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 22:00:11 +00:00
Nate Wilson
bfa04edca6
un-break ThemeData equality ( #154695 )
...
This PR is _almost_ able to close issue #89127 .
Sadly, no `InheritedModel` or custom `RenderObject`s today; instead the [WidgetState operators](https://main-api.flutter.dev/flutter/widgets/WidgetStateOperators.html ) have been restructured to support equality checks.
`WidgetStateProperty.fromMap()` is now capable of accurate equality checks, and all of the `.styleFrom()` methods have been refactored to use that constructor.
(Equality checks are still broken for `WidgetStateProperty.resolveWith()`, and any other non-`const` objects that implement the interface.)
<br><br>
credit for this idea goes to @justinmc: https://github.com/flutter/flutter/issues/89127#issuecomment-2313187703
2024-09-09 21:49:09 +00:00
Michal Hazdra
18c325af17
Add scrim color parameter to _ZoomEnterTransitionPainter ( #152815 )
...
Implements #152064
There is currently no test here as I am not sure how to do it efficiently, I tried making the painter public and adding the visibleForTestinhg attribute, but then I need to add comments to everything... And even when I did that I did not know how to test the painter itself maybe via Golden tests? I have not done those in the Flutter repo yet. And if it can be done without them then that is definitely a better way. I'll wait for what the review says I should do.
2024-09-09 21:49:07 +00:00
engine-flutter-autoroll
8dace15468
Roll Flutter Engine from 813ad2db9796 to 7ad9e5ba962c (1 revision) ( #154849 )
...
813ad2db97...7ad9e5ba96jonahwilliams@google.com [Impeller] fix obvious memory leak. (flutter/engine#55036 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 20:58:20 +00:00
Andrew Kolos
9cd2fc90af
Handle ProcessExceptions due to git missing on the host ( #154445 )
...
Fixes https://github.com/flutter/flutter/issues/133585 .
This PR elects to add a new catch within `_handleToolError` that checks any uncaught error. This new catch will exit the tool without crashing provided the following conditions are met:
1. the error is a `ProcessException`,
2. the error message contains `git` somewhere in the message (we don't match on the entire string in case it changes or is locale-dependent), and
3. `git` does not appear to be runnable on the host system (`ProcessManager.canRun` returns `false` for git).
This is preferable to checking for runnability of `git` before we run it for 1) its simplicity and 2) lack of performance penalty for users that already have git installed (almost every single one).
This PR also does some light refactoring to runner_test.dart to make room for tests that aren't related to crash reporting.
2024-09-09 20:47:05 +00:00
Polina Cherkasova
8435e12ce5
Fix leaky tests. ( #154847 )
2024-09-09 20:35:03 +00:00
engine-flutter-autoroll
42a4271f0c
Roll Flutter Engine from 1b2656a5b8aa to 813ad2db9796 (2 revisions) ( #154844 )
...
1b2656a5b8...813ad2db97jonahwilliams@google.com [Impeller] add herustic for ignoring coverage limit w/ image filters. (flutter/engine#55030 )
2024-09-09 skia-flutter-autoroll@skia.org Roll Skia from f7e4ddabb754 to 8103f53635fd (1 revision) (flutter/engine#55043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 19:49:06 +00:00
engine-flutter-autoroll
f49f2f5ca9
Roll Flutter Engine from 9822a711049c to 1b2656a5b8aa (1 revision) ( #154835 )
...
9822a71104...1b2656a5b8jacksongardner@google.com Revert "Add `crossOrigin` property to <img> tag used for decoding (#54961 )" (flutter/engine#55042 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 18:52:11 +00:00
engine-flutter-autoroll
cefca356e0
Roll Flutter Engine from 7e6d5c897a5a to 9822a711049c (1 revision) ( #154832 )
...
7e6d5c897a...9822a71104skia-flutter-autoroll@skia.org Roll Skia from 06cd203d0607 to f7e4ddabb754 (2 revisions) (flutter/engine#55041 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 17:52:13 +00:00
Lu Shueh Chou
4aecec70a9
Expose foreground property of TextStyle in Icon widget ( #150315 )
...
Expose foreground property to icon. See issues:
- #139411
2024-09-09 17:30:19 +00:00
engine-flutter-autoroll
d8ae99a790
Roll Packages from 56df73e3c54c to b4e0fc1bc117 (1 revision) ( #154824 )
...
56df73e3c5...b4e0fc1bc1engine-flutter-autoroll@skia.org Roll Flutter from 45ef8f36ff41 to 2e221e7308ba (20 revisions) (flutter/packages#7599 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 15:45:38 +00:00
engine-flutter-autoroll
fb24721a22
Roll Flutter Engine from 117a7d0859ed to 7e6d5c897a5a (1 revision) ( #154820 )
...
117a7d0859...7e6d5c897askia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Dxly0DC9pQXTXVNm0... to kIWQ460iagZLxVRPc... (flutter/engine#55039 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Dxly0DC9pQXT to kIWQ460iagZL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-09 13:44:25 +00:00
engine-flutter-autoroll
f566016ed3
Roll Flutter Engine from 331fd5af8217 to 117a7d0859ed (1 revision) ( #154794 )
...
331fd5af82...117a7d0859jonahwilliams@google.com [engine] dispatch platform channel messages through event loop, except navigation on start. (flutter/engine#55027 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 19:06:24 +00:00
engine-flutter-autoroll
7a685ad072
Roll Flutter Engine from 51d4402f17b4 to 331fd5af8217 (2 revisions) ( #154791 )
...
51d4402f17...331fd5af82skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BF-8UyvqW5l52-hP2... to Dxly0DC9pQXTXVNm0... (flutter/engine#55033 )
2024-09-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0f783bdb7a4d to b6c3cd9b93f1 (1 revision) (flutter/engine#55031 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BF-8UyvqW5l5 to Dxly0DC9pQXT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-08 10:42:38 +00:00
hgraceb
0139761878
Fix TabBar crash with SliverAppBar ( #154485 )
...
Fixes #154484
Similar to #104998 . Cause with updated at different phases of the same frame.
2024-09-08 03:57:20 +00:00
engine-flutter-autoroll
cede6ba628
Roll Flutter Engine from 7bf1169715d6 to 51d4402f17b4 (2 revisions) ( #154782 )
...
7bf1169715...51d4402f17jonahwilliams@google.com [Impeller] Disable exp canvas. (flutter/engine#55026 )
2024-09-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PBeI0gGvgFdXV6hCg... to BF-8UyvqW5l52-hP2... (flutter/engine#55024 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PBeI0gGvgFdX to BF-8UyvqW5l5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 19:25:35 +00:00
engine-flutter-autoroll
04d64d9c2f
Roll Flutter Engine from 419fb8c0ab3e to 7bf1169715d6 (14 revisions) ( #154769 )
...
419fb8c0ab...7bf1169715#55006 )" (flutter/engine#55022 )
2024-09-07 magder@google.com Turn off software rendering in iOS scenario golden tests (flutter/engine#55016 )
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 04:39:25 +00:00
auto-submit[bot]
07230960c1
Reverts "Roll Flutter Engine from 419fb8c0ab3e to b9f9015ff986 (12 revisions) ( #154764 )" ( #154765 )
...
Reverts: flutter/flutter#154764
Initiated by: jonahwilliams
Reason for reverting: failing post submit on mac module test.
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
419fb8c0ab...b9f9015ff9#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 03:04:25 +00:00
engine-flutter-autoroll
8e360edc38
Roll Flutter Engine from 419fb8c0ab3e to b9f9015ff986 (12 revisions) ( #154764 )
...
419fb8c0ab...b9f9015ff9#54917 )" (flutter/engine#55018 )
2024-09-06 jonahwilliams@google.com [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014 )
2024-09-06 paulberry@google.com [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996 )
2024-09-06 yjbanov@google.com [skwasm] use temporary RawPaint objects (flutter/engine#54917 )
2024-09-06 flar@google.com [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013 )
2024-09-06 jonahwilliams@google.com [Impeller] opt into exp canvas. (flutter/engine#54913 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008 )
2024-09-06 jonahwilliams@google.com [impeller] fake image for fake tests. (flutter/engine#54974 )
2024-09-06 skia-flutter-autoroll@skia.org Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001 )
2024-09-06 59215665+davidhicks980@users.noreply.github.com Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-07 02:08:16 +00:00
Siva
d7a658d705
Roll Flutter Engine from c50eb8a65097 to 419fb8c0ab3e ( #154734 )
...
c50eb8a650...419fb8c0abhttps://github.com/flutter/flutter/issues/54975 )"
(https://github.com/flutter/engine/pull/55000 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions)
(https://github.com/flutter/engine/pull/54999 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to
5dqcFlKzRjJb6V95W... (https://github.com/flutter/engine/pull/54998 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions)
(https://github.com/flutter/engine/pull/54997 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision)
(https://github.com/flutter/engine/pull/54995 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions)
(https://github.com/flutter/engine/pull/54992 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg...
(https://github.com/flutter/engine/pull/54990 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Skia from 809f868ded1c to aec11ae18bb6 (22 revisions)
(https://github.com/flutter/engine/pull/54988 )
2024-09-06
[30870216+gaaclarke@users.noreply.github.com ](mailto:30870216+gaaclarke@users.noreply.github.com)
Removes the int storage from Color
(https://github.com/flutter/engine/pull/54714 )
2024-09-06 [chris@bracken.jp ](mailto:chris@bracken.jp) iOS,macOS: Add
logging of duplicate codesign binaries
(https://github.com/flutter/engine/pull/54987 )
2024-09-06
[skia-flutter-autoroll@skia.org ](mailto:skia-flutter-autoroll@skia.org)
Roll Fuchsia Test Scripts from k4lKsecg0pdIp-U7c... to
D9INMR2u4wcyiZ750... (https://github.com/flutter/engine/pull/54984 )
2024-09-05
[a-siva@users.noreply.github.com ](mailto:a-siva@users.noreply.github.com)
Manual roll of Dart. (https://github.com/flutter/engine/pull/54983 )
2024-09-05 [chris@bracken.jp ](mailto:chris@bracken.jp) iOS,macOS: add
unsigned_binaries.txt (https://github.com/flutter/engine/pull/54977 )
2024-09-05
[jason-simmons@users.noreply.github.com ](mailto:jason-simmons@users.noreply.github.com)
Manual Skia roll to 809f868ded1c
(https://github.com/flutter/engine/pull/54972 )
2024-09-05
[1961493+harryterkelsen@users.noreply.github.com ](mailto:1961493+harryterkelsen@users.noreply.github.com)
[canvaskit] Fix incorrect calculation of ImageFilter paint bounds
(https://github.com/flutter/engine/pull/54980 )
2024-09-05 [jonahwilliams@google.com ](mailto:jonahwilliams@google.com)
[engine] always force platform channel responses to schedule a task.
(https://github.com/flutter/engine/pull/54975 )
2024-09-05
[tugorez@users.noreply.github.com ](mailto:tugorez@users.noreply.github.com)
Fix unexpected ViewFocus events when Text Editing utilities change focus
in the middle of a blur call.
(https://github.com/flutter/engine/pull/54965 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xNv47d1TZmK9 to PBeI0gGvgFdX
---------
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-09-06 15:42:07 -07:00
Taha Tesser
755cf0bd3f
Fix Material 3 AppBar.leading action IconButtons ( #154512 )
...
Fixes [`AppBar` back button focus/hover circle should not fill up whole height](https://github.com/flutter/flutter/issues/141361 )
Fixes [[Material 3] Date Range Picker close button has incorrect shape](https://github.com/flutter/flutter/issues/154393 )
This updates the leading condition added in https://github.com/flutter/flutter/pull/110722
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: SingleChildScrollView(
child: Column(
children: [
Column(
spacing: 10.0,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
AppBar(
leading: BackButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with BackButton'),
),
AppBar(
leading: CloseButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with CloseButton'),
),
AppBar(
leading: DrawerButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
title: const Text('AppBar with DrawerButton'),
),
],
),
const Divider(),
Column(
spacing: 10.0,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
AppBar(
leading: BackButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
AppBar(
leading: CloseButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
AppBar(
leading: DrawerButton(
style: IconButton.styleFrom(backgroundColor: Colors.red),
),
backgroundColor: Theme.of(context).colorScheme.secondaryContainer,
toolbarHeight: 100.0,
title: const Text('AppBar with custom height'),
),
],
),
],
),
),
),
);
}
}
```
</details>
### Before
<img width="912" alt="Screenshot 2024-09-04 at 12 38 05" src="https://github.com/user-attachments/assets/25a6893c-89c9-4b45-a5bb-8da0eee71cd2 ">
### After
<img width="912" alt="Screenshot 2024-09-04 at 12 38 28" src="https://github.com/user-attachments/assets/49727183-568c-412e-9fa1-1eefd0cd87a7 ">
2024-09-06 21:10:35 +00:00
Rajesh Malviya
6ad6641f0f
Remove allowoptimization modifier from FlutterPlugin proguard rules ( #154715 )
...
Fixes : #154580
Previous PR: #154677
More info: https://github.com/flutter/flutter/issues/154580#issuecomment-2333799620
The errors described in the original issue [are still occurring](https://github.com/flutter/flutter/issues/154580#issuecomment-2333799620 ) after #154677 . Before this change, the repro [broken_demo](https://github.com/rajveermalviya/broken_demo ) mentioned in the original issue logs:
```shell-session
$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'... 14.5s
â Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk... 739ms
Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
W/FlutterEngineCxnRegstry(13284): Attempted to register plugin (a0.a@53b33b6) but it was already registered with this FlutterEngine (d0.c@8baa8b7).
E/flutter (13284): [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null)
E/flutter (13284): #0 PathProviderApi.getApplicationSupportPath (package:path_provider_android/messages.g.dart:65)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #1 getApplicationSupportDirectory (package:path_provider/path_provider.dart:78)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #2 _BorkenDemoHomePageState.build.<anonymous closure> (package:broken_demo/main.dart:44)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284):
```
After this change:
```shell-session
$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'... 15.2s
â Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk... 857ms
Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
I/flutter (13040): path_provider: Directory: '/data/user/0/com.example.broken_demo/files'
```
2024-09-06 20:37:23 +00:00
Chris Bobbe
84757af9f8
Adjust ButtonStyle.{foreground,icon}Color dartdocs for new behavior ( #154646 )
...
Fixes #154644 .
This aligns these dartdocs with the new behavior introduced in PR #143501 / 51ed348f3, where passing `iconColor: null` would cause the icon to be colored with a hard-coded default instead of with `foregroundColor`.
2024-09-06 19:22:33 +00:00
auto-submit[bot]
8c6513ddd1
Reverts "Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. ( #154048 )" ( #154743 )
...
Reverts: flutter/flutter#154048
Initiated by: nate-thegrate
Reason for reverting: using `AnimationStyle` instead would allow for complete animation duration and curve customization.
Original PR Author: nploi
Reviewed By: {piedcipher, nate-thegrate}
This change reverts the following previous change:
Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
2024-09-06 19:13:17 +00:00
Bruno Leroux
2e221e7308
Fix DropdownMenu focused item styles ( #153159 )
...
## Description
This PR fixes the style resolution for selected dropdown menu items (make it possible to provide a custom style and avoid hardcoded values when possible).
For the moment, I kept the default selected background which was previously set (`onSurface.withOpacity(0.12)`) to keep this PR focused on its goal which is to make it possible to overrides the defaults item style by providing a custom button style at the theme level or at the menu entry level.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/123736 .
## Tests
Adds 4 tests.
2024-09-06 18:50:06 +00:00
Nguyen Phuc Loi
0eaeb0d1c5
Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. ( #154048 )
...
Currently we don't support custom transition duration for `DialogRoute`, `CupertinoDialogRoute` and show dialog methods , This PR will to support that.
2024-09-06 18:42:36 +00:00
