Byeongjin Kang
6fdcb0a511
feat: Add alignmentOffset to DropdownMenu ( #151731 )
...
Changes:
- Introduced `alignmentOffset` property to `DropdownMenu` to allow adjustment of menu alignment.
- Updated the `MenuAnchor` widget to utilize the new `alignmentOffset` property.
- Default value for `alignmentOffset` is `Offset.zero`, meaning no additional spacing by default.
Motivation:
- This PR closes #151524
- @nate-thegrate, please let me know if I need to make changes in order for this PR to be merged
The motivation behind this change is to provide developers with more control over the spacing between the `MenuAnchor` and `dropdownMenuEntries` in the `DropdownMenu` widget. This enhancement allows for better alignment and customization of the dropdown menu appearance.
| before | after |
| :---: | :---: |
| <img width="372" alt="Screenshot 2024-07-14 at 8 03 14â¯PM" src="https://github.com/user-attachments/assets/4a45b843-7fa4-44fd-843c-c7209c6f57ae "> | <img width="364" alt="Screenshot 2024-07-14 at 8 03 27â¯PM" src="https://github.com/user-attachments/assets/12e8b857-aefb-4aaf-a310-4a002abcbc2f "> |
Initially, it was suggested to use a `SizedBox` to introduce spacing. However, upon further examination of the source code, it was discovered that the `DropdownMenuEntries` are rendered on the screen via an `OverlayPortal`. This necessitated leveraging the existing `alignmentOffset` property within the `MenuAnchor` for a more seamless and effective alignment adjustment.
2024-07-24 21:17:06 +00:00
engine-flutter-autoroll
f060312115
Roll Flutter Engine from 490576daf810 to c2f489d783d6 (6 revisions) ( #152260 )
...
490576daf8...c2f489d783robert.ancell@canonical.com Fix embedder comments about struct_size (flutter/engine#54077 )
2024-07-24 jonahwilliams@google.com share platform view slicing logic across iOS and Android. (flutter/engine#54010 )
2024-07-24 jacksongardner@google.com [skwasm] Fix platform view occlusion logic. (flutter/engine#54061 )
2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 25f26f673502 to c11932925658 (4 revisions) (flutter/engine#54081 )
2024-07-24 43054281+camsim99@users.noreply.github.com Upgrade Engine Android SDK to 35 (flutter/engine#53574 )
2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from a9b1043eb23e to 25f26f673502 (1 revision) (flutter/engine#54079 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 21:00:28 +00:00
Matan Lurey
09461925a3
Scaffolding for NativeDriver and AndroidNativeDriver for taking screenshots using adb. ( #152194 )
...
Closes https://github.com/flutter/flutter/issues/152189 .
I have next to no clue how to configure this to run on CI, so bear with me as I rediscover the wheel.
2024-07-24 20:12:19 +00:00
LongCatIsLooong
00257e8c62
widgets docImport (#152146 )
...
https://github.com/flutter/flutter/issues/150800
> 2172 out-of-scope references in 138 files, 27 unique symbols were left unresolved.
Only did the most straightforward ones. There will be a part 2.
2024-07-24 19:51:53 +00:00
engine-flutter-autoroll
db97b1aac0
Roll Flutter Engine from 3078f6a90e71 to 490576daf810 (1 revision) ( #152239 )
...
3078f6a90e...490576daf8robert.ancell@canonical.com Don't rely on the renderer accessing the engine through the view. (flutter/engine#54049 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 18:09:51 +00:00
auto-submit[bot]
f64190aacb
Reverts "Use more CORS headers for flutter run server ( #152048 )" ( #152248 )
...
Reverts: flutter/flutter#152048
Initiated by: cbracken
Reason for reverting: breaks tool tests.
Example:
```
00:06 +762 ~2 -1: test/general.shard/web/web_asset_server_test.dart: release asset server serves correct mime type and content length for png [E]
Expected: {'Content-Type': 'image/png', 'content-length': '64'}
Actual: {
'Content-Type': 'image/png',
'Cross-Origin-Resource-Policy': 'cross-origin',
'Access-Contr
Original PR Author: johnpryan
Reviewed By: {eyebrowsoffire}
This change reverts the following previous change:
@eyebrowsoffire
2024-07-24 17:44:26 +00:00
John Ryan
11d81f2709
Use more CORS headers for flutter run server ( #152048 )
...
@eyebrowsoffire
2024-07-24 09:54:22 -07:00
auto-submit[bot]
f55ab0e77e
Reverts "Enable Swift Package Manager by default on master channel ( #152049 )" ( #152243 )
...
Reverts: flutter/flutter#152049
Initiated by: cbracken
Reason for reverting: iOS builds failing in post-submit
Original PR Author: loic-sharma
Reviewed By: {jmagman}
This change reverts the following previous change:
Changes:
1. Enables Swift Package Manager by default on the main/master channel
2. Fixes tests that fail if Swift Package Manager is enabled
Corresponding docs change: https://github.com/flutter/website/pull/10938
Addresses https://github.com/flutter/flutter/issues/151567
2024-07-24 16:49:25 +00:00
Loïc Sharma
08d8a7fa81
Enable Swift Package Manager by default on master channel ( #152049 )
...
Changes:
1. Enables Swift Package Manager by default on the main/master channel
2. Fixes tests that fail if Swift Package Manager is enabled
Corresponding docs change: https://github.com/flutter/website/pull/10938
Addresses https://github.com/flutter/flutter/issues/151567
2024-07-24 16:24:31 +00:00
engine-flutter-autoroll
0d504914c7
Roll Packages from e978e06eb920 to 1c319ac0fad1 (4 revisions) ( #152238 )
...
e978e06eb9...1c319ac0falouisehsu@google.com [in_app_purchase_storekit] convert paymentQueueTests to swift (flutter/packages#7204 )
2024-07-23 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 761747bfc538 to b0850beeb25f (6 revisions) (flutter/packages#7175 )
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7188 )
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7190 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 15:54:19 +00:00
engine-flutter-autoroll
90823f5b8c
Roll Flutter Engine from 817a4a2d41f8 to 3078f6a90e71 (2 revisions) ( #152234 )
...
817a4a2d41...3078f6a90eskia-flutter-autoroll@skia.org Roll Skia from 0315e534d936 to a9b1043eb23e (1 revision) (flutter/engine#54076 )
2024-07-24 skia-flutter-autoroll@skia.org Roll Dart SDK from f4f95688d5ca to 0b3c00feefb1 (1 revision) (flutter/engine#54075 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 14:28:22 +00:00
Flutter GitHub Bot
5e3ca708b7
Marks Mac_x64 plugin_lint_mac to be unflaky ( #152216 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 plugin_lint_mac"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20plugin_lint_mac%22 ).
This test can be marked as unflaky.
2024-07-24 14:14:15 +00:00
engine-flutter-autoroll
0b5dd7b0fb
Roll Flutter Engine from d3800a90d4fa to 817a4a2d41f8 (1 revision) ( #152225 )
...
d3800a90d4...817a4a2d41skia-flutter-autoroll@skia.org Roll Skia from 7ad882fb5320 to 0315e534d936 (1 revision) (flutter/engine#54073 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 10:54:26 +00:00
engine-flutter-autoroll
f6ebb1feb4
Roll Flutter Engine from 0b13fa350466 to d3800a90d4fa (3 revisions) ( #152214 )
...
0b13fa3504...d3800a90d4robert.ancell@canonical.com Rename FlBackingStoreProvider to FlFramebuffer (flutter/engine#54047 )
2024-07-24 robert.ancell@canonical.com Remove unnecessary double cast (flutter/engine#54044 )
2024-07-24 robert.ancell@canonical.com Fix variable name (flutter/engine#54045 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 09:50:25 +00:00
engine-flutter-autoroll
e721620b25
Roll Flutter Engine from a30f708c5804 to 0b13fa350466 (1 revision) ( #152210 )
...
a30f708c58...0b13fa3504skia-flutter-autoroll@skia.org Roll Skia from 3f1b4e98f65a to 7ad882fb5320 (4 revisions) (flutter/engine#54071 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 08:49:12 +00:00
engine-flutter-autoroll
f905761e9f
Roll Flutter Engine from 1572635432c0 to a30f708c5804 (1 revision) ( #152206 )
...
1572635432...a30f708c58skia-flutter-autoroll@skia.org Roll Dart SDK from e53beb039093 to f4f95688d5ca (1 revision) (flutter/engine#54068 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 07:20:26 +00:00
engine-flutter-autoroll
d4124bd5b5
Roll Flutter Engine from f5ec4ab0bf94 to 1572635432c0 (17 revisions) ( #152203 )
...
f5ec4ab0bf...157263543258529443+srujzs@users.noreply.github.com Change JSArray.length to return int (flutter/engine#54051 )
2024-07-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 17131486a2f7 to e53beb039093 (1 revision) (flutter/engine#54066 )
2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZcBsXDojTYbriHD7_... to qA7S-DZ5FyMtcM7_J... (flutter/engine#54064 )
2024-07-24 flar@google.com [DisplayList] Fix assertions on DisplayList verbose comparison tests (flutter/engine#54065 )
2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 5bzzKaW7fCp_No_w_... to clqtZA8cx4GEXwcOe... (flutter/engine#54063 )
2024-07-23 chris@bracken.jp [iOS] Flush layer pool after platform view dispose (flutter/engine#54056 )
2024-07-23 chris@bracken.jp [iOS] Mark EmbeddedViewCount const (flutter/engine#54062 )
2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from f4355cf73508 to 3f1b4e98f65a (1 revision) (flutter/engine#54060 )
2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 2d518b6a793a to f4355cf73508 (9 revisions) (flutter/engine#54058 )
2024-07-23 skia-flutter-autoroll@skia.org Roll Dart SDK from eeb2e4e409bf to 17131486a2f7 (1 revision) (flutter/engine#54055 )
2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from a9019fddac28 to 2d518b6a793a (4 revisions) (flutter/engine#54052 )
2024-07-23 jonahwilliams@google.com [Impeller] add emulated advanced blend support for exp canvas. (flutter/engine#54020 )
2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 1cda2a7b0ee4 to a9019fddac28 (3 revisions) (flutter/engine#54050 )
2024-07-23 flar@google.com [DisplayList] track unbounded state on save layers and DisplayLists (flutter/engine#54032 )
2024-07-23 robert.ancell@canonical.com Temporarily disable use of glBlitFramebuffer on NVIDIA (flutter/engine#54040 )
2024-07-23 robert.ancell@canonical.com Set the view ID for FlView (flutter/engine#54043 )
2024-07-23 chinmaygarde@google.com [Impeller] Implement OpenGL to Vulkan texture trampolining. (flutter/engine#53966 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZcBsXDojTYbr to qA7S-DZ5FyMt
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 04:10:30 +00:00
engine-flutter-autoroll
3d79c2ea59
Roll Flutter Engine from 13eac5d93def to f5ec4ab0bf94 (2 revisions) ( #152180 )
...
13eac5d93d...f5ec4ab0bfskia-flutter-autoroll@skia.org Roll Skia from f9a9c31b433b to 1cda2a7b0ee4 (72 revisions) (flutter/engine#54048 )
2024-07-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 50d9bb72a128 to eeb2e4e409bf (1 revision) (flutter/engine#54046 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-24 02:54:24 +00:00
Matan Lurey
3c4ee102aa
Allow-list sh as a code-snippet type. ( #152196 )
...
Otherwise I get the following failure on CI:
```txt
packages/flutter_driver/lib/src/native/android.dart:123: Found "```" in code but it did not match RegExp: pattern=^ */// *```dart$ flags= so something is wrong. Line was: " /// ```sh"
Found 1 snippet code errors.
See the documentation at the top of dev/bots/analyze_snippet_code.dart for details.
```
It seems reasonable to put a reference to a shell command in a Dartdoc
comment.
2024-07-23 17:33:38 -07:00
chunhtai
7912e6d27e
Updates mark needs semantics update logic for overlay portal ( #151688 )
...
OverlayPortal attaches its overlaychild's renderobject to overlay directly while keeps its semantics tree under overlayportal.
This become a problem when the `overlaychild` markNeedsSemanticsUpdate that it propagate upward the rendering tree.
This means instead of marking dirty upward to the OverlayPortal, it directly mark Overlay dirty instead and skip `OverlayPortal`.
Currently this does not pose an issue other than unnecessary rebuilds, but it become a problem when I try to optimize the semantics tree compilation https://github.com/flutter/flutter/pull/150394 .
After the optimization it won't rebuild semantics node unless it is marked dirty. Since the OverlayPortal widget does not get marked dirty, it won't update the subtree.
2024-07-24 00:30:19 +00:00
Amir Panahandeh
770c13bcff
Fix typo in clipboard.dart ( #151844 )
...
Fixes a typo in `clipboard.dart`
2024-07-23 22:52:32 +00:00
Eric Seidel
dc0ab7f3eb
Add more docs to DragTraget.builder ( #151447 )
...
Clarifications and changing a reference to a deprecated member.
2024-07-23 15:29:48 -07:00
Lasse R.H. Nielsen
6574484fc2
Fix the type of RenderTable.get rowDecorations. ( #151886 )
...
This changes the return type from `List<Decoration>` to `List<Decoration?>`, matching the corresponding setter.
As such it is a breaking change.
I believe the current type is a *bug*, and this is the correct fix.
The underlying value has a nullable element type, and the setter accepts a list which can contain `null`, but the getter tries to create a list with non-nullable elements from the stored value.
Calling this getter while the list contains `null` will throw.
(If this fix is too simplistic, I'll file a bug for the issue instead.)
2024-07-23 22:14:13 +00:00
Matan Lurey
d436acf808
Notify me of changes to flutter_driver. ( #152188 )
...
Part of https://github.com/flutter/flutter/issues/148028 .
2024-07-23 20:41:22 +00:00
Yegor
b4d7721af0
Update Flutter-Web-Triage.md ( #152191 )
...
Separate P0 triage from P1 triage.
2024-07-23 13:37:59 -07:00
Andrew Kolos
91813060c0
[tool] Guard more write/writeln calls on Process.stdin ( #151146 )
...
Contributes to fixing https://github.com/flutter/flutter/issues/137184 .
This PR guards write calls in non-test files. This PR excludes
* packages/flutter_tools/lib/src/dart/analysis.dart due to a test timeout I would like to figure out in a separate PR and
* packages/flutter_tools/lib/src/compile.dart due to https://github.com/flutter/flutter/issues/151255
2024-07-23 19:27:52 +00:00
LongCatIsLooong
ed587e6da0
More material docImports ( #152144 )
...
https://github.com/flutter/flutter/issues/150800 .
After applying the patch:
```
Can not fully resolve ../../flutter/packages/flutter/lib/src/material/material_state.dart: (MaterialState.pressed, MaterialState.focused, MaterialState.hovered, ..., value, update)
Can not fully resolve ../../flutter/packages/flutter/lib/src/material/material_state_mixin.dart: (MaterialStateProperty.resolve, MaterialState.disabled, MaterialState.dragged, ..., MaterialState.scrolledUnder, MaterialState.selected)
Can not fully resolve ../../flutter/packages/flutter/lib/src/material/reorderable_list.dart: (TargetPlatformVariant.desktop, TargetPlatformVariant.mobile)
Can not fully resolve ../../flutter/packages/flutter/lib/src/material/app.dart: (GlobalMaterialLocalizations)
Can not fully resolve ../../flutter/packages/flutter/lib/src/material/material_localizations.dart: (GlobalMaterialLocalizations)
57 out-of-scope references in 5 files, 22 unique symbols were left unresolved.
```
I'm going to leave `material_state` stuff alone because of https://github.com/flutter/flutter/issues/150800#issuecomment-2243923869 ,
`TargetPlatformVariant.desktop` requires `flutter_test` and `GlobalMaterialLocalizations` requires `package:flutter_localizations/flutter_localizations.dart`.
2024-07-23 19:23:07 +00:00
engine-flutter-autoroll
660694cb17
Roll Flutter Engine from c8b9571954f5 to 13eac5d93def (1 revision) ( #152172 )
...
c8b9571954...13eac5d93dskia-flutter-autoroll@skia.org Manual roll Skia from 939e1dac9815 to f9a9c31b433b (3 revisions) (flutter/engine#54037 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-23 17:13:16 +00:00
davidhicks980
f9dc7526fd
[widgets/shortcuts] Add includeSemantics property to the Shortcuts widget. ( #152077 )
...
Adds an `includeSemantics` property to the Shortcuts widget.
@gspencergoog and I discussed this change to make introducing Shortcuts easier on the MenuAnchor widget. This change should also make testing semantics trees slightly less onerous (assuming this doesn't harm accessibility, that is).
On the point of accessibility, I'm not sure what useful semantic information is exposed by the Shortcuts widget's semantic node, since it's basically just an unfocusable keyboard listener. However, I kept the `includeSemantics` defaulting to true so as to not break semantics tests in the Flutter repo.
Fixes https://github.com/flutter/flutter/issues/152076
2024-07-23 15:46:08 +00:00
engine-flutter-autoroll
64d340a503
Roll Flutter Engine from f36ef722876e to c8b9571954f5 (2 revisions) ( #152161 )
...
f36ef72287...c8b9571954skia-flutter-autoroll@skia.org Roll Dart SDK from 7beae001e066 to 50d9bb72a128 (1 revision) (flutter/engine#54042 )
2024-07-23 robert.ancell@canonical.com Add fl_engine_add/remove_view (flutter/engine#54018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-23 14:55:26 +00:00
engine-flutter-autoroll
5b678282bf
Roll Flutter Engine from 0d32c2d1955b to f36ef722876e (1 revision) ( #152158 )
...
0d32c2d195...f36ef72287robert.ancell@canonical.com Make FlWindowStateMonitor (flutter/engine#54011 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-23 13:05:34 +00:00
Brandon DeRosier
ed470fd101
[native_assets] Fix macOS host build failure when there are no frameworks to sign. ( #150742 )
...
When the `"${native_assets_path}"*.framework` glob doesn't resolve anything, the bash will run the loop once with the original unglobbed value: `/path/to/native/assets/*.framework`. Skip this case to prevent the build from failing when there are no frameworks to sign.
To reproduce this build failure:
1. Enable native assets in the Flutter tool: `flutter config --enable-native-assets`
2. Create a Flutter project with the default template: `flutter create test_native_assets`
3. Add a build hook that does nothing (`hook/build.dart`).
4. Try to build/run the app: `flutter run --debug -d macos`
2024-07-23 07:37:30 +00:00
Valentin Vignal
43da705701
Add test for focus_traversal_group.0.dart ( #151591 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/focus_traversal/focus_traversal_group.0.dart`
2024-07-23 07:01:09 +00:00
engine-flutter-autoroll
3a4d51f118
Roll Flutter Engine from 88726232be13 to 0d32c2d1955b (1 revision) ( #152151 )
...
88726232be...0d32c2d195skia-flutter-autoroll@skia.org Roll Dart SDK from b937619129a4 to 7beae001e066 (1 revision) (flutter/engine#54036 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-23 06:59:26 +00:00
engine-flutter-autoroll
92a1b9b051
Roll Flutter Engine from 84a46c370c30 to 88726232be13 (1 revision) ( #152149 )
...
84a46c370c...88726232beskia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from XtkBHdNTtIpWdxN_l... to 5bzzKaW7fCp_No_w_... (flutter/engine#54034 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-23 05:23:07 +00:00
Kevin Chisholm
28033eabc2
[Release] Update release note location ( #151931 )
...
**TLDR:** Move the changelog, currently called ["hotfixes to the stable
channel"](https://github.com/flutter/flutter/blob/master/docs/releases/Hotfixes-to-the-Stable-Channel.md ),
to the root directory of Flutter/Flutter and rename it to CHANGELOG.md
before the Q3 release cutoff.
This PR accomplishes the following:
1. Renames 'Hotfixes-to-the-stable-channel' to CHANGELOG.md
2. Moves CHANGELOG.md to Flutter/Flutter root.
3. Update references to 'Hotfixes-to-the-stable-channel' to
CHANGELOG.md.
---
#### Background
Flutter has historically kept documentation on wiki pages in the Flutter
repository. Recently, we executed a large-scale migration of our wiki
into a `docs` folder within flutter/flutter.
#### Proposal
I propose relocating the current changelog, which is called ["hotfixes
to the stable
channel"](https://github.com/flutter/flutter/blob/master/docs/releases/Hotfixes-to-the-Stable-Channel.md ),
to the root directory of the Flutter/Flutter repository and renaming it
to CHANGELOG.md. This change aims to improve the visibility,
accessibility, and consistency of our documentation processes.
#### Benefits
1. **Unify Dart and Flutter Processes:** This move aligns Flutter’s
changelog management with Dart's practices. As the release manager for
both Dart and Flutter, this unification will streamline the processes
and ensure consistency across projects.
#### Timeline
I would like this proposal **approved or denied before the Q3 release
cutoff** so it may be available within the stable branch.
---
> [!NOTE]
> This proposal aims to improve our workflow and documentation
standards. I am open to feedback and further discussion on how we can
best implement this change.
2024-07-23 11:53:20 +07:00
engine-flutter-autoroll
f69058c397
Roll Flutter Engine from f144aba638c6 to 84a46c370c30 (3 revisions) ( #152143 )
...
f144aba638...84a46c370cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PefNEmf1_cZtEGlZc... to ZcBsXDojTYbriHD7_... (flutter/engine#54029 )
2024-07-22 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 503192257a47 to b937619129a4 (13 revisions) (flutter/engine#54028 )
2024-07-22 chinmaygarde@google.com [Impeller] Cleanly revert requiring backpressure for AHB swapchains. (flutter/engine#54027 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PefNEmf1_cZt to ZcBsXDojTYbr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-23 00:48:27 +00:00
Jenn Magder
f33ffc00ea
Use Xcode build setting PRODUCT_NAME to find app and archive paths ( #140242 )
...
1. Instead of getting the `FULL_PRODUCT_NAME` Xcode build setting (`Runner.app`) instead use `PRODUCT_NAME` since most places really want the product name, and the extension stripping wasn't correct when the name contained periods.
2. Don't instruct the user to open the `xcarchive` in Xcode if it doesn't exist.
Fixes https://github.com/flutter/flutter/issues/140212
2024-07-22 23:54:24 +00:00
Andrew Kolos
ebe53d570a
Fix asset transformation in the presence of resolution-aware asset variants ( #151932 )
...
For the necessary background knowledge, see the flutter.dev content on [Resolution-aware image assets](https://docs.flutter.dev/ui/assets/assets-and-images#resolution-aware ) and [Conditional bundling of assets based on app flavor](https://docs.flutter.dev/ui/assets/assets-and-images#conditional-bundling-of-assets-based-on-app-flavor ) if you don't have a basic understanding of these features.
Fixes https://github.com/flutter/flutter/issues/151813 by using unique temporary directories, per asset file, for transformations. Currently, only a single directory is used and the name of the temporary files was based only on the basename of files. This means that `assets/image.png` and `assets/2x/image.png` would share an output path (`<temp dir path>/image.png`), causing a race. If this quick and rough explanation is a bit confusing, the original issueâ#151813âprovides a full repro and correct identification of the exact cause of the failure that can occur in the asset transformation process.
2024-07-22 23:46:19 +00:00
engine-flutter-autoroll
a8d11d2134
Roll Flutter Engine from ceb452f89003 to f144aba638c6 (2 revisions) ( #152138 )
...
ceb452f890...f144aba638skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0f61238a27b0 to 503192257a47 (2 revisions) (flutter/engine#54026 )
2024-07-22 jonahwilliams@google.com [Impeller] ensure fp rounding errors don't cause us to lose a row of pixels when computing text positions. (flutter/engine#54015 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-22 23:26:25 +00:00
LongCatIsLooong
da0b9d55bb
material docImports ( #152060 )
...
https://github.com/flutter/flutter/issues/150800 . I skipped files that contain generated code because the script isn't smart enough, and I did not fix some dubious comment refs. Those will be addressed in a different PR.
2024-07-22 20:50:50 +00:00
Sam Rawlins
f806a2ac64
Sort doc-imports according to the directives_ordering rule ( #152058 )
...
We're going to enforce sorting doc-imports with the same lint rule as
imports and exports: `directives_ordering`. These three locations need
sorting.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-07-22 13:01:18 -07:00
engine-flutter-autoroll
46dd5064df
Roll Flutter Engine from e7b599860d5d to ceb452f89003 (2 revisions) ( #152129 )
...
e7b599860d...ceb452f890chris@bracken.jp Prepend third_party/pyyaml to python sys.path (flutter/engine#54023 )
2024-07-22 chinmaygarde@google.com [Impeller] Remove implicit calls to glGetError in opt modes. (flutter/engine#54016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-22 19:54:25 +00:00
engine-flutter-autoroll
34a8fbd159
Roll Flutter Engine from 207f088f73cb to e7b599860d5d (2 revisions) ( #152126 )
...
207f088f73...e7b599860d#54019 )" (flutter/engine#54022 )
2024-07-22 jonahwilliams@google.com [Impeller] enable ahb swapchain on emulators. (flutter/engine#54019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-22 18:59:27 +00:00
engine-flutter-autoroll
874f9b0654
Roll Packages from 3144ac0576e3 to e978e06eb920 (3 revisions) ( #152106 )
...
3144ac0576...e978e06eb9stuartmorgan@google.com [various] Update Windows packages to Pigeon 21 (flutter/packages#7180 )
2024-07-20 engine-flutter-autoroll@skia.org Roll Flutter from 58068d8ea4ec to 7d5c1c04fb56 (104 revisions) (flutter/packages#7176 )
2024-07-19 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 761747bfc538 to b0850beeb25f (6 revisions) (flutter/packages#7167 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-22 17:22:18 +00:00
Justin McCandless
bb8f6b04d5
Will pop scope on home route ( #152057 )
...
Fixes a bug where WillPopScope no longer worked on the home route.
With this PR, Android's predictive back feature will be explicitly disabled when a WillPopScope widget is in the widget tree. To get the same behavior and still support predictive back, use PopScope.
2024-07-22 10:06:55 -07:00
Polina Cherkasova
c9ee9ad616
Clean up leaky test. ( #152094 )
2024-07-22 09:53:40 -07:00
engine-flutter-autoroll
c63733310f
Roll Flutter Engine from 311abadd6bd2 to 207f088f73cb (1 revision) ( #152074 )
...
311abadd6b...207f088f73jonahwilliams@google.com [Impeller] detect max cull rect on bounds. (flutter/engine#54013 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-20 23:26:30 +00:00
engine-flutter-autoroll
4c3380fa20
Roll Flutter Engine from 77f0cc9089e4 to 311abadd6bd2 (1 revision) ( #152071 )
...
77f0cc9089...311abadd6bjonahwilliams@google.com [Impeller] try disabling backpressure in AHB swapchain. (flutter/engine#54012 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-20 19:27:39 +00:00
engine-flutter-autoroll
4b0b3f4b34
Roll Flutter Engine from 5810b3fc791f to 77f0cc9089e4 (1 revision) ( #152059 )
...
5810b3fc79...77f0cc9089chris@bracken.jp [iOS] Eliminate --clang-dir flag (flutter/engine#54008 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-20 02:29:25 +00:00
