Zachary Anderson
1962e7fd1a
Stop running flaky mac tests in presubmit ( #151870 )
...
For currently unknown reasons, this test is failing at a rate >10% but only in presubmit. This is blocking many engine -> framework rolls, requiring a lot of manual intervention from the sheriff.
https://github.com/flutter/flutter/issues/150642
2024-07-17 18:02:11 +00:00
engine-flutter-autoroll
a1a7330eb6
Roll Flutter Engine from 7e2579634027 to 45b722b661f0 (1 revision) ( #151895 )
...
7e25796340...45b722b661skia-flutter-autoroll@skia.org Roll Skia from 7ebcb7ea944e to def61bdd977a (1 revision) (flutter/engine#53959 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-17 18:02:07 +00:00
Joy Serquiña
8a766ce354
fix(Flutter Web App): fixes html lang typo ( #151866 )
...
Updates the html tag lang attribute to valid "en-US" according to W3.org.
[Before screenshot](https://screenshot.googleplex.com/CMEvi8nAofR4twf )
[After screenshot](https://screenshot.googleplex.com/5aJZBc6o5Xm9fXH )
Fixes b/338044851
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-07-17 17:58:53 +00:00
Matan Lurey
8a0b34c9b9
Delete docs/engine directory ( #151616 )
...
Closes https://github.com/flutter/flutter/issues/150869 .
Pending the following:
- https://github.com/flutter/.github/pull/47
- https://github.com/flutter/flutter/pull/151614
- https://github.com/flutter/engine/pull/53828
- https://github.com/flutter/engine/pull/53829
The wiki backlinks and website have all been updated to <https://github.com/flutter/engine/tree/main/docs >.
2024-07-17 17:58:48 +00:00
LongCatIsLooong
1f489de409
Make CupertinoSlidingSegmentedControl type parameter non-null ( #151803 )
...
`null` is reserved for when there is no selected segment.
2024-07-17 17:55:13 +00:00
hgraceb
46cb56d313
Remove redundant assignment of geometry ( #151821 )
...
Remove redundant assignment of geometry.
2024-07-17 16:34:53 +00:00
Matan Lurey
e5d8466006
Update CONTRIBUTING.md ( #151614 )
...
Part of https://github.com/flutter/flutter/issues/150869 .
2024-07-17 09:16:41 -07:00
engine-flutter-autoroll
aeaef9be35
Roll Packages from 7022a4485325 to d03b1b4ed1a2 (1 revision) ( #151892 )
...
7022a44853...d03b1b4ed1louisehsu@google.com [in_app_purchase_storekit] convert productRequestHandlerTests to swift (flutter/packages#7049 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-17 15:49:20 +00:00
engine-flutter-autoroll
49d6d520cb
Manual roll Flutter Engine from 18eefacce1e9 to 7e2579634027 (6 revisions) ( #151889 )
...
Manual roll requested by zra@google.com
18eefacce1...7e25796340skia-flutter-autoroll@skia.org Roll Skia from 1b0ddc1355ef to 7ebcb7ea944e (1 revision) (flutter/engine#53958 )
2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from d19c61e55ea6 to 1b0ddc1355ef (1 revision) (flutter/engine#53957 )
2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from 80dde3f27830 to d19c61e55ea6 (3 revisions) (flutter/engine#53956 )
2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from 4c50b51875d4 to 80dde3f27830 (1 revision) (flutter/engine#53955 )
2024-07-17 ditman@gmail.com [web] Set touch-action:none in embedded views. (flutter/engine#53945 )
2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from d1478885de20 to 4c50b51875d4 (4 revisions) (flutter/engine#53953 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-17 15:18:10 +00:00
flyboy
0a1d550e5f
Add ListTileControlAffinity to ListTileTheme ( #150695 )
...
fixes https://github.com/flutter/flutter/issues/146414
---
I saw @abikko submitted a PR https://github.com/flutter/flutter/pull/146630 , but it was not completed due to CLA and lack of test cases.
I am willing to complete this PR in combination with @abikko's code (I don't know if this is allowed)
This PR adds contorlAffinity to ListTileTheme so that [CheckboxListTile], [RadioListTile], [SwitchListTile], and [ExpansionTile] can read and use it
For example: If ListTileTheme in Theme sets contorlAffinity, then [CheckboxListTile] can directly use contorlAffinity in ListTileTheme. Of course, if contorlAffinity is also set in [CheckboxListTile], the property in [CheckboxListTile] will be used first.
2024-07-17 14:06:13 +00:00
Sam Rawlins
e497ed7db0
Remove unnecessary parens in test ( #151846 )
...
In order to address [a bug in `unnecessary_parenthesis`](https://github.com/dart-lang/linter/issues/3046 ), we are reporting a few more cases in `unnecessary_parenthesis`. `a = (b = c)` is one such case. This change is being made in https://dart-review.googlesource.com/c/sdk/+/366891 .
2024-07-17 09:54:34 +00:00
flutter-pub-roller-bot
38cad013e0
Roll pub packages ( #151864 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-07-17 09:50:09 +00:00
engine-flutter-autoroll
392ba117b3
Manual roll Flutter Engine from b2bdd68ede15 to 18eefacce1e9 (1 revision) ( #151872 )
...
Manual roll requested by zra@google.com
b2bdd68ede...18eefacce1skia-flutter-autoroll@skia.org Manual roll Dart SDK from b44d99ea2bf4 to 7368b1d084b0 (12 revisions) (flutter/engine#53949 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-17 05:45:25 +00:00
Tong Mu
de04c13fdb
[CupertinoActionSheet] Support legacy buttons ( #151136 )
...
Fixes https://github.com/flutter/flutter/issues/150980
This PR allows buttons implemented with `GestureDetector.onTap` to be selected in the action sheet.
2024-07-17 05:09:24 +00:00
Tong Mu
f50feec5be
[CupertinoActionSheet] Add haptic feedback ( #151420 )
...
This PR implements the behavior of native action sheets that produces haptic feedback when the user slides into a button.
2024-07-17 04:57:26 +00:00
Kevin Moore
83bfab5376
flutter_tool: DRY up arg helpers, use new typed arg functions ( #151784 )
2024-07-17 04:01:28 +00:00
engine-flutter-autoroll
91a5b7bd9a
Manual roll Flutter Engine from 5b9fc4eaec84 to b2bdd68ede15 (2 revisions) ( #151868 )
...
Manual roll requested by zra@google.com
5b9fc4eaec...b2bdd68edebdero@google.com [Impeller] Use depth transform in framebuffer blend entities. (flutter/engine#53951 )
2024-07-16 chris@bracken.jp [macOS] Eliminate archive_gen_snapshot target (flutter/engine#53948 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-17 01:38:28 +00:00
engine-flutter-autoroll
7233347427
Roll Flutter Engine from 475980e29c51 to 5b9fc4eaec84 (8 revisions) ( #151863 )
...
475980e29c...5b9fc4eaecchris@bracken.jp [iOS] Delete gen_snapshot_armv7 support
(flutter/engine#53947 )
2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from f9422e08a793 to
d1478885de20 (3 revisions) (flutter/engine#53946 )
2024-07-16 yjbanov@google.com [web] fix unexpected scrolling in
semantics (flutter/engine#53922 )
2024-07-16 34871572+gmackall@users.noreply.github.com More logs for
Android unsatisfiedLinkError (flutter/engine#53920 )
2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from 9b789b35e109 to
f9422e08a793 (1 revision) (flutter/engine#53944 )
2024-07-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941 )
2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from a6ac2f8e82b4 to
9b789b35e109 (1 revision) (flutter/engine#53942 )
2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from 57ae89c0ffae to
a6ac2f8e82b4 (1 revision) (flutter/engine#53940 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 17:59:12 -07:00
Gray Mackall
8c5fbb4021
Remove conditionality in templates that was for AGP <= 4.2 support ( #151845 )
...
Not needed after https://github.com/flutter/flutter/pull/149204 (as long as nothing has changed since the comment was made ð).
Fixes https://github.com/flutter/flutter/issues/145105 .
2024-07-16 22:33:24 +00:00
n7484443
6e189a7452
chore: fix typo korean, cutButtonLabel ( #151364 )
...
[Wikipeidia](https://ko.wikipedia.org/wiki/%EC%9E%98%EB%9D%BC%EB%82%B4%EA%B8%B0,_%EB%B3%B5%EC%82%AC,_%EB%B6%99%EC%97%AC%EB%84%A3%EA%B8%B0 )
In korea, we use '잘라내기', '복사', '붙여넣기', not '잘라냄', '복사', '붙여넣기'.
e.g.) korean translation site, papago
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2024-07-16 15:29:43 -07:00
John Stef
aed548992a
Add borderRadius property to PopupMenuButton ( #151228 )
...
This PR is adding borderRadius property to PopupMenuButton. PopupMenuButton has a child wrapped in an InkWell widget where as of right now you can't customize it's border radius resulting in wrong splash effect when the child has border radius.
Fixes : #151227
https://github.com/flutter/flutter/assets/20647774/93feb0a4-c4ff-4059-bde2-e59c4d35e2b6
2024-07-16 20:27:11 +00:00
Taha Tesser
e1cd7b11f6
Introduce Switch.padding ( #149884 )
...
fixes [Switch has some padding that leads to uncentered UI](https://github.com/flutter/flutter/issues/148498 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
ColoredBox(
color: Colors.amber,
child: Switch(
padding: EdgeInsets.zero,
value: true,
materialTapTargetSize: MaterialTapTargetSize.padded,
onChanged: (bool value) {},
),
),
const SizedBox(height: 16),
ColoredBox(
color: Colors.amber,
child: Switch(
value: true,
materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
onChanged: (bool value) {},
),
),
],
),
),
),
);
}
}
```
</details>
### Default Switch size
<img width="476" alt="Screenshot 2024-07-11 at 13 25 05" src="https://github.com/flutter/flutter/assets/48603081/f9f3f6c6-443d-4bd5-81d4-5e314554b032 ">
### Update Switch size using the new `Switch.padding` to address [Switch has some padding that leads to uncentered UI](https://github.com/flutter/flutter/issues/148498 )
<img width="476" alt="Screenshot 2024-07-11 at 13 24 40" src="https://github.com/flutter/flutter/assets/48603081/aea0717b-e852-4b8d-b703-c8c4999d4863 ">
2024-07-16 20:25:09 +00:00
engine-flutter-autoroll
22a5c6cb0a
Roll Flutter Engine from 850e0c1b16c3 to 475980e29c51 (1 revision) ( #151841 )
...
850e0c1b16...475980e29cskia-flutter-autoroll@skia.org Roll Skia from 07bd32512db2 to 57ae89c0ffae (1 revision) (flutter/engine#53938 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 18:55:19 +00:00
Victor Sanni
b9e4416ad3
Add semanticLabel to CupertinoCheckbox ( #151789 )
2024-07-16 17:47:18 +00:00
Victor Sanni
cb4ba2fddc
Add example for CupertinoCheckbox ( #151779 )
2024-07-16 16:54:02 +00:00
Seth Ladd
ba57fa3821
Update Design-Documents.md ( #151472 )
...
Make it more clear that every design doc has a corresponding github tracking issue with appropriate label.
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-07-16 16:01:10 +00:00
engine-flutter-autoroll
41e6e6b041
Roll Packages from 4a4e63e43f42 to 7022a4485325 (3 revisions) ( #151826 )
...
4a4e63e43f...7022a44853ditman@gmail.com [webview_flutter_web] Migrate integration tests to package:web. (flutter/packages#7115 )
2024-07-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.10 to 3.25.12 (flutter/packages#7107 )
2024-07-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/packages#7071 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 15:44:35 +00:00
engine-flutter-autoroll
0913663f79
Roll Flutter Engine from 0629a5ca2ef4 to 850e0c1b16c3 (4 revisions) ( #151819 )
...
0629a5ca2e...850e0c1b16skia-flutter-autoroll@skia.org Roll Skia from 3a0067d2f105 to 07bd32512db2 (1 revision) (flutter/engine#53936 )
2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from 93ddcf356a02 to 3a0067d2f105 (4 revisions) (flutter/engine#53933 )
2024-07-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.11 to 3.25.12 (flutter/engine#53930 )
2024-07-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-python from 5.1.0 to 5.1.1 (flutter/engine#53932 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 14:55:39 +00:00
flutter-pub-roller-bot
bed034add2
Roll pub packages ( #151816 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-07-16 12:34:24 +00:00
Flutter GitHub Bot
dcdcdb070f
Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be unflaky ( #148392 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20hot_mode_dev_cycle_ios__benchmark%22 ).
This test can be marked as unflaky.
2024-07-16 11:24:31 +00:00
Valentin Vignal
f84139b665
Add tests for curve2_d.0.dart ( #150984 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/animation/curves/curve2_d.0.dart`
2024-07-16 10:44:22 +00:00
engine-flutter-autoroll
fde041869e
Roll Flutter Engine from 2e4401545c25 to 0629a5ca2ef4 (1 revision) ( #151810 )
...
2e4401545c...0629a5ca2eflutter/engine#53931 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 08:11:17 +00:00
engine-flutter-autoroll
0a99e1f9a9
Roll Flutter Engine from 235e67f4633e to 2e4401545c25 (1 revision) ( #151805 )
...
235e67f463...2e4401545cskia-flutter-autoroll@skia.org Roll Skia from c91cad775529 to 93ddcf356a02 (1 revision) (flutter/engine#53926 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 04:57:11 +00:00
engine-flutter-autoroll
6e1dfa5d8b
Roll Flutter Engine from f1363fb7c2da to 235e67f4633e (5 revisions) ( #151802 )
...
f1363fb7c2...235e67f463skia-flutter-autoroll@skia.org Roll Skia from d4acfbe0b001 to c91cad775529 (1 revision) (flutter/engine#53924 )
2024-07-16 34871572+gmackall@users.noreply.github.com Align `tools/android_sdk/packages.txt` with what is uploaded to CIPD (flutter/engine#53921 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from 6347d8255f83 to d4acfbe0b001 (3 revisions) (flutter/engine#53919 )
2024-07-15 codefu@google.com Move images to flutter/assets-for-api-docs (flutter/engine#53917 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from b63d0290b826 to 6347d8255f83 (5 revisions) (flutter/engine#53916 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-16 03:46:21 +00:00
engine-flutter-autoroll
fbb12c2c61
Roll Flutter Engine from cd78d213fcc8 to f1363fb7c2da (1 revision) ( #151790 )
...
cd78d213fc...f1363fb7c2skia-flutter-autoroll@skia.org Roll Skia from 476abcbc2e4d to b63d0290b826 (5 revisions) (flutter/engine#53915 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-15 22:34:38 +00:00
arbaker2
30bf2888b9
Add support for inverting CircularNotchedRectangle to optionally be drawn on the bottom of a path ( #151386 )
...
This PR allows for an optional argument [inverted[ to be passed to the [getOuterPath] method of a CircularNotchedRectangle object in order to invert the notch for situations where it is desired to draw the notch on the bottom of the path. This allows both of the below paths in the below screenshot to be drawn and changes no default behavior.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
This add a feature similar to the one discussed in #49973 , original feature proposal #151381
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-07-15 22:08:21 +00:00
engine-flutter-autoroll
a73c0f3abd
Roll Flutter Engine from 8440bbe9028a to cd78d213fcc8 (4 revisions) ( #151783 )
...
8440bbe902...cd78d213fcskia-flutter-autoroll@skia.org Roll Skia from 559a46957250 to 476abcbc2e4d (4 revisions) (flutter/engine#53911 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from fe05596a26ea to 559a46957250 (7 revisions) (flutter/engine#53909 )
2024-07-15 yjbanov@google.com [web] switch to SemanticsAction.focus (attempt 3) (flutter/engine#53689 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from a3c29413cdf0 to fe05596a26ea (1 revision) (flutter/engine#53907 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-15 21:38:36 +00:00
Zachary Anderson
57fa26cd5c
Retry plugin_test_ios in presubmit ( #151773 )
...
For https://github.com/flutter/flutter/issues/151772
This test is flaking frequently in presubmit and blocking engine -> framework rolls as in https://github.com/flutter/flutter/pull/151762 that only contained a Skia roll.
2024-07-15 20:11:25 +00:00
auto-submit[bot]
7cdc23b3e1
Reverts "Launch DDS from Dart SDK and prepare to serve DevTools from DDS ( #146593 )" ( #151781 )
...
Reverts: flutter/flutter#146593
Initiated by: zanderso
Reason for reverting: Consistently failing `Windows_android native_assets_android` as in https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20native_assets_android/2533/overview
Original PR Author: bkonyi
Reviewed By: {christopherfujino, kenzieschmoll}
This change reverts the following previous change:
This change is a major step towards moving away from shipping DDS via Pub.
The first component of this PR is the move away from importing package:dds to launch DDS. Instead, DDS is launched out of process using the `dart development-service` command shipped with the Dart SDK. This makes Flutter's handling of DDS consistent with the standalone Dart VM.
The second component of this PR is the initial work to prepare for the removal of instances of DevTools being served manually by the flutter_tool, instead relying on DDS to serve DevTools. This will be consistent with how the standalone Dart VM serves DevTools, tying the DevTools lifecycle to a live DDS instance. This will allow for the removal of much of the logic needed to properly manage the lifecycle of the DevTools server in a future PR. Also, by serving DevTools from DDS, users will no longer need to forward a secondary port in remote workflows as DevTools will be available on the DDS port.
There's two remaining circumstances that will prevent us from removing DevtoolsRunner completely:
- The daemon's `devtools.serve` endpoint
- `flutter drive`'s `--profile-memory` flag used for recording memory profiles
This PR also includes some refactoring around `DebuggingOptions` to reduce the number of debugging related arguments being passed as parameters adjacent to a `DebuggingOptions` instance.
2024-07-15 19:55:18 +00:00
Ben Konyi
f023430859
Launch DDS from Dart SDK and prepare to serve DevTools from DDS ( #146593 )
...
This change is a major step towards moving away from shipping DDS via
Pub.
The first component of this PR is the move away from importing
package:dds to launch DDS. Instead, DDS is launched out of process using
the `dart development-service` command shipped with the Dart SDK. This
makes Flutter's handling of DDS consistent with the standalone Dart VM.
The second component of this PR is the initial work to prepare for the
removal of instances of DevTools being served manually by the
flutter_tool, instead relying on DDS to serve DevTools. This will be
consistent with how the standalone Dart VM serves DevTools, tying the
DevTools lifecycle to a live DDS instance. This will allow for the
removal of much of the logic needed to properly manage the lifecycle of
the DevTools server in a future PR. Also, by serving DevTools from DDS,
users will no longer need to forward a secondary port in remote
workflows as DevTools will be available on the DDS port. This code is currently
commented out and will be enabled in a future PR.
There's two remaining circumstances that will prevent us from removing
DevtoolsRunner completely:
- The daemon's `devtools.serve` endpoint
- `flutter drive`'s `--profile-memory` flag used for recording memory
profiles
This PR also includes some refactoring around `DebuggingOptions` to
reduce the number of debugging related arguments being passed as
parameters adjacent to a `DebuggingOptions` instance.
2024-07-15 14:08:31 -04:00
Zachary Anderson
f4f556797a
Move tests on Linux/Mokey and a few others from staging to prod ( #151760 )
...
For https://github.com/flutter/flutter/issues/148085
2024-07-15 10:52:53 -07:00
engine-flutter-autoroll
d3d1eb25c7
Roll Flutter Engine from 54f0879a6d88 to 8440bbe9028a (1 revision) ( #151762 )
...
54f0879a6d...8440bbe902skia-flutter-autoroll@skia.org Roll Skia from 2a45bd56601e to a3c29413cdf0 (2 revisions) (flutter/engine#53905 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-15 17:36:19 +00:00
Jenn Magder
0cf6ae7686
Remove bringup from platform_views_scroll_perf_bottom_ad_banner__timeline_summary ( #151617 )
...
This benchmark is passing in post-submit. Remove bringup so skiaperf metrics can be collected.
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_ios%20platform_views_scroll_perf_bottom_ad_banner__timeline_summary/93/overview
Note there have been infra failures https://github.com/flutter/flutter/issues/151592 but I don't expect to see the same when this moves off the staging pool.
2024-07-15 17:32:55 +00:00
engine-flutter-autoroll
5afa7dd8e2
Roll Packages from 3379e51a042a to 4a4e63e43f42 (2 revisions) ( #151759 )
...
3379e51a04...4a4e63e43fflutter/packages#6918 )
2024-07-13 ditman@gmail.com Manual roll Flutter to 58068d8ea4ec (42 revisions) (flutter/packages#7099 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-15 15:43:12 +00:00
engine-flutter-autoroll
994d3d6454
Roll Flutter Engine from a921637f16f6 to 54f0879a6d88 (5 revisions) ( #151752 )
...
a921637f16...54f0879a6dskia-flutter-autoroll@skia.org Roll Skia from aacec1ee6359 to 2a45bd56601e (1 revision) (flutter/engine#53896 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from 6a046a1394a9 to aacec1ee6359 (3 revisions) (flutter/engine#53894 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from 3335b96bf189 to 6a046a1394a9 (2 revisions) (flutter/engine#53889 )
2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from 22e1169ba4fe to 3335b96bf189 (1 revision) (flutter/engine#53888 )
2024-07-14 skia-flutter-autoroll@skia.org Roll Skia from cc7f18b64b3c to 22e1169ba4fe (1 revision) (flutter/engine#53886 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-15 15:27:22 +00:00
Kevin Moore
ec16c86972
tool/build/web: move source-maps CLI flag to "general" web section ( #151722 )
...
...now that wasm supports source maps (see https://github.com/flutter/flutter/pull/151643 )
2024-07-15 14:17:39 +00:00
Taha Tesser
9e88446f89
Fix Slider thumb doesn't align with divisions, thumb padding, and rounded corners ( #149594 )
...
fixes [[Slider] Thumb's center doesn't align with division's center](https://github.com/flutter/flutter/issues/62567 )
fixes [Slider thumb doesn't respect round slider track shape](https://github.com/flutter/flutter/issues/149591 )
fixes [`RoundedRectSliderTrackShape` corners are not rendered correctly](https://github.com/flutter/flutter/issues/149589 )
(Verified these behaviors with Android components implementation)
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
double _value = 5.0;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
sliderTheme: const SliderThemeData(
trackHeight: 32,
thumbColor: Colors.green,
activeTrackColor: Colors.deepPurple,
inactiveTrackColor: Colors.amber,
),
),
home: Scaffold(
body: Slider(
value: _value,
// divisions: 10,
// ignore: avoid_redundant_argument_values
min: 0,
max: 10,
onChanged: (double value) {
setState(() {
_value = value;
});
},
),
),
);
}
}
```
</details>
### Description
This PR fixes several core `Sliders` issues which are apparent in https://github.com/flutter/flutter/pull/147783 . As a result, fixing the these bugs will unblock it.
### 1. Fixes the thumb doesn't align with `Slider` divisions.
### 2. Fixes `RoundedRectSliderTrackShape` corners are not rendered correctly.
### 3. Fixes round track shape corners when the thumb is at the start or end of the round track shape.
2024-07-15 07:09:09 +00:00
engine-flutter-autoroll
82b63ff27d
Roll Flutter Engine from 450d2ec7bbdf to a921637f16f6 (1 revision) ( #151728 )
...
450d2ec7bb...a921637f16skia-flutter-autoroll@skia.org Roll Skia from 2763d99b335e to cc7f18b64b3c (1 revision) (flutter/engine#53874 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-14 09:07:36 +00:00
engine-flutter-autoroll
7aac4c5fb8
Roll Flutter Engine from b531a5ae27fc to 450d2ec7bbdf (3 revisions) ( #151723 )
...
b531a5ae27...450d2ec7bbchinmaygarde@google.com [Impeller] Cleanup stale TODOs and fixup the format of others. (flutter/engine#53825 )
2024-07-13 skia-flutter-autoroll@skia.org Roll Skia from 6041fb033e38 to 2763d99b335e (1 revision) (flutter/engine#53862 )
2024-07-13 skia-flutter-autoroll@skia.org Roll Skia from 0257e2adc7a4 to 6041fb033e38 (1 revision) (flutter/engine#53860 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-13 23:55:27 +00:00
engine-flutter-autoroll
c95977568a
Roll Flutter Engine from 18e22f824c79 to b531a5ae27fc (2 revisions) ( #151704 )
...
18e22f824c...b531a5ae27skia-flutter-autoroll@skia.org Roll Skia from 49046798c05d to 0257e2adc7a4 (3 revisions) (flutter/engine#53852 )
2024-07-13 kevmoo@users.noreply.github.com Drop self-references to hash functions from doc comments (flutter/engine#53844 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-13 10:35:28 +00:00
