17579 Commits

Author SHA1 Message Date
Jonah Williams
18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Jason Simmons
324e20de09
Update TextStyle.hashCode to handle list fields (#50520) 2020-02-11 14:38:03 -08:00
LongCatIsLooong
48d5fcabbd
evict _SliverFractionalPadding cache on constraint change (#50523) 2020-02-11 12:52:53 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Lamonte
fd1062debd
Exposed optional scrollController property in ReorderableListView (#49148) 2020-02-11 10:58:02 -08:00
Jenn Magder
e002698c35
Turn back on macOS shard Cirrus caching (#50496) 2020-02-11 10:37:53 -08:00
Jonah Williams
fa44a1cf37
[flutter_tools] fix path escaping on in depfile generation (#50538) 2020-02-11 09:31:58 -08:00
Greg Spencer
c6e45ffa30
Updating snippets documentation README.md (#50483)
Updates the README file for snippets.
2020-02-11 09:19:23 -08:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Gary Qian
f769bcc5c4
Reland "Track lastKnownRemoteTextEditingValue separately from received data" (#50307) 2020-02-10 20:55:48 -05:00
Christopher Fujino
1f498e2471
Set bundle config rather than deprecated --system flag (#50497) 2020-02-10 17:41:37 -08:00
Amir Hardon
bcef4edfc8
Make the template plugin example depend on the plugin as a real dependency (#50485) 2020-02-10 16:03:02 -08:00
Mouad Debbar
bf551a31fe
EditableText's autofocus:true should not crash (#50372) 2020-02-10 15:58:02 -08:00
engine-flutter-autoroll
c388a26131
Roll engine 6158f03ef5fa..e4f46f32f1fd (3 commits) (#50399) 2020-02-10 15:54:03 -08:00
Shi-Hao Hong
67826bdce5
Revert "Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616)" (#50516)
This reverts commit 801a6a7e5e2c16525d3c2856a43ed34b5ff536a3.
2020-02-10 14:59:32 -08:00
Greg Spencer
18f8002ec8
Make FocusManager a ChangeNotifier that notifies when the prim… (#50392)
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus.

Fixes #50501
2020-02-10 14:33:31 -08:00
Dan Field
9cb2953e10
Fix image tests that make faulty assumptions about lifecycle of image provider (#50297) 2020-02-10 14:23:01 -08:00
Jonah Williams
568172793c
Add "flutter symbolize" command (#49465) 2020-02-10 14:18:03 -08:00
Dan Field
ffc85591c8
more gradle upgrades (#50388) 2020-02-10 14:16:49 -08:00
Michael Goderbauer
6d87337f51
Remove some obsolete // ignore: (#50481) 2020-02-10 14:08:09 -08:00
Jonah Williams
9bc0e6a991
Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)
This reverts commit 902064277265daced4a79bcdaae157a310cc13c8.
2020-02-10 13:26:59 -08:00
Zachary Anderson
c23d9cd4ce
[flutter_tools] Print emojis in Windows Terminal (#50446) 2020-02-10 10:23:35 -08:00
Per Classon
5f4658973b
Update RefreshIndicator documentation to clarify the need for the child for be scrollable (#50345) 2020-02-10 10:08:02 -08:00
Fedor Korotkov
038762bd69
[ci] Upgrade to Catalina (#49519)
Catalina VMs are using the latest major version of virtualization which has improved networking which should fix `Agent is not responding!` issue.
2020-02-10 10:03:59 -08:00
liyuqian
b277534026
Assert cache hints are not set for null painters (#49771) 2020-02-10 10:03:03 -08:00
Greg Spencer
9fb781a54a
Update samples to work with Dartpad, and convert all that make… (#50377)
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.

It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.

I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).

I modified a few of the examples so that they looked nicer, and fit better on the page.

I added the sample description text above each DartPad instance, since that often defines the context of the example.

I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
2020-02-10 10:00:20 -08:00
Jonah Williams
2a6bc617b8
[framework] minimize performance effect of stateless/stateful swap (#50394) 2020-02-10 10:00:11 -08:00
Jonah Williams
6146cd72e4
[flutter_tools] add missing vm_service dep to BUILD.gn (#50454) 2020-02-10 09:59:48 -08:00
Jonah Williams
a8cc85331a
[flutter-tools] replace mock with FakeProcessmanager (#50456) 2020-02-10 09:59:40 -08:00
Prerak Mann
9020642772
Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480) 2020-02-10 09:58:04 -08:00
Shi-Hao Hong
6dc3bfaa98
Fix Dropdown 'itemHeights' was called on null crash (#50366) 2020-02-07 18:28:02 -08:00
Michael Goderbauer
95d6ef741c
Nested TickerMode cannot turn tickers back on (#50355) 2020-02-07 18:23:02 -08:00
keyonghan
0ffecc6807
change capability for test tiles_scroll_perf_iphonexs__timeline_summary (#50385) 2020-02-07 17:24:56 -08:00
engine-flutter-autoroll
b40cb088d4
Roll engine 580503c35926..6158f03ef5fa (6 commits) (#50381)
* c9322145f Ensure fields of Rect and OffsetBase classes are optimized as non-null. (flutter/engine#16465)

* 5c70356a9 Simplify task queues locking mechanism (flutter/engine#16477)

* d589ddea6 Fix text range logic for a11y (flutter/engine#16496)

* 1a4f4e394 Fix unused import in Android embedder (flutter/engine#16494)

* 964ae1009 Disable ShellTest.WaitForFirstFrameTimeout on Fuchsia (flutter/engine#16495)

* 6158f03ef Roll src/third_party/skia 87e3bef6f82f..9f3eef796f63 (7 commits) (flutter/engine#16493)
2020-02-07 16:55:04 -08:00
filaps
801a6a7e5e
Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616) 2020-02-07 16:08:02 -08:00
jimshepherd
92a335e465
Use state value in DropdownButtonFieldForm (#37145)
The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor.

This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
2020-02-07 15:50:37 -08:00
Jenn Magder
082ae838bd
Fall back to global cache and platform if null when injected into constructor (#50370) 2020-02-07 15:28:45 -08:00
engine-flutter-autoroll
ef74572e76
Roll engine f3ce90e9387b..580503c35926 (24 commits) (#50363)
* 71ec0a181 Relax timing restrictions on WakeUpTimersAreSingletons. (flutter/engine#16446)

* 3ac1e6d8b Disable unit tests using --gtest-filter instead of at compile time (flutter/engine#16472)

* 80be2c43e Fix RasterCache LRU logic, opportunistic simplifications. (flutter/engine#16434)

* ca40f11ee Roll src/third_party/skia 7f36405ea3ec..c0360582d211 (6 commits) (flutter/engine#16476)

* c9e7713b5 Fix analyzer warnings for frontend_server change (flutter/engine#16470)

* 9ada1b0e0 Fix elf_loader.cc on Fuchsia, add a TODO for proper fix

* 051762798 Enable runtime_unittests on Fuchsia

* 03f639e12 Add noexcept annotations to EnableValue moves (flutter/engine#16478)

* 00904dd96 Various fixes in CanvasKit (flutter/engine#16433)

* de7022b3b Roll src/third_party/skia c0360582d211..121750c2efff (7 commits) (flutter/engine#16479)

* d2aab27b4 Enable shell_unittests on Fuchsia with Vulkan dependencies. (flutter/engine#16376)

* eec73e3a7 Roll src/third_party/dart b3396cbdcae1..49850e6919f7 (45 commits) (flutter/engine#16480)

* 557f3a2d2 Run Flutter framework tests against the web engine in Cirrus (flutter/engine#16343)

* 477527b3f Roll src/third_party/skia 121750c2efff..046f9893b953 (4 commits) (flutter/engine#16482)

* eb8691f2a Code cleanup on destructors (flutter/engine#16481)

* 73978177e Roll fuchsia/sdk/core/linux-amd64 from A9STP... to g2s3c... (flutter/engine#16484)

* 313527d2e Roll src/third_party/dart 49850e6919f7..16782e6c171f (16 commits) (flutter/engine#16485)

* 83feaf4fc Roll src/third_party/skia 046f9893b953..97bf6578796c (1 commits) (flutter/engine#16486)

* 918405870 Roll src/third_party/skia 97bf6578796c..f3560b680e35 (1 commits) (flutter/engine#16487)

* 0db017d09 Roll src/third_party/dart 16782e6c171f..d765d237460d (1 commits) (flutter/engine#16488)

* f9ed07cf5 Roll fuchsia/sdk/core/linux-amd64 from g2s3c... to LvSlH... (flutter/engine#16489)

* a1b91dad7 Roll src/third_party/skia f3560b680e35..77fdf66946d2 (1 commits) (flutter/engine#16490)

* 7edb803b6 Roll src/third_party/dart d765d237460d..514a8d4c8417 (7 commits) (flutter/engine#16491)

* 580503c35 Roll src/third_party/skia 77fdf66946d2..87e3bef6f82f (2 commits) (flutter/engine#16492)
2020-02-07 14:49:42 -08:00
Mouad Debbar
b54047932f
Reduce duplication in sharded tests in .cirrus.yml (#50306) 2020-02-07 14:43:25 -08:00
Jenn Magder
4411d8e64e
Update minimum version to Xcode 11.0 (#50371) 2020-02-07 14:35:01 -08:00
Christopher Fujino
b65f4211cf
Make codesign.dart integration test easier to run locally (#50289) 2020-02-07 14:34:16 -08:00
Shi-Hao Hong
5dfa8e9c05
Remove redundant gen_l10n tests (#50301) 2020-02-07 13:59:45 -08:00
Jenn Magder
48a9bd56b1
Revert "Update minimum version to Xcode 11.0 (#50315)" (#50369)
This reverts commit 2b7582ef61dff05a31f558c095aec8f8794d5a42.
2020-02-07 13:59:21 -08:00
Jenn Magder
2b7582ef61
Update minimum version to Xcode 11.0 (#50315) 2020-02-07 13:57:24 -08:00
Dan Field
9348aea016
Disable tests using gauge (#50367) 2020-02-07 13:51:24 -08:00
engine-flutter-autoroll
fc2c0af48d
Roll engine f34bc65bee49..f3ce90e9387b (20 commits) (#50305)
* d5442b86e Roll src/third_party/skia bc3307c395e2..ebc00f97fab1 (21 commits) (flutter/engine#16429)

* 76b291a65 Added a plugin method that gets called when the engine is about to be deleted (flutter/engine#16336)

* 07f25c51e fix bad reference to maxDiffRatePercent (flutter/engine#16440)

* 41d50c220 Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365)

* f25d325b1 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425)

* 473f55940 Suppress some deprecation warnings on Windows (flutter/engine#16416)

* 2e34ad6b7 Roll fuchsia/sdk/core/mac-amd64 from ubThi... to fvWgE... (flutter/engine#16454)

* 47c02e6fc Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456)

* 3d1b112d7 Roll buildroot (flutter/engine#16419)

* 28e663726 Add explicit casts to printing of function pointers (flutter/engine#16370)

* 9ad81dae1 Wrap strdup to use compliant name on Windows (flutter/engine#16372)

* 9708e5274 Roll rapidjson (flutter/engine#16347)

* f06ebba3e Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442)

* e530376fb Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457)

* 4cc41ae97 Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459)

* 2f233edf5 Roll src/third_party/skia 4721e067812f..f6e3eaf05150 (1 commits) (flutter/engine#16461)

* b0b0ed83b Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463)

* 7fea936a0 Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466)

* 001b3a0b1 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471)

* f3ce90e93 Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469)
2020-02-07 13:23:15 -08:00
Tong Mu
324a2168cd
Change definition of offset to object (#50157) 2020-02-07 13:08:02 -08:00
Dan Field
2627122324
Throw when trying to load an empty file (#50325) 2020-02-07 10:08:02 -08:00
Greg Spencer
f118b638ed
Add channel-specific dartpad URL to snippet generation (#49845)
Adds the channel to docs generation for dartpad samples, since the new query parameter was added in dart-lang/dart-pad#1462
2020-02-07 08:45:57 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00