3358 Commits

Author SHA1 Message Date
Ian Hickson
19fb068d83 Merge pull request #1108 from Hixie/canFlex-error
Rationalise all our exception catching and reporting code
2016-01-06 22:03:38 -08:00
Ian Hickson
13d6cc3273 Rationalise all our exception catching and reporting code
- make them all have the same style
- make them all include the stack trace last
- make them all stop printing if their callback is set (if
  appropriate, they don't yet all have callbacks)
2016-01-06 21:49:23 -08:00
Ian Hickson
07ed3fbf38 Merge pull request #1107 from Hixie/debugDoesLayoutWithCallback
Remove unreferenced getter "debugDoesLayoutWithCallback".
2016-01-06 19:42:51 -08:00
Ian Hickson
94833b24bf Remove unreferenced getter "debugDoesLayoutWithCallback".
I think I wanted to use this at some point but ended up going a
different direction. Instead, object.dart has a private field that
serves a similar purpose.
2016-01-06 19:14:45 -08:00
Adam Barth
f17f1ba1e5 Merge pull request #1102 from abarth/animated_container
AnimatedContainer has an issue with one config value change and not another
2016-01-06 18:04:19 -08:00
Eric Seidel
d8edf1c27b Merge pull request #1104 from flutter/revert-1103-listen_exit
Revert "Make `flutter listen` exit nicely when missing dependencies"
2016-01-06 17:17:28 -08:00
Eric Seidel
330c08199e Revert "Make flutter listen exit nicely when missing dependencies" 2016-01-06 17:17:16 -08:00
Eric Seidel
43cd6a0946 Merge pull request #1103 from eseidelGoogle/listen_exit
Make `flutter listen` exit nicely when missing dependencies
2016-01-06 17:09:56 -08:00
Adam Barth
79c797a115 AnimatedContainer has an issue with one config value change and not another
If we're already at the target value, we fail to configure the variable. If
another variable animates, we re-animate the other variable.

Fixes #958
2016-01-06 17:09:39 -08:00
Eric Seidel
3a2aa89064 Make flutter listen exit nicely when missing dependencies
Previously it died with a confusing exception.

@chinmaygarde
2016-01-06 17:07:36 -08:00
Adam Barth
8694fada8f Merge pull request #1101 from abarth/lockdown_virtual_viewport
Enable more asserts when building with virtual viewports
2016-01-06 16:13:46 -08:00
Adam Barth
0033a8fcdf Enable more asserts when building with virtual viewports 2016-01-06 16:03:26 -08:00
Adam Barth
d46f0cebb5 Merge pull request #1098 from abarth/pageable_list2
Switch PageableList over to using RenderList
2016-01-06 16:02:34 -08:00
Adam Barth
e64d93a520 Switch PageableList over to using RenderList
This patch moves PageableList off HomogeneousViewport and onto RenderList and
friends, making it match the new ScrollableList.
2016-01-06 15:28:01 -08:00
Chinmay Garde
e1b16729bf Merge pull request #1093 from chinmaygarde/master
Download the Xcode artifacts for the current engine revision
2016-01-06 13:40:35 -08:00
Devon Carew
854f9f717d Merge pull request #1090 from devoncarew/log_stderr
have flutter logs log stderr
2016-01-06 13:39:11 -08:00
Chinmay Garde
f5f9440a2d Download the Xcode artifacts for the current engine revision 2016-01-06 13:38:43 -08:00
Eric Seidel
d7d4a46d36 Merge pull request #1091 from eseidelGoogle/device_time
Teach `flutter trace stop` to use time on the device.
2016-01-06 13:38:39 -08:00
Eric Seidel
0d783718ba Teach flutter trace stop to use time on the device.
This is yet another hack on top of adb log handling.
This is fragile, but w/o this if you device time is out
of sync, you can't trace.

@abarth
2016-01-06 13:29:32 -08:00
Devon Carew
ed215fb842 have flutter logs log stderr 2016-01-06 13:29:24 -08:00
Adam Barth
a271eb5612 Merge pull request #1081 from abarth/ship_scrollable_list2
Replace ScrollableList with ScrollableList2
2016-01-06 11:26:16 -08:00
Adam Barth
627c1ffb5c Replace ScrollableList with ScrollableList2
ScrollableList2 is complete and subsumes all the use cases for the original
ScrollableList.
2016-01-06 11:16:57 -08:00
Hans Muller
fa15fc2d04 Merge pull request #1077 from HansMuller/selection_type
Convert TabBar to TabBar<T> and TabBarSelection to TabBarSelection<T>

The TabBarSelection constructor no longer has the odd maxIndex parameter and the selection is initialized by value rather than the index of the selected tab.

TabBar has a Map labels parameter instead of List.
2016-01-06 11:01:34 -08:00
Hans Muller
6494cd1f35 Make TabBarSelection a parameterized type 2016-01-06 10:54:16 -08:00
Adam Barth
81b7067544 Merge pull request #1082 from abarth/scrollable_crash
Fix assert in Stocks app
2016-01-06 10:51:56 -08:00
Adam Barth
d2a1389ed0 Fix assert in Stocks app
When paging a scrollable list, we were trying to read the render object's size
at a time when we're not allowed to read it. Instead, encode the information
into the repaint limit, which is more correct (and faster) anyway.
2016-01-06 10:44:19 -08:00
Adam Barth
c4faad115d Merge pull request #1074 from abarth/scrollable_list_features
Complete features of ScrollableList2
2016-01-05 16:35:18 -08:00
Adam Barth
b1f9138f52 Switch clients of ScrollableList to ScrollableList2
This patch also changed ScrollableList2 to use an Iterable instead of an
List for its children. This change lets clients map their underlying
data lazily. If the clients actually have a concrete list, we skip the
extra copy and grab the child list directly.
2016-01-05 16:21:00 -08:00
Adam Barth
37106ea603 Complete features of ScrollableList2
This patch implements the remaining missing features of ScrollableList2.
It should now be nearly a drop-in replacement for ScrollableList. The
next patch will switch callers over to the new machinery.
2016-01-05 14:29:12 -08:00
Devon Carew
f72c8f6db7 Merge pull request #1076 from devoncarew/clear_logs
clear logs on app launch
2016-01-05 13:34:03 -08:00
Devon Carew
782f505fb8 clear logs on app launch 2016-01-05 11:02:49 -08:00
Adam Barth
ad170378cf Merge pull request #1073 from abarth/rm_scrolldirection_both
Remove ScrollDirection.both
2016-01-04 17:01:36 -08:00
Jason Simmons
b4591274c9 Merge pull request #1072 from jason-simmons/apk_keystore
Add flags for signing an APK with a custom keystore
2016-01-04 16:50:54 -08:00
Adam Barth
7aa575b0d4 Remove ScrollDirection.both
Almost none of the clients of ScrollDirection can handle scrolling in both
directions.

Fixes #151
2016-01-04 16:46:40 -08:00
Adam Barth
24fadf49fc Merge pull request #1070 from abarth/scrollable_list2
Introduce ScrollableList2
2016-01-04 16:44:44 -08:00
Adam Barth
99bca282c9 Introduce ScrollableList2
ScrollableList2 uses the same pattern as ScrollableGrid, which requires the
client to allocate widgets for every list item but doesn't inflate them unless
they're actually needed for the view. It improves on the original
ScrollableList by not requiring a rebuild of the whole visible portion of the
list when scrolling. In fact, small scrolls can often be handled entirely by
repainting.
2016-01-04 16:34:39 -08:00
Ian Hickson
c8ac09a56d Merge pull request #1042 from Hixie/wordSpacing
Hook up wordSpacing and inline height.
2016-01-04 15:38:56 -08:00
Ian Hickson
dcd34f472c Merge pull request #1071 from flutter/rev
rev engine
2016-01-04 15:22:09 -08:00
Jason Simmons
3a37c36cea Add flags for signing an APK with a custom keystore
Fixes #1010
2016-01-04 13:59:01 -08:00
Ian Hickson
1156bd254f rev engine 2016-01-04 13:53:23 -08:00
Adam Barth
888dc770c8 Merge pull request #1063 from abarth/scrollable_grid
Add support for scrollable grids
2016-01-04 12:13:33 -08:00
Adam Barth
6106fa9d6d Add support for scrollable grids
We now support (vertically) scrollable grids with viewporting. If the
scroll doesn't reveal any new rows, we execute the scroll with a repaint
(i.e., no layout). If the scroll reveals a new row, we trigger a layout
to change the set of materialized children in the viewport.
2016-01-04 11:23:42 -08:00
Ian Hickson
35b18c3def Merge pull request #1062 from Hixie/better-asserts
Change how we provide additional information for asserts in the Widget framework.
2016-01-03 23:16:58 -08:00
Ian Hickson
b1bd8017b4 Change how we provide additional information for asserts in the Widget framework.
Fixes #1058.
2016-01-03 21:22:34 -08:00
Adam Barth
7bf3cb4102 Merge pull request #1061 from abarth/generalize_grid_layout
Generalize grid layout
2016-01-02 14:36:35 -08:00
Adam Barth
46a178dce6 Generalize grid layout
This patch make grid layout much more flexible. The behavior is factored
out into a GridDelegate that's modeled after the custom layout
delegates. The patch includes a MaxTileWidthGridDelegate that implements
the old behavior and a FixedColumnCountGridDelegate that implements a
grid layout with a fixed number of columns.

Fixes #1048
2016-01-02 14:30:45 -08:00
Adam Barth
a5925149d6 Merge pull request #1059 from abarth/moar_gitignore
flutter init should gitignore .atom
2016-01-01 22:03:59 -08:00
Adam Barth
e40912b1e0 Merge pull request #1060 from abarth/box_offset
RenderBox should use Offset for child offset
2016-01-01 22:03:41 -08:00
Adam Barth
e9ac6d308d RenderBox should use Offset for child offset
Previously we used Position, which makes it harder to accumulate offsets
when walking the render tree.
2016-01-01 20:11:38 -08:00
Adam Barth
eecb8012af flutter init should gitignore .atom
We now create a .atom folder to hold settings for the Atom project. We
should gitignore that folder our project template.
2016-01-01 19:44:39 -08:00