9643 Commits

Author SHA1 Message Date
Yegor
1c6decaa5e
update APK path in devicelab tests (#13540)
* update APK path in devicelab tests

* add missing transitive dependency on archive

* use path used by flutter tools
2017-12-13 13:12:10 -08:00
Mikkel Nygaard Ravn
789c7b75f7
Fix gradle plugin test (#13535) 2017-12-13 13:38:26 +01:00
Mikkel Nygaard Ravn
e5aac6928b
Support Android Gradle plugin v3.0.1 (#13492) 2017-12-13 12:16:22 +01:00
Michael Goderbauer
d04c906e0b
Add arguments to SemanticsActions; implement extend selection for a11y (#13490)
**This PR contains a breaking API change:**
`SemanticsConfiguration.addAction()` has been removed and replaces by action-specific setters (`onTap`, `onLongPress`, etc.) to take care of the fact that some action handlers (those, who take arguments) have different signatures.
2017-12-12 16:59:35 -08:00
Michael Goderbauer
1dd68d5deb
Roll engine to 2bdb21985c5eb9250a7b744b9b4d606c5ba30945 (#13526) 2017-12-12 16:01:08 -08:00
Mehmet Fidanboylu
951b85a12b
Increase coverage collection timeout to 2 minutes. Leafy is hitting the limits of the previous timeout of 30 seconds for tests that touch a lot of code in the app. (#13527) 2017-12-12 15:54:18 -08:00
Ian Hickson
9ac5963d2a
Fix TableBorder bugs (#13495)
Add more tests, fix docs, fix painting bugs...

Fixes https://github.com/flutter/flutter/issues/12902
2017-12-12 15:24:09 -08:00
Mehmet Fidanboylu
d4868b9c80
Add test for interim state of the animation to make sure we are transitioning the border color the right way. (#13499) 2017-12-12 14:34:51 -08:00
Chris Bracken
60d4a60811
Roll engine to 4ea7075c1def9dce38f16a3c9bf0ed6fb6b2d441 (#13523)
Includes:
flutter/engine#4425
2017-12-12 14:29:27 -08:00
Greg Spencer
4e1643ebe0
Updating SDK and package versions (#13524)
Updating SDK and package versions now that alpha has been rolled to 0.0.20
2017-12-12 14:20:59 -08:00
Chris Bracken
63027b035d
Roll engine to 6c6b709b2c4008e243dda3c148521c35e6e8b3df (#13522)
Includes:
flutter/engine#4442
flutter/engine#4445
flutter/engine#4444
flutter/engine#4448 (reverts flutter/engine#4444)
flutter/engine#4447
2017-12-12 13:37:19 -08:00
xster
e2192a90fc
Remove top mediaquery padding from modal bottom sheets (#13497) 2017-12-12 11:25:20 -08:00
Ian Hickson
715916fe1b
Tests for TextPainter.minIntrinsicWidth (#13515) 2017-12-12 10:58:17 -08:00
Greg Spencer
8f65fec5f5
Rolling alpha to 0.0.20 (#13511) 2017-12-12 09:50:14 -08:00
Greg Spencer
6b8ceb9472
Make the create command call pub get online instead of offline. (#13505)
We thought it would be OK to call the create command offline-only, but it turns out that isn't a great idea because not all of the create template dependencies are cached by running flutter_tool.

This PR makes it go online by default when running pub get after creating a project, and adds an "--offline" flag to the create command so that offline users can use it offline if their cache is warm.
2017-12-11 21:21:41 -08:00
Ian Hickson
9a957e4123
Remove hack for support of old Hebrew language code. (#13309)
See https://github.com/flutter/flutter/issues/11907 and https://github.com/flutter/engine/pull/4411
2017-12-11 13:43:07 -08:00
Zachary Anderson
c085e47478
Roll engine to edaecdc8b8098f20512c23745b9d0b135a8ee56d (#13488) 2017-12-11 13:37:28 -08:00
Fredrik Simón
eed471ea3d Expose textAlign on TextFormField (#13414)
* Expose textAlign on TextFormField

Fixes #11404

* Added name to AUTHORS

* Added a test for TextFormWidget's textAlign
2017-12-11 13:29:22 -08:00
Ben Konyi
0ca1af7e4f Removed additional dead code. 2017-12-11 11:13:16 -08:00
Ben Konyi
90ad465f8e Removed dead code. 2017-12-11 11:13:16 -08:00
Ben Konyi
08c2e0771f Removed special cases for '.exe'. 2017-12-11 11:13:16 -08:00
Ben Konyi
bf33eb78c5 Enabling 'flutter test' for Windows (woohoo!). 2017-12-11 11:13:16 -08:00
Ben Konyi
3fe19d95c6 update_script 2017-12-11 11:13:16 -08:00
Jason Simmons
35974d0b07
Fix one of the text painter RTL tests (#13470) 2017-12-11 10:45:09 -08:00
Mehmet Fidanboylu
0c09179b65
Fix for incorrect transparent -> DividerColor animation for ExpansionTile (#13449)
* Fix for incorrect transparent -> DividerColor animation for ExpansionTile

* Add comments and tests. Fix background color too.

* Fix analyzer warnings
2017-12-09 22:04:06 -08:00
Matt Sullivan
51ab5f36c6 Fix template for the driver test file created by 'flutter create' (#13472) 2017-12-08 20:39:56 -08:00
Chris Bracken
3264845e09
Roll engine to edb0201fa258d6a2c05899c185a4e5cba0dc26a3 (#13473)
Includes:
flutter/engine#4429
flutter/engine#4415
flutter/engine#4431
flutter/engine#4432
flutter/engine#4401
flutter/engine#4434
flutter/engine#4435
flutter/engine#4436
2017-12-08 20:30:16 -08:00
Chris Bracken
355ebef5fe
Remove bottom padding in SliverAppBar (#13471)
Removes bottom padding from the child AppBar in SliverAppBar. Scaffold
already does this for its own app bars, but sliver app bars in the body
should also apply the bottom padding removal.

Fixes flutter/flutter#13458
2017-12-08 18:53:55 -08:00
Ian Hickson
186d1e9b0d
Have the framework in charge of scheduling frames. (#13344)
...instead of the engine.
2017-12-08 16:51:59 -08:00
Alexander Thomas
425bd5a821 Make it possible to specify multiple test arguments in test.dart (#13383)
This removes the FLUTTER_TEST_ARGS environment variable handling.
2017-12-08 15:49:29 -08:00
Seth Ladd
33c66335a8
docs to redirect a user to dart:io.HttpClientOverrides (#13465) 2017-12-08 15:34:37 -08:00
Greg Spencer
aedee0df3d
Make create command use pub in offline mode. (#13462)
In order to allow offline usage of the create command we need to be able to tell pub not to try and contact the server to see if new versions are available. Since all the versions that create could want are pinned, it shouldn't need to check for new versions.
2017-12-08 15:32:10 -08:00
Ian Hickson
d25e0eb0d3
Fix tapping on a test in flutter run (#13397)
Also:

* Remove find.byIcon since it's identical to find.icon. (I sent mail to flutter-dev about this.)

* Fix IconData's operator== and hashCode, which had not been updated when we added fields.

* Add the byTooltip finder to the list of suggested finders.

* Make the suggested Key finder prettier.
2017-12-08 14:37:24 -08:00
Yegor
b80751cdc3
Make time picker accessible (#13152)
* make time picker accessible

* use new CustomPaint a11y API

* flutter_localizations tests; use bigger distance delta

* fix am/pm control; selected values

* fix translations; remove @mustCallSuper in describeSemanticsConfiguration

* exclude AM/PM announcement from iOS as on iOS the label is read back automatically
2017-12-08 14:29:28 -08:00
Zachary Anderson
927a143d79
[flutter_tools][plugins] generated registerWith guards against re-registration (#13384) 2017-12-08 09:38:02 -08:00
xster
ecf5041807
Let translucent Cupertino bars have its scaffold children automatically pad their heights - second try (#13440)
* Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)

* Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds.

* tests

* const lint

* Rename base abstract class to generalized ObstructingPreferredSizeWidget

* review

* More docs and comments from #13317
2017-12-08 09:00:20 -08:00
jcollins-g
80c691993a
Upgrade dartdoc to 0.15.0+1 (#13432)
* Update dartdoc to 0.15.0+1 for Flutter.

* Minimize change
2017-12-08 08:08:49 -08:00
Chris Bracken
f65fd74b88
Roll engine to 8e39760168e7669a023d1746823d9ab6db4e5df8 (#13442)
Includes:
flutter/engine#4427
flutter/engine#4428
2017-12-07 21:28:15 -08:00
Chris Bracken
c4f55ca02d
Roll engine to 1cdaab88e33f564eee8455c75479706293f2b655 (#13441)
Includes:
flutter/engine#4422 (Dart SDK roll)
2017-12-07 20:57:08 -08:00
Michael Goderbauer
52d06b8213 a11y cursor movement (#13405) 2017-12-07 19:06:16 -08:00
Yusuke Konishi
ca5ab1b42a Remove unnecessary error message when cocopods is not available (#13241)
* Remove unnecessary error message

* Add AUTHOR
2017-12-07 18:48:59 -08:00
Chris Bracken
276cbb1c27
Apply media bottom padding in BottomNavigationBar (#13431)
Updates scaffold to expose bottom padding to the associated
BottonNavigationBar (if present). BottomNavigationBar is now responsible
for adjusting itself to account for bottom padding.

This change is necessary to support the updated BottomNavigationBar
layout for the iPhone X.
2017-12-07 18:15:29 -08:00
xster
6f773944ae
Remove dangling MediaQuery paddings for non-fullscreen dialogs - 2 (#13438)
* Remove MediaQuery padding for various PopupRoutes that don't extend to the edge of the screen

* bottom sheet doesn't actually need handling. Scaffold does it already. Add test for others.
2017-12-07 17:58:50 -08:00
Chris Bracken
6ff844a9c0
Scaffold resizeToAvoidBottomPadding uses view insets (#13437)
Now that keyboard height is modelled as a (bottom) view inset, migrate
scaffold bottom resizing to use view insets instead of bottom padding,
which, after an engine roll, will only be used for safe areas.

Until the aforementioned engine roll, the keyboard height is still
included in both bottom padding and view insets. As such
resizeToAvoidBottomPadding still drives bottom padding removal until
that roll lands.

Renames _ScaffoldLayout.bottomPadding to bottomViewInset
2017-12-07 17:49:11 -08:00
Chris Bracken
60effb993c
Extract a shared MediaQueryData for padding and viewInsets (#13434)
Also adds a TODO that should have landed with flutter/flutter#13423.
2017-12-07 16:19:58 -08:00
Jason Simmons
3979dafaed
Fix calculation of downstream caret location at the end of a string (#13426) 2017-12-07 15:34:42 -08:00
Chris Bracken
38c82ea88f
Update scaffold test bottom bar height (#13429)
This patch contains no framework changes.

This change adjusts a test bottom navigation bar height to be greater
than the media bottom padding.

This change is pre-factoring to clarify diffs in an upcoming change that
will expose bottom padding to the bottom navigation bar in order to
allow it to visually adapt its appearance in the presence of bottom
padding such as thatexposed for the iPhone X home screen indicator.
Since the bottom padding was previously greater than the height of the
bottom navigation bar, the height of insideBottomNavigation bar was
driven to 0 when padding is exposed.
2017-12-07 14:53:26 -08:00
Ian Hickson
44e228eb9e
Move image logic from services/ to painting/. (#13409)
This allows the scheduler library to depend on the services library
and the painting library to depend on the scheduler library without
the services library having to depend on the scheduler library.

While I was at it I also cleaned up some of the binding logic: the
licenses logic can now be overridden (and the test library does so),
and the image cache can now be overridden as well.
2017-12-07 14:53:08 -08:00
Kevin Moore
64feb95ada
Revert "(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427)" (#13430)
This reverts commit 9315a79b11dfcd82ffd1af9da7451b2e29e71253.

There is an unfortunate interaction with verifyThenRunCommand
2017-12-07 14:29:12 -08:00
Kevin Moore
9315a79b11
(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427) 2017-12-07 13:31:32 -08:00