Ian Hickson
1ce4a4f36f
Make sure all our .dart files have license headers ( #44467 )
2019-11-08 16:53:21 -08:00
Ian Hickson
f4da9f72eb
Deprecation cleanup in flutter_tools ( #44469 )
...
One deprecated member was no longer used; removed it.
The other probably shouldn't be deprecated, because it's not the
parser that's deprecated so much as the format it's parsing. The code
itself will live on until we decide to stop supporting the format,
it's not like people calling the member should use something else.
2019-11-08 16:31:34 -08:00
Greg Spencer
c921c5ae67
Add macOS fn key support. ( #44410 )
...
This adds support for the fn key on macOS. It adds it to the key mappings as a supplemental mapping that overwrites the one from the Chrome headers, since the chrome headers have a TODO, but no implementation of the key.
Also, ignore the fn key entirely on macOS. This is because On macOS laptop keyboards, the fn key is used to generate home/end and f1-f12, but it ALSO generates a separate down/up event for the fn key itself. Other platforms hide the fn key, and just produce the key that it is combined with, so to keep it possible to write cross platform code that looks at which keys are pressed, the fn key is ignored.
2019-11-08 16:30:38 -08:00
Jonah Williams
9fa0f3b2ea
fix test for null flutter root ( #44468 )
2019-11-08 14:38:44 -08:00
Collin Jackson
03ac37af08
Re-enable docs uploading ( #44454 )
...
* Revert "Turn off docs upload temporarily (#44365 ) (#44413 )"
This reverts commit 8f2ea9d0e959b084e64e5adc23e3737d90f8118f.
* Re enables docs upload
2019-11-08 12:47:26 -08:00
Jonah Williams
eeb88f4385
Revert "Demonstrate that artifact invalidation works ( #44312 )" ( #44463 )
...
This reverts commit c1d029b84f852a95d02d535da36dd49581b9b27e.
2019-11-08 12:44:24 -08:00
Jonah Williams
69a783b806
switch web test to macOS ( #44421 )
2019-11-08 12:43:08 -08:00
Jonah Williams
978fada33c
Refactor flutter.gradle to use assemble directly ( #43876 )
...
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
2019-11-08 12:41:24 -08:00
Jonah Williams
c1d029b84f
Demonstrate that artifact invalidation works ( #44312 )
2019-11-08 12:32:55 -08:00
LongCatIsLooong
09c80aa45a
Segmented control quick double tap fix ( #44391 )
2019-11-08 10:05:53 -08:00
Luiz França
d961ae85b5
Adding subtitle to ExpansionTile ( #43946 )
...
* Adding subtitle to expansion_tile
2019-11-08 10:04:49 -08:00
engine-flutter-autoroll
dd59739513
Roll engine 6a1f093398c6..5f5713e33971 (5 commits) ( #44448 )
...
git@github.com:flutter/engine.git/compare/6a1f093398c6...5f5713e33971
git log 6a1f093398c6..5f5713e33971 --no-merges --oneline
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751 )
2019-11-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali... (flutter/engine#13750 )
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749 )
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76eaab6b8cef..3fd426d19df3 (1 commits) (flutter/engine#13746 )
2019-11-08 chinmaygarde@google.com Create a new picture recorder even when the embedder supplied render target is recycled. (flutter/engine#13744 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 13:01:17 -05:00
Greg Spencer
19778f9e33
Make selected item get focus when dropdown is opened ( #43722 )
...
As it stands, dropdowns currently do not focus the item that is selected, so if you select something on a dropdown, and then close it, and re-open it, then the new item is not auto-focused. This PR changes that so that selected value is focused by default when the dropdown is re-opened.
2019-11-08 08:58:37 -08:00
engine-flutter-autoroll
4cc8ce0628
Roll engine 7ed9c9fc5885..6a1f093398c6 (5 commits) ( #44419 )
...
git@github.com:flutter/engine.git/compare/7ed9c9fc5885...6a1f093398c6
git log 7ed9c9fc5885..6a1f093398c6 --no-merges --oneline
2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 345a2735e2c8..76eaab6b8cef (18 commits) (flutter/engine#13745 )
2019-11-08 gw280@google.com Only specify --no-link-platform when not specifying --aot, roll dart-lang sdk (flutter/engine#13742 )
2019-11-08 ferhat@gmail.com Don't run engine tests under vm (causing warnings) (flutter/engine#13737 )
2019-11-07 christopherfujino@gmail.com Switch to Cirrus Dockerfile as CI (flutter/engine#13440 )
2019-11-07 matthew-carroll@users.noreply.github.com Removed scary experimental warnings for new embedding. (#44314 ) (flutter/engine#13738 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 11:55:17 -05:00
engine-flutter-autoroll
ff95b14ad8
Roll engine 629930e8887c..7ed9c9fc5885 (2 commits) ( #44401 )
...
git@github.com:flutter/engine.git/compare/629930e8887c...7ed9c9fc5885
git log 629930e8887c..7ed9c9fc5885 --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia f66ec5d69d04..345a2735e2c8 (1 commits) (flutter/engine#13732 )
2019-11-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r1tS4... to H_5HL... (flutter/engine#13734 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 23:14:17 -05:00
Jonah Williams
cc51ad5d08
Reland: enable usage of experimental web compiler ( #44400 )
2019-11-07 20:13:02 -08:00
Jenn Magder
8f2ea9d0e9
Turn off docs upload temporarily ( #44365 ) ( #44413 )
2019-11-07 19:16:04 -08:00
chunhtai
6a9b72c16b
fixing todo comments in flutter tests to include url link. ( #42691 )
2019-11-07 17:34:36 -08:00
engine-flutter-autoroll
d3c403219c
629930e88 Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728) ( #44388 )
...
git@github.com:flutter/engine.git/compare/ddceed5f7af1...629930e8887c
git log ddceed5f7af1..629930e8887c --no-merges --oneline
2019-11-07 liyuqian@google.com Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 19:39:17 -05:00
Jonah Williams
7535ef735f
Revert "Enable usage of experimental incremental compiler for web ( #43576 )" ( #44396 )
...
This reverts commit e5d6d92498669b9a1aa0112685be1bbd96c85729.
2019-11-07 16:32:20 -08:00
Jonah Williams
e5d6d92498
Enable usage of experimental incremental compiler for web ( #43576 )
2019-11-07 16:29:51 -08:00
engine-flutter-autoroll
99f2b940f6
Roll engine c448d39d5307..ddceed5f7af1 (2 commits) ( #44380 )
...
git@github.com:flutter/engine.git/compare/c448d39d5307...ddceed5f7af1
git log c448d39d5307..ddceed5f7af1 --no-merges --oneline
2019-11-07 alexmarkov@google.com Cleanup obsolete --strong option of front-end server (flutter/engine#13735 )
2019-11-07 bkonyi@google.com Roll src/third_party/dart bdd9e74afc..4b9638aaa1 (7 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 18:42:17 -05:00
Collin Jackson
62b7ce306d
Revert "Turn off docs upload temporarily ( #44365 )" ( #44371 )
...
* Revert "Turn off docs upload temporarily (#44365 )"
This reverts commit 3dd67410787e918774f052121963086f0ef777a9.
* show contents of firebase-debug.log
2019-11-07 15:21:45 -08:00
Emmanuel Garcia
2c80bc973d
Flip enable-android-embedding-v2 flag ( #44369 )
2019-11-07 15:18:56 -08:00
liyuqian
cc9e9ce2ce
Remove TODO that's done ( #44318 )
...
See https://github.com/flutter/engine/pull/13728
2019-11-07 14:06:07 -08:00
liyuqian
2eb8caf13c
Re-enable Pesto in profile/release mode ( #44299 )
...
See https://github.com/flutter/flutter/issues/9257#issuecomment-550503833
2019-11-07 14:05:56 -08:00
Zachary Anderson
12c190f746
[flutter_tool] Stream artifact downloads to files ( #44360 )
2019-11-07 14:01:57 -08:00
Danny Tuppeny
b10a5d6898
Update packages to get latest dwds ( #44344 )
2019-11-07 13:15:58 -08:00
LongCatIsLooong
62db22d152
CupertinoDynamicColor improvements ( #44317 )
2019-11-07 13:14:08 -08:00
xster
604f176194
Add more flutter build ios-framework tests before the impending jonahpocalypse ( #44308 )
2019-11-07 13:12:56 -08:00
Kate Lovett
dfbbfcd390
Fixing local golden output flake ( #44307 )
2019-11-07 13:01:32 -08:00
Greg Spencer
3dd6741078
Turn off docs upload temporarily ( #44365 )
...
Turning off Docs upload temporarily until Firebase outage is over.
Landing on red to fix the build.
2019-11-07 11:29:49 -08:00
Emmanuel Garcia
b0ad6072ef
Don't print how to consume AARs when building plugins as AARs ( #44301 )
2019-11-07 10:18:55 -08:00
Afzaal Ahmad Zeeshan
9492dcc7cc
Update create.dart ( #43764 )
...
Changed the placements of the operands to make it more readable.
2019-11-07 10:17:03 -08:00
Emmanuel Garcia
cb614d1339
Fix v1 embedding support heuristic for plugins ( #44214 )
2019-11-07 08:24:19 -08:00
engine-flutter-autoroll
e3742b6e41
c448d39d5 Roll src/third_party/skia 714f8cc3ff4b..f66ec5d69d04 (3 commits) (flutter/engine#13729) ( #44321 )
...
git@github.com:flutter/engine.git/compare/d68c00947e6e...c448d39d5307
git log d68c00947e6e..c448d39d5307 --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 714f8cc3ff4b..f66ec5d69d04 (3 commits) (flutter/engine#13729 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-06 23:13:17 -05:00
engine-flutter-autoroll
106ef35e96
d68c00947 Roll fuchsia/sdk/core/mac-amd64 from 6Du8E... to r1tS4... (flutter/engine#13726) ( #44319 )
...
git@github.com:flutter/engine.git/compare/34a40cfbfd36...d68c00947e6e
git log 34a40cfbfd36..d68c00947e6e --no-merges --oneline
2019-11-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6Du8E... to r1tS4... (flutter/engine#13726 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-06 22:01:17 -05:00
Shi-Hao Hong
b883624c75
l10n tool improvements, stocks app refresh ( #44313 )
...
* Add pubspec.yaml comment
* Add --help flag
2019-11-06 18:52:24 -08:00
engine-flutter-autoroll
798e4272a2
Roll engine abaa85a394c8..34a40cfbfd36 (2 commits) ( #44315 )
...
git@github.com:flutter/engine.git/compare/abaa85a394c8...34a40cfbfd36
git log abaa85a394c8..34a40cfbfd36 --no-merges --oneline
2019-11-07 bkonyi@google.com Roll src/third_party/dart c154677699..bdd9e74afc (3 commits)
2019-11-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6790423f84ef..714f8cc3ff4b (8 commits) (flutter/engine#13724 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-06 21:04:17 -05:00
engine-flutter-autoroll
369860bcf6
abaa85a39 [web] Proper support for text field's obscureText (flutter/engine#13722) ( #44311 )
...
git@github.com:flutter/engine.git/compare/2a8f6dca6006...abaa85a394c8
git log 2a8f6dca6006..abaa85a394c8 --no-merges --oneline
2019-11-06 mouad.debbar@gmail.com [web] Proper support for text field's obscureText (flutter/engine#13722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-06 19:44:17 -05:00
engine-flutter-autoroll
4853c24080
Roll engine 8ebb31840134..2a8f6dca6006 (2 commits) ( #44303 )
...
git@github.com:flutter/engine.git/compare/8ebb31840134...2a8f6dca6006
git log 8ebb31840134..2a8f6dca6006 --no-merges --oneline
2019-11-06 bkonyi@google.com Roll src/third_party/dart 462a448ac8..c154677699 (2 commits)
2019-11-06 gw280@google.com Package fml_unittests in a .far file for fml unit tests on Fuchsia (flutter/engine#13471 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-06 18:54:17 -05:00
Emmanuel Garcia
114150b791
Don't add x86 nor x64 when building a local engine in debug mode ( #44302 )
2019-11-06 15:22:54 -08:00
xster
d2e87a5d2c
Build ios framework ( #44065 )
2019-11-06 14:54:15 -08:00
Greg Spencer
028ed7122a
Synchronize modifier keys in RawKeyboard.keysPressed with modifier flags on events. ( #43948 )
...
Currently, we listen to keyboard events to find out which keys should be represented in RawKeyboard.instance.keysPressed, but that's not sufficient to represent the physical state of the keys, since modifier keys could have been pressed when the overall app did not have keyboard focus (especially on desktop platforms).
This PR synchronizes the list of modifier keys in keysPressed with the modifier key flags that are present in the raw key event so that they can be relied upon to represent the current state of the keyboard. When synchronizing these states, we don't send any new key events, since they didn't happen when the app had keyboard focus, but if you ask "is this key down", we'll give the right answer
2019-11-06 14:52:55 -08:00
Taufiq Rahman
3243ebe3ee
Tap.dart: Fixes the spacing to the right side of reason ( #43246 )
2019-11-06 14:48:43 -08:00
Alexander Markov
cf6a8d6a47
Do not pass obsolete --strong option to front-end server ( #44278 )
2019-11-06 14:46:10 -08:00
engine-flutter-autoroll
5f62440e97
Roll engine 6c763bb551cb..8ebb31840134 (15 commits) ( #44300 )
...
git@github.com:flutter/engine.git/compare/6c763bb551cb...8ebb31840134
git log 6c763bb551cb..8ebb31840134 --no-merges --oneline
2019-11-06 47866232+chunhtai@users.noreply.github.com Revert "Issues/39832 reland (#13642 )" (flutter/engine#13720 )
2019-11-06 chinmaygarde@google.com Ensure that the device pixel ratio is taken into account with window metrics in physical pixels. (flutter/engine#13708 )
2019-11-06 jason-simmons@users.noreply.github.com Fix NPE in splash screen lookup (flutter/engine#13719 )
2019-11-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6e54a299cce9..6790423f84ef (11 commits) (flutter/engine#13718 )
2019-11-06 bkonyi@google.com Roll src/third_party/dart 24f1f313a2..462a448ac8 (2 commits)
2019-11-06 bkonyi@google.com Roll src/third_party/dart 80fc4d54e5..24f1f313a2 (5 commits)
2019-11-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia f00524707da7..6e54a299cce9 (1 commits) (flutter/engine#13715 )
2019-11-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from bCFtP... to 6Du8E... (flutter/engine#13714 )
2019-11-06 bkonyi@google.com Roll src/third_party/dart 51016532e8..80fc4d54e5 (2 commits)
2019-11-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia cdc0c23f1a2e..f00524707da7 (2 commits) (flutter/engine#13712 )
2019-11-06 bkonyi@google.com Roll src/third_party/dart 8bdca37e98..51016532e8 (21 commits)
2019-11-06 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3d4109a793b..cdc0c23f1a2e (36 commits) (flutter/engine#13707 )
2019-11-06 matthew-carroll@users.noreply.github.com Fix splash screen lookup. (#44131 ) (flutter/engine#13660 )
2019-11-06 gspencergoog@users.noreply.github.com Fix editing selection and deletion on macOS (flutter/engine#13702 )
2019-11-06 mouad.debbar@gmail.com [web] Don't send keyboard events from text fields to flutter (flutter/engine#13699 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-06 17:44:17 -05:00
chunhtai
50cb4ee4eb
Manual roll for add new enum roll back ( #44292 )
2019-11-06 14:36:26 -08:00
Emmanuel Garcia
0b0a614703
Add version to fuchsia_remote_debug_protocol ( #44151 )
2019-11-06 13:17:43 -08:00
Emmanuel Garcia
bb8cf609ec
Build local maven repo when using local engine ( #44243 )
2019-11-06 12:52:37 -08:00
