Nate
2e748e8598
Implementing control flow collections ( #146601 )
...
This pull request aims for improved readability, based on issue #146600 .
```dart
// before
Set<Color> _distinctVisibleColors() {
final Set<Color> distinctVisibleColors = <Color>{};
if (top.style != BorderStyle.none) {
distinctVisibleColors.add(top.color);
}
if (right.style != BorderStyle.none) {
distinctVisibleColors.add(right.color);
}
if (bottom.style != BorderStyle.none) {
distinctVisibleColors.add(bottom.color);
}
if (left.style != BorderStyle.none) {
distinctVisibleColors.add(left.color);
}
return distinctVisibleColors;
}
// after
Set<Color> _distinctVisibleColors() {
return <Color>{
if (top.style != BorderStyle.none) top.color,
if (right.style != BorderStyle.none) right.color,
if (bottom.style != BorderStyle.none) bottom.color,
if (left.style != BorderStyle.none) left.color,
};
}
```
Most of the repo should be covered in this PR (aside from `flutter_tools/`, since there was a lot going on in there).
2024-04-15 16:06:07 +00:00
engine-flutter-autoroll
600787891a
Roll Packages from 78f684ce6771 to 6698b2d67999 (3 revisions) ( #146761 )
...
78f684ce67...6698b2d679collin@flutterflow.io Fix error in markdown parsing image dimensions (flutter/packages#6518 )
2024-04-12 34871572+gmackall@users.noreply.github.com [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506 )
2024-04-12 stuartmorgan@google.com [video_player] Darwin implementation cleanup (flutter/packages#6507 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-15 16:02:17 +00:00
Valentin Vignal
0099d1a96a
test: Fix memory leak in transitions test ( #146747 )
2024-04-15 08:52:18 -07:00
Bruno Leroux
63634c25ad
Fix filled text field active indicator overflows container bounds ( #146637 )
...
## Description
This PRs fixes the active indicator vertical position for a filled text field.
Before this PR, the active indicator overflowed of container bounds, After this PR the active indicator is painted inside the container bounds.
Screenshot of filled text field with active indicator width sets to 4.0dp:
| Before | After |
|--------|--------|
|  |  |
</details>
## Related Issue
Fixes https://github.com/flutter/flutter/issues/146507
## Tests
Adds 1 tests, updates 3 tests.
2024-04-15 07:28:19 +00:00
Dimil Kalathiya
1002ce4b03
- Fixes _DropdownMenuState leaking text controller ( #146571 )
2024-04-14 07:59:43 -07:00
Valentin Vignal
266cdf0b1e
Fix memory leaks in FloatingActionButton ( #146711 )
2024-04-13 15:48:25 -07:00
engine-flutter-autoroll
46fbb73440
Roll Flutter Engine from 0e56e3dffe43 to 1a13c7d1f40e (2 revisions) ( #146703 )
...
0e56e3dffe...1a13c7d1f4skia-flutter-autoroll@skia.org Roll Skia from 5101cbe5a6bb to 761f6f7f6250 (1 revision) (flutter/engine#52076 )
2024-04-12 magder@google.com Migrate FlutterEmbedderKeyResponder to ARC (flutter/engine#52048 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-12 22:41:57 +00:00
flutter-pub-roller-bot
aac767e66a
Roll pub packages ( #146704 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-12 22:34:37 +00:00
dependabot[bot]
c845a78838
Bump peter-evans/create-pull-request from 6.0.2 to 6.0.3 ( #146702 )
...
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ) from 6.0.2 to 6.0.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v6.0.3</h2>
<p>â¡ Improves performance of the <code>push-to-fork</code> feature.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.23 to 18.19.25 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2826 ">peter-evans/create-pull-request#2826</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.25 to 18.19.26 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2831 ">peter-evans/create-pull-request#2831</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.26 to 18.19.28 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2836 ">peter-evans/create-pull-request#2836</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.28 to 18.19.31 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2842 ">peter-evans/create-pull-request#2842</a></li>
<li>fix: drop unnecessary fetch with unshallow on push-to-fork by <a href="https://github.com/peter-evans "><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2849 ">peter-evans/create-pull-request#2849</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v6.0.2...v6.0.3 ">https://github.com/peter-evans/create-pull-request/compare/v6.0.2...v6.0.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="c55203cfdehttps://redirect.github.com/peter-evans/create-pull-request/issues/2849 ">#2849</a>)</li>
<li><a href="6ce4eca6b6https://redirect.github.com/peter-evans/create-pull-request/issues/2842 ">#2842</a>)</li>
<li><a href="36ef0ed92fhttps://redirect.github.com/peter-evans/create-pull-request/issues/2836 ">#2836</a>)</li>
<li><a href="8500972a13https://redirect.github.com/peter-evans/create-pull-request/issues/2831 ">#2831</a>)</li>
<li><a href="bda5ade93chttps://redirect.github.com/peter-evans/create-pull-request/issues/2826 ">#2826</a>)</li>
<li>See full diff in <a href="70a41aba78...c55203cfdehttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=6.0.2&new-version=6.0.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-12 22:07:55 +00:00
Lau Ching Jun
8a9e74e8d7
Avoid forwarding the data after socket is disconnected. ( #146665 )
...
In a ProxiedDevicePortForwarder, there might be a race condition where the local socket has been disconnected, but the remote end was still sending new data. In this case, avoid forwarding new data to the socket.
2024-04-12 21:45:32 +00:00
Christopher Fujino
7a30d2b4ca
[flutter_tools] Fix conductor for package args roll ( #146646 )
...
The interface for `ArgResults` from `package:args` has added new fields. Change the implementations of these in the conductor to extend `Fake` so that these aren't analyzer errors.
This broke the pub roll here: https://github.com/flutter/flutter/pull/146642#issuecomment-2050169629
2024-04-12 21:38:03 +00:00
engine-flutter-autoroll
a7c667143d
Roll Flutter Engine from 6b37b170998e to 0e56e3dffe43 (4 revisions) ( #146698 )
...
6b37b17099...0e56e3dffejason-simmons@users.noreply.github.com Fix the Dart language version for Fuchsia's build of the args package (flutter/engine#52083 )
2024-04-11 magder@google.com Update iOS KeyCodeMap dictionary literal and migrate to ARC (flutter/engine#51981 )
2024-04-11 bdero@google.com [Impeller] Only set the stencil ref for StC draws. (flutter/engine#52006 )
2024-04-11 chinmaygarde@google.com Remove intermediate APKs during build process. (flutter/engine#52071 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-12 21:38:02 +00:00
Kate Lovett
25a0cc7e2b
Light sliver clean up before SliverTree ( #146696 )
...
This cleans up a few sliver classes, like moving RenderSliverVariedExtentList to the rendering layer (it was in the widgets layer), and moving SliverVariedExtentList to live with its sibling subclasses, SliverFixedExtentList, SliverList, and so on.
I moved these while working on SliverTree, so figure I should break out into a separate change.
SliverTree and SliverCarousel (both inbound in separate changes) will also be subclasses of RenderSliverFixedExtentBoxAdaptor, organizing them together felt easier to work with.
Related to https://github.com/flutter/flutter/issues/114299 and https://github.com/flutter/flutter/issues/125980
2024-04-12 21:20:59 +00:00
Bruno Leroux
58ac0dc16b
Fix label text color is wrong for a focused and hovered TextField ( #146572 )
...
Before, hovering a focused TextField would incorrect change the label color. Now it does not, which is correct per the spec.
2024-04-12 14:07:03 -07:00
LongCatIsLooong
7db26b09bb
Fix getOffsetForCaret crash ( #146669 )
...
Fixes a crash in Google tests (b/333560406) related to a decomposed complex character.
2024-04-12 13:58:02 -07:00
Jenn Magder
65e8ec2140
Update gen_keycodes templates ( #146481 )
...
1. Change chromium default branch from master (404) to main.
2. When I migrated the template to ARC is triggered a `-Wobjc-redundant-literal-use` error, so fix that. Engine PR is https://github.com/flutter/engine/pull/51981
3. Update to `FLUTTER_SHELL_PLATFORM_EMBEDDER_TEST_UTILS_KEY_CODES_G_H_` to match https://github.com/flutter/engine/pull/49006
This only updates the template and the script--I ran the script to validate it worked and built in the engine, but did not check in the actual generated key code changes (filed https://github.com/flutter/flutter/issues/146480 for that).
2024-04-12 20:07:11 +00:00
Jackson Gardner
9973673752
Support flutter run --wasm and flutter drive --wasm. ( #146231 )
...
This adds support for adding the `--wasm` flag to `flutter run` and `flutter drive`
* Emits errors if you attempt to use the skwasm renderer without the `--wasm` flag
* Emits errors if you try to use `--wasm` when not using a web device
* Uses the skwasm renderer by default if you pass `--wasm` and no `--web-renderer`
2024-04-12 19:27:26 +00:00
Valentin Vignal
e2c812155c
Fix curved animation memory leak for scrollbar ( #146670 )
2024-04-12 09:24:13 -07:00
engine-flutter-autoroll
699749e43f
Roll Packages from e98839a9b8de to 78f684ce6771 (6 revisions) ( #146691 )
...
e98839a9b8...78f684ce67engine-flutter-autoroll@skia.org Roll Flutter from 557fbf5167f6 to 53cba24de3a0 (11 revisions) (flutter/packages#6509 )
2024-04-11 stuartmorgan@google.com [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503 )
2024-04-11 ahmedelsaayid@gmail.com Access current location using uri.path to support deep links (flutter/packages#6474 )
2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter from 97cd47a02e60 to 557fbf5167f6 (22 revisions) (flutter/packages#6502 )
2024-04-11 louisehsu@google.com [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471 )
2024-04-11 vbuberen@users.noreply.github.com Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-12 16:22:19 +00:00
Jenn Magder
53cba24de3
Allow A/B tests to run as just aggregator of local engine benchmarks ( #146479 )
...
Add `--ab-local-engine-only` flag to change A/B benchmark aggregate behavior to instead run the number of tasks specified with the local engine only, not the default engine. This is useful when you are trying to get average and noise results for a particular engine branch, without needing the default engine every time you change the engine.
Fixes https://github.com/flutter/flutter/issues/143770
2024-04-12 04:07:19 +00:00
Chris Bracken
a34086a573
[Windows] Drop support for Windows 7/8 apps in template ( #146668 )
...
Since Flutter no longer supports Windows 7.x or 8.x, this eliminates support from the Windows app template. No tests to eliminate, since Windows 7 and 8 were "best-efforts" tier and untested.
Fixes: https://github.com/flutter/flutter/issues/140830
RFC: http://flutter.dev/go/flutter-drop-win7-2024
2024-04-12 01:07:20 +00:00
engine-flutter-autoroll
67bdf93966
Roll Flutter Engine from 2d85d1225d18 to 6b37b170998e (1 revision) ( #146666 )
...
2d85d1225d...6b37b17099jason-simmons@users.noreply.github.com Clear the surface to transparent black when creating a PlatformViewWrapper (flutter/engine#52047 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-12 00:05:23 +00:00
engine-flutter-autoroll
a557f0439c
Roll Flutter Engine from 16b0cfd85617 to 2d85d1225d18 (4 revisions) ( #146663 )
...
16b0cfd856...2d85d1225dskia-flutter-autoroll@skia.org Roll Skia from 08940c2e0c44 to 5101cbe5a6bb (1 revision) (flutter/engine#52066 )
2024-04-11 dkwingsmt@users.noreply.github.com Move `Shell::Add/RemoveView` to `PlatformView` and refine embedder API doc (flutter/engine#52003 )
2024-04-11 chaopeng@chaopeng.me [Fuchsia] Support per app present latency tracing (flutter/engine#51503 )
2024-04-11 jason-simmons@users.noreply.github.com Save and restore OpenGL bindings that are changed by fl_renderer_render (flutter/engine#51887 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 22:33:25 +00:00
engine-flutter-autoroll
4b180458db
Roll Flutter Engine from 0d36479e1d55 to 16b0cfd85617 (1 revision) ( #146662 )
...
0d36479e1d...16b0cfd856skia-flutter-autoroll@skia.org Roll Skia from 112fff965f8b to 08940c2e0c44 (1 revision) (flutter/engine#52064 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 21:39:36 +00:00
hangyu
07f3103c67
Update the gradle task to add fallback scheme and host if needed when retrieving deep links. ( #146470 )
...
This is to support feature:
https://github.com/flutter/devtools/issues/7541
before behavior: do not show this link in the dev tool if there's no
scheme or host
target behavior: show the link in the dev tool with a error text : (
missing scheme/ missing domain)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-11 14:24:51 -07:00
engine-flutter-autoroll
5bc3de9d75
Roll Flutter Engine from 98a8ad144597 to 0d36479e1d55 (2 revisions) ( #146653 )
...
98a8ad1445...0d36479e1dskia-flutter-autoroll@skia.org Roll Skia from 1dc3c2c1b550 to 112fff965f8b (2 revisions) (flutter/engine#52063 )
2024-04-11 737941+loic-sharma@users.noreply.github.com [Windows] Allow adding/removing views (flutter/engine#51923 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 20:39:06 +00:00
Polina Cherkasova
5ebc94082e
Fix leaking curved animation. ( #146644 )
2024-04-11 18:47:24 +00:00
Jesse
000101a369
Refactor verify codesigned ( #146450 )
...
Refactor verify codesigned tests in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing verify codesigned tests
Part of https://github.com/flutter/flutter/issues/145482
2024-04-11 18:33:39 +00:00
engine-flutter-autoroll
416c4cef28
Roll Flutter Engine from d8560d495d9f to 98a8ad144597 (9 revisions) ( #146645 )
...
d8560d495d...98a8ad1445zanderso@users.noreply.github.com [et] Correctly plumb usage line length limit (flutter/engine#52039 )
2024-04-11 zanderso@users.noreply.github.com Revert "Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (#52051 )" (flutter/engine#52060 )
2024-04-11 109111084+yaakovschectman@users.noreply.github.com Composite multiple layers in Windows software rendering (flutter/engine#51759 )
2024-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 764bdb7d0344 to 0219e897c6ac (1 revision) (#52053 )" (flutter/engine#52058 )
2024-04-11 skia-flutter-autoroll@skia.org Roll Skia from 2a2fe4303507 to 1dc3c2c1b550 (1 revision) (flutter/engine#52055 )
2024-04-11 skia-flutter-autoroll@skia.org Roll Skia from aa30d76a345f to 2a2fe4303507 (1 revision) (flutter/engine#52054 )
2024-04-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 764bdb7d0344 to 0219e897c6ac (1 revision) (flutter/engine#52053 )
2024-04-11 skia-flutter-autoroll@skia.org Roll Skia from 29f0c9d84e70 to aa30d76a345f (1 revision) (flutter/engine#52052 )
2024-04-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d13dbfb3284 to 764bdb7d0344 (1 revision) (flutter/engine#52051 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 17:56:16 +00:00
engine-flutter-autoroll
9ffc261fdd
Roll Packages from 2c15d86f2c11 to e98839a9b8de (3 revisions) ( #146638 )
...
2c15d86f2c...e98839a9b8ekuleshov@gmail.com [tool] Check for `test` and `flutter_test` in non-dev dependencies (flutter/packages#6472 )
2024-04-10 43054281+camsim99@users.noreply.github.com [camerax] Shorten interval for releasing weak references to Dart-wrapped native objects (flutter/packages#6493 )
2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter from 4967a94cd907 to 97cd47a02e60 (11 revisions) (flutter/packages#6497 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 15:44:12 +00:00
Bartek Pacia
557fbf5167
Update app Android gradle scripts to use flutter.versionName and flutter.versionCode ( #146604 )
...
Follow up of #146044 and #141417
Minor change to make Gradle buildscripts shorter.
2024-04-11 13:46:13 +00:00
Taha Tesser
9436b3c1c8
Fix out of sync templates files and add a check ( #145747 )
...
### Description
- Add a check to verify template code in the Material library is synced with `gen_defaults`
- Sync the changes to pass the new check.
2024-04-11 13:40:36 +00:00
Daco Harkes
ac5be2d821
[tools] Fix --template=plugin_ffi formatting ( #146269 )
...
It looks like the formatter was updated.
We have a test running on the FFIgen repo that checks that rerunning the generated bindings with FFIgen generates identical bindings.
Closes:
* https://github.com/dart-lang/native/issues/1072
2024-04-11 10:24:09 +00:00
engine-flutter-autoroll
508641ca7a
Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) ( #146622 )
...
40b0f81332...d8560d495dskia-flutter-autoroll@skia.org Roll Skia from 363a8ed80050 to 29f0c9d84e70 (2 revisions) (flutter/engine#52050 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 08:21:08 +00:00
engine-flutter-autoroll
a153e61e9e
Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) ( #146621 )
...
fef8499fb9...40b0f81332skia-flutter-autoroll@skia.org Roll Skia from 28579a88aa9c to 363a8ed80050 (1 revision) (flutter/engine#52049 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 07:30:03 +00:00
Taha Tesser
831226aada
Fix IconButton theming in the InputDecorator ( #146567 )
...
fixes [DropdownMenu TrailingIcon can't be styled through providing an IconButtonTheme](https://github.com/flutter/flutter/issues/145081 ) (second PR)
### Description
This PR replaces `IconButton.style` with `ButtonStyle` when merging parent `IconButtonTheme` as `styleFrom` returns defaults for some properties.
2024-04-11 07:15:24 +00:00
engine-flutter-autoroll
61cbe2f5b7
Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) ( #146619 )
...
e2a45bda45...fef8499fb9skia-flutter-autoroll@skia.org Roll Skia from cd47aa5d8d15 to 28579a88aa9c (1 revision) (flutter/engine#52045 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 05:44:16 +00:00
engine-flutter-autoroll
0f27d74d31
Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) ( #146618 )
...
e47dc9a7a2...e2a45bda45skia-flutter-autoroll@skia.org Roll Dart SDK from f5ef31c467a5 to 3d13dbfb3284 (2 revisions) (flutter/engine#52046 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 04:52:26 +00:00
engine-flutter-autoroll
333de2efb1
Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) ( #146617 )
...
069e73eaef...e47dc9a7a2skia-flutter-autoroll@skia.org Roll Skia from fcb5c05acaf2 to cd47aa5d8d15 (1 revision) (flutter/engine#52044 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 03:32:24 +00:00
engine-flutter-autoroll
5dbb313579
Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) ( #146613 )
...
28ed19073f...069e73eaefskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from imlnJ68ZziH-Lp2xk... to peYcbx9eguHcbhMP0... (flutter/engine#52043 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from imlnJ68ZziH- to peYcbx9eguHc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 02:48:32 +00:00
engine-flutter-autoroll
ebf133e668
Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) ( #146611 )
...
4e33a0b47e...28ed19073fskia-flutter-autoroll@skia.org Roll Dart SDK from 393a24d37b39 to f5ef31c467a5 (1 revision) (flutter/engine#52037 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 01:32:25 +00:00
engine-flutter-autoroll
575357f162
Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) ( #146609 )
...
6f8ee9ffd9...4e33a0b47eskia-flutter-autoroll@skia.org Roll Skia from 5bbca5a30653 to fcb5c05acaf2 (1 revision) (flutter/engine#52036 )
2024-04-10 jonahwilliams@google.com [Engine] allow --enable-asserts flag to be passed to dart vm in profile mode. (flutter/engine#52029 )
2024-04-10 magder@google.com Migrate FlutterRestorationPlugin, FlutterTextureRegistryRelay, FlutterScreenAndSceneIfLoaded to ARC (flutter/engine#51984 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-11 00:45:25 +00:00
engine-flutter-autoroll
2c5a10afd6
Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) ( #146607 )
...
91ba23575c...6f8ee9ffd9zanderso@users.noreply.github.com Manual roll ICU from a622de35ac31 to bad7ddbf9213 (7 revisions) (flutter/engine#52031 )
2024-04-10 jason-simmons@users.noreply.github.com Enable gtest-parallel for Impeller unit tests (flutter/engine#52004 )
2024-04-10 whesse@google.com Add additional dependencies to const_finder's pubspec.yaml (flutter/engine#52033 )
2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 91e0c0f4bf41 to 5bbca5a30653 (3 revisions) (flutter/engine#52032 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-10 23:56:08 +00:00
Jason Simmons
c9d4c749b5
Disable single character mode in the terminal when exiting flutter_tools ( #146534 )
2024-04-10 23:54:42 +00:00
flutter-pub-roller-bot
aff5477dad
Roll pub packages ( #146606 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-10 23:02:54 +00:00
engine-flutter-autoroll
e11b5f3cc2
Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) ( #146605 )
...
beee02b5ba...91ba23575czanderso@users.noreply.github.com Adds iOS builds to local_engine.json (flutter/engine#52027 )
2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from df6d08abb447 to 91e0c0f4bf41 (3 revisions) (flutter/engine#52026 )
2024-04-10 jonahwilliams@google.com [Android] post image task to main handler. (flutter/engine#52025 )
2024-04-10 zanderso@users.noreply.github.com [et] Adds --lto flag to build. Plumbs verbose flag differently. (flutter/engine#52021 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-10 22:51:24 +00:00
Gray Mackall
286c73c0eb
Remove additional references to engine v1 android embedding ( #146523 )
...
https://github.com/flutter/engine/pull/51229 blocked [the roll](https://github.com/flutter/flutter/pull/146522 ) and had to be reverted, which is a shame, but on the bright side it made it possible to point the framework at my removal pr, at the point of its merging the first time
This fixes all errors that are fixable in the framework that would have blocked the roll. There are some that aren't fixable here (they need to be fixed in the engine)*, so I'll fix those in the engine but unfortunately I can't pick up another version here to re-test until I try to roll again ð¢
*This category is: uses of plugins that in turn have a `registerWith`, that references the v1 embedding. The plan to fix these cases is to leave the interface that that method relies on around for now. See https://github.com/flutter/packages/pull/6494#issuecomment-2046010323 for details
2024-04-10 21:58:05 +00:00
engine-flutter-autoroll
2ef1372aa5
Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) ( #146591 )
...
077b742550...beee02b5baskia-flutter-autoroll@skia.org Roll Dart SDK from
78174b41ab0f to 393a24d37b39 (8 revisions) (flutter/engine#52020 )
2024-04-10 zanderso@users.noreply.github.com Use RBE in mac builds in
presubmit but not postsubmit (flutter/engine#52018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-10 14:54:53 -07:00
engine-flutter-autoroll
35c0ad1a79
Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) ( #146585 )
...
0d5412d4ee...077b742550skia-flutter-autoroll@skia.org Roll Skia from 2135d686708b to df6d08abb447 (1 revision) (flutter/engine#52017 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-10 17:16:35 +00:00
Victoria Ashworth
0f6756d750
Convert ProjectMigration and ProjectMigrator to be async ( #146537 )
...
Convert `ProjectMigration.run()` and `ProjectMigrator.migrate()` to be async.
Needed for Swift Package Manager migration, which requires some async processes: https://github.com/flutter/flutter/pull/146256
2024-04-10 16:26:19 +00:00
